Merge pull request #6847 from eugenp/BAEL-2580-v3

rename package, fix file upload tests

httpclient-simple/README.md

@@ -1,11 +1,5 @@
 =========
-## HttpClient 4.x Cookbooks and Examples
+## This module contains articles that are part of the HTTPClient Ebook
-
-###The Course
-The "REST With Spring" Classes: http://bit.ly/restwithspring
-
-
-### Relevant Articles: 
 
 - [HttpClient 4 – Get the Status Code](http://www.baeldung.com/httpclient-status-code)
 - [HttpClient with SSL](http://www.baeldung.com/httpclient-ssl)
@@ -14,3 +8,9 @@ The "REST With Spring" Classes: http://bit.ly/restwithspring
 - [Custom HTTP Header with the HttpClient](http://www.baeldung.com/httpclient-custom-http-header)
 - [HttpClient Basic Authentication](http://www.baeldung.com/httpclient-4-basic-authentication)
 - [Posting with HttpClient](https://www.baeldung.com/httpclient-post-http-request)
+
+
+### Running the Tests
+To run the live tests, use the command: mvn clean install -Plive
+This will start an embedded Jetty server on port 8082 using the Cargo plugin configured in the pom.xml file,
+for the live Maven profile

httpclient-simple/src/main/java/com/baeldung/basic/MyBasicAuthenticationEntryPoint.java

@@ -1,4 +1,4 @@
-package org.baeldung.basic;
+package com.baeldung.basic;
 
 import org.springframework.security.core.AuthenticationException;
 import org.springframework.security.web.authentication.www.BasicAuthenticationEntryPoint;

httpclient-simple/src/main/java/com/baeldung/client/HttpComponentsClientHttpRequestFactoryBasicAuth.java

@@ -1,4 +1,4 @@
-package org.baeldung.client;
+package com.baeldung.client;
 
 import java.net.URI;
 

httpclient-simple/src/main/java/com/baeldung/client/RestTemplateFactory.java

@@ -1,4 +1,4 @@
-package org.baeldung.client;
+package com.baeldung.client;
 
 import org.apache.http.HttpHost;
 import org.springframework.beans.factory.FactoryBean;

httpclient-simple/src/main/java/com/baeldung/client/spring/ClientConfig.java

@@ -1,10 +1,10 @@
-package org.baeldung.client.spring;
+package com.baeldung.client.spring;
 
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
 
 @Configuration
-@ComponentScan("org.baeldung.client")
+@ComponentScan("com.baeldung.client")
 public class ClientConfig {
 
     public ClientConfig() {

httpclient-simple/src/main/java/com/baeldung/filter/CustomFilter.java

@@ -1,4 +1,4 @@
-package org.baeldung.filter;
+package com.baeldung.filter;
 
 import org.springframework.web.filter.GenericFilterBean;
 

httpclient-simple/src/main/java/com/baeldung/filter/CustomWebSecurityConfigurerAdapter.java

@@ -1,6 +1,6 @@
-package org.baeldung.filter;
+package com.baeldung.filter;
 
-import org.baeldung.security.RestAuthenticationEntryPoint;
+import com.baeldung.security.RestAuthenticationEntryPoint;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;

httpclient-simple/src/main/java/com/baeldung/security/MySavedRequestAwareAuthenticationSuccessHandler.java

@@ -1,4 +1,4 @@
-package org.baeldung.security;
+package com.baeldung.security;
 
 import java.io.IOException;
 

httpclient-simple/src/main/java/com/baeldung/security/RestAuthenticationEntryPoint.java

@@ -1,4 +1,4 @@
-package org.baeldung.security;
+package com.baeldung.security;
 
 import java.io.IOException;
 

httpclient-simple/src/main/java/com/baeldung/spring/SecSecurityConfig.java

@@ -1,4 +1,4 @@
-package org.baeldung.spring;
+package com.baeldung.spring;
 
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
@@ -6,7 +6,7 @@ import org.springframework.context.annotation.ImportResource;
 
 @Configuration
 @ImportResource({ "classpath:webSecurityConfig.xml" })
-@ComponentScan("org.baeldung.security")
+@ComponentScan("com.baeldung.security")
 public class SecSecurityConfig {
 
     public SecSecurityConfig() {

httpclient-simple/src/main/java/com/baeldung/spring/WebConfig.java

@@ -1,4 +1,4 @@
-package org.baeldung.spring;
+package com.baeldung.spring;
 
 import java.util.List;
 
@@ -11,7 +11,7 @@ import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;
 
 @Configuration
 @EnableWebMvc
-@ComponentScan("org.baeldung.web")
+@ComponentScan("com.baeldung.web")
 public class WebConfig implements WebMvcConfigurer {
 
     public WebConfig() {

httpclient-simple/src/main/java/com/baeldung/web/controller/BarController.java

@@ -1,6 +1,6 @@
-package org.baeldung.web.controller;
+package com.baeldung.web.controller;
 
-import org.baeldung.web.dto.Bar;
+import com.baeldung.web.dto.Bar;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.stereotype.Controller;

httpclient-simple/src/main/java/com/baeldung/web/controller/FooController.java

@@ -1,6 +1,6 @@
-package org.baeldung.web.controller;
+package com.baeldung.web.controller;
 
-import org.baeldung.web.dto.Foo;
+import com.baeldung.web.dto.Foo;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.security.access.prepost.PreAuthorize;

httpclient-simple/src/main/java/com/baeldung/web/dto/Bar.java

@@ -1,4 +1,4 @@
-package org.baeldung.web.dto;
+package com.baeldung.web.dto;
 
 import java.io.Serializable;
 

httpclient-simple/src/main/java/com/baeldung/web/dto/Foo.java

@@ -1,4 +1,4 @@
-package org.baeldung.web.dto;
+package com.baeldung.web.dto;
 
 import java.io.Serializable;
 

httpclient-simple/src/main/resources/webSecurityConfig.xml

@@ -23,6 +23,6 @@
 
     <global-method-security pre-post-annotations="enabled"/>
         
-    <beans:bean id="myBasicAuthenticationEntryPoint" class="org.baeldung.basic.MyBasicAuthenticationEntryPoint" />
+    <beans:bean id="myBasicAuthenticationEntryPoint" class="com.baeldung.basic.MyBasicAuthenticationEntryPoint" />
 
 </beans:beans>

httpclient-simple/src/main/webapp/WEB-INF/web.xml

@@ -12,7 +12,7 @@
     </context-param>
     <context-param>
         <param-name>contextConfigLocation</param-name>
-        <param-value>org.baeldung.spring</param-value>
+        <param-value>com.baeldung.spring</param-value>
     </context-param>
 
     <listener>

httpclient-simple/src/test/java/com/baeldung/client/ClientLiveTest.java

@@ -1,11 +1,11 @@
-package org.baeldung.client;
+package com.baeldung.client;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
 import static org.junit.Assert.assertThat;
 
-import org.baeldung.client.spring.ClientConfig;
+import com.baeldung.client.spring.ClientConfig;
-import org.baeldung.web.dto.Foo;
+import com.baeldung.web.dto.Foo;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;

httpclient-simple/src/test/java/com/baeldung/client/RestClientLiveManualTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.client;
+package com.baeldung.client;
 
 import static org.apache.http.conn.ssl.SSLSocketFactory.ALLOW_ALL_HOSTNAME_VERIFIER;
 import static org.hamcrest.Matchers.equalTo;
@@ -51,6 +51,7 @@ public class RestClientLiveManualTest {
         final CloseableHttpClient httpClient = (CloseableHttpClient) requestFactory.getHttpClient();
 
         final TrustStrategy acceptingTrustStrategy = (cert, authType) -> true;
+
         final SSLSocketFactory sf = new SSLSocketFactory(acceptingTrustStrategy, ALLOW_ALL_HOSTNAME_VERIFIER);
         httpClient.getConnectionManager().getSchemeRegistry().register(new Scheme("https", 8443, sf));
 

httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import com.google.common.collect.Lists;
 import org.apache.http.Header;

httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientPostingLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import org.apache.http.HttpEntity;
 import org.apache.http.HttpResponse;
@@ -32,7 +32,7 @@ import static org.junit.Assert.assertThat;
  * NOTE : Need module spring-rest to be running
  */
 public class HttpClientPostingLiveTest {
-    private static final String SAMPLE_URL = "http://localhost:8082/spring-rest/users";
+    private static final String SAMPLE_URL = "http://www.example.com";
     private static final String URL_SECURED_BY_BASIC_AUTHENTICATION = "http://browserspy.dk/password-ok.php";
     private static final String DEFAULT_USER = "test";
     private static final String DEFAULT_PASS = "test";
@@ -69,7 +69,7 @@ public class HttpClientPostingLiveTest {
     @Test
     public void whenPostJsonUsingHttpClient_thenCorrect() throws IOException {
         final CloseableHttpClient client = HttpClients.createDefault();
-        final HttpPost httpPost = new HttpPost(SAMPLE_URL + "/detail");
+        final HttpPost httpPost = new HttpPost(SAMPLE_URL);
 
         final String json = "{\"id\":1,\"name\":\"John\"}";
         final StringEntity entity = new StringEntity(json);
@@ -92,7 +92,7 @@ public class HttpClientPostingLiveTest {
     @Test
     public void whenSendMultipartRequestUsingHttpClient_thenCorrect() throws IOException {
         final CloseableHttpClient client = HttpClients.createDefault();
-        final HttpPost httpPost = new HttpPost(SAMPLE_URL + "/multipart");
+        final HttpPost httpPost = new HttpPost(SAMPLE_URL);
 
         final MultipartEntityBuilder builder = MultipartEntityBuilder.create();
         builder.addTextBody("username", DEFAULT_USER);
@@ -110,7 +110,7 @@ public class HttpClientPostingLiveTest {
     @Test
     public void whenUploadFileUsingHttpClient_thenCorrect() throws IOException {
         final CloseableHttpClient client = HttpClients.createDefault();
-        final HttpPost httpPost = new HttpPost(SAMPLE_URL + "/upload");
+        final HttpPost httpPost = new HttpPost(SAMPLE_URL);
 
         final MultipartEntityBuilder builder = MultipartEntityBuilder.create();
         builder.addBinaryBody("file", new File("src/test/resources/test.in"), ContentType.APPLICATION_OCTET_STREAM, "file.ext");
@@ -126,7 +126,7 @@ public class HttpClientPostingLiveTest {
     @Test
     public void whenGetUploadFileProgressUsingHttpClient_thenCorrect() throws IOException {
         final CloseableHttpClient client = HttpClients.createDefault();
-        final HttpPost httpPost = new HttpPost(SAMPLE_URL + "/upload");
+        final HttpPost httpPost = new HttpPost(SAMPLE_URL);
 
         final MultipartEntityBuilder builder = MultipartEntityBuilder.create();
         builder.addBinaryBody("file", new File("src/test/resources/test.in"), ContentType.APPLICATION_OCTET_STREAM, "file.ext");

httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientTimeoutLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.junit.Assert.assertThat;
@@ -20,6 +20,7 @@ import org.apache.http.impl.client.HttpClientBuilder;
 import org.apache.http.params.CoreConnectionPNames;
 import org.apache.http.params.HttpParams;
 import org.junit.After;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class HttpClientTimeoutLiveTest {
@@ -91,6 +92,7 @@ public class HttpClientTimeoutLiveTest {
      * This simulates a timeout against a domain with multiple routes/IPs to it (not a single raw IP)
      */
     @Test(expected = ConnectTimeoutException.class)
+    @Ignore
     public final void givenTimeoutIsConfigured_whenTimingOut_thenTimeoutException() throws IOException {
         final int timeout = 3;
 

httpclient-simple/src/test/java/com/baeldung/httpclient/HttpsClientSslLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertThat;

httpclient-simple/src/test/java/com/baeldung/httpclient/ProgressEntityWrapper.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import java.io.FilterOutputStream;
 import java.io.IOException;

httpclient-simple/src/test/java/com/baeldung/httpclient/ResponseUtil.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient;
+package com.baeldung.httpclient;
 
 import org.apache.http.HttpEntity;
 import org.apache.http.client.methods.CloseableHttpResponse;

httpclient-simple/src/test/java/com/baeldung/httpclient/base/HttpClientBasicLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient.base;
+package com.baeldung.httpclient.base;
 
 import org.apache.http.HttpStatus;
 import org.apache.http.client.ClientProtocolException;
@@ -8,7 +8,7 @@ import org.apache.http.entity.ContentType;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.http.impl.client.HttpClientBuilder;
 import org.apache.http.util.EntityUtils;
-import org.baeldung.httpclient.ResponseUtil;
+import com.baeldung.httpclient.ResponseUtil;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;

httpclient-simple/src/test/java/com/baeldung/httpclient/sec/HttpClientAuthLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient.sec;
+package com.baeldung.httpclient.sec;
 
 import org.apache.commons.codec.binary.Base64;
 import org.apache.http.HttpHeaders;
@@ -17,7 +17,7 @@ import org.apache.http.impl.client.BasicCredentialsProvider;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.http.impl.client.HttpClientBuilder;
 import org.apache.http.protocol.HttpContext;
-import org.baeldung.httpclient.ResponseUtil;
+import com.baeldung.httpclient.ResponseUtil;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;

httpclient-simple/src/test/java/com/baeldung/httpclient/sec/HttpClientCookieLiveTest.java

@@ -1,4 +1,4 @@
-package org.baeldung.httpclient.sec;
+package com.baeldung.httpclient.sec;
 
 import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.CloseableHttpResponse;
@@ -10,7 +10,7 @@ import org.apache.http.impl.client.HttpClientBuilder;
 import org.apache.http.impl.cookie.BasicClientCookie;
 import org.apache.http.protocol.BasicHttpContext;
 import org.apache.http.protocol.HttpContext;
-import org.baeldung.httpclient.ResponseUtil;
+import com.baeldung.httpclient.ResponseUtil;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;

httpclient-simple/src/test/java/com/baeldung/test/LiveTestSuite.java

@@ -1,7 +1,7 @@
-package org.baeldung.test;
+package com.baeldung.test;
 
-import org.baeldung.client.ClientLiveTest;
+import com.baeldung.client.ClientLiveTest;
-import org.baeldung.client.RestClientLiveManualTest;
+import com.baeldung.client.RestClientLiveManualTest;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 

httpclient-simple/src/test/resources/test.in

@@ -0,0 +1 @@
+hello world