iSharkFly-Docs/java-tutorials
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[BAEL-3646] Fixing tests per review comments

Browse Source
This commit is contained in:
mike b 2020-03-19 20:15:52 -04:00
parent e58683f48b
commit f953196ddf
6 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spring-batch/src/main/java/org/baeldung/conditionalflow/step/NumberInfoClassifier.java
View File

@ -10,7 +10,8 @@ import org.springframework.batch.item.ItemProcessor;
import static org.baeldung.conditionalflow.NumberInfoDecider.NOTIFY;
import static org.baeldung.conditionalflow.NumberInfoDecider.QUIET;
public class NumberInfoClassifier extends ItemListenerSupport<NumberInfo, Integer> implements ItemProcessor<NumberInfo, Integer> {
public class NumberInfoClassifier extends ItemListenerSupport<NumberInfo, Integer>
implements ItemProcessor<NumberInfo, Integer> {
private StepExecution stepExecution;
@BeforeStep

1
spring-batch/src/main/java/org/baeldung/conditionalflow/step/NumberInfoClassifierWithDecider.java
View File

@ -13,5 +13,4 @@ public class NumberInfoClassifierWithDecider extends ItemListenerSupport<NumberI
public Integer process(NumberInfo numberInfo) throws Exception {
return Integer.valueOf(numberInfo.getNumber());
}
}

16
spring-batch/src/test/java/org/baeldung/conditionalflow/DeciderJobIntegrationTest.java
View File

@ -1,15 +1,12 @@
package org.baeldung.conditionalflow;
import org.baeldung.conditionalflow.config.NumberInfoConfig;
import org.junit.After;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.batch.core.ExitStatus;
import org.springframework.batch.core.JobExecution;
import org.springframework.batch.core.StepExecution;
import org.springframework.batch.test.AssertFile;
import org.springframework.batch.test.JobLauncherTestUtils;
import org.springframework.batch.test.JobRepositoryTestUtils;
import org.springframework.batch.test.context.SpringBatchTest;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
@ -37,17 +34,20 @@ public class DeciderJobIntegrationTest {
private JobLauncherTestUtils jobLauncherTestUtils;
@Test
public void whenNumberGeneratorDecider_thenNotifyStepRuns() throws Exception {
public void givenNumberGeneratorDecider_whenDeciderRuns_thenStatusIsNotify() throws Exception {
JobExecution jobExecution = jobLauncherTestUtils.launchJob();
Collection<StepExecution> actualStepExecutions = jobExecution.getStepExecutions();
ExitStatus actualJobExitStatus = jobExecution.getExitStatus();
assertEquals(actualJobExitStatus.getExitCode().toString(), "COMPLETED");
assertEquals(actualStepExecutions.size(), 2);
assertEquals("COMPLETED", actualJobExitStatus.getExitCode()
.toString());
assertEquals(2, actualStepExecutions.size());
boolean notifyStepDidRun = false;
Iterator<StepExecution> iterator = actualStepExecutions.iterator();
while(iterator.hasNext() && !notifyStepDidRun){
if(iterator.next().getStepName().equals("Notify step")){
while (iterator.hasNext() && !notifyStepDidRun) {
if (iterator.next()
.getStepName()
.equals("Notify step")) {
notifyStepDidRun = true;
}
}

10
spring-batch/src/test/java/org/baeldung/conditionalflow/model/NumberInfoUnitTest.java
View File

@ -12,7 +12,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
class NumberInfoUnitTest {
@Test
void whenPositive_isPositive() {
void givenPositive_whenFrom_isPositive() {
assertTrue(NumberInfo.from(1)
.isPositive());
assertTrue(NumberInfo.from(11)
@ -22,7 +22,7 @@ class NumberInfoUnitTest {
}
@Test
void whenNegative_isPositive_isFalse() {
void givenNegative_whenFrom_isNegative() {
assertFalse(NumberInfo.from(-1)
.isPositive());
assertFalse(NumberInfo.from(-10)
@ -30,7 +30,7 @@ class NumberInfoUnitTest {
}
@Test
void whenEven_isEven() {
void givenEven_whenFrom_isEven() {
assertTrue(NumberInfo.from(0)
.isEven());
assertTrue(NumberInfo.from(-2)
@ -44,7 +44,7 @@ class NumberInfoUnitTest {
}
@Test
void whenOdd_isEven_isFalse() {
void givenOdd_whenFrom_isOdd() {
assertFalse(NumberInfo.from(1)
.isEven());
@ -62,7 +62,7 @@ class NumberInfoUnitTest {
}
@Test
void testStatic_fromMethod_equals_getNumber() {
void giveGeneratedInt_whenFrom_isNumberFromGenerator() {
for (int i = -100; i < 100; i++) {
assertEquals(i, NumberInfo.from(i)
.getNumber());

2
spring-batch/src/test/java/org/baeldung/conditionalflow/step/NumberInfoClassifierUnitTest.java
View File

@ -8,7 +8,7 @@ import org.junit.jupiter.api.Test;
class NumberInfoClassifierUnitTest {
@Test
void process_convertsToInteger() throws Exception {
void givenNumberInfo_whenProcess_thenConvertsToInteger() throws Exception {
NumberInfoClassifier nic = new NumberInfoClassifier();
assertEquals(Integer.valueOf(4), nic.process(NumberInfo.from(4)));
assertEquals(Integer.valueOf(-4), nic.process(NumberInfo.from(-4)));

2
spring-batch/src/test/java/org/baeldung/conditionalflow/step/NumberInfoGeneratorUnitTest.java
View File

@ -8,7 +8,7 @@ import org.junit.jupiter.api.Test;
public class NumberInfoGeneratorUnitTest {
@Test
public void testGenerateNumbers_correctOrderAndValue() {
public void givenArray_whenGenerator_correctOrderAndValue() {
int[] numbers = new int[]{1, -2, 4, -10};
NumberInfoGenerator numberGenerator = new NumberInfoGenerator(numbers);
assertEquals(new NumberInfo(numbers[0]), numberGenerator.read());