diff --git a/httpclient/src/test/java/org/baeldung/httpclient/conn/MultiHttpClientConnThread.java b/httpclient/src/test/java/org/baeldung/httpclient/conn/MultiHttpClientConnThread.java index b21684fdbb..e29aa11a2b 100644 --- a/httpclient/src/test/java/org/baeldung/httpclient/conn/MultiHttpClientConnThread.java +++ b/httpclient/src/test/java/org/baeldung/httpclient/conn/MultiHttpClientConnThread.java @@ -1,8 +1,6 @@ package org.baeldung.httpclient.conn; import java.io.IOException; -import java.util.logging.Level; -import java.util.logging.Logger; import org.apache.http.HttpResponse; import org.apache.http.client.ClientProtocolException; @@ -10,52 +8,56 @@ import org.apache.http.client.methods.HttpGet; import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.conn.PoolingHttpClientConnectionManager; import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class MultiHttpClientConnThread extends Thread { + private final Logger logger = LoggerFactory.getLogger(getClass()); + private final CloseableHttpClient client; private final HttpGet get; - private PoolingHttpClientConnectionManager connManager = null; + + private PoolingHttpClientConnectionManager connManager; private static HttpResponse response; - private Logger logger; public int leasedConn; public MultiHttpClientConnThread(final CloseableHttpClient client, final HttpGet get, final PoolingHttpClientConnectionManager connManager) { this.client = client; this.get = get; this.connManager = connManager; - logger = Logger.getLogger(MultiHttpClientConnThread.class.getName()); - leasedConn = 0; + this.leasedConn = 0; } public MultiHttpClientConnThread(final CloseableHttpClient client, final HttpGet get) { this.client = client; this.get = get; - logger = Logger.getLogger(MultiHttpClientConnThread.class.getName()); } - public int getLeasedConn() { + // API + + public final int getLeasedConn() { return leasedConn; } - @Override - public void run() { + // + @Override + public final void run() { try { - if (this != null) - logger.log(Level.SEVERE, "Thread Running: " + getName()); + logger.info("Thread Running: " + getName()); + response = client.execute(get); if (connManager != null) { - logger.log(Level.SEVERE, "Leased Connections " + connManager.getTotalStats().getLeased()); + logger.info("Leased Connections " + connManager.getTotalStats().getLeased()); leasedConn = connManager.getTotalStats().getLeased(); - logger.log(Level.SEVERE, "Available Connections " + connManager.getTotalStats().getAvailable()); + logger.info("Available Connections " + connManager.getTotalStats().getAvailable()); } EntityUtils.consume(response.getEntity()); - } catch (final ClientProtocolException ex) { - + logger.error("", ex); } catch (final IOException ex) { - + logger.error("", ex); } - } + } diff --git a/httpclient/src/test/java/org/baeldung/httpclient/conn/TesterVersion_MultiHttpClientConnThread.java b/httpclient/src/test/java/org/baeldung/httpclient/conn/TesterVersion_MultiHttpClientConnThread.java index 9562ffbae1..99619d3023 100644 --- a/httpclient/src/test/java/org/baeldung/httpclient/conn/TesterVersion_MultiHttpClientConnThread.java +++ b/httpclient/src/test/java/org/baeldung/httpclient/conn/TesterVersion_MultiHttpClientConnThread.java @@ -1,49 +1,49 @@ package org.baeldung.httpclient.conn; import java.io.IOException; -import java.util.logging.Level; -import java.util.logging.Logger; import org.apache.http.client.ClientProtocolException; import org.apache.http.client.methods.HttpGet; import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.conn.PoolingHttpClientConnectionManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class TesterVersion_MultiHttpClientConnThread extends Thread { + private final Logger logger = LoggerFactory.getLogger(getClass()); + private final CloseableHttpClient client; private final HttpGet get; - private PoolingHttpClientConnectionManager connManager = null; - private Logger logger; + private PoolingHttpClientConnectionManager connManager; public int leasedConn; public TesterVersion_MultiHttpClientConnThread(final CloseableHttpClient client, final HttpGet get, final PoolingHttpClientConnectionManager connManager) { this.client = client; this.get = get; this.connManager = connManager; - logger = Logger.getLogger(TesterVersion_MultiHttpClientConnThread.class.getName()); leasedConn = 0; } - public int getLeasedConn() { + // + + public final int getLeasedConn() { return leasedConn; } @Override - public void run() { + public final void run() { try { - if (this != null) - logger.log(Level.SEVERE, "Thread Running: " + getName()); + logger.info("Thread Running: " + getName()); client.execute(get); if (connManager != null) { - logger.log(Level.SEVERE, "Leased Connections " + connManager.getTotalStats().getLeased()); + logger.info("Leased Connections " + connManager.getTotalStats().getLeased()); leasedConn = connManager.getTotalStats().getLeased(); - logger.log(Level.SEVERE, "Available Connections " + connManager.getTotalStats().getAvailable()); + logger.info("Available Connections " + connManager.getTotalStats().getAvailable()); } - } catch (final ClientProtocolException ex) { - + logger.error("", ex); } catch (final IOException ex) { - + logger.error("", ex); } }