Use the hashicorp/go-getter to download files
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 12:11:58 +01:00
|
|
|
package cleanhttp
|
|
|
|
|
|
|
|
import (
|
|
|
|
"net/http"
|
|
|
|
"strings"
|
|
|
|
"unicode"
|
|
|
|
)
|
|
|
|
|
|
|
|
// HandlerInput provides input options to cleanhttp's handlers
|
|
|
|
type HandlerInput struct {
|
|
|
|
ErrStatus int
|
|
|
|
}
|
|
|
|
|
|
|
|
// PrintablePathCheckHandler is a middleware that ensures the request path
|
|
|
|
// contains only printable runes.
|
|
|
|
func PrintablePathCheckHandler(next http.Handler, input *HandlerInput) http.Handler {
|
|
|
|
// Nil-check on input to make it optional
|
|
|
|
if input == nil {
|
|
|
|
input = &HandlerInput{
|
|
|
|
ErrStatus: http.StatusBadRequest,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Default to http.StatusBadRequest on error
|
|
|
|
if input.ErrStatus == 0 {
|
|
|
|
input.ErrStatus = http.StatusBadRequest
|
|
|
|
}
|
|
|
|
|
|
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
2020-05-11 21:26:01 +02:00
|
|
|
if r != nil {
|
|
|
|
// Check URL path for non-printable characters
|
|
|
|
idx := strings.IndexFunc(r.URL.Path, func(c rune) bool {
|
|
|
|
return !unicode.IsPrint(c)
|
|
|
|
})
|
|
|
|
|
|
|
|
if idx != -1 {
|
|
|
|
w.WriteHeader(input.ErrStatus)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if next != nil {
|
|
|
|
next.ServeHTTP(w, r)
|
|
|
|
}
|
Use the hashicorp/go-getter to download files
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 12:11:58 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return
|
|
|
|
})
|
|
|
|
}
|