packer-cn/.github/PULL_REQUEST_TEMPLATE.md

20 lines
758 B
Markdown
Raw Normal View History

**DELETE THIS TEMPLATE BEFORE SUBMITTING**
In order to have a good experience with our community, we recommend that you
read the contributing guidelines for making a PR, and understand the lifecycle
of a Packer PR:
https://github.com/hashicorp/packer/blob/master/.github/CONTRIBUTING.md#opening-an-pull-request
2016-03-01 22:31:07 -05:00
Describe the change you are making here!
2016-02-24 20:41:57 -05:00
2016-03-01 22:31:07 -05:00
Please include tests. Check out these examples:
2016-02-24 20:41:57 -05:00
2017-04-04 16:39:01 -04:00
- https://github.com/hashicorp/packer/blob/master/builder/virtualbox/common/ssh_config_test.go#L19-L37
- https://github.com/hashicorp/packer/blob/master/post-processor/compress/post-processor_test.go#L153-L182
2016-03-01 22:31:07 -05:00
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
2016-02-24 20:41:57 -05:00
Closes #xxx
Closes #xxx