Use the hashicorp/go-getter to download files
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 07:11:58 -04:00
|
|
|
# How to contribute
|
|
|
|
|
|
|
|
|
|
We'd love to accept your patches and contributions to this project. There are
|
|
|
|
|
just a few small guidelines you need to follow.
|
|
|
|
|
|
|
|
|
|
## Contributor License Agreement
|
|
|
|
|
|
|
|
|
|
Contributions to this project must be accompanied by a Contributor License
|
|
|
|
|
Agreement. You (or your employer) retain the copyright to your contribution,
|
|
|
|
|
this simply gives us permission to use and redistribute your contributions as
|
|
|
|
|
part of the project. Head over to <https://cla.developers.google.com/> to see
|
|
|
|
|
your current agreements on file or to sign a new one.
|
|
|
|
|
|
|
|
|
|
You generally only need to submit a CLA once, so if you've already submitted one
|
|
|
|
|
(even if it was for a different project), you probably don't need to do it
|
|
|
|
|
again.
|
|
|
|
|
|
|
|
|
|
## Code reviews
|
|
|
|
|
|
|
|
|
|
All submissions, including submissions by project members, require review. We
|
|
|
|
|
use GitHub pull requests for this purpose. Consult [GitHub Help] for more
|
|
|
|
|
information on using pull requests.
|
|
|
|
|
|
|
|
|
|
[GitHub Help]: https://help.github.com/articles/about-pull-requests/
|
|
|
|
|
|
|
|
|
|
## Instructions
|
|
|
|
|
|
|
|
|
|
Fork the repo, checkout the upstream repo to your GOPATH by:
|
|
|
|
|
|
|
|
|
|
```
|
|
|
|
|
$ go get -d go.opencensus.io
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Add your fork as an origin:
|
|
|
|
|
|
|
|
|
|
```
|
|
|
|
|
cd $(go env GOPATH)/src/go.opencensus.io
|
|
|
|
|
git remote add fork git@github.com:YOUR_GITHUB_USERNAME/opencensus-go.git
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Run tests:
|
|
|
|
|
|
|
|
|
|
```
|
2019-04-20 19:53:34 -04:00
|
|
|
$ make install-tools # Only first time.
|
|
|
|
|
$ make
|
Use the hashicorp/go-getter to download files
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 07:11:58 -04:00
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Checkout a new branch, make modifications and push the branch to your fork:
|
|
|
|
|
|
|
|
|
|
```
|
|
|
|
|
$ git checkout -b feature
|
|
|
|
|
# edit files
|
|
|
|
|
$ git commit
|
|
|
|
|
$ git push fork feature
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Open a pull request against the main opencensus-go repo.
|
2019-04-20 19:53:34 -04:00
|
|
|
|
|
|
|
|
## General Notes
|
|
|
|
|
This project uses Appveyor and Travis for CI.
|
|
|
|
|
|
|
|
|
|
The dependencies are managed with `go mod` if you work with the sources under your
|
|
|
|
|
`$GOPATH` you need to set the environment variable `GO111MODULE=on`.
|
