From 06b0cebd1e827633948b519ebb4fb7f7bc95b032 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Wed, 22 May 2013 14:39:32 -0700 Subject: [PATCH] packer: Template properly calls builder type builderType --- packer/template.go | 11 +++++++---- packer/template_test.go | 4 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packer/template.go b/packer/template.go index 467d3bf71..2a1c34f99 100644 --- a/packer/template.go +++ b/packer/template.go @@ -30,7 +30,7 @@ type Template struct { // raw configuration. If requested, this is used to compile into a full // builder configuration at some point. type rawBuilderConfig struct { - builderName string + builderType string rawConfig interface{} } @@ -88,7 +88,10 @@ func ParseTemplate(data []byte) (t *Template, err error) { continue } - t.Builders[name] = rawBuilderConfig{typeName, v} + t.Builders[name] = rawBuilderConfig{ + typeName, + v, + } } // If there were errors, we put it into a MultiError and return @@ -122,13 +125,13 @@ func (t *Template) Build(name string, components *ComponentFinder) (b Build, err return } - builder, err := components.Builder(builderConfig.builderName) + builder, err := components.Builder(builderConfig.builderType) if err != nil { return } if builder == nil { - err = fmt.Errorf("Builder not found: %s", name) + err = fmt.Errorf("Builder type not found: %s", builderConfig.builderType) return } diff --git a/packer/template_test.go b/packer/template_test.go index 7aaf4eb81..00754b0e3 100644 --- a/packer/template_test.go +++ b/packer/template_test.go @@ -91,7 +91,7 @@ func TestParseTemplate_BuilderWithoutName(t *testing.T) { builder, ok := result.Builders["amazon-ebs"] assert.True(ok, "should have amazon-ebs builder") - assert.Equal(builder.builderName, "amazon-ebs", "builder should be amazon-ebs") + assert.Equal(builder.builderType, "amazon-ebs", "builder should be amazon-ebs") } func TestParseTemplate_BuilderWithName(t *testing.T) { @@ -116,7 +116,7 @@ func TestParseTemplate_BuilderWithName(t *testing.T) { builder, ok := result.Builders["bob"] assert.True(ok, "should have bob builder") - assert.Equal(builder.builderName, "amazon-ebs", "builder should be amazon-ebs") + assert.Equal(builder.builderType, "amazon-ebs", "builder should be amazon-ebs") } func TestParseTemplate_BuilderWithConflictingName(t *testing.T) {