After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.

This commit is contained in:
Eric Mowry 2019-02-28 21:36:25 -05:00
parent e74a81e27b
commit 109ba2c54c
1 changed files with 10 additions and 1 deletions

View File

@ -102,7 +102,16 @@ func (s *StepConfigureVMX) Run(_ context.Context, state multistep.StateBag) mult
}
}
vmxData["extendedconfigfile"] = fmt.Sprintf("%s.vmxf", s.DisplayName)
// Set the extendedConfigFile setting for the .vmxf filename to the VMName
// if displayName is not set. This is needed so that when VMWare creates
// the .vmxf file it matches the displayName if it is set. When just using
// the sisplayName if it was empty VMWare would make a file named ".vmxf".
// The ".vmxf" file would not get deleted when the VM got deleted.
if s.DisplayName != "" {
vmxData["extendedconfigfile"] = fmt.Sprintf("%s.vmxf", s.DisplayName)
} else {
vmxData["extendedconfigfile"] = fmt.Sprintf("%s.vmxf", s.VMName)
}
err = WriteVMX(vmxPath, vmxData)