From 1e162ffd26747907bef07eab778187648a9bf9dc Mon Sep 17 00:00:00 2001 From: Matthew Hooker Date: Mon, 9 Oct 2017 21:31:19 -0700 Subject: [PATCH] skip doc PRs in changelog helper --- scripts/prepare_changelog.sh | 63 ++++++++++++++++++++++++++++-------- 1 file changed, 50 insertions(+), 13 deletions(-) diff --git a/scripts/prepare_changelog.sh b/scripts/prepare_changelog.sh index f44bd93bd..5834c639f 100755 --- a/scripts/prepare_changelog.sh +++ b/scripts/prepare_changelog.sh @@ -1,27 +1,64 @@ #!/bin/zsh - LAST_RELEASE=$1 +DO_PR_CHECK=1 + +set -o pipefail + +is_doc_pr(){ + if ! (($+commands[jq])); then + DO_PR_CHECK=0 + echo "jq not found" + return 1 + fi + PR_NUM=$1 + out=$(curl -fsS "https://api.github.com/repos/hashicorp/packer/issues/${PR_NUM}" | jq '[.labels[].name == "docs"] | any') + exy="$?" + if [ $exy -ne 0 ]; then + echo "bad response from github" + exit $exy + fi + grep -q true <<< $out + return $? +} if [ -z $LAST_RELEASE ]; then echo "you need to give the previous release version. prepare_changelog.sh v" exit 1 fi +get_prs(){ + # git log --merges v0.10.2...c3861d167533fb797b0fae0c380806625712e5f7 | + git log --merges HEAD...${LAST_RELEASE} | + grep -o "Merge pull request #\(\d\+\)" | awk -F\# '{print $2}' | while read line + do + grep -q "GH-${line}" CHANGELOG.md + if [ $? -ne 0 ]; then + echo $line + fi + done | while read PR_NUM + do + if (($DO_PR_CHECK)) && is_doc_pr $PR_NUM; then + continue + fi + echo "https://github.com/hashicorp/packer/pull/${PR_NUM}" + done +} -# git log --merges v0.10.2...c3861d167533fb797b0fae0c380806625712e5f7 | -git log --merges HEAD...${LAST_RELEASE} | -grep -o "Merge pull request #\(\d\+\)" | awk -F\# '{print $2}' | while read line -do - grep -q "GH-${line}" CHANGELOG.md - if [ $? -ne 0 ]; then - echo $line - fi -done | while read line -do - echo "https://github.com/hashicorp/packer/pull/${line}" - #TODO get tags. ignore docs +#is_doc_pr 52061111 +# is_doc_pr 5206 # non-doc pr +#is_doc_pr 5434 # doc pr +#echo $? +#exit + +# prpid=$! +# trap 'kill -9 ${prpid}; exit' INT TERM + +get_prs | while read line; do echo $line + if [[ "$line" =~ "bad" ]]; then + exit 1 + fi vared -ch ok done