From 328baced05c8b9d82ec39a5f3eb950cfb6473757 Mon Sep 17 00:00:00 2001 From: Miles Crabill Date: Mon, 16 Sep 2019 10:18:22 -0700 Subject: [PATCH] add some test cases for image names --- builder/googlecompute/config_test.go | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/builder/googlecompute/config_test.go b/builder/googlecompute/config_test.go index f247775d6..a884d7f8b 100644 --- a/builder/googlecompute/config_test.go +++ b/builder/googlecompute/config_test.go @@ -156,6 +156,24 @@ func TestConfigPrepare(t *testing.T) { "foo bar", true, }, + { + // underscore will be replaced + "image_name", + "foo_bar", + false, + }, + { + // too long + "image_name", + "foobar123xyz_abc-456-one-two_three_five_nine_seventeen_eleventy-seven", + true, + }, + { + // starts with non-alphabetic character + "image_name", + "1boohoo", + true, + }, { "image_encryption_key", map[string]string{"kmsKeyName": "foo"},