This commit is contained in:
Mitchell Hashimoto 2013-05-10 17:01:24 -07:00
parent 368ccab8e8
commit 44bd56c3a8
28 changed files with 53 additions and 58 deletions

View File

@ -54,10 +54,10 @@ func (b *Builder) Run(build packer.Build, ui packer.Ui) {
ec2conn := ec2.New(auth, region)
runOpts := &ec2.RunInstances{
ImageId: b.config.SourceAmi,
ImageId: b.config.SourceAmi,
InstanceType: "m1.small",
MinCount: 0,
MaxCount: 0,
MinCount: 0,
MaxCount: 0,
}
ui.Say("Launching a source AWS instance...\n")
@ -97,7 +97,7 @@ func (b *Builder) Run(build packer.Build, ui packer.Ui) {
ui.Say("Creating the AMI...\n")
createOpts := &ec2.CreateImage{
InstanceId: instance.InstanceId,
Name: b.config.AMIName,
Name: b.config.AMIName,
}
createResp, err := ec2conn.CreateImage(createOpts)

View File

@ -17,7 +17,7 @@ func TestBuilder_Prepare_BadType(t *testing.T) {
assert := asserts.NewTestingAsserts(t, true)
b := &Builder{}
c := map[string]interface{} {
c := map[string]interface{}{
"access_key": []string{},
}
@ -29,7 +29,7 @@ func TestBuilder_Prepare_Good(t *testing.T) {
assert := asserts.NewTestingAsserts(t, true)
b := &Builder{}
c := map[string]interface{} {
c := map[string]interface{}{
"access_key": "foo",
"secret_key": "bar",
"source_ami": "123456",

View File

@ -1,6 +1,5 @@
package build
import (
"bytes"
"cgl.tideland.biz/asserts"

View File

@ -2,9 +2,9 @@
package main
import (
"fmt"
"github.com/mitchellh/packer/packer"
"github.com/mitchellh/packer/packer/plugin"
"fmt"
"io/ioutil"
"log"
"os"

View File

@ -15,8 +15,8 @@ type Build interface {
// multiple files, of course, but it should be for only a single provider
// (such as VirtualBox, EC2, etc.).
type coreBuild struct {
name string
builder Builder
name string
builder Builder
rawConfig interface{}
prepareCalled bool

View File

@ -8,9 +8,9 @@ import (
type TestBuilder struct {
prepareCalled bool
prepareConfig interface{}
runCalled bool
runBuild Build
runUi Ui
runCalled bool
runBuild Build
runUi Ui
}
func (tb *TestBuilder) Prepare(config interface{}) error {
@ -27,8 +27,8 @@ func (tb *TestBuilder) Run(b Build, ui Ui) {
func testBuild() Build {
return &coreBuild{
name: "test",
builder: &TestBuilder{},
name: "test",
builder: &TestBuilder{},
rawConfig: 42,
}
}

View File

@ -13,4 +13,3 @@ type Builder interface {
Prepare(config interface{}) error
Run(build Build, ui Ui)
}

View File

@ -1,9 +1,9 @@
package packer
type TestCommand struct {
runArgs []string
runArgs []string
runCalled bool
runEnv Environment
runEnv Environment
}
func (tc *TestCommand) Run(env Environment, args []string) int {

View File

@ -31,17 +31,17 @@ type Environment interface {
// environment.
type coreEnvironment struct {
builderFunc BuilderFunc
commands []string
commands []string
commandFunc CommandFunc
ui Ui
ui Ui
}
// This struct configures new environments.
type EnvironmentConfig struct {
BuilderFunc BuilderFunc
CommandFunc CommandFunc
Commands []string
Ui Ui
Commands []string
Ui Ui
}
// DefaultEnvironmentConfig returns a default EnvironmentConfig that can

View File

@ -2,15 +2,15 @@ package plugin
import (
"github.com/mitchellh/packer/packer"
packrpc "github.com/mitchellh/packer/packer/rpc"
"log"
"net/rpc"
"os/exec"
packrpc "github.com/mitchellh/packer/packer/rpc"
)
type cmdBuilder struct {
builder packer.Builder
client *client
client *client
}
func (b *cmdBuilder) Prepare(config interface{}) error {
@ -39,7 +39,6 @@ func (c *cmdBuilder) checkExit(p interface{}, cb func()) {
}
}
// Returns a valid packer.Builder where the builder is executed via RPC
// to a plugin that is within a subprocess.
//

View File

@ -28,4 +28,3 @@ func TestBuilder_Good(t *testing.T) {
_, err := Builder(helperProcess("builder"))
assert.Nil(err, "should start builder properly")
}

View File

@ -16,8 +16,8 @@ import (
var managedClients = make([]*client, 0, 5)
type client struct {
cmd *exec.Cmd
exited bool
cmd *exec.Cmd
exited bool
doneLogging bool
}

View File

@ -2,15 +2,15 @@ package plugin
import (
"github.com/mitchellh/packer/packer"
packrpc "github.com/mitchellh/packer/packer/rpc"
"log"
"net/rpc"
"os/exec"
packrpc "github.com/mitchellh/packer/packer/rpc"
)
type cmdCommand struct {
command packer.Command
client *client
client *client
}
func (c *cmdCommand) Run(e packer.Environment, args []string) (exitCode int) {

View File

@ -10,11 +10,11 @@ package plugin
import (
"fmt"
"github.com/mitchellh/packer/packer"
packrpc "github.com/mitchellh/packer/packer/rpc"
"log"
"net"
"net/rpc"
"os"
packrpc "github.com/mitchellh/packer/packer/rpc"
"strconv"
"strings"
)

View File

@ -8,7 +8,7 @@ import (
"time"
)
func helperProcess(s... string) *exec.Cmd {
func helperProcess(s ...string) *exec.Cmd {
cs := []string{"-test.run=TestHelperProcess", "--"}
cs = append(cs, s...)
env := []string{

View File

@ -42,7 +42,7 @@ func (b *Build) Run(ui packer.Ui) {
b.client.Call("Build.Run", args, new(interface{}))
}
func (b *BuildServer) Name(args *interface{}, reply*string) error {
func (b *BuildServer) Name(args *interface{}, reply *string) error {
*reply = b.build.Name()
return nil
}

View File

@ -8,10 +8,10 @@ import (
)
type testBuild struct {
nameCalled bool
nameCalled bool
prepareCalled bool
runCalled bool
runUi packer.Ui
runCalled bool
runUi packer.Ui
}
func (b *testBuild) Name() string {

View File

@ -10,9 +10,9 @@ import (
type testBuilder struct {
prepareCalled bool
prepareConfig interface{}
runCalled bool
runBuild packer.Build
runUi packer.Ui
runCalled bool
runBuild packer.Build
runUi packer.Ui
}
func (b *testBuilder) Prepare(config interface{}) error {

View File

@ -19,7 +19,7 @@ type CommandServer struct {
type CommandRunArgs struct {
RPCAddress string
Args []string
Args []string
}
type CommandSynopsisArgs byte

View File

@ -8,9 +8,9 @@ import (
)
type TestCommand struct {
runArgs []string
runArgs []string
runCalled bool
runEnv packer.Environment
runEnv packer.Environment
}
func (tc *TestCommand) Run(env packer.Environment, args []string) int {

View File

@ -12,10 +12,10 @@ var testEnvUi = &testUi{}
type testEnvironment struct {
builderCalled bool
builderName string
cliCalled bool
cliArgs []string
uiCalled bool
builderName string
cliCalled bool
cliArgs []string
uiCalled bool
}
func (e *testEnvironment) Builder(name string) (packer.Builder, error) {

View File

@ -9,7 +9,7 @@ import (
func addrPort(address net.Addr) string {
parts := strings.Split(address.String(), ":")
return parts[len(parts) - 1]
return parts[len(parts)-1]
}
func Test_netListenerInRange(t *testing.T) {

View File

@ -1,2 +1 @@
package rpc

View File

@ -19,7 +19,7 @@ type UiServer struct {
type UiSayArgs struct {
Format string
Vars []interface{}
Vars []interface{}
}
func (u *Ui) Error(format string, a ...interface{}) {

View File

@ -9,10 +9,10 @@ import (
type testUi struct {
errorCalled bool
errorFormat string
errorVars []interface{}
sayCalled bool
sayFormat string
sayVars []interface{}
errorVars []interface{}
sayCalled bool
sayFormat string
sayVars []interface{}
}
func (u *testUi) Error(format string, a ...interface{}) {

View File

@ -111,8 +111,8 @@ func (t *Template) Build(name string, bf BuilderFunc) (b Build, err error) {
}
b = &coreBuild{
name: name,
builder: builder,
name: name,
builder: builder,
rawConfig: builderConfig.rawConfig,
}

View File

@ -178,7 +178,7 @@ func TestTemplate_Build(t *testing.T) {
}
`
expectedConfig := map[string]interface{} {
expectedConfig := map[string]interface{}{
"name": "test1",
"type": "test-builder",
}
@ -187,7 +187,7 @@ func TestTemplate_Build(t *testing.T) {
assert.Nil(err, "should not error")
builder := testBuilder()
builderMap := map[string]Builder {
builderMap := map[string]Builder{
"test-builder": builder,
}

View File

@ -8,7 +8,7 @@ import "io"
// is formatted and various levels of output.
type Ui interface {
Say(format string, a ...interface{})
Error(format string, a...interface{})
Error(format string, a ...interface{})
}
// The ReaderWriterUi is a UI that writes and reads from standard Go