Merge pull request #2296 from mitchellh/f-amazon-chroot-mount-options

builder/amazon-chroot: add mount_options configuration option
This commit is contained in:
Clint 2015-06-23 11:55:56 -05:00
commit 5b67472d07
3 changed files with 24 additions and 2 deletions

View File

@ -35,6 +35,7 @@ type Config struct {
MountPath string `mapstructure:"mount_path"`
SourceAmi string `mapstructure:"source_ami"`
RootVolumeSize int64 `mapstructure:"root_volume_size"`
MountOptions []string `mapstructure:"mount_options"`
ctx interpolate.Context
}
@ -165,7 +166,9 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe
},
&StepAttachVolume{},
&StepEarlyUnflock{},
&StepMountDevice{},
&StepMountDevice{
MountOptions: b.config.MountOptions,
},
&StepMountExtra{},
&StepCopyFiles{},
&StepChrootProvision{},

View File

@ -6,6 +6,7 @@ import (
"log"
"os"
"path/filepath"
"strings"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/mitchellh/multistep"
@ -23,6 +24,8 @@ type mountPathData struct {
// mount_path string - The location where the volume was mounted.
// mount_device_cleanup CleanupFunc - To perform early cleanup
type StepMountDevice struct {
MountOptions []string
mountPath string
}
@ -70,8 +73,15 @@ func (s *StepMountDevice) Run(state multistep.StateBag) multistep.StepAction {
ui.Say("Mounting the root device...")
stderr := new(bytes.Buffer)
// build mount options from mount_options config, usefull for nouuid options
// or other specific device type settings for mount
opts := ""
if len(s.MountOptions) > 0 {
opts = "-o " + strings.Join(s.MountOptions, " -o ")
}
mountCommand, err := wrappedCommand(
fmt.Sprintf("mount %s %s", deviceMount, mountPath))
fmt.Sprintf("mount %s %s %s", opts, deviceMount, mountPath))
if err != nil {
err := fmt.Errorf("Error creating mount command: %s", err)
state.Put("error", err)

View File

@ -133,6 +133,12 @@ AMI if one with the same name already exists. Default `false`.
template where the `.Device` variable is replaced with the name of the
device where the volume is attached.
* `mount_options` (array of strings)  Options to supply the `mount` command
when mounting devices. Each option will be prefixed with `-o ` and supplied to
the `mount` command ran by Packer. Because this command is ran in a shell, user
discrestion is advised. See [this manual page for the mount command][1] for valid
file system specific options
* `root_volume_size` (integer)  The size of the root volume for the chroot
environment, and the resulting AMI
@ -225,3 +231,6 @@ prevent packages installed by your provisioners from starting services:
]
}
```
[1]: http://linuxcommand.org/man_pages/mount8.html