iSharkFly-Docs
/
packer-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

communicator/ssh: Clearer TODO message about acks

This commit is contained in:
Mitchell Hashimoto 2013-05-24 09:40:20 -07:00
parent 3a9069037e
commit 69f1d0fd9f
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
communicator/ssh/communicator.go
View File

@ -125,7 +125,10 @@ func (c *comm) Upload(path string, input io.Reader) error {
// Start the protocol
fmt.Fprintln(w, "C0644", input_memory.Len(), target_file)
io.Copy(w, input_memory)
fmt.Fprint(w, "\x00") // XXX(mitchellh): WHY?
fmt.Fprint(w, "\x00")
// TODO(mitchellh): Each step above results in a 0/1/2 being sent by
// the remote side to confirm. We should check for those confirmations.
// Close the stdin, which sends an EOF, and then set w to nil so that
// our defer func doesn't close it again since that is unsafe with
@ -147,9 +150,8 @@ func (c *comm) Upload(path string, input io.Reader) error {
}
// TODO(mitchellh): Check for return data (expect a 0 or error)
log.Printf("scp stdout: %s", stdout.String())
log.Printf("scp stderr: %s", stderr.String())
log.Printf("scp stdout (length %d): %#v", stdout.Len(), stdout.Bytes())
log.Printf("scp stderr (length %d): %s", stderr.Len(), stderr.String())
return nil
}