Merge pull request #2548 from mitchellh/makefile

Use go vet instead of go tool vet, and actually run it with make
This commit is contained in:
Chris Bednarski 2015-08-03 11:44:47 -07:00
commit 6a2bedb699
1 changed files with 3 additions and 5 deletions

View File

@ -1,8 +1,6 @@
TEST?=./...
VETARGS?=-asmdecl -atomic -bool -buildtags -copylocks -methods \
-nilfunc -printf -rangeloops -shift -structtags -unsafeptr
default: test
default: test vet dev
bin:
@sh -c "$(CURDIR)/scripts/build.sh"
@ -41,10 +39,10 @@ updatedeps:
| xargs go get -f -u -v
vet:
@go tool vet 2>/dev/null ; if [ $$? -eq 3 ]; then \
@go vet 2>/dev/null ; if [ $$? -eq 3 ]; then \
go get golang.org/x/tools/cmd/vet; \
fi
@go tool vet $(VETARGS) . ; if [ $$? -eq 1 ]; then \
@go vet ./... ; if [ $$? -eq 1 ]; then \
echo ""; \
echo "Vet found suspicious constructs. Please check the reported constructs"; \
echo "and fix them if necessary before submitting the code for reviewal."; \