diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 97ff978d6..3df8f5a6b 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -292,3 +292,12 @@ make testacc TEST=./builder/amazon/ebs TESTARGS="-run TestBuilderAcc_forceDelete Acceptance tests typically require other environment variables to be set for things such as API tokens and keys. Each test should error and tell you which credentials are missing, so those are not documented here. + +#### Debugging Plugins + +Each packer plugin runs in a separate process and communicates with RCP over a +socket therefore using a debugger will not work (be complicated at least). + +But most of the Packer code is really simple and easy to follow with PACKER_LOG +turned on. If that doesn't work adding some extra debug print outs when you have +homed in on the problem is usually enough. diff --git a/CODEOWNERS b/CODEOWNERS index bb416e3cc..0bbc1d4b7 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -14,6 +14,7 @@ /builder/profitbricks/ @jasmingacic /builder/triton/ @sean- /builder/ncloud/ @YuSungDuk +/builder/proxmox/ @carlpett /builder/scaleway/ @sieben @mvaude @jqueuniet @fflorens @brmzkw /builder/hcloud/ @LKaemmerling /builder/hyperone @m110 @gregorybrzeski @ad-m diff --git a/go.mod b/go.mod index 4dc5d52da..a132d598c 100644 --- a/go.mod +++ b/go.mod @@ -135,3 +135,5 @@ require ( gopkg.in/ini.v1 v1.42.0 // indirect gopkg.in/jarcoal/httpmock.v1 v1.0.0-20181117152235-275e9df93516 // indirect ) + +replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999 diff --git a/go.sum b/go.sum index 1d48c54fa..4fc7f942b 100644 --- a/go.sum +++ b/go.sum @@ -38,6 +38,7 @@ github.com/antchfx/xquery v0.0.0-20170730121040-eb8c3c172607 h1:BFFG6KP8ASFBg2pt github.com/antchfx/xquery v0.0.0-20170730121040-eb8c3c172607/go.mod h1:LzD22aAzDP8/dyiCKFp31He4m2GPjl0AFyzDtZzUu9M= github.com/antihax/optional v0.0.0-20180407024304-ca021399b1a6 h1:uZuxRZCz65cG1o6K/xUqImNcYKtmk9ylqaH0itMSvzA= github.com/antihax/optional v0.0.0-20180407024304-ca021399b1a6/go.mod h1:V8iCPQYkqmusNa815XgQio277wI47sdRh1dUOLdyC6Q= +github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ= github.com/approvals/go-approval-tests v0.0.0-20160714161514-ad96e53bea43 h1:ePCAQPf5tUc5IMcUvu6euhSGna7jzs7eiXtJXHig6Zc= github.com/approvals/go-approval-tests v0.0.0-20160714161514-ad96e53bea43/go.mod h1:S6puKjZ9ZeqUPBv2hEBnMZGcM2J6mOsDRQcmxkMAND0= github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o= diff --git a/website/source/docs/other/debugging.html.md b/website/source/docs/other/debugging.html.md index 367e81061..c10e65da6 100644 --- a/website/source/docs/other/debugging.html.md +++ b/website/source/docs/other/debugging.html.md @@ -71,6 +71,15 @@ to force the log to always go to a specific file when logging is enabled. Note that even when `PACKER_LOG_PATH` is set, `PACKER_LOG` must be set in order for any logging to be enabled. +### Debugging Plugins + +Each packer plugin runs in a separate process and communicates with RCP over a +socket therefore using a debugger will not work (be complicated at least). + +But most of the Packer code is really simple and easy to follow with PACKER_LOG +turned on. If that doesn't work adding some extra debug print outs when you have +homed in on the problem is usually enough. + ### Debugging Packer in Powershell/Windows In Windows you can set the detailed logs environmental variable `PACKER_LOG` or