From 7b0000cd4c6425f276e8b9899bdc4037238a65ee Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Sun, 9 Jun 2013 23:05:11 -0700 Subject: [PATCH] packer: Actually return if prepare of a build fails --- packer/build.go | 1 + packer/rpc/build.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packer/build.go b/packer/build.go index da09ccbc2..5c4815d28 100644 --- a/packer/build.go +++ b/packer/build.go @@ -47,6 +47,7 @@ func (b *coreBuild) Prepare(ui Ui) (err error) { err = b.builder.Prepare(b.builderConfig) if err != nil { log.Printf("Build '%s' prepare failure: %s\n", b.name, err) + return } // Prepare the provisioners diff --git a/packer/rpc/build.go b/packer/rpc/build.go index ebaa30628..c0cd5fde4 100644 --- a/packer/rpc/build.go +++ b/packer/rpc/build.go @@ -41,8 +41,8 @@ func (b *build) Prepare(ui packer.Ui) (err error) { RegisterUi(server, ui) args := &BuildPrepareArgs{serveSingleConn(server)} - if err := b.client.Call("Build.Prepare", args, &err); err != nil { - panic(err) + if cerr := b.client.Call("Build.Prepare", args, &err); cerr != nil { + panic(cerr) } return