packer/rpc: complete command

packer/rpc/command.go

@@ -20,8 +20,8 @@ type CommandServer struct {
 }
 
 type CommandRunArgs struct {
-	RPCAddress string
 	Args       []string
+	StreamId   uint32
 }
 
 type CommandSynopsisArgs byte
@@ -40,11 +40,15 @@ func (c *command) Help() (result string) {
 }
 
 func (c *command) Run(env packer.Environment, args []string) (result int) {
-	// Create and start the server for the Environment
+	nextId := c.mux.NextId()
-	server := rpc.NewServer()
+	server := NewServerWithMux(c.mux, nextId)
-	RegisterEnvironment(server, env)
+	server.RegisterEnvironment(env)
+	go server.Serve()
 
-	rpcArgs := &CommandRunArgs{serveSingleConn(server), args}
+	rpcArgs := &CommandRunArgs{
+		Args: args,
+		StreamId: nextId,
+	}
 	err := c.client.Call("Command.Run", rpcArgs, &result)
 	if err != nil {
 		panic(err)
@@ -68,14 +72,13 @@ func (c *CommandServer) Help(args *interface{}, reply *string) error {
 }
 
 func (c *CommandServer) Run(args *CommandRunArgs, reply *int) error {
-	client, err := rpcDial(args.RPCAddress)
+	client, err := NewClientWithMux(c.mux, args.StreamId)
 	if err != nil {
-		return err
+		return NewBasicError(err)
 	}
+	defer client.Close()
 
-	env := &Environment{client: client}
+	*reply = c.command.Run(client.Environment(), args.Args)
-
-	*reply = c.command.Run(env, args.Args)
 	return nil
 }
 

packer/rpc/command_test.go

@@ -59,11 +59,6 @@ func TestRPCCommand(t *testing.T) {
 		t.Fatal("runEnv should not be nil")
 	}
 
-	command.runEnv.Ui()
-	if !testEnv.uiCalled {
-		t.Fatal("ui should be called")
-	}
-
 	// Test Synopsis
 	synopsis := commClient.Synopsis()
 	if synopsis != "foo" {

packer/rpc/post_processor.go

@@ -30,10 +30,6 @@ type PostProcessorProcessResponse struct {
 	StreamId uint32
 }
 
-func PostProcessor(client *rpc.Client) *postProcessor {
-	return &postProcessor{client: client}
-}
-
 func (p *postProcessor) Configure(raw ...interface{}) (err error) {
 	args := &PostProcessorConfigureArgs{Configs: raw}
 	if cerr := p.client.Call("PostProcessor.Configure", args, &err); cerr != nil {

packer/rpc/post_processor_test.go

@@ -83,7 +83,7 @@ func TestPostProcessorRPC(t *testing.T) {
 
 func TestPostProcessor_Implements(t *testing.T) {
 	var raw interface{}
-	raw = PostProcessor(nil)
+	raw = new(postProcessor)
 	if _, ok := raw.(packer.PostProcessor); !ok {
 		t.Fatal("not a postprocessor")
 	}