packer: Clean up some of the JSON syntax stuff

CHANGELOG.md

@@ -1,6 +1,8 @@
 ## 0.1.4 (unreleased)
 
+IMPROVEMENTS:
 
+* core: Template syntax errors now show line and character number. [GH-56]
 
 ## 0.1.3 (July 1, 2013)
 

packer/template.go

@@ -57,29 +57,6 @@ type rawProvisionerConfig struct {
 	rawConfig interface{}
 }
 
-// displaySyntaxError returns a location for the json syntax error
-// Adapted from:
-// https://groups.google.com/forum/#!topic/golang-nuts/fizimmXtVfc
-func displaySyntaxError(js []byte, syntaxError error) (err error) {
-	syntax, ok := syntaxError.(*json.SyntaxError)
-	if !ok {
-		err = syntaxError
-		return
-	}
-	newline := []byte{'\x0a'}
-	space := []byte{' '}
-
-	start, end := bytes.LastIndex(js[:syntax.Offset], newline)+1, len(js)
-	if idx := bytes.Index(js[start:], newline); idx >= 0 {
-		end = start + idx
-	}
-	
-	line, pos := bytes.Count(js[:start], newline)+1, int(syntax.Offset) - start - 1
-	
-	err = fmt.Errorf("\nError in line %d: %s \n%s\n%s^", line, syntaxError, js[start:end], bytes.Repeat(space, pos))
-	return
-}
-
 // ParseTemplate takes a byte slice and parses a Template from it, returning
 // the template and possibly errors while loading the template. The error
 // could potentially be a MultiError, representing multiple errors. Knowing
@@ -89,7 +66,27 @@ func ParseTemplate(data []byte) (t *Template, err error) {
 	var rawTpl rawTemplate
 	err = json.Unmarshal(data, &rawTpl)
 	if err != nil {
-		err = displaySyntaxError(data, err)
+		syntaxErr, ok := err.(*json.SyntaxError)
+		if !ok {
+			return
+		}
+
+		// We have a syntax error. Extract out the line number and friends.
+		// https://groups.google.com/forum/#!topic/golang-nuts/fizimmXtVfc
+		newline := []byte{'\x0a'}
+
+		start := bytes.LastIndex(data[:syntaxErr.Offset], newline)+1
+		end := len(data)
+		if idx := bytes.Index(data[start:], newline); idx >= 0 {
+			end = start + idx
+		}
+
+		line := bytes.Count(data[:start], newline)+1
+		pos := int(syntaxErr.Offset) - start - 1
+
+		err = fmt.Errorf("Error in line %d, char %d: %s\n%s",
+			line, pos, syntaxErr, data[start:end])
+
 		return
 	}
 
@@ -231,151 +228,151 @@ func parsePostProvisioner(i int, rawV interface{}) (result []map[string]interfac
 				errors = append(
 					errors,
 					fmt.Errorf("Post-processor %d.%d: sequences not allowed to be nested in sequences", i+1, j+1))
-			default:
+				default:
-				errors = append(errors, fmt.Errorf("Post-processor %d.%d is in a bad format.", i+1, j+1))
+					errors = append(errors, fmt.Errorf("Post-processor %d.%d is in a bad format.", i+1, j+1))
+				}
 			}
+
+			if len(errors) == 0 {
+				errors = nil
+			}
+		default:
+			result = nil
+			errors = []error{fmt.Errorf("Post-processor %d is in a bad format.", i+1)}
 		}
 
-		if len(errors) == 0 {
-			errors = nil
-		}
-	default:
-		result = nil
-		errors = []error{fmt.Errorf("Post-processor %d is in a bad format.", i+1)}
-	}
-
-	return
-}
-
-// BuildNames returns a slice of the available names of builds that
-// this template represents.
-func (t *Template) BuildNames() []string {
-	names := make([]string, 0, len(t.Builders))
-	for name, _ := range t.Builders {
-		names = append(names, name)
-	}
-
-	return names
-}
-
-// Build returns a Build for the given name.
-//
-// If the build does not exist as part of this template, an error is
-// returned.
-func (t *Template) Build(name string, components *ComponentFinder) (b Build, err error) {
-	// Setup the Builder
-	builderConfig, ok := t.Builders[name]
-	if !ok {
-		err = fmt.Errorf("No such build found in template: %s", name)
 		return
 	}
 
-	// We panic if there is no builder function because this is really
+	// BuildNames returns a slice of the available names of builds that
-	// an internal bug that always needs to be fixed, not an error.
+	// this template represents.
-	if components.Builder == nil {
+	func (t *Template) BuildNames() []string {
-		panic("no builder function")
+		names := make([]string, 0, len(t.Builders))
-	}
+		for name, _ := range t.Builders {
-
+			names = append(names, name)
-	// Panic if there are provisioners on the template but no provisioner
-	// component finder. This is always an internal error, so we panic.
-	if len(t.Provisioners) > 0 && components.Provisioner == nil {
-		panic("no provisioner function")
-	}
-
-	builder, err := components.Builder(builderConfig.Type)
-	if err != nil {
-		return
-	}
-
-	if builder == nil {
-		err = fmt.Errorf("Builder type not found: %s", builderConfig.Type)
-		return
-	}
-
-	// Gather the Hooks
-	hooks := make(map[string][]Hook)
-	for tplEvent, tplHooks := range t.Hooks {
-		curHooks := make([]Hook, 0, len(tplHooks))
-
-		for _, hookName := range tplHooks {
-			var hook Hook
-			hook, err = components.Hook(hookName)
-			if err != nil {
-				return
-			}
-
-			if hook == nil {
-				err = fmt.Errorf("Hook not found: %s", hookName)
-				return
-			}
-
-			curHooks = append(curHooks, hook)
 		}
 
-		hooks[tplEvent] = curHooks
+		return names
 	}
 
-	// Prepare the post-processors
+	// Build returns a Build for the given name.
-	postProcessors := make([][]coreBuildPostProcessor, 0, len(t.PostProcessors))
+	//
-	for _, rawPPs := range t.PostProcessors {
+	// If the build does not exist as part of this template, an error is
-		current := make([]coreBuildPostProcessor, len(rawPPs))
+	// returned.
-		for i, rawPP := range rawPPs {
+	func (t *Template) Build(name string, components *ComponentFinder) (b Build, err error) {
-			pp, err := components.PostProcessor(rawPP.Type)
+		// Setup the Builder
-			if err != nil {
+		builderConfig, ok := t.Builders[name]
-				return nil, err
+		if !ok {
-			}
+			err = fmt.Errorf("No such build found in template: %s", name)
-
+			return
-			if pp == nil {
-				return nil, fmt.Errorf("PostProcessor type not found: %s", rawPP.Type)
-			}
-
-			current[i] = coreBuildPostProcessor{
-				processor:         pp,
-				processorType:     rawPP.Type,
-				config:            rawPP.rawConfig,
-				keepInputArtifact: rawPP.KeepInputArtifact,
-			}
 		}
 
-		postProcessors = append(postProcessors, current)
+		// We panic if there is no builder function because this is really
-	}
+		// an internal bug that always needs to be fixed, not an error.
+		if components.Builder == nil {
+			panic("no builder function")
+		}
 
-	// Prepare the provisioners
+		// Panic if there are provisioners on the template but no provisioner
-	provisioners := make([]coreBuildProvisioner, 0, len(t.Provisioners))
+		// component finder. This is always an internal error, so we panic.
-	for _, rawProvisioner := range t.Provisioners {
+		if len(t.Provisioners) > 0 && components.Provisioner == nil {
-		var provisioner Provisioner
+			panic("no provisioner function")
-		provisioner, err = components.Provisioner(rawProvisioner.Type)
+		}
+
+		builder, err := components.Builder(builderConfig.Type)
 		if err != nil {
 			return
 		}
 
-		if provisioner == nil {
+		if builder == nil {
-			err = fmt.Errorf("Provisioner type not found: %s", rawProvisioner.Type)
+			err = fmt.Errorf("Builder type not found: %s", builderConfig.Type)
 			return
 		}
 
-		configs := make([]interface{}, 1, 2)
+		// Gather the Hooks
-		configs[0] = rawProvisioner.rawConfig
+		hooks := make(map[string][]Hook)
+		for tplEvent, tplHooks := range t.Hooks {
+			curHooks := make([]Hook, 0, len(tplHooks))
 
-		if rawProvisioner.Override != nil {
+			for _, hookName := range tplHooks {
-			if override, ok := rawProvisioner.Override[name]; ok {
+				var hook Hook
-				configs = append(configs, override)
+				hook, err = components.Hook(hookName)
+				if err != nil {
+					return
+				}
+
+				if hook == nil {
+					err = fmt.Errorf("Hook not found: %s", hookName)
+					return
+				}
+
+				curHooks = append(curHooks, hook)
 			}
+
+			hooks[tplEvent] = curHooks
 		}
 
-		coreProv := coreBuildProvisioner{provisioner, configs}
+		// Prepare the post-processors
-		provisioners = append(provisioners, coreProv)
+		postProcessors := make([][]coreBuildPostProcessor, 0, len(t.PostProcessors))
-	}
+		for _, rawPPs := range t.PostProcessors {
+			current := make([]coreBuildPostProcessor, len(rawPPs))
+			for i, rawPP := range rawPPs {
+				pp, err := components.PostProcessor(rawPP.Type)
+				if err != nil {
+					return nil, err
+				}
 
-	b = &coreBuild{
+				if pp == nil {
-		name:           name,
+					return nil, fmt.Errorf("PostProcessor type not found: %s", rawPP.Type)
-		builder:        builder,
+				}
-		builderConfig:  builderConfig.rawConfig,
-		builderType:    builderConfig.Type,
-		hooks:          hooks,
-		postProcessors: postProcessors,
-		provisioners:   provisioners,
-	}
 
-	return
+				current[i] = coreBuildPostProcessor{
-}
+					processor:         pp,
+					processorType:     rawPP.Type,
+					config:            rawPP.rawConfig,
+					keepInputArtifact: rawPP.KeepInputArtifact,
+				}
+			}
+
+			postProcessors = append(postProcessors, current)
+		}
+
+		// Prepare the provisioners
+		provisioners := make([]coreBuildProvisioner, 0, len(t.Provisioners))
+		for _, rawProvisioner := range t.Provisioners {
+			var provisioner Provisioner
+			provisioner, err = components.Provisioner(rawProvisioner.Type)
+			if err != nil {
+				return
+			}
+
+			if provisioner == nil {
+				err = fmt.Errorf("Provisioner type not found: %s", rawProvisioner.Type)
+				return
+			}
+
+			configs := make([]interface{}, 1, 2)
+			configs[0] = rawProvisioner.rawConfig
+
+			if rawProvisioner.Override != nil {
+				if override, ok := rawProvisioner.Override[name]; ok {
+					configs = append(configs, override)
+				}
+			}
+
+			coreProv := coreBuildProvisioner{provisioner, configs}
+			provisioners = append(provisioners, coreProv)
+		}
+
+		b = &coreBuild{
+			name:           name,
+			builder:        builder,
+			builderConfig:  builderConfig.rawConfig,
+			builderType:    builderConfig.Type,
+			hooks:          hooks,
+			postProcessors: postProcessors,
+			provisioners:   provisioners,
+		}
+
+		return
+	}