From a5546fa0f39de0fbde9e4c1cbfb125285fc6bc46 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Sun, 21 Jul 2013 22:46:11 -0700 Subject: [PATCH] builder/amazon/*: Fix failing tests from rebase of VPC --- builder/amazon/common/artifact_test.go | 7 +++++-- builder/amazon/common/step_run_source_instance.go | 3 ++- builder/amazon/common/step_security_group.go | 8 +++++++- builder/amazon/ebs/builder.go | 1 + builder/amazon/instance/builder.go | 1 + 5 files changed, 16 insertions(+), 4 deletions(-) diff --git a/builder/amazon/common/artifact_test.go b/builder/amazon/common/artifact_test.go index be8121074..28af553c7 100644 --- a/builder/amazon/common/artifact_test.go +++ b/builder/amazon/common/artifact_test.go @@ -22,7 +22,10 @@ func TestArtifactId(t *testing.T) { amis["east"] = "foo" amis["west"] = "bar" - a := &Artifact{amis, nil} + a := &Artifact{ + Amis: amis, + } + result := a.Id() assert.Equal(result, expected, "should match output") } @@ -39,7 +42,7 @@ west: bar` amis["east"] = "foo" amis["west"] = "bar" - a := &Artifact{amis, nil} + a := &Artifact{Amis: amis} result := a.String() assert.Equal(result, expected, "should match output") } diff --git a/builder/amazon/common/step_run_source_instance.go b/builder/amazon/common/step_run_source_instance.go index b7c7d4ab5..2c7254b49 100644 --- a/builder/amazon/common/step_run_source_instance.go +++ b/builder/amazon/common/step_run_source_instance.go @@ -12,6 +12,7 @@ type StepRunSourceInstance struct { ExpectedRootDevice string InstanceType string SourceAMI string + SubnetId string instance *ec2.Instance } @@ -29,7 +30,7 @@ func (s *StepRunSourceInstance) Run(state map[string]interface{}) multistep.Step MinCount: 0, MaxCount: 0, SecurityGroups: []ec2.SecurityGroup{ec2.SecurityGroup{Id: securityGroupId}}, - SubnetId: config.SubnetId, + SubnetId: s.SubnetId, } ui.Say("Launching a source AWS instance...") diff --git a/builder/amazon/common/step_security_group.go b/builder/amazon/common/step_security_group.go index dec317262..d7576f40a 100644 --- a/builder/amazon/common/step_security_group.go +++ b/builder/amazon/common/step_security_group.go @@ -13,6 +13,7 @@ import ( type StepSecurityGroup struct { SecurityGroupId string SSHPort int + VpcId string createdGroupId string } @@ -35,7 +36,12 @@ func (s *StepSecurityGroup) Run(state map[string]interface{}) multistep.StepActi ui.Say("Creating temporary security group for this instance...") groupName := fmt.Sprintf("packer %s", hex.EncodeToString(identifier.NewUUID().Raw())) log.Printf("Temporary group name: %s", groupName) - groupResp, err := ec2conn.CreateSecurityGroup(ec2.SecurityGroup{Name: groupName, Description: "Temporary group for Packer", VpcId: config.VpcId}) + group := ec2.SecurityGroup{ + Name: groupName, + Description: "Temporary group for Packer", + VpcId: s.VpcId, + } + groupResp, err := ec2conn.CreateSecurityGroup(group) if err != nil { ui.Error(err.Error()) return multistep.ActionHalt diff --git a/builder/amazon/ebs/builder.go b/builder/amazon/ebs/builder.go index f258e7ab9..629ded646 100644 --- a/builder/amazon/ebs/builder.go +++ b/builder/amazon/ebs/builder.go @@ -97,6 +97,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe ExpectedRootDevice: "ebs", InstanceType: b.config.InstanceType, SourceAMI: b.config.SourceAmi, + SubnetId: b.config.SubnetId, }, &common.StepConnectSSH{ SSHAddress: awscommon.SSHAddress(b.config.SSHPort), diff --git a/builder/amazon/instance/builder.go b/builder/amazon/instance/builder.go index 9cb7ce20b..e3b7e2ef7 100644 --- a/builder/amazon/instance/builder.go +++ b/builder/amazon/instance/builder.go @@ -103,6 +103,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe ExpectedRootDevice: "instance-store", InstanceType: b.config.InstanceType, SourceAMI: b.config.SourceAmi, + SubnetId: b.config.SubnetId, }, &common.StepConnectSSH{ SSHAddress: awscommon.SSHAddress(b.config.SSHPort),