Remove HCL config for runtime field `UserAgent`

Results before change
```
⇶  packer build /tmp/minimal.pkr.hcl
Error: 1 error occurred:
* unknown configuration key: '"user_agent"'

on /tmp/minimal.pkr.hcl line 1:
(source code not available)

==> Builds finished but no artifacts were created.
```

Results after change
```
⇶  packer build /tmp/minimal.pkr.hcl
scaleway.required: output will be in this color.

==> scaleway.required: Creating temporary ssh key for server...
==> scaleway.required: Creating server...
```
This commit is contained in:
Wilken Rivera 2020-07-31 11:22:55 -04:00
parent 980f02ce5d
commit a76c6c55a9
4 changed files with 14 additions and 5 deletions

View File

@ -41,6 +41,19 @@ func TestBuilder_Prepare_BadType(t *testing.T) {
}
}
func TestBuilderPrepare(t *testing.T) {
var b Builder
config := testConfig()
_, warnings, err := b.Prepare(config)
if len(warnings) > 0 {
t.Fatalf("bad: %#v", warnings)
}
if err != nil {
t.Fatal("should not have errors")
}
}
func TestBuilderPrepare_InvalidKey(t *testing.T) {
var b Builder
config := testConfig()

View File

@ -67,7 +67,7 @@ type Config struct {
RemoveVolume bool `mapstructure:"remove_volume"`
UserAgent string `mapstructure:"user_agent"`
UserAgent string `mapstructure-to-hcl2:",skip"`
ctx interpolate.Context
}

View File

@ -74,7 +74,6 @@ type FlatConfig struct {
Bootscript *string `mapstructure:"bootscript" required:"false" cty:"bootscript" hcl:"bootscript"`
BootType *string `mapstructure:"boottype" required:"false" cty:"boottype" hcl:"boottype"`
RemoveVolume *bool `mapstructure:"remove_volume" cty:"remove_volume" hcl:"remove_volume"`
UserAgent *string `mapstructure:"user_agent" cty:"user_agent" hcl:"user_agent"`
}
// FlatMapstructure returns a new FlatConfig.
@ -154,7 +153,6 @@ func (*FlatConfig) HCL2Spec() map[string]hcldec.Spec {
"bootscript": &hcldec.AttrSpec{Name: "bootscript", Type: cty.String, Required: false},
"boottype": &hcldec.AttrSpec{Name: "boottype", Type: cty.String, Required: false},
"remove_volume": &hcldec.AttrSpec{Name: "remove_volume", Type: cty.Bool, Required: false},
"user_agent": &hcldec.AttrSpec{Name: "user_agent", Type: cty.String, Required: false},
}
return s
}

View File

@ -16,5 +16,3 @@
bootscript, Default bootscript
- `remove_volume` (bool) - Remove Volume
- `user_agent` (string) - User Agent