Merge pull request #4230 from mitchellh/revert-4223-closes_3320

Revert "Adds `force_delete_snapshot` flag"

builder/amazon/chroot/builder.go

@@ -245,7 +245,6 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe
 		&StepSnapshot{},
 		&awscommon.StepDeregisterAMI{
 			ForceDeregister: b.config.AMIForceDeregister,
-			ForceDeleteSnapshot: b.config.AMIForceDeleteSnapshot,
 			AMIName:         b.config.AMIName,
 		},
 		&StepRegisterAMI{

builder/amazon/common/ami_config.go

@@ -19,7 +19,6 @@ type AMIConfig struct {
 	AMITags                 map[string]string `mapstructure:"tags"`
 	AMIEnhancedNetworking   bool              `mapstructure:"enhanced_networking"`
 	AMIForceDeregister      bool              `mapstructure:"force_deregister"`
-	AMIForceDeleteSnapshot  bool              `mapstructure:"force_delete_snapshot"`
 	AMIEncryptBootVolume    bool              `mapstructure:"encrypt_boot"`
 	SnapshotTags            map[string]string `mapstructure:"snapshot_tags"`
 }

builder/amazon/common/step_deregister_ami.go

@@ -11,7 +11,6 @@ import (
 
 type StepDeregisterAMI struct {
 	ForceDeregister bool
-	ForceDeleteSnapshot bool
 	AMIName         string
 }
 
@@ -19,7 +18,7 @@ func (s *StepDeregisterAMI) Run(state multistep.StateBag) multistep.StepAction {
 	ec2conn := state.Get("ec2").(*ec2.EC2)
 	ui := state.Get("ui").(packer.Ui)
 
-	// Check for force deregister
+	// check for force deregister
 	if s.ForceDeregister {
 		resp, err := ec2conn.DescribeImages(&ec2.DescribeImagesInput{
 			Filters: []*ec2.Filter{{
@@ -34,7 +33,7 @@ func (s *StepDeregisterAMI) Run(state multistep.StateBag) multistep.StepAction {
 			return multistep.ActionHalt
 		}
 
-		// Deregister image(s) by name
+		// deregister image(s) by that name
 		for _, i := range resp.Images {
 			_, err := ec2conn.DeregisterImage(&ec2.DeregisterImageInput{
 				ImageId: i.ImageId,
@@ -47,25 +46,6 @@ func (s *StepDeregisterAMI) Run(state multistep.StateBag) multistep.StepAction {
 				return multistep.ActionHalt
 			}
 			ui.Say(fmt.Sprintf("Deregistered AMI %s, id: %s", s.AMIName, *i.ImageId))
-
-			// Delete snapshot(s) by image
-			if s.ForceDeleteSnapshot {
-				for _, b := range i.BlockDeviceMappings {
-					if b.Ebs != nil {
-						_, err := ec2conn.DeleteSnapshot(&ec2.DeleteSnapshotInput{
-							SnapshotId: b.Ebs.SnapshotId,
-						})
-
-						if err != nil {
-							err := fmt.Errorf("Error deleting existing snapshot: %s", err)
-							state.Put("error", err)
-							ui.Error(err.Error())
-							return multistep.ActionHalt
-						}
-						ui.Say(fmt.Sprintf("Deleted snapshot: %s", *b.Ebs.SnapshotId))
-					}
-				}
-			}
 		}
 	}
 

builder/amazon/ebs/builder.go

@@ -167,7 +167,6 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe
 		},
 		&awscommon.StepDeregisterAMI{
 			ForceDeregister: b.config.AMIForceDeregister,
-			ForceDeleteSnapshot: b.config.AMIForceDeleteSnapshot,
 			AMIName:         b.config.AMIName,
 		},
 		&stepCreateAMI{},

builder/amazon/ebs/builder_acc_test.go

@@ -46,22 +46,6 @@ func TestBuilderAcc_forceDeregister(t *testing.T) {
 	})
 }
 
-func TestBuilderAcc_forceDeleteSnapshot(t *testing.T) {
-	// Build the same AMI name twice, with force_delete_snapshot on the second run
-	builderT.Test(t, builderT.TestCase{
-		PreCheck:             func() { testAccPreCheck(t) },
-		Builder:              &Builder{},
-		Template:             buildForceDeleteSnapshotConfig("false", "dereg"),
-		SkipArtifactTeardown: true,
-	})
-
-	builderT.Test(t, builderT.TestCase{
-		PreCheck: func() { testAccPreCheck(t) },
-		Builder:  &Builder{},
-		Template: buildForceDeleteSnapshotConfig("true", "dereg"),
-	})
-}
-
 func TestBuilderAcc_amiSharing(t *testing.T) {
 	builderT.Test(t, builderT.TestCase{
 		PreCheck: func() { testAccPreCheck(t) },
@@ -270,21 +254,6 @@ const testBuilderAccForceDeregister = `
 }
 `
 
-const testBuilderAccForceDeleteSnapshot = `
-{
-	"builders": [{
-		"type": "test",
-		"region": "us-east-1",
-		"instance_type": "m3.medium",
-		"source_ami": "ami-76b2a71e",
-		"ssh_username": "ubuntu",
-		"force_deregister": "%s",
-		"force_delete_snapshot": "%s",
-		"ami_name": "packer-test-%s"
-	}]
-}
-`
-
 // share with catsby
 const testBuilderAccSharing = `
 {
@@ -315,10 +284,6 @@ const testBuilderAccEncrypted = `
 }
 `
 
-func buildForceDeregisterConfig(val, name string) string {
-	return fmt.Sprintf(testBuilderAccForceDeregister, val, name)
-}
-
-func buildForceDeleteSnapshotConfig(val, name string) string {
-	return fmt.Sprintf(testBuilderAccForceDeleteSnapshot, val, val, name)
+func buildForceDeregisterConfig(name, flag string) string {
+	return fmt.Sprintf(testBuilderAccForceDeregister, name, flag)
 }

builder/amazon/instance/builder.go

@@ -249,7 +249,6 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe
 		},
 		&awscommon.StepDeregisterAMI{
 			ForceDeregister: b.config.AMIForceDeregister,
-			ForceDeleteSnapshot: b.config.AMIForceDeleteSnapshot,
 			AMIName:         b.config.AMIName,
 		},
 		&StepRegisterAMI{},

website/source/docs/builders/amazon-chroot.html.md

@@ -124,9 +124,6 @@ each category, the available configuration keys are alphabetized.
 -   `force_deregister` (boolean) - Force Packer to first deregister an existing
     AMI if one with the same name already exists. Default `false`.
 
--   `force_delete_snapshot` (boolean) - Force Packer to delete snapshots associated with
-    AMIs, which have been deregistered by `force_deregister`. Default `false`.
-
 -   `from_scratch` (boolean) - Build a new volume instead of starting from an
     existing AMI root volume snapshot. Default `false`. If true, `source_ami` is
     no longer used and the following options become required:

website/source/docs/builders/amazon-ebs.html.md

@@ -155,9 +155,6 @@ builder.
 -   `force_deregister` (boolean) - Force Packer to first deregister an existing
     AMI if one with the same name already exists. Default `false`.
 
--   `force_delete_snapshot` (boolean) - Force Packer to delete snapshots associated with
-    AMIs, which have been deregistered by `force_deregister`. Default `false`.
-
 -   `encrypt_boot` (boolean) - Instruct packer to automatically create a copy of the
     AMI with an encrypted boot volume (discarding the initial unencrypted AMI in the
     process). Default `false`.

website/source/docs/builders/amazon-instance.html.md

@@ -179,9 +179,6 @@ builder.
 -   `force_deregister` (boolean) - Force Packer to first deregister an existing
     AMI if one with the same name already exists. Default `false`.
 
--   `force_delete_snapshot` (boolean) - Force Packer to delete snapshots associated with
-    AMIs, which have been deregistered by `force_deregister`. Default `false`.
-
 -   `iam_instance_profile` (string) - The name of an [IAM instance
     profile](https://docs.aws.amazon.com/IAM/latest/UserGuide/instance-profiles.html)
     to launch the EC2 instance with.