respect the destroy flag in content library config (#10165)

* respect the destroy flag in content library config

* Make vsphere-clone respect delete_vm state tag; use a common delete func to prevent future drift

builder/vsphere/clone/step_clone.go

@@ -123,24 +123,5 @@ func (s *StepCloneVM) Run(ctx context.Context, state multistep.StateBag) multist
 }
 
 func (s *StepCloneVM) Cleanup(state multistep.StateBag) {
-	_, cancelled := state.GetOk(multistep.StateCancelled)
-	_, halted := state.GetOk(multistep.StateHalted)
-	if !cancelled && !halted {
-		return
-	}
-
-	ui := state.Get("ui").(packer.Ui)
-
-	st := state.Get("vm")
-	if st == nil {
-		return
-	}
-	vm := st.(*driver.VirtualMachineDriver)
-
-	ui.Say("Destroying VM...")
-
-	err := vm.Destroy()
-	if err != nil {
-		ui.Error(err.Error())
-	}
+	common.CleanupVM(state)
 }

builder/vsphere/common/cleanup_vm.go

@@ -0,0 +1,30 @@
+package common
+
+import (
+	"github.com/hashicorp/packer/builder/vsphere/driver"
+	"github.com/hashicorp/packer/helper/multistep"
+	"github.com/hashicorp/packer/packer"
+)
+
+func CleanupVM(state multistep.StateBag) {
+	_, cancelled := state.GetOk(multistep.StateCancelled)
+	_, halted := state.GetOk(multistep.StateHalted)
+	_, destroy := state.GetOk("destroy_vm")
+	if !cancelled && !halted && !destroy {
+		return
+	}
+
+	ui := state.Get("ui").(packer.Ui)
+
+	st := state.Get("vm")
+	if st == nil {
+		return
+	}
+	vm := st.(driver.VirtualMachine)
+
+	ui.Say("Destroying VM...")
+	err := vm.Destroy()
+	if err != nil {
+		ui.Error(err.Error())
+	}
+}

builder/vsphere/common/cleanup_vm_test.go

@@ -0,0 +1,62 @@
+package common
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/hashicorp/packer/builder/vsphere/driver"
+	"github.com/hashicorp/packer/helper/multistep"
+	"github.com/hashicorp/packer/packer"
+)
+
+func cleanupTestState(mockVM driver.VirtualMachine) multistep.StateBag {
+	state := new(multistep.BasicStateBag)
+	state.Put("vm", mockVM)
+	state.Put("ui", &packer.BasicUi{
+		Reader: new(bytes.Buffer),
+		Writer: new(bytes.Buffer),
+	})
+	return state
+}
+
+func Test_CleanupVM(t *testing.T) {
+	type testCase struct {
+		Reason        string
+		ExtraState    map[string]interface{}
+		ExpectDestroy bool
+	}
+	testCases := []testCase{
+		{
+			"if cancelled, we should destroy the VM",
+			map[string]interface{}{multistep.StateCancelled: true},
+			true,
+		},
+		{
+			"if halted, we should destroy the VM",
+			map[string]interface{}{multistep.StateHalted: true},
+			true,
+		},
+		{
+			"if destroy flag is set, we should destroy the VM",
+			map[string]interface{}{"destroy_vm": true},
+			true,
+		},
+		{
+			"if none of the above flags are set, we should not destroy the VM",
+			map[string]interface{}{},
+			false,
+		},
+	}
+	for _, tc := range testCases {
+		mockVM := &driver.VirtualMachineMock{}
+		state := cleanupTestState(mockVM)
+		for k, v := range tc.ExtraState {
+			state.Put(k, v)
+		}
+		CleanupVM(state)
+		if mockVM.DestroyCalled != tc.ExpectDestroy {
+			t.Fatalf("Problem with cleanup: %s", tc.Reason)
+		}
+	}
+
+}

builder/vsphere/iso/step_create.go

@@ -277,24 +277,5 @@ func (s *StepCreateVM) Run(_ context.Context, state multistep.StateBag) multiste
 }
 
 func (s *StepCreateVM) Cleanup(state multistep.StateBag) {
-	_, cancelled := state.GetOk(multistep.StateCancelled)
-	_, halted := state.GetOk(multistep.StateHalted)
-	_, destroy := state.GetOk("destroy_vm")
-	if !cancelled && !halted && !destroy {
-		return
-	}
-
-	ui := state.Get("ui").(packer.Ui)
-
-	st := state.Get("vm")
-	if st == nil {
-		return
-	}
-	vm := st.(driver.VirtualMachine)
-
-	ui.Say("Destroying VM...")
-	err := vm.Destroy()
-	if err != nil {
-		ui.Error(err.Error())
-	}
+	common.CleanupVM(state)
 }