packer: Core, and template validate

This commit is contained in:
Mitchell Hashimoto 2015-05-23 14:48:07 -07:00
parent 28dc1c2aed
commit ded13a8b10
5 changed files with 167 additions and 0 deletions

77
packer/core.go Normal file
View File

@ -0,0 +1,77 @@
package packer
import (
"fmt"
"os"
"github.com/hashicorp/go-multierror"
"github.com/mitchellh/packer/template"
)
// Core is the main executor of Packer. If Packer is being used as a
// library, this is the struct you'll want to instantiate to get anything done.
type Core struct {
cache Cache
components ComponentFinder
ui Ui
template *template.Template
variables map[string]string
}
// CoreConfig is the structure for initializing a new Core. Once a CoreConfig
// is used to initialize a Core, it shouldn't be re-used or modified again.
type CoreConfig struct {
Cache Cache
Components ComponentFinder
Ui Ui
Template *template.Template
Variables map[string]string
}
// NewCore creates a new Core.
func NewCore(c *CoreConfig) (*Core, error) {
if c.Ui == nil {
c.Ui = &BasicUi{
Reader: os.Stdin,
Writer: os.Stdout,
ErrorWriter: os.Stdout,
}
}
return &Core{
cache: c.Cache,
components: c.Components,
ui: c.Ui,
template: c.Template,
variables: c.Variables,
}, nil
}
// Validate does a full validation of the template.
//
// This will automatically call template.Validate() in addition to doing
// richer semantic checks around variables and so on.
func (c *Core) Validate() error {
// First validate the template in general, we can't do anything else
// unless the template itself is valid.
if err := c.template.Validate(); err != nil {
return err
}
// Validate variables are set
var err error
for n, v := range c.template.Variables {
if v.Required {
if _, ok := c.variables[n]; !ok {
err = multierror.Append(err, fmt.Errorf(
"required variable not set: %s", n))
}
}
}
// TODO: validate all builders exist
// TODO: ^^ provisioner
// TODO: ^^ post-processor
return err
}

60
packer/core_test.go Normal file
View File

@ -0,0 +1,60 @@
package packer
import (
"os"
"testing"
"github.com/mitchellh/packer/template"
)
func TestCoreValidate(t *testing.T) {
cases := []struct {
File string
Vars map[string]string
Err bool
}{
{
"validate-dup-builder.json",
nil,
true,
},
// Required variable not set
{
"validate-req-variable.json",
nil,
true,
},
{
"validate-req-variable.json",
map[string]string{"foo": "bar"},
false,
},
}
for _, tc := range cases {
f, err := os.Open(fixtureDir(tc.File))
if err != nil {
t.Fatalf("err: %s", err)
}
tpl, err := template.Parse(f)
f.Close()
if err != nil {
t.Fatalf("err: %s\n\n%s", tc.File, err)
}
core, err := NewCore(&CoreConfig{
Template: tpl,
Variables: tc.Vars,
})
if err != nil {
t.Fatalf("err: %s\n\n%s", tc.File, err)
}
if err := core.Validate(); (err != nil) != tc.Err {
t.Fatalf("err: %s\n\n%s", tc.File, err)
}
}
}

11
packer/packer_test.go Normal file
View File

@ -0,0 +1,11 @@
package packer
import (
"path/filepath"
)
const FixtureDir = "./test-fixtures"
func fixtureDir(n string) string {
return filepath.Join(FixtureDir, n)
}

View File

@ -0,0 +1,10 @@
{
"builders": [
{"type": "foo"}
],
"provisioners": [{
"type": "foo",
"only": ["bar"]
}]
}

View File

@ -0,0 +1,9 @@
{
"variables": {
"foo": null
},
"builders": [{
"type": "foo"
}]
}