From e73ec1f70daf0284cca4c189633be8e37b8c2981 Mon Sep 17 00:00:00 2001 From: Chris Bednarski Date: Mon, 3 Aug 2015 11:16:17 -0700 Subject: [PATCH] Use go vet instead of go tool vet, and actually run it with make --- Makefile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 2fb386399..8ff6560a5 100644 --- a/Makefile +++ b/Makefile @@ -1,8 +1,6 @@ TEST?=./... -VETARGS?=-asmdecl -atomic -bool -buildtags -copylocks -methods \ - -nilfunc -printf -rangeloops -shift -structtags -unsafeptr -default: test +default: test vet dev bin: @sh -c "$(CURDIR)/scripts/build.sh" @@ -41,10 +39,10 @@ updatedeps: | xargs go get -f -u -v vet: - @go tool vet 2>/dev/null ; if [ $$? -eq 3 ]; then \ + @go vet 2>/dev/null ; if [ $$? -eq 3 ]; then \ go get golang.org/x/tools/cmd/vet; \ fi - @go tool vet $(VETARGS) . ; if [ $$? -eq 1 ]; then \ + @go vet ./... ; if [ $$? -eq 1 ]; then \ echo ""; \ echo "Vet found suspicious constructs. Please check the reported constructs"; \ echo "and fix them if necessary before submitting the code for reviewal."; \