iSharkFly-Docs
/
packer-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed TestFileExistsLocally tests in common/config_test.go so that they're actually being run. Added a non-existent-protocol:// test.

This commit is contained in:
Ali Rizvi-Santiago 2018-02-02 20:29:10 -06:00
parent c366a1e160
commit efc97dbda2
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/config_test.go
View File

@ -285,7 +285,7 @@ func TestDownloadableURL_FilePaths(t *testing.T) {
} }
} }
func test_FileExistsLocally(t *testing.T) { func TestFileExistsLocally(t *testing.T) {
portablepath := GetPortablePathToTestFixtures(t) portablepath := GetPortablePathToTestFixtures(t)
dirCases := []struct { dirCases := []struct {
@ -294,15 +294,17 @@ func test_FileExistsLocally(t *testing.T) {
}{ }{
// file exists locally // file exists locally
{fmt.Sprintf("file:///%s/SomeDir/myfile.txt", portablepath), true}, {fmt.Sprintf("file:///%s/SomeDir/myfile.txt", portablepath), true},
// file is not supposed to exist locally // remote protocols short-circuit and are considered to exist locally
{"https://myfile.iso", true}, {"https://myfile.iso", true},
// non-existent protocols do not exist and hence fail
{"nonexistent-protocol://myfile.iso", false},
// file does not exist locally // file does not exist locally
{"file:///C/i/dont/exist", false}, {"file:///C/i/dont/exist", false},
} }
// Run through test cases to make sure they all parse correctly // Run through test cases to make sure they all parse correctly
for _, tc := range dirCases { for _, tc := range dirCases {
fileOK := FileExistsLocally(tc.Input) fileOK := FileExistsLocally(tc.Input)
if !fileOK { if fileOK != tc.Output {
t.Fatalf("Test Case failed: Expected %#v, received = %#v, input = %s", t.Fatalf("Test Case failed: Expected %#v, received = %#v, input = %s",
tc.Output, fileOK, tc.Input) tc.Output, fileOK, tc.Input)
} }