9 Commits

Author SHA1 Message Date
Luba Grinkevich
a067b23e6d Execute make generate #8716 2020-02-10 18:51:29 +03:00
Adrien Delorme
819329228a Change back to make sure all durations are a time.Duration
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:

* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
Adrien Delorme
bf3d9841c6 Force durations to be passed a strings
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
Gennady Lipenkov
d070b4868a Wrap values with backticks
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-25 16:04:45 +03:00
Gennady Lipenkov
00e4e0c7a7 Add description of field in config struct
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
2019-09-25 14:31:27 +03:00
Gennady Lipenkov
b9e0e4947e make generate 2019-09-23 21:27:29 +03:00
Adrien Delorme
3fe9d52e3f Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-20 11:15:44 +02:00
Adrien Delorme
82525e4d20 use parials in yandex docs after master merge 2019-06-12 14:49:28 +02:00
Adrien Delorme
4ae10f08b2 docs: generate builders partials from struct comments 2019-06-06 17:34:17 +02:00