Andrew Starr-Bochicchio
a1f334daff
Use constant and move check to template generator.
2020-05-13 13:28:44 -04:00
Andrew Starr-Bochicchio
bf0ab6b722
Force test to be skipped unless PACKER_ACC set.
2020-05-13 11:48:49 -04:00
Wilken Rivera
b5639d4697
tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps ( #9213 )
...
* test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base
* Update mod files
2020-05-13 10:10:55 -04:00
Adrien Delorme
a50c27c05d
single `
2020-05-13 15:51:18 +02:00
Adrien Delorme
c2d3e494b6
alicloud: better docs + autogenerated post processor docs
2020-05-13 15:49:34 +02:00
Megan Marsh
fe472f45ae
don't put error in state, or we'll fail.
2020-05-12 16:51:40 -07:00
Megan Marsh
807a09a770
don't error if metadata can't be set. Old versions of openstack don't seem to play nicely with this API call
2020-05-12 16:51:40 -07:00
Wilken Rivera
6f5f6bf999
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
...
Tests before change
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2]
goroutine 299 [running]:
github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2
github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6
github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...)
/home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2
github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/wilken/Development/packer/packer/build.go:287 +0x7ef
github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...)
/home/wilken/Development/packer/command/build.go:290 +0x189
created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext
/home/wilken/Development/packer/command/build.go:284 +0xd5a
FAIL github.com/hashicorp/packer/provisioner/shell 188.335s
FAIL
```
Test After change
```
--- PASS: TestShellProvisioner (212.39s)
--- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s)
PASS
```
2020-05-12 14:49:57 -04:00
Andrew Starr-Bochicchio
05d56034dd
builder/digitalocean: Add acceptance test for creating Droplet using image ID.
2020-05-12 14:15:35 -04:00
Andrew Starr-Bochicchio
374a29d75c
builder/digitalocean: Add logging of Droplet create attributes.
2020-05-12 12:38:51 -04:00
Andrew Starr-Bochicchio
80b4e0425e
builder/digitalocean: Use correct type for image for Droplet creates.
2020-05-12 11:46:58 -04:00
Andrew Starr-Bochicchio
e8783873d0
builder/digitalocean: Fix failing acceptance test.
2020-05-12 11:37:07 -04:00
Adrien Delorme
4ebcbad332
update consul and vault dependencies ( #9205 )
...
* update consul and vault dependencies
* update triton sign call accorting to https://github.com/joyent/triton-go/pull/135
* Delete readme.md
* put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why
* fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order
2020-05-11 15:26:01 -04:00
Megan Marsh
480c938162
generate virtualbox-vm docs instead of letting them be copy pasted
2020-05-08 15:58:36 -07:00
Megan Marsh
4ef34f7fba
fix iso config prepare
2020-05-08 14:11:51 -07:00
Megan Marsh
9476aa03de
Merge pull request #9105 from hashicorp/google_iap
...
Implement iap proxy for googlecompute
2020-05-08 12:40:42 -07:00
Megan Marsh
fcef10fd2f
Merge pull request #9082 from hashicorp/f-amazon_builder-ssm-session-tunnel-poc
...
builder/amazon: Add SSM Session Manager as a SSH interface connection
2020-05-08 12:40:03 -07:00
Megan Marsh
a55b73473a
fix logic
2020-05-08 10:24:28 -07:00
Megan Marsh
dde162622d
use local port in listener config, when set
2020-05-08 10:20:47 -07:00
Megan Marsh
81e043f2b0
fix windows tests
2020-05-08 10:13:43 -07:00
Megan Marsh
60600e6cf6
make windows work with account files containing spaces
2020-05-08 10:13:43 -07:00
Megan Marsh
dae60799bc
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
fda55fe928
deduplicate excess code
2020-05-08 10:13:43 -07:00
Megan Marsh
54b33ad8d1
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
850303b8b8
get gcloud integration working on Windows
2020-05-08 10:13:43 -07:00
Megan Marsh
c578afc62c
working on windows
2020-05-08 10:13:43 -07:00
Megan Marsh
32752d4577
fix linting and tests
2020-05-08 10:13:43 -07:00
Megan Marsh
b5744efb42
add config prepare tests
2020-05-08 10:13:43 -07:00
Megan Marsh
f583674cd6
linding
2020-05-08 10:13:43 -07:00
Megan Marsh
4fc92d7858
add tests
2020-05-08 10:13:42 -07:00
Megan Marsh
937a4859d4
Make retries a bit smarter, clean up language to be gentler, and give up on parsing stdout for tunnel launch
2020-05-08 10:13:42 -07:00
Megan Marsh
3e1ddad0c7
fix behavior when not using IAP, try to use more sophisticated streaming than buffer.String()
2020-05-08 10:13:42 -07:00
Megan Marsh
9353635b43
send sigint instead of sigkill; we can at least ask the tunnel nicely to shut down.
2020-05-08 10:13:42 -07:00
Megan Marsh
f67a8ab431
revert unneeded changes to driver roles
2020-05-08 10:13:42 -07:00
Megan Marsh
80ecd2013d
basic untested implementation for Windows. May leave zombie processes lying around
2020-05-08 10:13:42 -07:00
Megan Marsh
3cd28e98a7
linting
2020-05-08 10:13:42 -07:00
Megan Marsh
365eb09842
import context
2020-05-08 10:13:42 -07:00
Megan Marsh
eb05f6ff88
fix windows
2020-05-08 10:13:42 -07:00
Megan Marsh
d713f7ec64
add conditional building becasue windows support is still forthcoming
2020-05-08 10:13:42 -07:00
Megan Marsh
e6073bcec7
implement iap proxy for googlecompute. ssh-only so far
2020-05-08 10:13:42 -07:00
Ryo Tagami
fdc73376ba
floppy_label Parameter for vsphere-iso Builder ( #9187 )
...
Add ability to specify `floppy_label` parameter for `vsphere-iso`
builder, which would be especially beneficial when someone wants to pass
information to cloud-init via floppy disk images.
Signed-off-by: Ryo Tagami <rtagami@airstrip.jp>
2020-05-08 16:13:54 +02:00
Markus Liljedahl
d807e81adb
Changed default disk size for when using googlecompute to match minimum disk sice to the google api. Closes https://github.com/hashicorp/packer/issues/9023 ( #9071 )
2020-05-08 15:55:38 +02:00
Wilken Rivera
89fb7bb080
Apply suggestions from code review
...
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-05-08 09:36:43 -04:00
Wilken Rivera
056f1f6e76
docs/amazon/builder: Add not about using a temporary_iam_instance_profile_policy_document
2020-05-08 09:32:54 -04:00
Wilken Rivera
bf1da57a05
Update address to localhost to be consistent with other proxies
2020-05-08 09:32:54 -04:00
Wilken Rivera
7cea7466ba
buider/amazon: Add session_manager_port
option for setting a custom local port
2020-05-08 09:32:54 -04:00
Wilken Rivera
0d13c634b7
Update logging constructs for Session Manger driver
2020-05-08 09:32:49 -04:00
Wilken Rivera
81c40b8d08
Add section to docs about the session-manager-plugin tunnel
2020-05-08 09:32:49 -04:00
Wilken Rivera
5f68303504
Remove no longer needed port check
...
The communicator code base will default to the correct port settings for
valid communicators and fail the build for non valid communicators.
2020-05-08 09:32:49 -04:00
Wilken Rivera
3ae7ab994b
step_create_ssm_tunnel: Add port availability check for LocalPortNumber
2020-05-08 09:32:49 -04:00