Megan Marsh
0058422a5c
also for vmx
2018-12-05 15:58:44 -08:00
Megan Marsh
0fe4d79bbf
add validation to prevent users from being confused about format functionality
2018-12-05 15:57:45 -08:00
Ali Rizvi-Santiago
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
Ali Rizvi-Santiago
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
Megan Marsh
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
Ali Rizvi-Santiago
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
Ali Rizvi-Santiago
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
Ali Rizvi-Santiago
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
Ali Rizvi-Santiago
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
Rickard von Essen
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
Ali Rizvi-Santiago
4e73c85e22
Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.
2018-11-16 22:20:00 -06:00
Megan Marsh
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
Megan Marsh
3b413d2e5e
fix rebase conflicts
2018-11-12 13:24:03 -08:00
Megan Marsh
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
Megan Marsh
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
Megan Marsh
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
Adrien Delorme
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
Adrien Delorme
78ac943679
Merge pull request #6987 from hashicorp/6624
...
6624
2018-11-12 15:31:36 +01:00
Megan Marsh
2e2b2cea82
add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data
2018-11-09 15:46:52 -08:00
Megan Marsh
3cf4c63a87
Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary.
2018-11-09 14:00:07 -08:00
Megan Marsh
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
Megan Marsh
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
Megan Marsh
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
Megan Marsh
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
Megan Marsh
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
Megan Marsh
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
Megan Marsh
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
Megan Marsh
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
Megan Marsh
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
Megan Marsh
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
Megan Marsh
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
Megan Marsh
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
Alexander Laamanen
3193f50f17
Support export with the vmx builder.
2018-10-25 13:02:37 -07:00
Alexander Laamanen
a68a639a1a
Move step_export to common.
2018-10-25 12:55:10 -07:00
Alexander Laamanen
63054fb808
Fix the test.
2018-10-25 12:45:44 -07:00
Stuart Miller
da5f322484
Add quotes around all filenames to prevent issues with spaces
2018-10-25 12:45:44 -07:00
Alexander Laamanen
f42f5a8ad3
Remove some extra logging.
2018-10-25 12:44:29 -07:00
Alexander Laamanen
e7e6a80587
No need to make upload public.
2018-10-25 12:39:51 -07:00
Alexander Laamanen
c294e65c36
A separate driver file is not really needed anymore
2018-10-25 12:39:51 -07:00
Alexander Laamanen
2ed6c3ef5e
Set output dir always according to the config.
2018-10-25 12:37:47 -07:00
Alexander Laamanen
c940f7e754
Conditional reload.
2018-10-25 12:37:47 -07:00
Alexander Laamanen
17845beadc
Fix the CommHost tests
2018-10-25 12:37:47 -07:00
Alexander Laamanen
5e74bcfb88
Fix tests, move remote_ default values to driver_config.
2018-10-25 12:30:57 -07:00
Alexander Laamanen
4d9cb19012
Refactor artifacts and output_dir implementations.
2018-10-25 12:21:24 -07:00
Alexander Laamanen
2d00dc6756
Add VMName to the vmx mods.
2018-10-25 11:17:09 -07:00