5dfd2a763e
send logs about floppy failure directly to UI not just logs ( #9272 )
2020-05-25 12:02:29 +02:00
9bd19df040
validate if user assigned identity exists
2020-05-24 19:05:46 -07:00
b334458b91
use empty struct for UserAssignedIdentities map value; omitempty
2020-05-24 19:05:45 -07:00
c5e2eff847
change to []*Resource
2020-05-24 19:05:45 -07:00
3e3fdaa24e
make generate
2020-05-24 19:05:45 -07:00
76a7ab25e2
add SetIdentity test
2020-05-24 19:05:45 -07:00
764f99ec7b
add correct api-version
2020-05-24 19:05:45 -07:00
f7f033a7fd
add config validation test
2020-05-24 19:05:45 -07:00
10b0a4548f
add identity resource id validation
2020-05-24 19:05:45 -07:00
7c1a62dfed
set identity field in the template
2020-05-24 19:05:45 -07:00
d9c9bfbae8
add identity field to the template
2020-05-24 19:05:45 -07:00
b5b2982772
add user_assigned_managed_identities to the config
2020-05-24 19:05:45 -07:00
082d806b1f
fix httpip acquisition
2020-05-21 09:39:54 -07:00
06fad6cc4f
qemu: add support for using a network bridge
2020-05-20 16:46:32 -07:00
266bba279b
linting
2020-05-19 16:45:14 -07:00
aadd95497a
fix tests
2020-05-19 16:39:17 -07:00
a892d13d56
make package_include match output_vagrantfile parsing and abspath calculation
2020-05-19 16:32:54 -07:00
58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
...
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
820f353573
(vsphere-iso) remove deprecated network and disk fields ( #9149 )
...
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
1c30a71d09
Replace file shared state by statebag ( #9238 )
2020-05-19 11:49:48 +02:00
c954831bb2
builder/azure-arm: Update runtime constants with a valid DataDiskName
...
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.
Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n \"error\": {\r\n \"code
\": \"InvalidParameter\",\r\n \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n \"target\": \"dataDisk.name\"\r\n }\r\n}"}]
```
Build results after change
```
Build 'azure-arm' finished.
==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:
OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```
Closes #9249
2020-05-18 14:57:20 -04:00
f31f5bc61b
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
...
Closes #9199
2020-05-14 13:31:40 -04:00
e4eaff6bba
s/Directoty/Directory ( #9221 )
2020-05-14 15:00:27 +02:00
0d900fd007
Merge pull request #9198 from hashicorp/fix_9190
...
don't error if metadata can't be set. Old versions of openstack don't…
2020-05-13 14:45:18 -07:00
a17ef01ea9
Merge pull request #9212 from andrewsomething/asb/do-image-id
...
builder/digitalocean: Use correct image type for Droplet creates.
2020-05-13 14:43:13 -07:00
37d953881f
Merge pull request #9219 from hashicorp/azr_autodoc_alicloud_pp
...
alicloud: better docs + autogenerated post processor docs
2020-05-13 14:41:44 -07:00
84f0079c3a
Move to a new func to make testable.
2020-05-13 13:29:22 -04:00
a1f334daff
Use constant and move check to template generator.
2020-05-13 13:28:44 -04:00
bf0ab6b722
Force test to be skipped unless PACKER_ACC set.
2020-05-13 11:48:49 -04:00
b5639d4697
tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps ( #9213 )
...
* test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base
* Update mod files
2020-05-13 10:10:55 -04:00
a50c27c05d
single `
2020-05-13 15:51:18 +02:00
c2d3e494b6
alicloud: better docs + autogenerated post processor docs
2020-05-13 15:49:34 +02:00
fe472f45ae
don't put error in state, or we'll fail.
2020-05-12 16:51:40 -07:00
807a09a770
don't error if metadata can't be set. Old versions of openstack don't seem to play nicely with this API call
2020-05-12 16:51:40 -07:00
6f5f6bf999
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
...
Tests before change
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2]
goroutine 299 [running]:
github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2
github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6
github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...)
/home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2
github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/wilken/Development/packer/packer/build.go:287 +0x7ef
github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...)
/home/wilken/Development/packer/command/build.go:290 +0x189
created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext
/home/wilken/Development/packer/command/build.go:284 +0xd5a
FAIL github.com/hashicorp/packer/provisioner/shell 188.335s
FAIL
```
Test After change
```
--- PASS: TestShellProvisioner (212.39s)
--- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s)
PASS
```
2020-05-12 14:49:57 -04:00
05d56034dd
builder/digitalocean: Add acceptance test for creating Droplet using image ID.
2020-05-12 14:15:35 -04:00
374a29d75c
builder/digitalocean: Add logging of Droplet create attributes.
2020-05-12 12:38:51 -04:00
80b4e0425e
builder/digitalocean: Use correct type for image for Droplet creates.
2020-05-12 11:46:58 -04:00
e8783873d0
builder/digitalocean: Fix failing acceptance test.
2020-05-12 11:37:07 -04:00
4ebcbad332
update consul and vault dependencies ( #9205 )
...
* update consul and vault dependencies
* update triton sign call accorting to https://github.com/joyent/triton-go/pull/135
* Delete readme.md
* put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why
* fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order
2020-05-11 15:26:01 -04:00
480c938162
generate virtualbox-vm docs instead of letting them be copy pasted
2020-05-08 15:58:36 -07:00
4ef34f7fba
fix iso config prepare
2020-05-08 14:11:51 -07:00
9476aa03de
Merge pull request #9105 from hashicorp/google_iap
...
Implement iap proxy for googlecompute
2020-05-08 12:40:42 -07:00
fcef10fd2f
Merge pull request #9082 from hashicorp/f-amazon_builder-ssm-session-tunnel-poc
...
builder/amazon: Add SSM Session Manager as a SSH interface connection
2020-05-08 12:40:03 -07:00
a55b73473a
fix logic
2020-05-08 10:24:28 -07:00
dde162622d
use local port in listener config, when set
2020-05-08 10:20:47 -07:00
81e043f2b0
fix windows tests
2020-05-08 10:13:43 -07:00
60600e6cf6
make windows work with account files containing spaces
2020-05-08 10:13:43 -07:00
dae60799bc
fix tests
2020-05-08 10:13:43 -07:00
fda55fe928
deduplicate excess code
2020-05-08 10:13:43 -07:00
54b33ad8d1
fix tests
2020-05-08 10:13:43 -07:00
850303b8b8
get gcloud integration working on Windows
2020-05-08 10:13:43 -07:00
c578afc62c
working on windows
2020-05-08 10:13:43 -07:00
32752d4577
fix linting and tests
2020-05-08 10:13:43 -07:00
b5744efb42
add config prepare tests
2020-05-08 10:13:43 -07:00
f583674cd6
linding
2020-05-08 10:13:43 -07:00
4fc92d7858
add tests
2020-05-08 10:13:42 -07:00
937a4859d4
Make retries a bit smarter, clean up language to be gentler, and give up on parsing stdout for tunnel launch
2020-05-08 10:13:42 -07:00
3e1ddad0c7
fix behavior when not using IAP, try to use more sophisticated streaming than buffer.String()
2020-05-08 10:13:42 -07:00
9353635b43
send sigint instead of sigkill; we can at least ask the tunnel nicely to shut down.
2020-05-08 10:13:42 -07:00
f67a8ab431
revert unneeded changes to driver roles
2020-05-08 10:13:42 -07:00
80ecd2013d
basic untested implementation for Windows. May leave zombie processes lying around
2020-05-08 10:13:42 -07:00
3cd28e98a7
linting
2020-05-08 10:13:42 -07:00
365eb09842
import context
2020-05-08 10:13:42 -07:00
eb05f6ff88
fix windows
2020-05-08 10:13:42 -07:00
d713f7ec64
add conditional building becasue windows support is still forthcoming
2020-05-08 10:13:42 -07:00
e6073bcec7
implement iap proxy for googlecompute. ssh-only so far
2020-05-08 10:13:42 -07:00
fdc73376ba
floppy_label Parameter for vsphere-iso Builder ( #9187 )
...
Add ability to specify `floppy_label` parameter for `vsphere-iso`
builder, which would be especially beneficial when someone wants to pass
information to cloud-init via floppy disk images.
Signed-off-by: Ryo Tagami <rtagami@airstrip.jp>
2020-05-08 16:13:54 +02:00
d807e81adb
Changed default disk size for when using googlecompute to match minimum disk sice to the google api. Closes https://github.com/hashicorp/packer/issues/9023 ( #9071 )
2020-05-08 15:55:38 +02:00
89fb7bb080
Apply suggestions from code review
...
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-05-08 09:36:43 -04:00
056f1f6e76
docs/amazon/builder: Add not about using a temporary_iam_instance_profile_policy_document
2020-05-08 09:32:54 -04:00
bf1da57a05
Update address to localhost to be consistent with other proxies
2020-05-08 09:32:54 -04:00
7cea7466ba
buider/amazon: Add `session_manager_port` option for setting a custom local port
2020-05-08 09:32:54 -04:00
0d13c634b7
Update logging constructs for Session Manger driver
2020-05-08 09:32:49 -04:00
81c40b8d08
Add section to docs about the session-manager-plugin tunnel
2020-05-08 09:32:49 -04:00
5f68303504
Remove no longer needed port check
...
The communicator code base will default to the correct port settings for
valid communicators and fail the build for non valid communicators.
2020-05-08 09:32:49 -04:00
3ae7ab994b
step_create_ssm_tunnel: Add port availability check for LocalPortNumber
2020-05-08 09:32:49 -04:00
08dc2cb847
Remove call to unstubbed session start
2020-05-08 09:32:49 -04:00
f498866c3a
Update validation for session_manager connectivity
...
Validation will now check that either a IamInstanceProfile or a TemporaryIamInstanceProfilePolicyDocument is set
2020-05-08 09:32:49 -04:00
2f09b74587
amazon/builder: Move port validation for security group into RunConfig.Prepare
2020-05-08 09:32:48 -04:00
3f6b28b70c
Add SSMTunnel step to other amazon builders, minus chroot
2020-05-08 09:32:48 -04:00
743df19af2
Add tests for driver and ssm tunnel step
2020-05-08 09:32:48 -04:00
e53d6aea66
amazon/ssm_driver: Update to support command context
...
* Defer the release of the found port to prevent possible Packer build collisions.
2020-05-08 09:32:48 -04:00
5e14089851
tests/builder/amazon: Add basic testing for session_manager
...
* Add a test to ensure the proper host is returned when using session_manager
* Add a basic driver test for the validating that the SSMDriver will fail if the plugin is not in the path.
2020-05-08 09:32:48 -04:00
60e0ba7e68
Update iam instance profile name
2020-05-08 09:32:48 -04:00
d5a0262d6c
builder/amazon/instance: Add session manager support
2020-05-08 09:32:48 -04:00
e515aefee3
Add validation checks for session_manager
...
* Session manager connectivity only supported via SSH
* Session manager requires the use of an iam instance profile with system manager permissions
2020-05-08 09:32:48 -04:00
c1d2477d18
builder/amzon: Update port configuration for WinRM
...
Connectivity for WinRM works for the initial connection, but fails to upload any provisioning scripts - need to dive in deeper.
For now connectivity over SSH works as expected.
2020-05-08 09:32:48 -04:00
fbffbd1899
docs/builder/amazon: Add short blurb for connecting via the AWS session_manager interface
2020-05-08 09:32:48 -04:00
520061dee6
builder/amazon: Update Session Manger connectivity
...
* Update security group creation step skip ingress rules if using session manager
* Update create ssm tunnel step to dynamically set a session port
* Add SSHPort function to common to return session-manager tunnel port
* Update SSHHost to return proper host for session-manager
2020-05-08 09:32:48 -04:00
3dd46eb5f4
Add PoC of connectivity using session-manager-plugin
...
* Add a bunch of hard coded values for testing on port 8081; ssh configs
are set to localhost and 8081
* Add a base drive for communicating with the session manager plugin
* Update step for creating tunnel to actually create SSM session tunnel via driver
2020-05-08 09:32:48 -04:00
16604373ac
initial ssm tunnel changes - not working
2020-05-08 09:32:48 -04:00
b86efe7604
Vbox Checksum Bugfix ( #9101 )
...
* attempting to repro github issue 9049
* update vbox ovf configtest to table test for mixedcase bug
2020-05-07 19:08:52 -04:00
26d05abd4f
Merge pull request #9182 from hashicorp/fix_9131
...
support pushing multiple tags
2020-05-07 12:09:19 -07:00
62556c464c
Update builder/docker/artifact_import.go
2020-05-07 11:39:09 +02:00
02c1cf5b28
support pushing multiple tags
2020-05-06 16:39:41 -07:00
49af617be3
Merge pull request #9179 from hashicorp/fix_9177
...
fix docs for video_ram to use correct units
2020-05-06 09:53:40 -07:00
279fbb45ab
Merge pull request #9174 from hashicorp/do_9145
...
output_filename virtualbox option.
2020-05-06 09:40:33 -07:00
9baf2edd94
fix docs for video_ram to use correct units
2020-05-06 09:39:41 -07:00
5b4de6b16f
fix tests
2020-05-06 09:27:20 -07:00
Megan Marsh
Feiyu Shi
Rui Lopes
jhawk28
Sylvia Moss
Wilken Rivera
Evan Digby
Andrew Starr-Bochicchio
Adrien Delorme
Adrien Delorme
Ryo Tagami
Markus Liljedahl
Ryan Hartje