Commit Graph

3349 Commits

Author SHA1 Message Date
Hariharan Jayaraman 1f46271a6b Ensuring device login works for Windows build 2018-05-18 00:32:01 -07:00
Christopher Boumenot a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
Async delete Resource Group
2018-05-16 15:13:09 -07:00
Matt Coleman 3192f5e0da qemu builder: add the 'use_backing_file' setting for QCOW2 images 2018-05-16 10:22:50 -04:00
DanHam 73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
This reverts commit f342975ff3.
2018-05-16 13:52:00 +01:00
DanHam 2939cd75ae
Revert "Report the result of the disk compaction step"
Unfortunately this broke the ability to build on remote (ESXi) hosts.

This reverts commit 08f9d619a9.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman e1b18d594a Updates based on PR feedback 2018-05-15 11:41:26 -07:00
DanHam ec8b70721c
Use an explicit error message when an error is expected and we don't get one
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam 82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting 2018-05-15 12:25:06 +01:00
DanHam 99e3487795
Add missing validation and tests for Spot Instance requests 2018-05-15 12:25:06 +01:00
DanHam d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders 2018-05-15 12:25:06 +01:00
DanHam 6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance 2018-05-15 12:25:06 +01:00
DanHam df7fb86984
Add tests for T2 Unlimited configuration 2018-05-15 12:25:06 +01:00
DanHam be02b3f613
Validate template settings when T2 Unlimited has been enabled
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam 482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance 2018-05-15 12:25:06 +01:00
DanHam 2c339b99d2
Sort run config options alphabetically 2018-05-15 12:25:06 +01:00
Hariharan Jayaraman c8c9bbb22a Async delete Resource Group 2018-05-14 20:06:23 -07:00
Unknown 5710c0aca1 Making log output clearer for hyper-v gui connection 2018-05-14 20:53:51 +10:00
Unknown 29c4b4436d Changes requested in PR #6243
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown fc734b6bd9 Using vmconnect to display gui for hyper-v
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
Christopher Boumenot 132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
M. Marsh 5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Hariharan Jayaraman 13c0b0b370 Added warning for VHD creation and updated samples 2018-05-10 13:15:35 -07:00
Stefan Henseler 6f00596053 Adds config option to specify hyper-v secure boot template 2018-05-10 19:00:35 +02:00
M. Marsh 84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
DanHam a866232ac9
Use regex based approach to detect attached disks 2018-05-08 12:52:39 +01:00
Megan Marsh 6dc4b1cbdc move all of the run commands for shell-local provisioner and postprocessor into common library too 2018-05-07 15:10:09 -07:00
Megan Marsh 616b41e58f deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module 2018-05-07 15:10:09 -07:00
Christopher Boumenot 80a096cadd azure: device login for US Gov 2018-05-06 20:59:38 -07:00
Paul Meyer 8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
Update Azure SDK
2018-05-04 09:47:28 -07:00
Rickard von Essen 4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
Paul Meyer 169f9d22e6 Update 'the other place' too 2018-05-04 00:32:15 +00:00
Paul Meyer 80f57308d7 Process review feedback 2018-05-04 00:28:34 +00:00
Christopher Boumenot 420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
Matthew Hooker 0521efa200
correctly log reason waiting for ami failed. 2018-05-03 12:27:09 -07:00
Matthew Hooker 7d5ebd5500
Merge pull request #6217 from alessiot77/5887
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
DanHam c47e5d19f0
Fix use of auto generated ssh key for scaleway builder 2018-05-03 11:33:28 +01:00
DanHam 585b93cfd6
Follow variable privateKey <-> statebag private_key convention 2018-05-03 00:33:12 +01:00
Oskar Wycislak 78d68880c0 Randomize osDisk name for Azure Managed Image builds.
This fixes #6115
2018-05-02 22:42:08 +02:00
Paul Meyer 07d8c71a2d Create and use context for Builder.Run 2018-05-01 23:40:40 +00:00
M. Marsh e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
Paul Meyer cf94086b5f Formatting fixes 2018-05-01 19:53:20 +00:00
Matthew Hooker 6260151034
Merge pull request #6226 from hashicorp/fix6225
builder/qemu: properly prepare boot command.
2018-05-01 12:41:11 -07:00
Matthew Hooker 4f1395e0f6
builder/qemu: properly prepare boot command. 2018-05-01 12:40:00 -07:00
Paul Meyer c13965c0ce Add acceptance tests 2018-05-01 15:39:50 +00:00
Paul Meyer a3fb24639a make tests pass again 2018-05-01 15:39:50 +00:00
Paul Meyer 09ce3c9803 Make it compile again 2018-05-01 15:39:50 +00:00
AlessioT 3d4c7d0df1 Feature Request: Log reason why AMI creation failed 2018-04-30 20:59:13 +01:00
DanHam 25dd27a164
Remove tmp directories created by builder/vmware/common tests 2018-04-30 20:38:03 +01:00
DanHam 13b7078cb0
Remove tmp directories created by builder/virtualbox/common tests 2018-04-30 20:38:03 +01:00
DanHam 475b3978d2
Remove tmp directories created by builder/parallels/common tests 2018-04-30 20:38:03 +01:00
DanHam 5642f8cb01
Remove tmp files created by builder/googlecompute tests 2018-04-30 20:38:03 +01:00
DanHam 9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests 2018-04-30 18:16:46 +01:00
DanHam 54e9690dff
Remove tmp files created by builder/amazon/common tests 2018-04-30 18:16:46 +01:00
DanHam 96adb4a9d1
Remove tmp files created by builder/alicloud/ecs tests 2018-04-30 18:16:46 +01:00
AlessioT 373226e9c5 Extract state reason for failure 2018-04-28 12:40:48 +01:00
AlessioT 09bb21774d alessio.tomasino@yahoo.co.uk 2018-04-28 11:02:53 +01:00
AlessioT c27f3e9445 alessio.tomasino@yahoo.co.uk 2018-04-28 11:00:33 +01:00
DanHam c828015bc3
Follow variable varName <-> statebag var_name convention 2018-04-27 20:09:19 +01:00
M. Marsh df5c67090e
Merge pull request #6193 from adarobin/hvf
add support for hvf accelerator to qemu builder
2018-04-27 11:41:01 -07:00
Megan Marsh ed6d999b1f add windows-sql-cloud to the list of projects to check for an image name 2018-04-27 11:24:08 -07:00
DanHam f342975ff3
Fix test - reporting compaction results requires a tmp file 2018-04-27 16:40:44 +01:00
DanHam 08f9d619a9
Report the result of the disk compaction step 2018-04-27 16:40:29 +01:00
DanHam 10d93dffa4
Fix tests for vmware/common 2018-04-27 16:40:23 +01:00
DanHam a729ecda87
Fix tests for vmware/vmx builder 2018-04-27 16:40:13 +01:00
DanHam c48a7889f9
Simplify handling of disks by collating requirements and unifying ops 2018-04-27 16:39:52 +01:00
Adam Robinson 29b89e63b8 add support for hvf accelerator to qemu builder 2018-04-27 10:11:20 -04:00
M. Marsh 879319a76c
Merge pull request #6202 from rickard-von-essen/fix-6184
builder/parallels-pvm: Add missing compaction of disks
2018-04-26 15:44:12 -07:00
Matthew Hooker 67a9c7fb92
we never expect remote cache to be a directory. 2018-04-26 12:40:40 -07:00
Matthew Hooker de1dac1bdf
don't delete the cache directory. 2018-04-26 12:40:40 -07:00
Matthew Hooker 97cfd60b82
Remove remote cache correctly. 2018-04-26 12:40:35 -07:00
Matthew Hooker 451e3d0554
builder/vmware-esxi: remove floppy files when done 2018-04-26 10:47:33 -07:00
Adam Robinson 3aebd5f462 Add use_fixed_vhd_format Hyper-V ISO option 2018-04-26 13:35:19 -04:00
Rickard von Essen 77d0ba492d
parallels-pvm: Add missing compaction of disks 2018-04-26 14:09:17 +02:00
Megan Marsh 59e3ec722d allow user to mount entire block device in chroot builder 2018-04-25 10:47:52 -07:00
Matthew Donoughe ef03e97dc3 pass MacAddress to StepCreateVM 2018-04-24 20:39:42 -04:00
M. Marsh 148f7d39e4
Merge pull request #6142 from harveylowndes/use-official-go-sdk
builder/oracle: Use official OCI Go SDK
2018-04-24 16:34:38 -07:00
Richard Nienaber db65c99bf4 update code based on master and update docs 2018-04-24 10:35:27 +01:00
Richard Nienaber e2e7953fe4 Merge branch 'master' into allow_gcp_winrm_password 2018-04-24 10:25:27 +01:00
Matthew Hooker cbdf9db832
Use contexts with amazon waiters. 2018-04-23 12:57:15 -07:00
Matthew Hooker 6bbfe7e0bd
remove useless check against format 2018-04-23 10:24:49 -07:00
Matthew Hooker fdeadfe3f6
builder/vmware: correctly default export format to ovf 2018-04-23 10:17:53 -07:00
Matthew Hooker 0e80d98805
Merge pull request #6166 from hashicorp/parallelsfixes
forcefully stop parallels vm.
2018-04-23 10:08:35 -07:00
M. Marsh 69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
M. Marsh e455e7b054
Merge pull request #6074 from DanHam/fix-vmx-compacting-error
Fix error with VMware vmx builder at compacting stage
2018-04-23 09:03:36 -07:00
Rickard von Essen a2a593759e
Merge pull request #6041 from Xeite/f-add-instance-name
builder/openstack: Add instance_name config to OpenStack builder
2018-04-23 08:47:50 +02:00
DanHam bd9e585cb9
Add test for enumeration of vmx network type 2018-04-21 22:49:36 +01:00
DanHam 94d5a7f2e2
Fix copy/paste error referencing Virtualbox 2018-04-21 22:49:36 +01:00
DanHam 1aee759f06
Fix tests and reconfigure for support of multi-disk vm 2018-04-21 22:49:36 +01:00
DanHam 6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm 2018-04-21 22:49:36 +01:00
M. Marsh bcbee45bf9
Merge pull request #6039 from stack72/triton-insecure-skip-tls-verify
builder/triton: Add support to Skip TLS Verification of Triton Certificate
2018-04-20 13:44:28 -07:00
Matthew Hooker 024fac4b4f
Merge pull request #6129 from hashicorp/bc_replace
Replace boot command parser with PEG parser.
2018-04-20 12:21:20 -07:00
Evgeni Golov 5a10e5a038
fix invalid disc_discard setting error message 2018-04-20 13:17:40 +02:00
Matthew Hooker 11de2b9759
remove unnecessary log line. 2018-04-19 16:13:24 -07:00
Matthew Hooker c920e0a20b
forcefully stop parallels vm.
also only output parallels version once.
2018-04-19 16:11:29 -07:00
Matthew Hooker 1d36ef038c
implement boot config struct for hyperv 2018-04-19 14:26:31 -07:00
Matthew Hooker a0c9ddb9ae
implement boot config struct for virtualbox 2018-04-19 14:26:31 -07:00
Matthew Hooker c8e76ce298
implement config struct for qemu 2018-04-19 14:26:31 -07:00
Matthew Hooker c6299972b9
s/boot_command/bootcommand/ 2018-04-19 14:26:31 -07:00
Matthew Hooker 7990966a09
fix boot command config struct name 2018-04-19 14:26:31 -07:00
Matthew Hooker e662927623
Implement boot config struct for parallels 2018-04-19 14:26:30 -07:00
Matthew Hooker 408eba88ad
flatten boot command config and implement for vmware 2018-04-19 14:26:30 -07:00
Matthew Hooker 94129b7fe3
we're using PC-XT (set1) not PC-AT 2018-04-19 14:26:30 -07:00
Matthew Hooker a46a7afa20
Remove old tests. 2018-04-19 14:26:29 -07:00
Matthew Hooker cba4d3235f
cleanup 2018-04-19 14:26:29 -07:00
Matthew Hooker bf0a320125
Implement new parser for qemu boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker bdb1eee7d8
Implement new parser for HyperV boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker 81d127768c
Add key press interval to virtualbox. 2018-04-19 14:26:29 -07:00
Matthew Hooker 59376294ef
Maximize scancode throughput.
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
Matthew Hooker 9b7704c714
Implement new parser for Parallels boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker 99d61920d0
Abstract vbox driver into PC-AT driver. 2018-04-19 14:26:29 -07:00
Matthew Hooker e4af71858f
Implement new parser for Virtualbox boot command
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
Matthew Hooker 1c0af28662
Some cleanup and comments. 2018-04-19 14:26:29 -07:00
Matthew Hooker 4e2f14196a
Rely on context to cancel typing boot command. 2018-04-19 14:26:28 -07:00
Matthew Hooker 673245afcf
Replace boot command parser with PEG parser. 2018-04-19 14:26:28 -07:00
M. Marsh f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00
Harvey Lowndes c442ba165e Migrate to official OCI Go SDK 2018-04-17 10:30:42 +01:00
Megan Marsh 3afb243f11 use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run. 2018-04-16 13:41:17 -07:00
Richard Nienaber ec6f8264bf fix winrm password access in google compute 2018-04-16 10:56:26 +01:00
Megan Marsh ee1ff3132d remove attempt to discover whether destination is a directory from upload function in various communicators 2018-04-10 08:13:06 -07:00
M. Marsh 83162717ed
Merge pull request #4563 from marema31/vmware-iso-warn-esx
builder/vmware-iso: Fail on wrong remote_type value
2018-04-06 16:52:26 -07:00
Matthew Hooker f094b3be85
update changelog 2018-04-05 16:32:03 -07:00
Matthew Hooker cb90e8b375
Merge pull request #6111 from hashicorp/replace4448
Restrict deregistered AMIs to those owned by self.
2018-04-05 16:30:37 -07:00
Matthew Hooker d70451f82e
Merge pull request #6106 from sethvargo/sethvargo/useragent
Add a common package for specifying useragent and adopt that everywhere
2018-04-05 15:38:11 -07:00
Megan Marsh d236f26439 allow users to access winrm password in powershell and elevated powershell provisioners 2018-04-05 15:24:54 -07:00
Matthew Hooker 302b1988a5
Restrict deregistered AMIs to those owned by self. 2018-04-05 13:29:36 -07:00
Seth Vargo 5eeac07b63
Include existing azure user agent 2018-04-05 14:28:51 -04:00
Seth Vargo b17b333e29
Add a common package for specifying useragent and adopt that everywhere
There were 5 different formats for the Packer useragent string. This
fixes that and unifies it into a helper package.

I did not touch oracle's user-agent, because it looked kinda special.
2018-04-05 14:28:50 -04:00
Megan Marsh f2df7a45ba
Merge pull request #6096 from arizvisa/GH-5882
Fixes the DHCP lease and configuration pathfinders for VMware Player.
2018-04-02 16:57:20 -07:00
Megan Marsh 67d2de8de1
Merge pull request #6079 from hashicorp/do_5866
add user data and user data file to oracle oci builder
2018-04-02 16:48:48 -07:00
Megan Marsh d6e5b01a23
Merge pull request #6095 from hashicorp/OPaniC
prevent panics when cleaning up resources that haven't been created.
2018-04-02 16:34:34 -07:00
Megan Marsh 22608f3efd
Merge pull request #6088 from adongy/master
Expose more source ami data in the template
2018-04-02 16:32:16 -07:00
Matthew Hooker 7e13b5c62a
prevent panics when cleaning up resources that haven't been created. 2018-04-02 11:56:11 -07:00
Matthew Hooker 52f69cd91a
Validate image name. 2018-04-02 11:22:15 -07:00
Ali Rizvi-Santiago 2c2904c095 Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases.. 2018-03-30 18:19:25 -05:00
Ali Rizvi-Santiago 7e9699675f Modified device matching logs to look more consistent. 2018-03-30 18:15:46 -05:00
Matthew Hooker 0533e1ad9c
Validate destination image name. 2018-03-30 13:01:52 -07:00
ADO 04790695e6 Add interpolate_build_info_test tests 2018-03-30 16:46:35 +02:00
ADO 507b3619e7 Expose more source ami data in the template 2018-03-30 10:47:11 +02:00
Ali Rizvi-Santiago 6e176f97a0 Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network. 2018-03-29 13:12:59 -05:00
Ali Rizvi-Santiago 646523c5f4 Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers. 2018-03-29 13:04:25 -05:00
Matthew Hooker f2fc064037
Merge pull request #6056 from rjosephwright/snapshots
Modify ebssurrogate builder to snapshot all launch devices
2018-03-29 10:15:19 -07:00
Matthew Hooker 541d33a80f
Merge pull request #6067 from mcandre/virtualbox-fixes
VirtualBox fixes
2018-03-29 10:13:49 -07:00
Omer Katz 56af885212
Avoid warning when using raw format.
When using the raw image format and attempting to resize it we get the following error message:
```
WARNING: Image format was not specified for 'test.raw' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
```
Specifying the format will remove this warning.
2018-03-29 14:51:02 +03:00
Megan Marsh 7623c26e4e
Merge pull request #6057 from arizvisa/GH-5925
Fixed a case-sensitivity issue when determing the network type during the cloning step in the vmware-vmx builder
2018-03-28 13:54:09 -07:00
Megan Marsh 16d044b398 add user data and user data file to oracle oci builder 2018-03-28 13:27:41 -07:00
Megan Marsh 58ecd32289 remove redundant security_protocol code from the winrm implementation of the oracle-classic provisioner 2018-03-28 10:54:06 -07:00
Andrew Pennebaker fdc6ac631a fix vbox scancodes and support critical key combinations during boot-time operations 2018-03-26 18:35:45 -05:00
Ali Rizvi-Santiago 55702a697a Ack, forgot to :w in vim. Changed ui.Say in step_clone_vmx.go to use fmt.Sprintf as it originally was a call to log.Printf. 2018-03-25 19:03:46 -05:00
Joseph Wright 1913517d29 Fix formatting by running `make fmt` 2018-03-25 19:51:49 -04:00
Ali Rizvi-Santiago 72da7cbfbb Fixed a case-sensitivity issue when determing the network type during cloning in the vmware-vmx builder and added also some logs that output the different options that were determined from the .vmx. This outputs more accurate debug information and helps out with issue #5925 2018-03-25 18:51:37 -05:00