Commit Graph

11922 Commits

Author SHA1 Message Date
Don Kuntz e251adb37e Make the amazon-private-ip fixer errors more visible
At present, when using the packer fix command on a template that has
"ssh_private_ip" set to anything but a boolean value, the fixer will
fail, and appear to fail silently, simply returning a non-zero status
code without any message.

To determine what happened, users have to know to set PACKER_LOG=1 to
make the log message visible.

So far as I can tell, this is the only instance of log.Fatalf being
called, and based on the surrounding code the better solution would be
to return an error, which will then be visible to users of packer fix
without having to look in the logs.
2019-02-22 10:26:55 -06:00
Adrien Delorme 4da79a8837
Merge pull request #7333 from pop/patch-2
Update vsphere+vsphere-template array pairing docs
2019-02-22 10:59:32 +01:00
Joel Lopes c8a60c77d1 Add comments 2019-02-21 18:12:57 -08:00
Megan Marsh 440f1f5f3c
Merge pull request #7317 from hashicorp/pause_before_connecting
add a configurable pause before step_connect to work around bootstrap…
2019-02-21 11:59:47 -08:00
Elijah Caine M. Voigt 472b5ba710
Update vsphere+vsphere-template array pairing docs
The example and description of pairing `vsphere` and `vsphere-template` in a JSON array is accurate but ought to be more spelled out.
This introduces a change which makes that part of the example and docs more verbose, hopefully mitigating potential confusion.
2019-02-21 10:51:48 -08:00
Joel Lopes 1c030cb54b Use IMDS to get subscription for Azure MSI 2019-02-21 09:35:14 -08:00
Adrien Delorme 944c00900e parse_test.go: still display file name in case of error 2019-02-20 12:54:57 +01:00
Adrien Delorme c12e9eea3a template/parse_test.go: name the post-processors to their type as it's now the default 2019-02-20 12:49:21 +01:00
Adrien Delorme b6b3cc901c template/parse_test.go: use diff for easier eye debug 2019-02-20 12:48:52 +01:00
Adrien Delorme b37dee1a67 Update post-processor docs 2019-02-20 12:39:37 +01:00
Adrien Delorme 5eccbc702d name a post-processor to it's type if it is not named 2019-02-20 12:38:30 +01:00
Adrien Delorme 3167d5d52c document post-processor execpt more 2019-02-20 12:38:21 +01:00
Adrien Delorme 0f7065f6b1 post-processor except: don't match empty names 2019-02-20 12:38:03 +01:00
Adrien Delorme 7e2d86731e tests: add a post-processor that creates an unnamed.txt file 2019-02-20 11:03:17 +01:00
lrxcy 3f04b8193f fix endpoints description 2019-02-20 14:38:54 +08:00
lrxcy 4fae17767d add Endpoints Description 2019-02-20 12:18:16 +08:00
Megan Marsh 5cc442872e
Merge pull request #7314 from hashicorp/fix_7234
add noSSLVerify to ovftool args
2019-02-19 16:54:48 -08:00
Adrien Delorme de336ef15e TestBuildOnlyFileMultipleFlags: check that tomato.txt is not created 2019-02-19 16:40:42 +01:00
Adrien Delorme b04b8b3857 test building with `-except=""` 2019-02-19 15:25:41 +01:00
Adrien Delorme 560b15de00
Merge pull request #7326 from hashicorp/allow_to_set_build_settings
scripts/build.sh: allow to set build settings when building
2019-02-19 15:11:51 +01:00
Adrien Delorme f6be550f1a scripts/build.sh: allow to set build settings when building
this will for example allow me to have the following alias:
alias buildmain='export T=$(mktemp -d) && ALL_XC_OS="linux darwin windows" ALL_XC_ARCH="amd64" GOLDFLAGS="-s -w" ./scripts/build.sh && cd pkg/ && for dir in *; do zip -r "$dir.zip" $dir & ; done ;  wait && mv *.zip $T/. && open $T'

that build only on 'main' platforms, so that I can share binaries easily.
2019-02-19 15:10:30 +01:00
Adrien Delorme e93eda2c88
Merge pull request #7311 from hashicorp/fix_7228
make sure we don't try to load an iso into memory because of a user m…
2019-02-18 18:35:01 +01:00
Adrien Delorme 4f46bd74ab
Merge pull request #7313 from kristi/patch-1
add DescribeInstanceStatus to minimum permissions
2019-02-18 18:19:56 +01:00
Megan Marsh 31c8acc5bc add a configurable pause before step_connect to work around bootstrap race conditions 2019-02-15 15:05:29 -08:00
Megan Marsh 9b69790514 update changelog 2019-02-15 13:12:45 -08:00
Manuel Riezebosch d79b54e46a feat(arm-builder): print warning on zone resiliency for currently not supported locations 2019-02-15 19:27:53 +01:00
Manuel Riezebosch f31031f6b1 feat(arm-builder): zone resilient from config 2019-02-15 19:27:32 +01:00
Megan Marsh 75f574bd4b
Merge pull request #7221 from hashicorp/vagrant_builder
Vagrant builder
2019-02-15 10:05:44 -08:00
Megan Marsh cb5c896c01
Merge pull request #7310 from hashicorp/fix_7286
also strip \r to work around windows file ending strangeness
2019-02-15 09:19:33 -08:00
Megan Marsh 9f702af6d9 we lost the skip_add step somewhere 2019-02-14 14:46:14 -08:00
Megan Marsh bbc52f9a7d add noSSLVerify to ovftool args 2019-02-14 12:10:58 -08:00
Megan Marsh be21850e32
Merge pull request #7060 from andrewsomething/do-post-processor
Add digitalocean-import post-processor.
2019-02-14 11:58:00 -08:00
Kristi 7e7e486901
add DescribeInstanceStatus to minimum permissions
Packer needs DescribeInstanceStatus or else it ends up waiting forever for the instance to become ready.
2019-02-14 11:53:53 -08:00
Megan Marsh 2a9f49a5c6 make sure we don't try to load an iso into memory because of a user mistake 2019-02-13 16:21:55 -08:00
Andrew Starr-Bochicchio 37b3305301 Better varibable naming. 2019-02-13 18:55:27 -05:00
Megan Marsh bd3339f1f9 also strip \r to work around windows file ending strangeness 2019-02-13 15:41:37 -08:00
Megan Marsh 9fe1366eeb
Merge pull request #7180 from xinau/packer-provisioner-inspec
Added inspec.io provisioner
2019-02-13 13:14:32 -08:00
xinau b449af84ee moved concurrency-safe ui code to packer/ui.go 2019-02-13 21:01:50 +00:00
Andrew Starr-Bochicchio ee430d9a40 Only filter on suffix if more than one file. 2019-02-12 20:20:39 -05:00
xinau ae59b81f44 added check for docker backend 2019-02-12 20:07:13 +00:00
Megan Marsh 9bada2e35d
Merge pull request #7305 from boumenot/pr-azure-new-maintainer
azure: new maintainer
2019-02-12 11:11:22 -08:00
Christopher Boumenot bc69f3e1c3 azure: new maintainer 2019-02-12 10:49:05 -08:00
Stephen Fox 2ab2ea6ef1 Fixed interface documentation typo. 2019-02-12 10:29:43 -05:00
xinau 36c1e8d838 moved adapter to common package 2019-02-12 07:10:57 +00:00
xinau 8526244285 changed local_port to uint representation 2019-02-12 06:32:19 +00:00
xinau c207451f7e Merge branch 'master' of https://github.com/hashicorp/packer into packer-provisioner-inspec 2019-02-12 05:32:05 +00:00
Megan Marsh 956bc35769
Merge pull request #7281 from pauloj95/patch-1
add force to powershell move command
2019-02-11 16:16:18 -08:00
Andrew Starr-Bochicchio 62865cf37b Mention environmental variables in docs. 2019-02-11 18:24:16 -05:00
Andrew Starr-Bochicchio 203b6ca8b4 Prefix env vars w/ 'DIGITALOCEAN_' 2019-02-11 18:20:35 -05:00
Megan Marsh c7278e871c
Merge pull request #7038 from kmbulebu/openstack_deprecated_api
Replaced compute/v2/images with imageservice/v2/images.
2019-02-11 15:05:45 -08:00