a819217c93
fix virtualbox 6.0 beta command options
2018-12-10 15:18:21 -08:00
1a36458e9e
Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-10 16:24:27 -06:00
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
...
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
a6af04417e
Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument.
2018-12-10 15:09:56 -06:00
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
...
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
...
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
...
Fix 6965
2018-12-07 13:35:00 +01:00
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type
...
azure: configuration for disk caching
2018-12-06 15:06:21 -08:00
042e9ad14b
Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder.
2018-12-06 14:37:31 -08:00
dbfc1b5aff
fix tests
2018-12-06 09:36:16 -08:00
0058422a5c
also for vmx
2018-12-05 15:58:44 -08:00
0fe4d79bbf
add validation to prevent users from being confused about format functionality
2018-12-05 15:57:45 -08:00
2e977019e4
Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920 .
2018-12-04 23:52:17 -06:00
0174a502eb
support -force option and update docs
2018-12-05 11:50:35 +08:00
310ea6c006
Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920 .
2018-12-04 18:28:48 -06:00
040a33567e
Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser..
2018-12-04 16:54:47 -06:00
79b68fb89c
Replaced the previous incorrect logic with an re-implementation of common.ExpandUser.
2018-12-04 16:53:33 -06:00
e04986659a
Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified.
2018-12-04 16:53:33 -06:00
1a3c3f2ffc
Replaced all instances of mitchellh/go-homedir with an implementation based on os/user.
2018-12-04 16:53:33 -06:00
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices
...
Add a "temporaryDevices" key to the statebag for the VMware builder
2018-12-04 10:34:37 -08:00
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
65124985d1
don't set DetectZeroes if it's off, because some versions of QEMU don't support this option
2018-12-03 15:52:13 -08:00
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
c0c5c6afac
Add DigitalOcean post-processor.
2018-11-29 21:00:57 -05:00
c03894c05d
fix bad interpolation exemption for volume_size
2018-11-29 16:39:43 -08:00
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
...
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
...
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
bf97557abf
Backport VNC log from vmware to qemu
2018-11-28 19:13:29 +01:00
a485bcfdf3
delete copied image and snapshots if corresponding options are specified
2018-11-28 21:34:21 +08:00
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
fccd7d0692
add snapshot_labels to hcloud builder
2018-11-27 14:41:32 -05:00
6728244480
simplify for loop logic
2018-11-27 09:33:29 -08:00
c05ac784d3
fix tests
2018-11-27 09:31:01 -08:00
5ada3376b8
fix test
2018-11-27 09:31:01 -08:00
2c989157e4
gofmt
2018-11-27 09:31:01 -08:00
5b6cbeed1d
expose `--iso` option down in `VBoxManage export --iso` up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled.
2018-11-27 09:31:01 -08:00
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
...
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
7704ff2f24
apply tags to relevant snapshots
2018-11-26 16:58:32 +08:00
1aaa998b02
Revert back to reset server
2018-11-26 09:49:45 +01:00
6589bfaaab
Small code improvements and fixes
2018-11-26 09:10:17 +01:00
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks
...
alicloud: support creating image without data disks
2018-11-26 13:13:51 +08:00
76d1bf567e
Replaced compute/v2/images with imageservice/v2/images.
...
Removed usage of a deprecated API.
Standardized clientService naming.
2018-11-25 14:30:31 -05:00
3c1395eb04
support wait_snapshot_ready_timeout for much bigger disk
2018-11-25 16:05:26 +08:00
0f3bfbf8e6
Fix timing issues by updating to hcloud-go v1.11.0
2018-11-24 17:56:09 +01:00
802e7d467d
openstack: Add support for tagging new images.
2018-11-23 20:22:10 -05:00
064e6c7e08
Add support for builds using rescue mode
2018-11-23 20:35:32 +01:00
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory
...
Add configuration options to vmware builder to specify cpu count and memory size
2018-11-23 10:53:46 +01:00
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory
...
Add configuration options to parallels builder to specify cpu count and memory size
2018-11-23 10:50:01 +01:00
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory
...
Add configuration options to virtualbox builder to specify cpu count and memory size
2018-11-23 10:27:14 +01:00
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
0f019407d6
Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions.
2018-11-22 20:48:00 -06:00
784535a4e3
Updated things related to the parallels-iso builder to correspond to @azr's suggestions.
2018-11-22 20:19:00 -06:00
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
da6e350949
fix tests
2018-11-20 15:20:01 -08:00
fbb3d526e3
move region validation to run so that we don't break validation when we don't have aws creds set
2018-11-20 15:01:28 -08:00
849a6ed353
add ssh_keys config to hcloud builder
2018-11-20 13:58:17 -05:00
3c2c13a021
support creating image without data disks
2018-11-19 15:25:12 +08:00
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
eca26f43f2
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:34:22 -06:00
24140131c7
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:32:11 -06:00
51948daf92
Added options for the cpu count, memory, audio, and usb to the virtualbox builder.
2018-11-17 06:19:54 -06:00
71d15d05c0
Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder.
2018-11-17 06:13:59 -06:00
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
4e73c85e22
Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.
2018-11-16 22:20:00 -06:00
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
...
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
b8def0b3fb
Added test to check for missing OS disk snapshot name and data disk snapshot prefix
2018-11-15 22:01:16 +00:00
67342750a3
Addressed PR comments
2018-11-14 01:47:48 +00:00
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
3b413d2e5e
fix rebase conflicts
2018-11-12 13:24:03 -08:00
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
...
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
78ac943679
Merge pull request #6987 from hashicorp/6624
...
6624
2018-11-12 15:31:36 +01:00
175b6a7971
add test for MSI configuration
2018-11-12 12:04:57 +01:00
1958ef6e81
remove unecessary check
2018-11-12 11:32:49 +01:00
08e8b1850e
remove unnecessary parenthesis
2018-11-12 10:49:39 +01:00
2d6b18e63e
Fix tests after bug fix
2018-11-10 00:05:25 +00:00
2e2b2cea82
add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data
2018-11-09 15:46:52 -08:00
213fbbae00
Updated go version and reformatted
2018-11-09 22:41:48 +00:00
3cf4c63a87
Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary.
2018-11-09 14:00:07 -08:00
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
a297d73b98
correcting wrong log message
2018-11-09 19:29:57 +00:00
06525dd885
adding logs in the steps
2018-11-09 19:28:37 +00:00
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id""
2018-11-09 08:47:22 -08:00
1ab0173e69
azure builder: allow to auth with managed identities ( MSI )
2018-11-09 17:39:03 +01:00
8881bc2d64
Fix bug in snapshot client creation
2018-11-09 03:30:57 +00:00
c1c929164f
Revert "Rename attribute api_access_key to organization_id"
2018-11-08 16:34:23 -08:00
210d62de2c
Merge pull request #6925 from sieben/organization_renaming
...
Rename attribute api_access_key to organization_id
2018-11-08 16:33:15 -08:00
e54d2e3591
Rename attribute api_access_key to organization
2018-11-08 13:45:32 +01:00
536252683e
builders: reuse private key file reading function
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
8d8c86366b
Config tests + typo fix
2018-11-07 22:23:22 +00:00
1fa9f1ef11
formatting changes in stateBag.go
2018-11-07 18:11:48 +00:00
8c326dbab7
Formatting changes
2018-11-07 18:08:15 +00:00
b2d1675d39
Added tests
2018-11-07 03:23:17 +00:00
369b2dae5e
Inlining suggested functions
2018-11-06 21:50:53 +00:00
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
593363c5be
fix typo in last commit
2018-11-06 19:23:15 +00:00
1266d5146d
addressed PR comments + add file for data disk snapshots
2018-11-06 19:17:03 +00:00
8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591
...
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591 )
2018-11-06 09:59:26 -08:00
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
d12d23d34b
OS disk snapshot
2018-11-05 23:48:22 +00:00
79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
...
aws: better error handling of region/credential guessing from metadata
2018-11-05 11:24:09 -08:00
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
3f288fc6ca
aws client: config.WithMaxRetries(8)
2018-11-01 15:09:07 +01:00
daf1f39930
Merge pull request #6918 from hashicorp/oracle_classic_volumes
...
Parameterized volume size support for Oracle classic builder
2018-10-31 16:03:40 -07:00
3ff038d4d1
remove todo
2018-10-31 12:00:33 -07:00
c3a60ad0ce
add options for system disk properties
2018-10-30 21:09:59 +08:00
42cd3e4bf7
Warn if not a pv build but builder image entry is set. cleanup
2018-10-29 15:23:58 -07:00
653fa2298f
use guard clauses
...
* just return early if no FloatingIP is required
* move the instanceIP declaration up and store in the state bag to avoid
errors in ssh.go
2018-10-29 18:36:08 +00:00
4608b5d39d
amazon: add option for skipping TLS verification
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-29 21:35:29 +03:00
ea78cb62fd
Make the config.networkV2Client conditional
...
In cases where the OpenStack environment does not contain a v2 network, the
builder will error out. We only need the networkV2Client when using floating
IPs. This will allow packer to work in environments where a v2 network is not
available.
2018-10-29 18:32:09 +00:00
eb976894fc
cleanup
2018-10-27 02:04:36 -07:00
c697c9d3de
cleanup
2018-10-26 21:59:26 -07:00
f322397413
add config tests
2018-10-26 21:56:39 -07:00
6d6d262308
some final fixes and documentation work
2018-10-26 21:56:00 -07:00
4eba1ee724
remove unused config key
2018-10-26 20:02:51 -07:00
03932f1157
Clean up volumes
2018-10-26 20:02:13 -07:00
e2a0cbf7df
move upload script to const
2018-10-26 16:59:23 -07:00
7331d6fc7f
some final clean up
2018-10-26 16:59:23 -07:00
ab4f205bf6
correctly building linux/windows now
2018-10-26 16:59:23 -07:00
09de194d8e
trying to wrap the base communicator config but it needs to be prepared
2018-10-26 16:59:22 -07:00
ab5e964ca6
Connecting to master instance but not builder
2018-10-26 16:59:22 -07:00
ade396e140
don't echo image creation commands
2018-10-26 16:59:22 -07:00
3e966ae38d
make fmt
2018-10-26 16:59:22 -07:00
86f6cf478a
cleanup
2018-10-26 16:59:22 -07:00
6f729d0265
Adding some missing configuration
2018-10-26 16:59:22 -07:00
c42be62d90
fix identifier changes from oracle sdk
2018-10-26 16:59:22 -07:00
bbb0d450f1
todo
2018-10-26 16:59:22 -07:00
be91c99d29
warn about dangling segments.
...
The client offers no way to bulk delete keys, so for now let's just warn users.
The issue is tracked upstream here: https://github.com/hashicorp/go-oracle-terraform/issues/172
2018-10-26 16:59:22 -07:00
ce30e1053e
wip
2018-10-26 16:59:22 -07:00
9f310045fc
split image upload/creation. clean up
2018-10-26 16:59:22 -07:00
420d0ebe3e
fix artifact generation
2018-10-26 16:59:21 -07:00
84bb5d2f6f
create image list
2018-10-26 16:59:21 -07:00
fa54a64d28
WIP
2018-10-26 16:59:21 -07:00
b84c7df9da
Segments going into per-run subfolder
2018-10-26 16:59:21 -07:00
b5c6beb8a3
don't delete segments. registering works now.
2018-10-26 16:59:21 -07:00
705fa976a8
more debugging
2018-10-26 16:59:21 -07:00
2536790e0a
todo
2018-10-26 16:59:21 -07:00
7a35e2408f
fix pty, some todo and refactor of bash scri[t
2018-10-26 16:59:21 -07:00
fc301601e1
actually delete temp container
2018-10-26 16:59:21 -07:00
cd77d00fd8
delete temporary image container
2018-10-26 16:59:21 -07:00
21f786d686
todo and some clean up. correct values for machine image
2018-10-26 16:59:21 -07:00
b222d36669
use 2x volume size
2018-10-26 16:59:21 -07:00
7c577abbcb
WIP: register machine image.
...
remove passwords
2018-10-26 16:59:21 -07:00
8207ba4fa4
Use jq to create manifest. Upload to compute_images
2018-10-26 16:59:20 -07:00
96e62236ec
upload volume WIP
...
check upload for error
increase builder volume size to account for chunking
2018-10-26 16:59:20 -07:00
8598e2d0a3
WIP
2018-10-26 16:59:20 -07:00
bf7c4a7ad6
wip
2018-10-26 16:59:20 -07:00
445c3fb5bb
cleanup temp keys
2018-10-26 16:59:20 -07:00
098764d8ac
WIP
2018-10-26 16:59:20 -07:00
2db0a03142
image upload WIP
2018-10-26 16:59:20 -07:00
265ee0b0b8
add whitespace
2018-10-26 16:59:20 -07:00
7c26ffef9c
builder instance now runs and is connected to
2018-10-26 16:59:20 -07:00
b3ffa975c3
Revert "add boot volume to builder instance"
...
This reverts commit cbce7b42079d2087bc622fd8c6f65d1339b735d1.
2018-10-26 16:59:20 -07:00
2febfa2c7d
attach volume after instance booted
2018-10-26 16:59:20 -07:00
b68f214ca4
add boot volume to builder instance
2018-10-26 16:59:20 -07:00
ca3bffcb0d
bugfix and some debug logging
2018-10-26 16:59:19 -07:00
00ff187d77
master instance working
2018-10-26 16:59:19 -07:00
e271e88b49
oracle-classic variable volume size WIP
2018-10-26 16:59:19 -07:00
f4fbf45349
remove duplicate region check error
2018-10-26 17:44:56 +02:00
16aa21dffe
aws: better error handling of region guessing from metadata
...
* this will fix #6919
2018-10-26 12:24:10 +02:00
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
3193f50f17
Support export with the vmx builder.
2018-10-25 13:02:37 -07:00
a68a639a1a
Move step_export to common.
2018-10-25 12:55:10 -07:00
63054fb808
Fix the test.
2018-10-25 12:45:44 -07:00
da5f322484
Add quotes around all filenames to prevent issues with spaces
2018-10-25 12:45:44 -07:00
f42f5a8ad3
Remove some extra logging.
2018-10-25 12:44:29 -07:00
e7e6a80587
No need to make upload public.
2018-10-25 12:39:51 -07:00
c294e65c36
A separate driver file is not really needed anymore
2018-10-25 12:39:51 -07:00
2ed6c3ef5e
Set output dir always according to the config.
2018-10-25 12:37:47 -07:00
c940f7e754
Conditional reload.
2018-10-25 12:37:47 -07:00
17845beadc
Fix the CommHost tests
2018-10-25 12:37:47 -07:00
5e74bcfb88
Fix tests, move remote_ default values to driver_config.
2018-10-25 12:30:57 -07:00
4d9cb19012
Refactor artifacts and output_dir implementations.
2018-10-25 12:21:24 -07:00
2d00dc6756
Add VMName to the vmx mods.
2018-10-25 11:17:09 -07:00
7b5943160b
Re-enable the CommHost() call. Use common's driver factory.
2018-10-25 11:17:09 -07:00
ba22090bc9
Move step_register and step_uload_vmx from iso to common.
2018-10-25 11:07:02 -07:00
b5298464c5
Move the remote_driver from iso to common.
2018-10-25 11:01:22 -07:00
91c7089455
Implement the first version of the remote Clone().
2018-10-25 10:37:45 -07:00
46cfb5a30c
Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver()
2018-10-25 10:33:37 -07:00
c7b938c9d4
Merge pull request #6904 from hashicorp/fix_6890
...
Fix 6890
2018-10-24 10:43:34 -07:00
8908a72fa9
builder/hyperv/vmcx: allow to set generation from buildfile
...
this commit fixes #6908
2018-10-24 12:20:52 +02:00
ed793a8fb8
make ValidateRegion a member of *AccessConfig and make it variadic
2018-10-24 11:26:53 +02:00
fe044d8ff7
fix tests
2018-10-23 13:31:56 -07:00
Megan Marsh
Ali Rizvi-Santiago
chhaj5236
Adrien Delorme
bozhi.ch
Christopher Boumenot
Andrew Starr-Bochicchio
PORTE Loïc
Nathan A. Ferch
Andrew Pennebaker
dedene
zhuzhih2017
Kevin Bulebush
Rickard von Essen
Christopher Boumenot
Amrita Dutta
Adrien Delorme
Rémy Léone
Mikhail Ushanov
Matthew Hooker
chbell43
Alexander Laamanen
Stuart Miller