0be5a28080
Fix issue 4693 - Derive vpc_id from subnet_id
...
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.
This fixes issue #4693 .
2017-05-15 13:46:05 -07:00
6f63881020
fixes a typo introduced in a previous change
2017-05-11 13:34:48 -07:00
a269bbc6fa
Fix issue 4875 - use retry logic when creating instance tags
2017-05-11 16:25:28 +01:00
eece75a7a6
Wait for a 410 before returning success on a machine delete.
2017-05-10 09:12:24 -07:00
bd12c17bb0
Update triton client calls to pass along context
2017-05-05 11:20:21 -04:00
80d6cd91fd
remove unneeded keypair var
2017-05-01 10:17:21 -07:00
c4b8e8e5df
Merge branch 'master' into virtualbox_sata_port_count
2017-05-01 09:23:05 +10:00
602fd64c5d
builder/amazon: set flag to delete temporary keypair
2017-04-30 14:24:22 -07:00
7aca9b7f71
builder/azure: replace panics with error returns
2017-04-27 11:04:57 -07:00
d2ae36214a
builder/triton: Reconcile #4829 and #4838 docs
...
This changes the default region to match the default from Joyent
documentation.
2017-04-26 15:47:04 -07:00
c1cad8726b
builder/triton: Better AccessConfig tests
...
This commit adds an actual public/private key pair for testing since
these are now validated.
2017-04-26 14:08:29 -07:00
d9ba951929
builder/triton: Switch to joyent/triton-go library
...
This commit substitutes the now-deprecated gosdc library for the newer
triton-go library. This is transparent from a user perspective, except
for the fact that key material can now be ommitted and requests can be
signed with an SSH agent. This allows for both encrypted keys and ECDSA
keys to be used.
In addition, a fix is made to not pass in an empty array of networks if
none are specified in configuration, thus honouring the API default of
putting instances with no explicit networks specified on the Joyent
public and internal shared networks.
2017-04-26 14:02:03 -07:00
9f992b8f80
go files are 0644
2017-04-25 12:50:58 -07:00
f0e5f75b06
Update TODO.md
2017-04-24 14:19:24 -07:00
d092044834
Help ensure VMX builder properly removes mounted CDs on OS X
...
Pull request 1504 describes a workaround for a potential race condition in which the VMX builder can fail to remove mounted floppies or CDs. This workaround was enabled for all operating systems except OS X. Since this issue can also occur on OS X, also apply the workaround on it.
2017-04-19 16:27:16 -07:00
d646e1d035
refactor the code according hashicorp rename the repository
2017-04-18 15:14:45 +08:00
a3f70b874b
Spelling (context)
2017-04-09 20:38:19 +02:00
5ee212c85f
Inlined ctx
2017-04-09 20:33:05 +02:00
5b7ec545c5
Added monitoring and updated godo
2017-04-08 15:52:57 -04:00
da8c4004f0
builder/amazon: numbers are valid in ami name
2017-04-05 12:39:16 -07:00
bc3510b473
fix spelling
...
closes #4767
2017-04-05 12:01:02 -07:00
3f6b5165f2
add affirmative test case for #4762
2017-04-04 22:08:09 -07:00
d9041bda0c
Improved the test for special character so that it doesn't get halted by less than 3 character check
2017-04-05 11:06:59 +10:00
7911cfa94b
Formatting as per make fmt
2017-04-05 11:02:23 +10:00
fdae6858c8
conforming to the standard for imports
2017-04-05 10:53:58 +10:00
df6337e8ab
Added AMIName validation (issue 4761)
2017-04-05 10:46:44 +10:00
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
bce03492d9
remove references to ServiceAccountEmail
2017-04-03 11:22:00 -07:00
77dc8b84c1
builder/googlecompute: Revert to using default service account
...
Fixes issue with cross Project builds.
Closes #4608
Regression introduced in PR #3639
2017-04-02 17:52:14 +02:00
6f27f67346
more fixes from errcheck
2017-03-29 13:38:31 -07:00
4fcbf75da9
s/non existent/nonexistent/
2017-03-29 12:38:33 -07:00
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
bf64d7bdc2
automagic simplification
2017-03-28 20:36:20 -07:00
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
e4aa2a34ca
builder/amazon-chroot: nullable copy_files
...
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
35480e21b2
fix typo
2017-03-24 11:56:49 -07:00
0ad6b169bc
builder/virtualbox: retry removing floppy controller
2017-03-23 23:58:23 -07:00
74c8c585f5
builder/amazon: report tag creation
2017-03-23 16:12:59 -07:00
0c777a1d63
Fix for DriverMock not implementing Driver
2017-03-23 12:11:19 +11:00
67eb600c08
Add sata_port_count so that a SATA controller can be created with more than 1 port. The default of prevents additional drives being added. Default preserved if not overridden.
2017-03-22 23:09:25 +11:00
8b763032ce
builder/hyper-v don't wait for shutdown to return.
...
Mirrors work done in #4436
2017-03-20 15:32:42 -07:00
68e2b150cd
builder/virtualbox: allow skipping upload of version file
2017-03-16 18:14:11 -07:00
8c2a8f5f81
Merge pull request #4655 from lbordowitz/ostk-sshca
...
OpenStack: Add ssh agent support
2017-03-14 21:07:03 +01:00
6cd3cb18da
builder/openstack: validate ssh key name/file
...
This is a port for OpenStack of PR #4665
2017-03-14 20:47:40 +01:00
bd76b7bb6f
builder/amazon: validate ssh key name/file
...
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
4c5461102a
amazon: Added (more) support for SSH Agent and temporary keypair names
2017-03-13 07:29:59 +01:00
0400ebae95
Fix the code according PR review
2017-03-12 10:22:25 +08:00
a047916944
Merge pull request #4621 from hui-yang/disk-type
...
builder/parallels-iso: Configuration of disk type, plain or expanding
2017-03-10 19:32:41 +01:00
c5b8a1069a
Add ssh agent to enable SSH-CA authentication.
2017-03-10 08:45:50 -08:00
50d9546658
builder/amazon: set force_deregister to true on -force
2017-03-09 14:24:49 -08:00
597b7ad8c5
builder/hyper-v: validate output dir in step, not in config
...
essentially same work as #2233
2017-03-08 23:52:34 -08:00
c5ddbacb62
Merge pull request #4318 from Tadas/fix-hyperv-admin
...
Check for 'Hyper-V Administrators' security group
2017-03-08 23:35:17 -08:00
9e8b602f28
Merge pull request #4643 from rickard-von-essen/issue-4620
...
googlecompute: Correct values for on_host_maintenance
2017-03-08 14:17:51 -08:00
eac5b6392d
googlecompute: Correct values for on_host_maintenance
...
If preemptible is true then on_host_maintenance must be TERMINATE.
Also corrected order in docs.
Closes #4620
2017-03-08 19:44:07 +01:00
2300b102b7
amazon: Step Region Copy crashing on device mapping
...
Closes #4635
2017-03-08 18:12:37 +01:00
b3c6ef9f6b
Skip disk compaction for plain disks
2017-03-07 18:22:23 -08:00
52d4514d6a
builder/parallels-iso: Configuration of disk type, plain or expanding
2017-03-03 15:32:51 -08:00
5e44a28a42
fix the missing access key for testcase
2017-03-03 17:56:48 +08:00
fadfb696dd
Add packer plugin which support alicloud ecs images
2017-03-03 16:56:17 +08:00
8cc2ed7d6e
vmware/esx: try for longer to connect to vnc port
2017-02-28 22:21:19 -08:00
9c027aa70b
Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
...
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
e856339309
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
...
As pointed out in the initial code review of #4351 , some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:
- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`
We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
1eec5bf058
builder/amazon-ebssurrogate: Exclude duplicate root volume
...
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
fd1b00a0d1
use aws helper method
2017-02-26 19:33:34 -08:00
61976dfd86
Merge pull request #4578 from life360/enable_ena
...
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
ed92055372
Merge pull request #4532 from mitchellh/vmipgetagain
...
builder/vmware: don't cache ip address so we know if it changes
2017-02-26 18:46:46 -08:00
1f2df5c174
Merge pull request #4536 from mitchellh/vmwareextraopts
...
builder/vmware: allow extra options for ovftool
2017-02-26 18:45:40 -08:00
6a7c37beb6
builder/amazon-chroot: support encrypted boot volume
2017-02-26 17:48:13 -08:00
f62d0abf4e
Merge pull request #4560 from guessi/deprecated_option_tag
...
Conditional ignore `force` flag for `docker-tag`
2017-02-26 17:43:25 -08:00
2cb9b32acf
don't attempt to delete non-existant key when using agent auth
2017-02-26 17:38:22 -08:00
f95514c120
fix ssh agent authentication
...
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
1cc3cdf7b5
Always set both SRIOV and ENA when Enhanced Networking is enabled
...
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).
Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
33a4c2e13b
Change EC2 WindowsPasswordTimeout to 20 minutes
...
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
635aeb765b
amazon/ebssurrogate: Add New Builder
...
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
3409ea76ee
Merge pull request #4564 from wtsi-hgi/fix/4551-openstack-builder-reuse-ips
...
add reuse_ips option for openstack builder
2017-02-21 15:20:10 -08:00
2381bfa8ad
Merge pull request #4518 from AlexLov/bugfix_image_family
...
[googlecompute] fix bug of creating image from custom image_family
2017-02-21 10:58:23 -08:00
e9cfaa2730
add reuse_ips option for openstack builder
...
add reuse_ips option and use it to control whether openstack builder
will attempt to reuse existing unassigned floating ips rather than
allocating a new one.
fix #4551
2017-02-16 12:44:03 +00:00
66615e3f56
reuse the func DockerDriver.Version()
2017-02-16 08:26:44 +08:00
5eae809b0c
improve description
2017-02-16 01:14:21 +08:00
c5e01da3c6
Conditional ignore `force` flag for `docker-tag`
...
`docker tag -f` will now become an error, since it was removed after
upgrading docker daemon to 1.12.0 (or later)
this PR is to bypass `force` flag if docker >= 1.12.0 was detected
reference:
- https://docs.docker.com/engine/deprecated/#/f-flag-on-docker-tag
Signed-off-by: guessi <guessi@gmail.com>
2017-02-16 00:50:46 +08:00
4f92b9fb61
Merge branch 'pr/4544'
2017-02-10 12:11:43 -08:00
2009fcd9df
OnHostMaintenance, googlecompute updating documenation , additional option for validation and setting defaults
2017-02-10 11:57:15 -08:00
bab590c177
Adding OnHostMaintenance option for googlecompue builder
2017-02-10 10:58:57 -08:00
0ed84f843e
builder/vmware: allow extra options for ovftool
2017-02-10 00:22:20 -08:00
29dd20da68
builder/vmware: don't cache ip address so we know if it changes
2017-02-09 23:16:40 -08:00
c41e32dbc1
print stderr on docker import failure
2017-02-09 20:41:29 -08:00
cfa8f8c215
fix bug of creating image from custom image_family
2017-02-08 22:50:19 +03:00
84fc62f6b2
Merge pull request #4496 from mitchellh/vmrmguest2
...
builder/virtualbox: remove guest additions
2017-02-03 23:14:35 -08:00
1fa643e88d
Merge pull request #4498 from mitchellh/f-simple-passwords
...
Reduce character set for passwords
2017-02-02 15:04:02 -08:00
70af3d8148
Merge pull request #4497 from mitchellh/f-clickable-links
...
Make rdp and vnc links clickable by adding the protocol
2017-02-02 12:41:59 -08:00
dcb4b50dbf
Reduce character set for passwords
...
At the beginning of each VMware build packer generates a random VNC password and prints it to the terminal / log. When copying a password from a terminal emulator with double-click, the text selection uses word boundaries to attempt to automatically detect where the password string is located. When the password contains weird characers like %^&# this parsing fails and you only get half the password. The reduction in characters does not significantly reduce the entropy of the password but improves user-friendliness when you actually want to use it.
Also deletedsome unused files
2017-02-02 04:03:46 -08:00
facf27ceeb
Make rdp and vnc links clickable by adding the protocol
2017-02-02 01:55:28 -08:00
e9e3215c38
builder/virtualbox: remove guest additions
2017-02-02 00:47:56 -08:00
228bc9cfd3
use driver delete method
2017-02-01 23:57:45 -08:00
6973e752d2
Vmware vsphere vnc port timeout increased
2017-01-29 14:41:14 +01:00
d294d2c576
gofmt
2017-01-28 10:29:35 +01:00
1ec6578c02
Add two new variables to Azure builder config
2017-01-27 12:26:28 +01:00
22d1322bd9
always check for an error first when walking a path
2017-01-26 16:32:21 -08:00
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
76f897077d
Merge pull request #4399 from rickard-von-essen/aws-interpolate
...
WIP: builder/amazon: Interpolate {{ .BuildRegion }} and {{ .SourceAMI }}
2017-01-26 11:41:16 -08:00
485fa58b43
Merge pull request #4443 from mitchellh/preservedockermode
...
communicator/docker: preserve file mode.
2017-01-26 11:22:00 -08:00
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
2a7c84e9ff
Merge pull request #4343 from vtolstov/qemu_convert
...
builder/qemu: allow to convert from any supported format
2017-01-24 01:12:31 -08:00
a51f492558
communicator/docker: preserve file mode.
2017-01-23 13:47:22 -08:00
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
9e2d69fb97
builder/docker: create export dir if needed
2017-01-21 23:51:08 -08:00
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
f1175c1921
parallels/vmware: don't wait for shutdown command.
...
Resolves #4134
replaces/ closes #4379
Leaving Hyper-V builder alone for now until we can get a case that reproduces.
2017-01-20 01:44:18 -08:00
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
7ad77b9e93
integrate new winrm transport interface
2017-01-18 22:11:48 +01:00
0a46d883df
Merge pull request #4409 from mitchellh/httpenvvar
...
set PACKER_HTTP_ADDR env var when available.
2017-01-18 12:35:14 -08:00
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
26dd3af9ec
Merge pull request #4411 from rickard-von-essen/issue-4406
...
builder/vmware: Try to use `ip address` to find host IP
2017-01-17 22:02:59 -08:00
d4b043451f
Merge pull request #4357 from dave2/gh-4215
...
Openstack builder should use existing floating IPs before allocating them
2017-01-17 11:14:59 -08:00
94a2aae749
Merge pull request #4361 from Tom-Byrne/openstack-instance-metadata
...
support OpenStack instance (not image) metadata
2017-01-17 11:05:20 -08:00
81ad800fb6
builder/vmware: Try to use `ip address` to find host IP
...
Closes #4406
2017-01-17 10:33:48 +01:00
d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
...
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.
Closes #2869
2017-01-16 23:19:52 -08:00
6ad702ad74
Update comments to reflect current implementation
2017-01-14 20:11:51 -08:00
ee2d636840
Improve delay between key events
...
- Can now tune delay using PACKER_KEY_INTERVAL
- Added implementation to all of VMware and QEMU
- Removed double delay for QEMU
- Default key delay of 100ms (as before)
- Added docs to QEMU and VMware pages
2017-01-14 17:56:04 -08:00
d0c64f90d5
Read key interval from ENV; default to 100ms
2017-01-14 16:52:37 -08:00
da083506f1
Reduce key delay to 10ms to boot times are a lot faster
2017-01-14 16:52:24 -08:00
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
b9d08e9d56
Merge pull request #4385 from rickard-von-essen/issue-4383
...
docker: Fix crash when performing log in to ECR with an invalid URL.
2017-01-11 11:37:37 -08:00
112f5abdae
docker: Fix crash when performing log in to ECR with an invalid URL.
...
Closes #4383
2017-01-11 20:23:24 +01:00
98b0f018fa
Merge pull request #4378 from DanHam/skip-export-vmware
...
Add option to skip export of installed VM for VMware ISO builder
2017-01-10 15:24:58 -08:00
a3da92dc97
Merge pull request #4339 from DanHam/gh-4131
...
Add option to skip export of installed VM for vbox ISO & OVF builders
2017-01-10 15:08:15 -08:00
c7e8d671a9
Add option to skip export of installed VM for VMware iso builder
2017-01-10 11:44:11 +00:00
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00
377f451a9e
it's InvalidGroup
2017-01-05 16:56:49 -08:00
e54605c120
Properly wait for security group to exist.
...
Adds check for `InvalidGroupID.NotFound` in addition to
`InvalidSecurityGroupID.NotFound`.
Uses aws's `waiter` for clarity.
2017-01-05 15:20:28 -08:00
d7545c4ba0
support OpenStack instance metadata
2017-01-05 14:42:32 +00:00
08ef89f032
Openstack builder should use existing floating IPs before allocating them
...
Rather than always creating a new floating IP, search the provided pool
for an unallocated address and use this instead. Only allocate a temporary
address if there is no spare address in the pool.
Closes #4215
2017-01-05 08:59:49 +13:00
aef6e0e93f
Merge pull request #4304 from dave2/gh-4277
...
Querying EC2 security groups should report unexpected errors
2017-01-04 10:53:28 -08:00
85cf00069f
Merge pull request #4294 from legal90/iso-target-extension
...
Add "iso_target_extension" option for all local *-iso builders
2017-01-04 13:48:28 +01:00
01c09aa7f7
Merge pull request #4325 from siepkes/f-triton-builder-2
...
Add Joyent Triton Builder
2017-01-01 15:40:11 -06:00
ae2e59634c
Merge pull request #4341 from rahart/f-chroot-snapshots-crash
...
amazon-chroot builder snapshot interface panic
2017-01-01 22:13:11 +01:00
ac769be49a
Pause between each boot command element rather than each char with -debug
...
Fixes #4332
2016-12-31 11:57:11 +00:00
Paul Thrasher
Ben Fagin
luis-silva
Sean Chittenden
Justin Reagor
Matthew Hooker
Ben Phegan
James Nugent
Christopher Boumenot
Bryon Ross
zhuzhih2017
Rickard von Essen
Luke Farnell
Craig Barr
Ben Phegan
Larry Bordowitz
huiyang
Aaron Stone
Richard Owen
Joshua Randall
guessi
Dimitri Rudnev
Alex Lov
Chris Bednarski
Jelle Hissink
Thomas Conte
Eike Verdenhalven
Roman Zhuzha
Richard Moore
DanHam
Tom-Byrne
Zanetti, David