Andrew Starr-Bochicchio
84f0079c3a
Move to a new func to make testable.
2020-05-13 13:29:22 -04:00
Andrew Starr-Bochicchio
a1f334daff
Use constant and move check to template generator.
2020-05-13 13:28:44 -04:00
Megan Marsh
481ef0bf82
add andrewsomething to codeowners for do
2020-05-13 10:06:16 -07:00
Andrew Starr-Bochicchio
bf0ab6b722
Force test to be skipped unless PACKER_ACC set.
2020-05-13 11:48:49 -04:00
Adrien Delorme
a1bff83afb
Update Config-required.mdx
2020-05-13 16:22:46 +02:00
Wilken Rivera
aa2c069067
Update post-processor/alicloud-import/post-processor.go
2020-05-13 10:19:55 -04:00
Wilken Rivera
b5639d4697
tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps ( #9213 )
...
* test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base
* Update mod files
2020-05-13 10:10:55 -04:00
Adrien Delorme
57395b8812
show a better error message in ssh.scpSession ( #9217 )
2020-05-13 15:57:05 +02:00
Adrien Delorme
a50c27c05d
single `
2020-05-13 15:51:18 +02:00
Adrien Delorme
c2d3e494b6
alicloud: better docs + autogenerated post processor docs
2020-05-13 15:49:34 +02:00
Christian Frichot
e2a02636bc
website: npm audit fix ( #9218 )
2020-05-13 13:49:19 +02:00
Kennith Leung
6a1737847d
Update vagrant.mdx ( #9215 )
...
If the `output_dir` is not set, the folder will be set to `output-` plus buildname.
2020-05-13 10:17:26 +02:00
Megan Marsh
fe472f45ae
don't put error in state, or we'll fail.
2020-05-12 16:51:40 -07:00
Megan Marsh
807a09a770
don't error if metadata can't be set. Old versions of openstack don't seem to play nicely with this API call
2020-05-12 16:51:40 -07:00
Megan Marsh
cccf74d755
update changelog
2020-05-12 16:50:26 -07:00
Megan Marsh
5b6f4a3286
Merge pull request #9209 from hashicorp/ssm-panic-fix
...
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
2020-05-12 15:16:34 -07:00
Wilken Rivera
6f5f6bf999
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
...
Tests before change
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2]
goroutine 299 [running]:
github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2
github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6
github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...)
/home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2
github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/wilken/Development/packer/packer/build.go:287 +0x7ef
github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...)
/home/wilken/Development/packer/command/build.go:290 +0x189
created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext
/home/wilken/Development/packer/command/build.go:284 +0xd5a
FAIL github.com/hashicorp/packer/provisioner/shell 188.335s
FAIL
```
Test After change
```
--- PASS: TestShellProvisioner (212.39s)
--- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s)
PASS
```
2020-05-12 14:49:57 -04:00
Andrew Starr-Bochicchio
05d56034dd
builder/digitalocean: Add acceptance test for creating Droplet using image ID.
2020-05-12 14:15:35 -04:00
Andrew Starr-Bochicchio
374a29d75c
builder/digitalocean: Add logging of Droplet create attributes.
2020-05-12 12:38:51 -04:00
Andrew Starr-Bochicchio
80b4e0425e
builder/digitalocean: Use correct type for image for Droplet creates.
2020-05-12 11:46:58 -04:00
Andrew Starr-Bochicchio
e8783873d0
builder/digitalocean: Fix failing acceptance test.
2020-05-12 11:37:07 -04:00
Adrien Delorme
52b2151b21
go generate ./packer
2020-05-12 16:19:26 +02:00
GennadySpb
334550b729
Fix mardown format ( #9211 )
2020-05-12 16:07:57 +02:00
Adrien Delorme
d147ebe79f
packer/new_stuff.go => packer/run_interfaces.go
2020-05-12 12:31:05 +02:00
Adrien Delorme
d34cecc668
Update new_stuff.go
2020-05-12 12:29:31 +02:00
Adrien Delorme
466358a13e
Delete command.go
2020-05-12 12:17:00 +02:00
Adrien Delorme
7ca0a80a86
remove Ui from command.MetaArgs
2020-05-12 12:14:30 +02:00
Adrien Delorme
77297e49e9
Update cli.go
2020-05-12 12:07:02 +02:00
Adrien Delorme
49c2a8cb17
update fix command with new synthax
2020-05-12 11:33:44 +02:00
Adrien Delorme
14f18f4236
dont catch signals in console, as it seems unecessary for now
2020-05-12 11:29:09 +02:00
Adrien Delorme
22a36ef97a
Move vars from Meta to cla args; this forces us to use it in GetConfigFromJSON which in turn forces us into updating console and validate
2020-05-12 11:24:22 +02:00
Adrien Delorme
4ebcbad332
update consul and vault dependencies ( #9205 )
...
* update consul and vault dependencies
* update triton sign call accorting to https://github.com/joyent/triton-go/pull/135
* Delete readme.md
* put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why
* fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order
2020-05-11 15:26:01 -04:00
Adrien Delorme
534e98c4ef
pass Meta command line arguments around
2020-05-11 17:56:14 +02:00
Rae Krantz
f861704961
replace AZR token with a CI one ( #9195 )
2020-05-11 11:21:30 +02:00
Sylvia Moss
25971b3b5c
Add pwd to gogetter ChecksumFromFile ( #9129 )
2020-05-11 11:14:50 +02:00
Megan Marsh
9c37d20721
Merge pull request #9196 from hashicorp/virtualbox_generate_docs
...
Virtualbox generate docs
2020-05-08 16:51:41 -07:00
Megan Marsh
2733109294
add generated docs
2020-05-08 15:58:36 -07:00
Megan Marsh
480c938162
generate virtualbox-vm docs instead of letting them be copy pasted
2020-05-08 15:58:36 -07:00
Megan Marsh
0f3e749f1a
Merge pull request #9197 from hashicorp/fix_9186
...
fix iso config prepare
2020-05-08 15:55:46 -07:00
Megan Marsh
16233371e6
fix unrelated broken flaky test
2020-05-08 15:14:29 -07:00
Megan Marsh
4ef34f7fba
fix iso config prepare
2020-05-08 14:11:51 -07:00
Megan Marsh
9476aa03de
Merge pull request #9105 from hashicorp/google_iap
...
Implement iap proxy for googlecompute
2020-05-08 12:40:42 -07:00
Megan Marsh
fcef10fd2f
Merge pull request #9082 from hashicorp/f-amazon_builder-ssm-session-tunnel-poc
...
builder/amazon: Add SSM Session Manager as a SSH interface connection
2020-05-08 12:40:03 -07:00
Megan Marsh
a55b73473a
fix logic
2020-05-08 10:24:28 -07:00
Megan Marsh
dde162622d
use local port in listener config, when set
2020-05-08 10:20:47 -07:00
Megan Marsh
81e043f2b0
fix windows tests
2020-05-08 10:13:43 -07:00
Megan Marsh
60600e6cf6
make windows work with account files containing spaces
2020-05-08 10:13:43 -07:00
Megan Marsh
dae60799bc
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
fda55fe928
deduplicate excess code
2020-05-08 10:13:43 -07:00
Megan Marsh
54b33ad8d1
fix tests
2020-05-08 10:13:43 -07:00