415ef26768
Removed TODO about key pair description per review feedback.
2019-02-28 09:30:30 -05:00
22df491c67
mock tty using interfaces to test more easily
2019-02-28 14:40:55 +01:00
0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
...
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
328cbf4e42
Merge branch 'master' into feature/7322
2019-02-27 19:29:18 +00:00
7f5c794e5f
add go-tty vendor
2019-02-27 17:01:02 +01:00
239a0c633f
use go-tty in ui.Ask to fix #7299
2019-02-27 16:59:59 +01:00
c588a8a24d
Revert "cheggaaa.pb: try to not open tty at init to see if it causes #7299"
...
This reverts commit 4e55278839
2019-02-27 16:52:55 +01:00
f535464097
up a test
2019-02-27 11:17:56 +01:00
f03cbd8a10
aws: allow to pass nil bool as encryption parameter
...
to retain current encryption settings
this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted
This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
ce8532e94b
aws: document ValidateRegion better
2019-02-27 11:17:08 +01:00
6af621c37a
aws: StepAMIRegionCopy call waitgroup.add only once
2019-02-27 11:17:08 +01:00
0e8afa37d5
Merge pull request #7347 from amphied/master
...
Fix support for aws-us-gov
2019-02-27 10:57:53 +01:00
01a0b0c766
kmsArnStartPattern - fix support for aws-us-gov
...
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html
Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00
9db844a807
move pause to after connection can be established.
2019-02-26 12:24:45 -08:00
b8510f35fc
Merge pull request #7330 from hashicorp/except_post_processor_tests
...
name a post-processor to it's type when it is not named
2019-02-26 09:26:17 -08:00
cc2e30826b
Merge pull request #7344 from ad-m/patch-1
...
Add hyperone builder to CHANGELOG.md
2019-02-26 16:16:59 +01:00
4e55278839
cheggaaa.pb: try to not open tty at init to see if it causes #7299
2019-02-26 11:55:39 +01:00
b32449cdcc
Merge pull request #7336 from dkuntz2/make-private-ip-fixer-error-more-clearly
...
Make the amazon-private-ip fixer errors more visible
2019-02-26 09:47:31 +01:00
674ff489a9
Merge pull request #7343 from hashicorp/fix_6369
...
move snapshot deletion to cleanup; this allows people with tag-specif…
2019-02-25 17:50:14 -08:00
026e543b24
move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation
2019-02-25 17:01:19 -08:00
2ef6b9247d
Initial take on code review feedback from @azr.
...
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
134cf3a141
update gemfile to fix vulnerability in bootstrap-saas dependency
2019-02-25 12:58:35 -08:00
279fb7a632
gofix
2019-02-25 14:41:26 -06:00
419a8c3324
Add hyperone builder to CHANGELOG.md
2019-02-25 21:31:22 +01:00
b0589c9643
Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip
2019-02-25 14:20:14 -06:00
04de86d211
Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP
2019-02-25 14:19:13 -06:00
3b726e66c1
swap region copy and encryption steps
2019-02-25 11:03:03 -08:00
142a84ef43
amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour
...
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
2019-02-25 10:45:23 -08:00
1c3bc70b12
Merge pull request #7338 from chhaj5236/feature/update_aliyun_sdk
...
alicloud: update aliyun sdk to support eu-west-1 region
2019-02-25 09:32:02 -08:00
3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325
...
openstack WaitForImage: pass context for cancellation
2019-02-25 09:30:36 -08:00
05897c8653
Merge pull request #7294 from hyperonecom/hyperone
...
Add HyperOne builder
2019-02-25 08:30:04 -08:00
f7ba933809
Merge pull request #7332 from joellopes03/fix_7301
...
Use IMDS to get subscription for Azure MSI
2019-02-25 08:25:12 -08:00
b9411712eb
builder/openstack/step_create_image.go: pass context for cancellation
...
fix #7325
2019-02-25 15:03:11 +01:00
3cda840504
Merge pull request #7329 from lrxcy/fix_190220
...
add Endpoints Description
2019-02-25 09:02:32 +01:00
94a7a07c87
Merge branch 'master' into hyperone
2019-02-24 15:16:21 +01:00
4d2a5fb9a2
✨ Implement template marshalling logic
...
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 22:41:07 +00:00
afba444373
✨ Refactor rawTemplate to better align with real raw template structure
...
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 21:42:27 +00:00
0673bb2c57
Add cleanup for stepCreateImage
2019-02-23 14:57:19 +01:00
ad9349a6c5
add reviewers for builder to CODEOWNERS file
2019-02-23 12:13:41 +01:00
ab939989ea
fix some typos
2019-02-23 14:03:48 +08:00
610eecfc99
✨ Track sensitive variable keys to support JSON template writing
...
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 04:52:03 +00:00
d8793e3f85
✨ Store comments in the Template structure
...
Signed-off-by: Brendan Devenney <brendan@devenney.io>
2019-02-23 04:37:08 +00:00
f751e20b7e
update aliyun sdk to support eu-west-1 region
2019-02-23 11:43:35 +08:00
d3c65ee77d
builder/amazon/chroot: Fix building PV images with mount_partition
...
Right now, if we have a source image that's PV, and try to build an
image with mount_partition set to not 0, it does not get picked up.
This is because under PV we only had a filesystem, not partitions,
but you can convert a PV image to an HVM image during build time.
2019-02-22 18:21:01 -08:00
e4faa98b6f
cleanup: remove continue statement after a return statement, because it's unreachable
2019-02-22 10:38:27 -06:00
e251adb37e
Make the amazon-private-ip fixer errors more visible
...
At present, when using the packer fix command on a template that has
"ssh_private_ip" set to anything but a boolean value, the fixer will
fail, and appear to fail silently, simply returning a non-zero status
code without any message.
To determine what happened, users have to know to set PACKER_LOG=1 to
make the log message visible.
So far as I can tell, this is the only instance of log.Fatalf being
called, and based on the surrounding code the better solution would be
to return an error, which will then be visible to users of packer fix
without having to look in the logs.
2019-02-22 10:26:55 -06:00
4da79a8837
Merge pull request #7333 from pop/patch-2
...
Update vsphere+vsphere-template array pairing docs
2019-02-22 10:59:32 +01:00
c8a60c77d1
Add comments
2019-02-21 18:12:57 -08:00
440f1f5f3c
Merge pull request #7317 from hashicorp/pause_before_connecting
...
add a configurable pause before step_connect to work around bootstrap…
2019-02-21 11:59:47 -08:00
472b5ba710
Update vsphere+vsphere-template array pairing docs
...
The example and description of pairing `vsphere` and `vsphere-template` in a JSON array is accurate but ought to be more spelled out.
This introduces a change which makes that part of the example and docs more verbose, hopefully mitigating potential confusion.
2019-02-21 10:51:48 -08:00
Stephen Fox
Adrien Delorme
Chris Marget
Brendan Devenney
Adrien Delorme
Michael F
Megan Marsh
Don Kuntz
Adam Dobrawy
Sargun Dhillon
Miłosz Smółka
gregorybrzeski
lrxcy
bozhi.ch
Joel Lopes
Elijah Caine M. Voigt