11ba986abc
Merge pull request #4930 from hashicorp/fix4925
...
builder/amazon: don't try to delete extra volumes during clean up
2017-06-02 14:08:49 -07:00
1f4b532ed5
Merge pull request #4948 from hashicorp/kms_key_regions
...
Kms key regions
2017-06-01 13:30:31 -07:00
b8c2a5fd43
fix step initializer everywhere StepAMIRegionCopy is called
2017-06-01 09:28:17 -07:00
875745ab9b
one more test
2017-05-31 14:16:02 -07:00
1944f38985
update docs and clean up
2017-05-31 13:41:32 -07:00
5b35d199da
golang has different style than python
2017-05-31 12:27:45 -07:00
f9d7292566
builder/amazon regional KMS keys
2017-05-31 11:23:18 -07:00
cc309c0e5f
spelling fix
2017-05-26 01:03:11 -04:00
0e3469e913
spell fix
2017-05-25 18:49:45 -07:00
7174a7a3d5
New map: region_kms_key_ids, allowing custom encryption keys on a per-region basis. Also new tests.
2017-05-25 14:42:03 -07:00
77b4d47409
only delete snapshots which exist
2017-05-25 14:16:20 -07:00
c0b27dfa6f
don't try to delete extra volumes during clean up
2017-05-25 13:48:32 -07:00
1cf4754d80
correct ami_name error reporting
2017-05-25 13:02:36 -07:00
4abb541468
fix logging to clarify that encrypt_boot needs to be set, not encrypt, and fix typo
2017-05-24 16:39:36 -07:00
4137660b7a
fix ami name validation
2017-05-19 02:11:43 -07:00
ee5d13611f
update ssh client usage for new crypto/ssh version
2017-05-18 12:01:44 -07:00
45143bb6f4
add an option custom_endpoint_ec2 for amazon builder, add a condition if vpc_id is empty don't add the parameter to the aws call
2017-05-17 18:45:20 +02:00
0be5a28080
Fix issue 4693 - Derive vpc_id from subnet_id
...
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.
This fixes issue #4693 .
2017-05-15 13:46:05 -07:00
6f63881020
fixes a typo introduced in a previous change
2017-05-11 13:34:48 -07:00
a269bbc6fa
Fix issue 4875 - use retry logic when creating instance tags
2017-05-11 16:25:28 +01:00
80d6cd91fd
remove unneeded keypair var
2017-05-01 10:17:21 -07:00
602fd64c5d
builder/amazon: set flag to delete temporary keypair
2017-04-30 14:24:22 -07:00
da8c4004f0
builder/amazon: numbers are valid in ami name
2017-04-05 12:39:16 -07:00
3f6b5165f2
add affirmative test case for #4762
2017-04-04 22:08:09 -07:00
d9041bda0c
Improved the test for special character so that it doesn't get halted by less than 3 character check
2017-04-05 11:06:59 +10:00
7911cfa94b
Formatting as per make fmt
2017-04-05 11:02:23 +10:00
fdae6858c8
conforming to the standard for imports
2017-04-05 10:53:58 +10:00
df6337e8ab
Added AMIName validation (issue 4761)
2017-04-05 10:46:44 +10:00
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
e4aa2a34ca
builder/amazon-chroot: nullable copy_files
...
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
74c8c585f5
builder/amazon: report tag creation
2017-03-23 16:12:59 -07:00
bd76b7bb6f
builder/amazon: validate ssh key name/file
...
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
50d9546658
builder/amazon: set force_deregister to true on -force
2017-03-09 14:24:49 -08:00
2300b102b7
amazon: Step Region Copy crashing on device mapping
...
Closes #4635
2017-03-08 18:12:37 +01:00
9c027aa70b
Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
...
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
e856339309
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
...
As pointed out in the initial code review of #4351 , some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:
- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`
We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
1eec5bf058
builder/amazon-ebssurrogate: Exclude duplicate root volume
...
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
fd1b00a0d1
use aws helper method
2017-02-26 19:33:34 -08:00
61976dfd86
Merge pull request #4578 from life360/enable_ena
...
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
6a7c37beb6
builder/amazon-chroot: support encrypted boot volume
2017-02-26 17:48:13 -08:00
2cb9b32acf
don't attempt to delete non-existant key when using agent auth
2017-02-26 17:38:22 -08:00
f95514c120
fix ssh agent authentication
...
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
1cc3cdf7b5
Always set both SRIOV and ENA when Enhanced Networking is enabled
...
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).
Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
33a4c2e13b
Change EC2 WindowsPasswordTimeout to 20 minutes
...
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
635aeb765b
amazon/ebssurrogate: Add New Builder
...
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00
377f451a9e
it's InvalidGroup
2017-01-05 16:56:49 -08:00
e54605c120
Properly wait for security group to exist.
...
Adds check for `InvalidGroupID.NotFound` in addition to
`InvalidSecurityGroupID.NotFound`.
Uses aws's `waiter` for clarity.
2017-01-05 15:20:28 -08:00
aef6e0e93f
Merge pull request #4304 from dave2/gh-4277
...
Querying EC2 security groups should report unexpected errors
2017-01-04 10:53:28 -08:00
e31d75eca8
Quick fix for issue #4340
2016-12-29 09:16:52 -07:00
4b1e014be8
builder/amazon: Crashes when multiple EBS vols are used
...
If you use a new EBS vol (which hasn't any snapshot) Packer crashes when
creating the AMI.
Closes #4303
2016-12-21 15:37:08 +01:00
ae5730c5a5
Querying EC2 security groups should report unexpected errors
...
As noted in #4277 , we don't report any errors from the loop waiting for
a security group to exist. Instead, we should accept 'errors' which result
from the group not yet existing, and report errors which are actual issues
the user needs to resolve (eg, IAM permissions are incorrect).
Closes #4277
2016-12-21 11:45:12 +13:00
e4f6eaae9b
Merge pull request #4231 from artburkart/force-delete-snapshot-patch
...
Fixes acceptance test for PR #4223
2016-12-17 11:43:26 -08:00
d3c2239b9e
builder/amazon: Change shutdown_behaviour to shutdown_behavior
2016-12-14 21:59:16 +01:00
c24b4423b2
builder/amazon: Added new region London - eu-west-2
2016-12-14 10:55:19 +01:00
ac98aad1df
Fix log statement
2016-12-13 12:53:03 +01:00
f1fb942219
add ca-central-1 to list of known aws regions.
...
resolves #4273
2016-12-09 11:21:44 -08:00
5c4d331a34
Added missing LaunchPermission
2016-12-06 09:59:09 +01:00
4ce3b8712a
Replace unencrypted EBS snapshots with encrypted
...
To ensure that groups and users attributes are added to the encrypted
snapshots.
2016-12-06 03:31:09 +01:00
c3a352955e
amazon: Added snapshot_users and snapshot_groups
2016-12-04 16:03:01 +01:00
46f217f255
amazon - Snapshot permissions correctly applied
...
Fixes #3344
2016-12-04 16:03:01 +01:00
d7a7d8c852
It's not possible to share encrypted AMI's
2016-12-04 15:52:23 +01:00
8b13b75097
Updated documentation and error messages
...
The docs for kms_key_id needed to be next to encrypt_boot.
Shortened some of the kms_key_id error messages.
2016-12-03 07:49:54 +11:00
7ea17e1630
Allow custom encrypted AMIs to be shared
...
When using a custom KMS key to encrypt the boot volume of an AMI, packer should allow it to be shared with other users.
2016-12-03 07:49:54 +11:00
3eed6fd508
Added KMS CMK support to EBS builder
...
Added the 'kms_key_id' parameter. This supports supplying a customer master key (CMK) when encrypting the EBS volume.
The parameter is optional and only takes effect when 'encrypted' is true. When 'encrypted' is true but 'kms_key_id' is missing the 'aws/ebs' key will be used.
2016-12-03 07:49:34 +11:00
8d2ceea5f1
builder/amazon: crash on tagging snapshot when snapshot_tags is unset
...
Closes #4238
2016-12-01 20:43:15 +01:00
bcc7f455b3
amazon: Fix source_ami_filter ignores owners
2016-12-01 14:29:31 +01:00
576f6f1b39
Fixes acceptance test
...
The original acceptance test required a manual check. This one does
not.
2016-11-30 22:58:19 -05:00
832de2104b
Revert "Merge pull request #4230 from mitchellh/revert-4223-closes_3320"
...
This reverts commit bda89b0c42f9f9d82419
2016-11-30 13:28:34 -08:00
f5c3c25d2b
Revert "Adds `force_delete_snapshot` flag"
2016-11-30 13:10:22 -08:00
f9f9d82419
Merge pull request #4223 from artburkart/closes_3320
...
Adds `force_delete_snapshot` flag
2016-11-30 12:53:34 -08:00
5b59f56cdb
Adds `force_delete_snapshot` flag
...
This PR adds the ability for Packer to clean up snapshots in addition to
deregistering AMIs at build time.
To test this, I used the following `test.json` file:
```json
{
"builders": [
{
"type": "amazon-ebs",
"region": "us-east-1",
"source_ami": "ami-fce3c696",
"ami_name": "packer-test",
"instance_type": "m3.medium",
"ssh_username": "ubuntu",
"vpc_id": "some-vpc-id",
"subnet_id": "some-subnet-routed-through-igw",
"security_group_id": "some-security-group-with-port-22-access",
"force_delete_snapshot": true
}
],
"provisioners": [
{
"type": "shell-local",
"command": "echo 'hello'"
}
]
}
```
I appreciate any constructive feedbakc that can be given. Cheers!
2016-11-29 23:39:36 -05:00
99ee610afa
builder/amazon: Fix SSH Agent
...
Closes #4220
2016-11-29 22:33:53 +01:00
aedf4ca465
Merge pull request #4141 from mitchellh/ebsvoluemartifact
...
add ebsvolume artifact
2016-11-28 15:50:03 -08:00
50267572a4
add ebsvolume artifact
2016-11-28 15:26:09 -08:00
a09f20f996
Merge pull request #4015 from artburkart:closes_3908
...
Closes #3908 : Adds snapshot tag overrides
2016-11-26 17:54:00 +01:00
0c7e73b1cf
Implements Snapshot tagging
...
While implementing my acceptance test, I stumbled upon a comment stating
that snapshot deletion should also be implemented, so I snuck that in. I
can't help but wonder if there is some generic logic that is implemented
a few times throughout the packer code base that could maybe better serve
us if it were abstracted to the common package.
2016-11-26 17:48:26 +01:00
17eda06d61
Fixed formatting
2016-11-24 21:12:20 +01:00
Matthew Hooker
Megan Marsh
Jason Ramey
Rémi Jouannet
Paul Thrasher
Ben Fagin
luis-silva
Craig Barr
Rickard von Essen
James Nugent
Aaron Stone
Richard Owen
Roman Zhuzha
Richard Moore
Travis Harrington
Zanetti, David
Alexander Krasnukhin
Ari Aviran
poida
Arthur Burkart