Ali Rizvi-Santiago
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
Megan Marsh
65124985d1
don't set DetectZeroes if it's off, because some versions of QEMU don't support this option
2018-12-03 15:52:13 -08:00
Ali Rizvi-Santiago
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81
Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a
Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX.
2018-12-03 17:47:45 -06:00
Christopher Boumenot
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
Andrew Starr-Bochicchio
c0c5c6afac
Add DigitalOcean post-processor.
2018-11-29 21:00:57 -05:00
Megan Marsh
c03894c05d
fix bad interpolation exemption for volume_size
2018-11-29 16:39:43 -08:00
Adrien Delorme
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
...
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
Megan Marsh
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
...
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
PORTE Loïc
bf97557abf
Backport VNC log from vmware to qemu
2018-11-28 19:13:29 +01:00
bozhi.ch
a485bcfdf3
delete copied image and snapshots if corresponding options are specified
2018-11-28 21:34:21 +08:00
Megan Marsh
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e
fix defaulting/lack thereof for cpu count and memory in vmware template
2018-11-27 15:43:48 -08:00
Nathan A. Ferch
fccd7d0692
add snapshot_labels to hcloud builder
2018-11-27 14:41:32 -05:00
Megan Marsh
6728244480
simplify for loop logic
2018-11-27 09:33:29 -08:00
Andrew Pennebaker
c05ac784d3
fix tests
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5ada3376b8
fix test
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
2c989157e4
gofmt
2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5b6cbeed1d
expose `--iso` option down in `VBoxManage export --iso` up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled.
2018-11-27 09:31:01 -08:00
Megan Marsh
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
...
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
bozhi.ch
7704ff2f24
apply tags to relevant snapshots
2018-11-26 16:58:32 +08:00
dedene
1aaa998b02
Revert back to reset server
2018-11-26 09:49:45 +01:00
dedene
6589bfaaab
Small code improvements and fixes
2018-11-26 09:10:17 +01:00
zhuzhih2017
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks
...
alicloud: support creating image without data disks
2018-11-26 13:13:51 +08:00
Kevin Bulebush
76d1bf567e
Replaced compute/v2/images with imageservice/v2/images.
...
Removed usage of a deprecated API.
Standardized clientService naming.
2018-11-25 14:30:31 -05:00
bozhi.ch
3c1395eb04
support wait_snapshot_ready_timeout for much bigger disk
2018-11-25 16:05:26 +08:00
dedene
0f3bfbf8e6
Fix timing issues by updating to hcloud-go v1.11.0
2018-11-24 17:56:09 +01:00
Kevin Bulebush
802e7d467d
openstack: Add support for tagging new images.
2018-11-23 20:22:10 -05:00
dedene
064e6c7e08
Add support for builds using rescue mode
2018-11-23 20:35:32 +01:00
Adrien Delorme
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory
...
Add configuration options to vmware builder to specify cpu count and memory size
2018-11-23 10:53:46 +01:00
Adrien Delorme
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory
...
Add configuration options to parallels builder to specify cpu count and memory size
2018-11-23 10:50:01 +01:00
Adrien Delorme
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory
...
Add configuration options to virtualbox builder to specify cpu count and memory size
2018-11-23 10:27:14 +01:00
Ali Rizvi-Santiago
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
Ali Rizvi-Santiago
0f019407d6
Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions.
2018-11-22 20:48:00 -06:00
Ali Rizvi-Santiago
784535a4e3
Updated things related to the parallels-iso builder to correspond to @azr's suggestions.
2018-11-22 20:19:00 -06:00
Ali Rizvi-Santiago
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
Megan Marsh
da6e350949
fix tests
2018-11-20 15:20:01 -08:00
Megan Marsh
fbb3d526e3
move region validation to run so that we don't break validation when we don't have aws creds set
2018-11-20 15:01:28 -08:00
Nathan A. Ferch
849a6ed353
add ssh_keys config to hcloud builder
2018-11-20 13:58:17 -05:00
bozhi.ch
3c2c13a021
support creating image without data disks
2018-11-19 15:25:12 +08:00
Ali Rizvi-Santiago
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
Ali Rizvi-Santiago
eca26f43f2
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:34:22 -06:00
Ali Rizvi-Santiago
24140131c7
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:32:11 -06:00
Ali Rizvi-Santiago
51948daf92
Added options for the cpu count, memory, audio, and usb to the virtualbox builder.
2018-11-17 06:19:54 -06:00
Ali Rizvi-Santiago
71d15d05c0
Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder.
2018-11-17 06:13:59 -06:00
Ali Rizvi-Santiago
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
Rickard von Essen
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
Ali Rizvi-Santiago
4e73c85e22
Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized.
2018-11-16 22:20:00 -06:00
Christopher Boumenot
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
...
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
Amrita Dutta
b8def0b3fb
Added test to check for missing OS disk snapshot name and data disk snapshot prefix
2018-11-15 22:01:16 +00:00
Amrita Dutta
67342750a3
Addressed PR comments
2018-11-14 01:47:48 +00:00
Megan Marsh
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
Megan Marsh
3b413d2e5e
fix rebase conflicts
2018-11-12 13:24:03 -08:00
Megan Marsh
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
Megan Marsh
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
Megan Marsh
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
...
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
Megan Marsh
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
Adrien Delorme
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
Adrien Delorme
78ac943679
Merge pull request #6987 from hashicorp/6624
...
6624
2018-11-12 15:31:36 +01:00
Adrien Delorme
175b6a7971
add test for MSI configuration
2018-11-12 12:04:57 +01:00
Adrien Delorme
1958ef6e81
remove unecessary check
2018-11-12 11:32:49 +01:00
Adrien Delorme
08e8b1850e
remove unnecessary parenthesis
2018-11-12 10:49:39 +01:00
Amrita Dutta
2d6b18e63e
Fix tests after bug fix
2018-11-10 00:05:25 +00:00
Megan Marsh
2e2b2cea82
add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data
2018-11-09 15:46:52 -08:00
Amrita Dutta
213fbbae00
Updated go version and reformatted
2018-11-09 22:41:48 +00:00
Megan Marsh
3cf4c63a87
Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary.
2018-11-09 14:00:07 -08:00
Megan Marsh
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
Amrita Dutta
a297d73b98
correcting wrong log message
2018-11-09 19:29:57 +00:00
Amrita Dutta
06525dd885
adding logs in the steps
2018-11-09 19:28:37 +00:00
Megan Marsh
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
Megan Marsh
be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id""
2018-11-09 08:47:22 -08:00
Adrien Delorme
1ab0173e69
azure builder: allow to auth with managed identities ( MSI )
2018-11-09 17:39:03 +01:00
Amrita Dutta
8881bc2d64
Fix bug in snapshot client creation
2018-11-09 03:30:57 +00:00
Megan Marsh
c1c929164f
Revert "Rename attribute api_access_key to organization_id"
2018-11-08 16:34:23 -08:00
Megan Marsh
210d62de2c
Merge pull request #6925 from sieben/organization_renaming
...
Rename attribute api_access_key to organization_id
2018-11-08 16:33:15 -08:00
Rémy Léone
e54d2e3591
Rename attribute api_access_key to organization
2018-11-08 13:45:32 +01:00
Mikhail Ushanov
536252683e
builders: reuse private key file reading function
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
Amrita Dutta
8d8c86366b
Config tests + typo fix
2018-11-07 22:23:22 +00:00
Amrita Dutta
1fa9f1ef11
formatting changes in stateBag.go
2018-11-07 18:11:48 +00:00
Amrita Dutta
8c326dbab7
Formatting changes
2018-11-07 18:08:15 +00:00
Amrita Dutta
b2d1675d39
Added tests
2018-11-07 03:23:17 +00:00
Amrita Dutta
369b2dae5e
Inlining suggested functions
2018-11-06 21:50:53 +00:00
Megan Marsh
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
Amrita Dutta
593363c5be
fix typo in last commit
2018-11-06 19:23:15 +00:00
Amrita Dutta
1266d5146d
addressed PR comments + add file for data disk snapshots
2018-11-06 19:17:03 +00:00
Megan Marsh
8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591
...
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591 )
2018-11-06 09:59:26 -08:00
Megan Marsh
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
Amrita Dutta
d12d23d34b
OS disk snapshot
2018-11-05 23:48:22 +00:00
Megan Marsh
79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
...
aws: better error handling of region/credential guessing from metadata
2018-11-05 11:24:09 -08:00
Megan Marsh
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
Megan Marsh
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
Megan Marsh
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
Megan Marsh
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
Megan Marsh
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
Megan Marsh
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
Adrien Delorme
3f288fc6ca
aws client: config.WithMaxRetries(8)
2018-11-01 15:09:07 +01:00
Megan Marsh
daf1f39930
Merge pull request #6918 from hashicorp/oracle_classic_volumes
...
Parameterized volume size support for Oracle classic builder
2018-10-31 16:03:40 -07:00
Matthew Hooker
3ff038d4d1
remove todo
2018-10-31 12:00:33 -07:00
bozhi.ch
c3a60ad0ce
add options for system disk properties
2018-10-30 21:09:59 +08:00
Matthew Hooker
42cd3e4bf7
Warn if not a pv build but builder image entry is set. cleanup
2018-10-29 15:23:58 -07:00
chbell43
653fa2298f
use guard clauses
...
* just return early if no FloatingIP is required
* move the instanceIP declaration up and store in the state bag to avoid
errors in ssh.go
2018-10-29 18:36:08 +00:00
Mikhail Ushanov
4608b5d39d
amazon: add option for skipping TLS verification
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-29 21:35:29 +03:00
chbell43
ea78cb62fd
Make the config.networkV2Client conditional
...
In cases where the OpenStack environment does not contain a v2 network, the
builder will error out. We only need the networkV2Client when using floating
IPs. This will allow packer to work in environments where a v2 network is not
available.
2018-10-29 18:32:09 +00:00
Matthew Hooker
eb976894fc
cleanup
2018-10-27 02:04:36 -07:00
Matthew Hooker
c697c9d3de
cleanup
2018-10-26 21:59:26 -07:00
Matthew Hooker
f322397413
add config tests
2018-10-26 21:56:39 -07:00
Matthew Hooker
6d6d262308
some final fixes and documentation work
2018-10-26 21:56:00 -07:00
Matthew Hooker
4eba1ee724
remove unused config key
2018-10-26 20:02:51 -07:00
Matthew Hooker
03932f1157
Clean up volumes
2018-10-26 20:02:13 -07:00
Matthew Hooker
e2a0cbf7df
move upload script to const
2018-10-26 16:59:23 -07:00
Matthew Hooker
7331d6fc7f
some final clean up
2018-10-26 16:59:23 -07:00
Matthew Hooker
ab4f205bf6
correctly building linux/windows now
2018-10-26 16:59:23 -07:00
Matthew Hooker
09de194d8e
trying to wrap the base communicator config but it needs to be prepared
2018-10-26 16:59:22 -07:00
Matthew Hooker
ab5e964ca6
Connecting to master instance but not builder
2018-10-26 16:59:22 -07:00
Matthew Hooker
ade396e140
don't echo image creation commands
2018-10-26 16:59:22 -07:00
Matthew Hooker
3e966ae38d
make fmt
2018-10-26 16:59:22 -07:00
Matthew Hooker
86f6cf478a
cleanup
2018-10-26 16:59:22 -07:00
Matthew Hooker
6f729d0265
Adding some missing configuration
2018-10-26 16:59:22 -07:00
Matthew Hooker
c42be62d90
fix identifier changes from oracle sdk
2018-10-26 16:59:22 -07:00
Matthew Hooker
bbb0d450f1
todo
2018-10-26 16:59:22 -07:00
Matthew Hooker
be91c99d29
warn about dangling segments.
...
The client offers no way to bulk delete keys, so for now let's just warn users.
The issue is tracked upstream here: https://github.com/hashicorp/go-oracle-terraform/issues/172
2018-10-26 16:59:22 -07:00
Matthew Hooker
ce30e1053e
wip
2018-10-26 16:59:22 -07:00
Matthew Hooker
9f310045fc
split image upload/creation. clean up
2018-10-26 16:59:22 -07:00
Matthew Hooker
420d0ebe3e
fix artifact generation
2018-10-26 16:59:21 -07:00
Matthew Hooker
84bb5d2f6f
create image list
2018-10-26 16:59:21 -07:00
Matthew Hooker
fa54a64d28
WIP
2018-10-26 16:59:21 -07:00
Matthew Hooker
b84c7df9da
Segments going into per-run subfolder
2018-10-26 16:59:21 -07:00
Matthew Hooker
b5c6beb8a3
don't delete segments. registering works now.
2018-10-26 16:59:21 -07:00
Matthew Hooker
705fa976a8
more debugging
2018-10-26 16:59:21 -07:00
Matthew Hooker
2536790e0a
todo
2018-10-26 16:59:21 -07:00
Matthew Hooker
7a35e2408f
fix pty, some todo and refactor of bash scri[t
2018-10-26 16:59:21 -07:00
Matthew Hooker
fc301601e1
actually delete temp container
2018-10-26 16:59:21 -07:00
Matthew Hooker
cd77d00fd8
delete temporary image container
2018-10-26 16:59:21 -07:00
Matthew Hooker
21f786d686
todo and some clean up. correct values for machine image
2018-10-26 16:59:21 -07:00
Matthew Hooker
b222d36669
use 2x volume size
2018-10-26 16:59:21 -07:00
Matthew Hooker
7c577abbcb
WIP: register machine image.
...
remove passwords
2018-10-26 16:59:21 -07:00
Matthew Hooker
8207ba4fa4
Use jq to create manifest. Upload to compute_images
2018-10-26 16:59:20 -07:00
Matthew Hooker
96e62236ec
upload volume WIP
...
check upload for error
increase builder volume size to account for chunking
2018-10-26 16:59:20 -07:00
Matthew Hooker
8598e2d0a3
WIP
2018-10-26 16:59:20 -07:00
Matthew Hooker
bf7c4a7ad6
wip
2018-10-26 16:59:20 -07:00
Matthew Hooker
445c3fb5bb
cleanup temp keys
2018-10-26 16:59:20 -07:00
Matthew Hooker
098764d8ac
WIP
2018-10-26 16:59:20 -07:00
Matthew Hooker
2db0a03142
image upload WIP
2018-10-26 16:59:20 -07:00
Matthew Hooker
265ee0b0b8
add whitespace
2018-10-26 16:59:20 -07:00
Matthew Hooker
7c26ffef9c
builder instance now runs and is connected to
2018-10-26 16:59:20 -07:00
Matthew Hooker
b3ffa975c3
Revert "add boot volume to builder instance"
...
This reverts commit cbce7b42079d2087bc622fd8c6f65d1339b735d1.
2018-10-26 16:59:20 -07:00
Matthew Hooker
2febfa2c7d
attach volume after instance booted
2018-10-26 16:59:20 -07:00
Matthew Hooker
b68f214ca4
add boot volume to builder instance
2018-10-26 16:59:20 -07:00
Matthew Hooker
ca3bffcb0d
bugfix and some debug logging
2018-10-26 16:59:19 -07:00
Matthew Hooker
00ff187d77
master instance working
2018-10-26 16:59:19 -07:00
Matthew Hooker
e271e88b49
oracle-classic variable volume size WIP
2018-10-26 16:59:19 -07:00
Adrien Delorme
f4fbf45349
remove duplicate region check error
2018-10-26 17:44:56 +02:00
Adrien Delorme
16aa21dffe
aws: better error handling of region guessing from metadata
...
* this will fix #6919
2018-10-26 12:24:10 +02:00
Megan Marsh
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
Megan Marsh
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
Alexander Laamanen
3193f50f17
Support export with the vmx builder.
2018-10-25 13:02:37 -07:00
Alexander Laamanen
a68a639a1a
Move step_export to common.
2018-10-25 12:55:10 -07:00
Alexander Laamanen
63054fb808
Fix the test.
2018-10-25 12:45:44 -07:00
Stuart Miller
da5f322484
Add quotes around all filenames to prevent issues with spaces
2018-10-25 12:45:44 -07:00
Alexander Laamanen
f42f5a8ad3
Remove some extra logging.
2018-10-25 12:44:29 -07:00
Alexander Laamanen
e7e6a80587
No need to make upload public.
2018-10-25 12:39:51 -07:00
Alexander Laamanen
c294e65c36
A separate driver file is not really needed anymore
2018-10-25 12:39:51 -07:00
Alexander Laamanen
2ed6c3ef5e
Set output dir always according to the config.
2018-10-25 12:37:47 -07:00
Alexander Laamanen
c940f7e754
Conditional reload.
2018-10-25 12:37:47 -07:00
Alexander Laamanen
17845beadc
Fix the CommHost tests
2018-10-25 12:37:47 -07:00
Alexander Laamanen
5e74bcfb88
Fix tests, move remote_ default values to driver_config.
2018-10-25 12:30:57 -07:00
Alexander Laamanen
4d9cb19012
Refactor artifacts and output_dir implementations.
2018-10-25 12:21:24 -07:00
Alexander Laamanen
2d00dc6756
Add VMName to the vmx mods.
2018-10-25 11:17:09 -07:00
Alexander Laamanen
7b5943160b
Re-enable the CommHost() call. Use common's driver factory.
2018-10-25 11:17:09 -07:00
Alexander Laamanen
ba22090bc9
Move step_register and step_uload_vmx from iso to common.
2018-10-25 11:07:02 -07:00
Alexander Laamanen
b5298464c5
Move the remote_driver from iso to common.
2018-10-25 11:01:22 -07:00
Alexander Laamanen
91c7089455
Implement the first version of the remote Clone().
2018-10-25 10:37:45 -07:00
Alexander Laamanen
46cfb5a30c
Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver()
2018-10-25 10:33:37 -07:00
Megan Marsh
c7b938c9d4
Merge pull request #6904 from hashicorp/fix_6890
...
Fix 6890
2018-10-24 10:43:34 -07:00
Adrien Delorme
8908a72fa9
builder/hyperv/vmcx: allow to set generation from buildfile
...
this commit fixes #6908
2018-10-24 12:20:52 +02:00
Adrien Delorme
ed793a8fb8
make ValidateRegion a member of *AccessConfig and make it variadic
2018-10-24 11:26:53 +02:00
Megan Marsh
fe044d8ff7
fix tests
2018-10-23 13:31:56 -07:00
Megan Marsh
340009009d
Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
...
This reverts commit 0cd3f36d50
.
2018-10-23 09:58:27 -07:00
Megan Marsh
0cd3f36d50
Revert "Merge pull request #6892 from hashicorp/fix_6890"
...
This reverts commit 1c4062c316
, reversing
changes made to 9bc41a23b9
.
2018-10-23 09:34:05 -07:00
Megan Marsh
1c4062c316
Merge pull request #6892 from hashicorp/fix_6890
...
fix template-set credentials
2018-10-22 13:55:48 -07:00
Megan Marsh
0924a316b7
fix template-set credentials
...
update tests with mocked session
2018-10-22 13:53:40 -07:00
Megan Marsh
cdd99564fd
Merge pull request #6891 from hashicorp/fix_6794
...
Fix 6794
2018-10-22 11:10:05 -07:00
Megan Marsh
091efae8bb
Merge branch 'master' into misc
2018-10-22 11:07:30 -07:00
Megan Marsh
fd8a85042d
use strconv.Quote instead of fmt.Sprint
2018-10-22 10:59:47 -07:00
Megan Marsh
18c5e8deb8
fix
2018-10-19 13:46:55 -07:00
Megan Marsh
1e4133cbf9
quote upload path
2018-10-19 13:43:13 -07:00
Megan Marsh
3f591d78f3
quote vmx path in register function
2018-10-19 13:42:40 -07:00
Megan Marsh
8cba32d526
escape all the d.sh calls that contain paths
2018-10-19 13:42:40 -07:00
Megan Marsh
5b9adc0c48
single quotes
2018-10-19 13:42:40 -07:00
Megan Marsh
9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
...
Add support to explicitly disable ENA support
2018-10-19 10:54:38 -07:00
Megan Marsh
9fe27c225b
Merge pull request #6703 from shield-9/wait_volume
...
OpenStack: wait for volume availability when cleaning up
2018-10-19 10:25:51 -07:00
Matt Dainty
feb8067c7d
Convert `ena_support` to a pointer
...
This means it now has three states, `true`, `false`, & `nil`. The
default state is now `nil` which does nothing instead of `false` which
now will explicitly disable ENA support instead of just not enabling it.
2018-10-19 12:40:43 +01:00
Josh Soref
b68168807a
Miscellaneous doc improvements
...
backticks, spaces, commas
In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.
one off indent filters section
singular
backticks...
word wrap long lines...
spelling: macOS
contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
Megan Marsh
57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
...
builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter
2018-10-18 14:34:02 -07:00
Megan Marsh
3175dcdf81
Merge pull request #6807 from dev-rowbot/qemu-net-device-6804
...
Fix for #6804 - KVM/QEMU Network "has no peer"
2018-10-18 14:09:22 -07:00
Megan Marsh
c5b6eff691
Merge pull request #6871 from LKaemmerling/master
...
Add hcloud builder
2018-10-18 11:13:16 -07:00
Lukas Kämmerling
e4a670d2a2
Remove Debug Message
2018-10-18 10:29:06 +02:00
Adrien Delorme
29d041ea8a
Merge pull request #6858 from hashicorp/tests_race_detector
...
test with race detection enabled + fix race on progressbar
2018-10-18 09:48:03 +02:00
Lukas Kämmerling
bad1b95a49
Unify steps, fix some typos
2018-10-18 08:03:04 +02:00
Megan Marsh
fd89d4f020
Merge pull request #6827 from skish/qemuDiskZero
...
builder/qemu add drive detect-zeroes option
2018-10-17 19:12:38 -07:00
Megan Marsh
2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
...
aws: wait for temporary security group before authorize rules
2018-10-17 14:08:49 -07:00
Megan Marsh
e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
...
Fix 6862
2018-10-17 13:07:29 -07:00
Mikhail Ushanov
00c96fc400
aws: use IpPermissions for authorizing temporary security group
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:25 +03:00
Mikhail Ushanov
b316be51cd
aws: wait for temporary security group before authorizing
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:24 +03:00
Megan Marsh
b0cfecf314
remove unnecessary valid flag
2018-10-17 11:03:31 -07:00
Matt Dainty
9e0fae9db3
Add support to explicitly disable ENA support
...
If `ena_support` is set to false then it previously didn't do anything
whereas now it will explicitly disable ENA support.
Fixes #6852
2018-10-17 14:58:07 +01:00
Adrien Delorme
410bee0666
make TestStepShutdown_shutdownDelay less strict on schedule
2018-10-17 12:49:38 +02:00
Lukas Kämmerling
270110767c
Add hcloud Builder
2018-10-17 12:15:47 +02:00
Adrien Delorme
af3b818de0
TestBuilderPrepare_ISOChecksumType: set config["switch_name"] = "switch" to avoid using builder.detectSwitchName which can lock down in CI mode
2018-10-17 12:09:24 +02:00
Adrien Delorme
0237956e66
builder/virtualbox/common/step_shutdown_test.go: compare durations instead of floats & ouput duration
2018-10-17 11:19:57 +02:00
Adrien Delorme
1ca21499c6
Revert "make builder/hyperv/vmcx/builder_test.go invisible to windows"
...
This reverts commit e692dee2d8
.
2018-10-17 10:21:53 +02:00
Adrien Delorme
b80a0fed42
make builder/parallels/common/output_config_test.go invisible to windows
2018-10-17 09:59:13 +02:00
Adrien Delorme
e692dee2d8
make builder/hyperv/vmcx/builder_test.go invisible to windows
2018-10-17 09:57:42 +02:00
Megan Marsh
d4767845f0
fix tests
2018-10-16 15:01:13 -07:00
Megan Marsh
7c3f0aa3b2
make sure region validation catches authentication errors
2018-10-16 14:17:30 -07:00
Mikhail Ushanov
ee133482b4
aws: add validation for device_name parameter
...
cause it's required in block-device-mapping.
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
Adrien Delorme
8a6c55dd69
make builder/hyperv/iso/builder_test.go invisible to windows
2018-10-16 19:09:35 +02:00
Matthew Aynalem
28eff7303e
builder/googlecompute: validate startup_script_file exists
2018-10-15 16:09:33 -07:00
Megan Marsh
cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
...
Fix 6774
2018-10-10 13:25:58 -07:00
Megan Marsh
f5af2afc06
Merge pull request #6818 from hashicorp/fix_6732
...
default wait time for amazon import to one hour.
2018-10-10 11:27:34 -07:00
Megan Marsh
f331327f24
Merge pull request #6823 from hashicorp/fix_6794
...
fix datastore path that contains spaces
2018-10-10 10:06:15 -07:00
Megan Marsh
53bce398bb
add Managed Image test to azure artifact
2018-10-10 10:04:19 -07:00
Megan Marsh
5dc4ff95da
fix azure artifact so it works with managed images as well as VHDs
2018-10-10 10:04:11 -07:00
Christopher Boumenot
520dea23fd
Merge pull request #6798 from mbearup/mb-sharedgallery
...
Consume images from Azure Shared Image Gallery
2018-10-10 09:53:18 -07:00
mbearup
de8d30d77c
Update tests for Azure Shared Image Gallery
2018-10-10 09:20:34 -07:00
Konstantin Shloma
fe341e2bd0
fix go source formatting
...
add description to documentation page
2018-10-10 16:16:23 +03:00
Konstantin Shloma
1155347b55
add qemu disk detect-zeroes= option
2018-10-10 14:38:59 +03:00
mbearup
c7180413b0
Fix tests for Shared Image Gallery
2018-10-09 16:38:50 -07:00
Megan Marsh
e5e75df033
fix datastore path that contains spaces
2018-10-09 16:36:55 -07:00
mbearup
a3a2a9e970
Fix issue with composite literal in test
2018-10-09 15:35:09 -07:00
mbearup
335feaf89c
Convert shared_image_gallery options to a struct
...
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
Megan Marsh
895e7fe111
Merge pull request #6812 from hashicorp/remove_unused_processPrivateKeyFile
...
removed unused processPrivateKeyFile func & tests
2018-10-09 13:14:11 -07:00
Megan Marsh
02bfac118f
default wait time for amazon import to one hour.
2018-10-09 13:08:42 -07:00
Megan Marsh
f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
...
abort if image import fails
2018-10-09 12:56:28 -07:00
Adrien Delorme
b2e2d3b008
removed unused processPrivateKeyFile func & tests
2018-10-09 11:56:43 +02:00
Rowan Potgieter
65db6be6b9
Fix for #6804
...
The user QEMU args may overwrite the default -device.
This results in no network
2018-10-06 14:40:43 +02:00
mbearup
5373b8586d
Update tests for Azure Shared Image Gallery
2018-10-05 16:04:07 -07:00
mbearup
b6bb5d4b4d
Fix format/spacing for config.go
2018-10-05 10:52:02 -07:00
mbearup
c1e0146d33
Dynamically set apiVersion for Shared Image Gallery scenario.
2018-10-03 16:33:28 -07:00
mbearup
d21b13cb85
Modify variable names for Shared Image Gallery.
...
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
Adrien Delorme
f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
...
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
Adrien Delorme
146db5667a
fix intermitent TestProcessPrivateKeyFile_encrypted failure
...
Because of deficiencies in the encrypted-PEM format, it's not always possible to detect an incorrect
password. In these cases no error will be returned but the decrypted DER bytes will be random noise.
this closes #3337
2018-10-01 10:29:30 +02:00
mbearup
55be0da5da
Initial changes to support Shared Image Gallery
2018-09-30 13:56:44 -07:00
Adrien Delorme
b7b1720a91
Merge pull request #6772 from fflorens/scaleway-add-boottype
...
scaleway: add boottype parameter in config
2018-09-27 16:51:01 +02:00
Florian Florensa
9ea5104b74
scaleway: add boottype parameter in config
2018-09-27 16:37:07 +02:00
Adrien Delorme
37c6f08abe
Revert "Fix bugs"
...
This reverts commit 02139dcb69
that constitutes pr #6701
2018-09-27 16:27:34 +02:00
Adrien Delorme
016b0985a6
builder/openstack: use config as a pointer so values could be set
...
this commit will close #6712
2018-09-27 16:27:34 +02:00
Adrien Delorme
b328d3569d
builer/triton: pass config as a pointer so values could be set
2018-09-27 16:27:34 +02:00
Adrien Delorme
22d3e9b5c4
builder/amazon/ebs: pass config as a pointer so values could be populated by a run
2018-09-27 16:27:34 +02:00
mvaude
7f78eef08d
scaleway: fix builder problems with ssh keys
...
The builder is currently failing with the last packer version.
This commit is fixing:
- the ssh keys and configuration management (the config is passed through a pointer and the ssh keys through the config instead of the runner states)
- the key size for generated ssh key
- the public key added as a tag to the instance<Paste>
fix #6757
2018-09-27 15:40:18 +02:00
Matthew Hooker
9181570bc3
remove stray struct dumps in logs
2018-09-27 00:14:05 -07:00
zhuzhih2017
676b28ecc5
Merge pull request #6764 from chhaj5236/feature/support_disable_stop_instance
...
support disable_stop_instance option for some specific scenarios
2018-09-27 14:52:07 +08:00
zhuzhih2017
f59cde03c4
Merge pull request #6763 from chhaj5236/fix/invalid_type_convert
...
fix type error in step_create_tags
2018-09-27 14:49:52 +08:00
bozhi.ch
bb19cdeb55
support disable_stop_instance option for some specific scenarios
2018-09-25 22:02:05 +08:00
bozhi.ch
1f3a517a19
fix type error in step_create_tags
2018-09-25 20:20:10 +08:00
Rickard von Essen
838d5021f5
openstack: use source_image_name to find UUID
2018-09-21 10:35:15 +02:00
Daisuke Takahashi
3b8aba2d24
OpenStack: wait for volume availability when cleaning up
2018-09-21 10:13:45 +09:00
Megan Marsh
d616f0ba71
abort if image import fails
2018-09-20 13:18:59 -07:00
Daisuke Takahashi
c848f59a55
Check condition for image_disk_format option
2018-09-20 11:02:30 +09:00
Daisuke Takahashi
b7bd3d4b34
OpenStack: Change option name to `image_disk_format`
2018-09-20 10:44:28 +09:00
Daisuke Takahashi
904dd1df63
Add disk_format option for OpenStack builder
2018-09-20 10:44:28 +09:00
Megan Marsh
b0774d155a
Merge pull request #6512 from sharmaanshul2102/5786-use-describe-regions-for-validation-aws
...
Use DescribeRegions for aws region validation
2018-09-19 10:37:42 -07:00
Megan Marsh
79093da6ad
skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock
2018-09-19 10:30:08 -07:00
Adrien Delorme
9ba959598b
Merge pull request #6729 from hashicorp/fix_ssh_digitalocean
...
builder/digitalocean: pass config as a pointer so that ssh configuration is correctly set
2018-09-19 18:26:36 +02:00
zhuzhih2017
9e3e2e83ae
Merge pull request #6720 from chhaj5236/fix/attach_keypair
...
fix attaching keypair error due to missing keypair name
2018-09-19 14:14:55 +08:00
Megan Marsh
93f1155a14
remove test-related special casing
2018-09-18 08:08:36 -07:00
bozhi.ch
3c312eb2a0
change b.config to pointer
2018-09-18 21:40:57 +08:00
Adrien Delorme
5389ab1694
pass config as a pointer so that ssh configuration is correctly set
2018-09-18 11:36:21 +02:00
Anshul Sharma
ef3c10c403
Modify Validate Region for test cases
2018-09-17 14:45:55 -07:00
Anshul Sharma
98f13eaf29
Use DescribeRegions for aws region validation
2018-09-17 14:45:55 -07:00
Megan Marsh
f4e6d06e68
reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides
2018-09-17 11:10:50 -07:00
chhaj5236
43e091de15
Merge branch 'master' into feature/support_tags
2018-09-17 16:50:44 +08:00
zhuzhih2017
31bbe2983b
Merge pull request #6688 from chhaj5236/feature/support_ssh_private_ip
...
support ssh with private ip address
2018-09-17 16:46:38 +08:00
bozhi.ch
b3aae89a53
fix attaching keypair error due to missing keypair name
2018-09-16 18:19:00 +08:00
bozhi.ch
b8a3e3b8f4
support adding tags to image
2018-09-16 18:16:13 +08:00
Adrien Delorme
fc75449e06
Merge pull request #6713 from hashicorp/cleanup_keys
...
new option allowing user to clean up the ephemeral ssh key from the a…
2018-09-14 11:12:33 -07:00
Megan Marsh
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
Daisuke Takahashi
02139dcb69
Fix bugs
2018-09-13 14:39:38 +09:00
Adrien Delorme
770f61e682
spot instance creation, only set blockDurationMinutes when > 0
2018-09-12 10:21:39 -07:00
Adrien Delorme
2e73ed8d46
pass Comm instance to fix Spot instance creation
2018-09-11 18:20:14 -07:00
Matt DeBoer
09797df958
use a UI wrapper to auto-decode error messages
...
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
bozhi.ch
743be8a808
support ssh with private ip address
2018-09-11 16:56:57 +08:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
e02d0dacc4
Merge branch 'master' into aws-filters
2018-09-07 16:14:00 +02:00
Sargun Dhillon
63d784023f
Add support to support non-gp2 volume types for building from_scratch
2018-09-06 13:22:09 -07:00
Sargun Dhillon
07ce820c70
Enable setting the volume type when building with the Amazon Chroot builder
2018-09-06 13:22:09 -07:00
Megan Marsh
b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
...
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
Adrien Delorme
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
Adrien Delorme
b80e1d51c6
aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI
2018-09-05 10:24:28 +02:00
Adrien Delorme
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Sargun Dhillon
902497d6ce
Allow users to build hvm images from pv images to have ena_support
2018-09-04 18:16:52 -07:00
Megan Marsh
cb35829f80
Merge pull request #6411 from jmartin-r7/esxi_compact
...
add support for disk compaction to esx5 builder
2018-09-04 12:44:32 -07:00
Christopher Boumenot
2e294da82a
Merge pull request #6644 from riezebosch/master
...
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
Megan Marsh
349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
...
Increase retries
2018-09-04 11:39:28 -07:00
Adrien Delorme
819bda50d5
Merge pull request #6648 from hashicorp/fix_6642
...
Update public google cloud image projects
2018-09-03 09:29:31 +02:00
Adrien Delorme
2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
...
Fix 6569
2018-09-03 08:44:07 +02:00
RenaudS
26aab49aaf
aws spot instances: add block_duration_minutes option ( #6638 )
...
* Add block_duration_minutes option
* int64 cannot be nil
* Update doc
* Fix formating
2018-09-03 08:33:58 +02:00