On Windows, packer's 'file' provisioner fails to copy files/directories that include both a volume identifier (e.g. C:) and spaces in the path.
The root cause of this was found to be embedded single quotes in the 'destination' value, added by the github.com/packer-community/winrmcp/winrmcp project.
This updated winrmcp revision includes the fix to resolve this issue.
This is last merge that will happen from the github.com/Azure/packer-Azure
repository. All development is being over to this repository.
The biggest change in this merge is support for Windows. There are a few other
fixes as well.
* If the user cancels the build, clean up any resources.
* Output a reasonable build artifact.
* Log requests and responses with Azure.
* Support for US Government and the China clouds.
* Support interrupting long running tasks.
* Allow the user to set the image version.
* Device login support.
The dollar signs do not need to be escaped. The backslashes show up on
the website right now. This commit makes it so that they do not show up
on the website.
Commonly /tmp is set as noexec, as a result packer scripts
fail to run. In order to get around this one can set a
remote_path, whoever, remote path requires full filename
and path.
By making remote_path a combination of
remote_folder/remote_script we can change remote_folder
and keep the default script_nnn.sh
Signed-off-by: Ian Duffy <ian@ianduffy.ie>
No sure if this will work...
Appveyor builds appear to always choke on go vet, so I am removing it. The
Travis build already does it, so I do not think there's much value in
repeating it.
RequestPty from crypto/ssh looks like this:
func (s *Session) RequestPty(term string, h, w int, termmodes TerminalModes) error
So arguments 2 and 3 are height and width, respectively. I'm not sure if
the original was just a typo, or if there's an actual reason we want a
40 column terminal. Either way, having a terminal this narrow led me to
a really "fun" bug[0], where `wget` in my shell provisioner scripts
would segfault when trying to display the progress bar.
[0] http://lists.gnu.org/archive/html/bug-wget/2016-02/msg00041.html
Chris Bednarski
Scott Pynn
Christopher Boumenot
Seth Vargo
Jake Champlin
Paul Hinze
Justin Nauman
Hao
Mark Campbell
Ian Duffy
Khalid Saifullah
mansunkuo
Rickard von Essen
Alex Brown
Tyler Tidman
Christopher Boumenot