Wilken Rivera
ecf11816c5
Merge pull request #8639 from hashicorp/fix_8627
...
provisioner/shell: Fix envVarFile clean up issue
2020-01-23 16:23:12 -05:00
nywilken
b80882f3b8
provisioner/shell: Fix envVarFile clean up issue
...
This change ensures the deletion of the external envVarFile (use_env_var_file = true) occurs after all script files have been executed and deleted.
Build results before change
```
> packer build build.pkr.hcl [~0]
docker: output will be in this color.
==> docker: Creating a temporary directory for sharing data...
==> docker: Pulling Docker image: ubuntu:bionic
docker: bionic: Pulling from library/ubuntu
docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110
docker: Status: Image is up to date for ubuntu:bionic
docker: docker.io/library/ubuntu:bionic
==> docker: Starting docker container...
docker: Run command: docker run -v /home/wilken/.packer.d/tmp476880774:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic
docker: Container ID: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b
==> docker: Using docker communicator to connect: 172.17.0.2
==> docker: Provisioning with shell script: sample.sh
docker: Sample Script
docker: wilken is NotForSale!
==> docker: Provisioning with shell script: foobar.sh
==> docker: /bin/sh: 1: .: Can't open /tmp/varfile_2555.sh
==> docker: Provisioning step had errors: Running the cleanup provisioner, if present...
==> docker: Killing the container: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b
Build 'docker' errored: Script exited with non-zero exit status: 2.Allowed exit codes are: [0]
==> Some builds didn't complete successfully and had errors:
--> docker: Script exited with non-zero exit status: 2.Allowed exit codes are: [0]
==> Builds finished but no artifacts were created.
```
Build results after change
```
> packer build build.pkr.hcl
docker: output will be in this color.
==> docker: Creating a temporary directory for sharing data...
==> docker: Pulling Docker image: ubuntu:bionic
docker: bionic: Pulling from library/ubuntu
docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110
docker: Status: Image is up to date for ubuntu:bionic
docker: docker.io/library/ubuntu:bionic
==> docker: Starting docker container...
docker: Run command: docker run -v /home/wilken/.packer.d/tmp819845000:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic
docker: Container ID: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5
==> docker: Using docker communicator to connect: 172.17.0.2
==> docker: Provisioning with shell script: sample.sh
docker: Sample Script
docker: wilken is NotForSale!
==> docker: Provisioning with shell script: foobar.sh
docker: FooBar Script
docker: wilken is NotForSale!
==> docker: Committing the container
docker: Image ID: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3
==> docker: Killing the container: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5
Build 'docker' finished.
==> Builds finished. The artifacts of successful builds are:
--> docker: Imported Docker image: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3
```
2020-01-23 14:59:36 -05:00
Megan Marsh
b0b10f6939
Merge pull request #8496 from ryanhartje/delete_arm_deployment_on_cleanup
...
attempting to resolve deployment quota issue due to non-cleanup
2020-01-23 09:48:20 -08:00
Zian Ke
dd5893ec23
Fix grammatical error ( #8643 )
2020-01-23 10:03:39 +01:00
Ryan Hartje
c4a9715e50
updated the deleteTemplate invocation to a defer at the start of cleanup
2020-01-22 16:58:26 -06:00
Wilken Rivera
111bab86d9
Merge pull request #8622 from datalot/pre-validate-with-filters
...
Allow aws builder pre validation to pass when subnet filters are present
2020-01-22 15:00:44 -05:00
Megan Marsh
6046818897
Merge pull request #8638 from hashicorp/hashibot.hcl
...
Create .hashibot.hcl
2020-01-22 10:43:52 -08:00
Adrien Delorme
93f421ce89
Update .hashibot.hcl
2020-01-22 17:15:34 +01:00
Adrien Delorme
266a8ccffc
Create .hashibot.hcl
2020-01-22 17:13:15 +01:00
Chris Lundquist
15cbe4769c
fixes and closes #8547
2020-01-21 19:49:49 -08:00
Megan Marsh
ff62d5b29b
Merge pull request #8631 from leitu/fix_website_example
...
update website example
2020-01-21 15:15:22 -08:00
Lei Tu
e4aca6298d
update website
2020-01-21 21:56:15 +09:00
Sylvia Moss
0b7251a4bb
Share .Device and .MountPath between builders, provisioners and post-processors ( #8621 )
2020-01-20 16:29:38 +01:00
Megan Marsh
d25b4cf514
update changelog
2020-01-17 15:44:42 -08:00
Megan Marsh
9bff85e853
Merge pull request #8623 from hashicorp/f_packerconfig_logging
...
config: Update loading of packerconfig to only log when a plugin is loaded
2020-01-17 14:50:48 -08:00
Megan Marsh
db275ade8d
Merge pull request #8624 from carlpett/proxmox-upload-iso
...
Proxmox upload iso
2020-01-17 14:50:16 -08:00
Calle Pettersson
8e4c165173
Proxmox upload ISO
2020-01-17 22:17:28 +01:00
Calle Pettersson
d70d1e8bf7
Bump proxmox-api-go
2020-01-17 22:17:28 +01:00
Megan Marsh
a163ff7388
swap ordering so PACKER_PLUGIN_PATH gets precedence
2020-01-17 12:40:30 -08:00
nywilken
93640b0854
Update test case for Windows
2020-01-17 14:03:35 -05:00
nywilken
c93a076698
config: Update loading of packerconfig to only log when a plugin is loaded
...
Before this change loading of a packerconfig would display `loaded
plugin ...` for any plugin defined in the packerconfig - even if it
didn't exist on disk. This change updates how plugins defined in
packerconfig are loaded to ensure that only successfully loaded plugins
get the lovely message `loaded plugin ...`. For any plugin that fails to
load Packer will log that it failed to load the plugin and continue
processing any other defined plugins.
* Add a test to ensure loadSingleComponent errors when plugin does not
exists
2020-01-17 13:33:51 -05:00
Rich Cavanaugh
4fb0de5256
allow validation to pass when subnet filters are present
2020-01-17 11:57:42 -05:00
Sylvia Moss
fce24ca71d
Add extend packer build template engine docs ( #8615 )
2020-01-17 11:21:52 +01:00
Megan Marsh
83ecebbf37
add PACKER_PLUGIN_PATH for plugin discovery
2020-01-16 13:13:29 -08:00
Megan Marsh
76fa85fd93
Merge pull request #8613 from hashicorp/add_pp_names
...
log name of postprocessor running to disambiguate long chains of pps
2020-01-16 13:12:02 -08:00
Adrien Delorme
c905418d4e
Avoid field confusion be naming fields in packer/build_test.go
2020-01-16 16:24:33 +01:00
Sylvia Moss
39c25b2c66
Add retry mechanism to amazon DeleteSnapshot ( #8614 )
2020-01-16 14:38:46 +01:00
Adrien Delorme
2d1a67c6cb
hcl2: allow to optionnaly name provisioners and post-processors
2020-01-16 12:08:39 +01:00
Sylvia Moss
0677b02e18
Share SourceImageName with provisioners and manifest post-processor ( #8603 )
2020-01-16 12:04:03 +01:00
Megan Marsh
b5075a35c0
fix tests
2020-01-15 15:36:52 -08:00
Megan Marsh
b498e5af12
Merge pull request #8612 from hashicorp/fix_8611
...
fix config decode
2020-01-15 15:12:09 -08:00
Megan Marsh
e228a5bcb9
log name of postprocessor running to disambiguate long chains of pps
2020-01-15 14:47:56 -08:00
Megan Marsh
83dc0a7c8b
fix config decode
2020-01-15 14:27:55 -08:00
Megan Marsh
fac320d290
Merge pull request #8480 from hashicorp/merge-vsphere-builder
...
Merge the vSphere builder
2020-01-15 14:11:20 -08:00
Megan Marsh
ecf0e5794a
Merge pull request #8607 from hashicorp/fix_vagrant_crash
...
Fix a crash in the vagrant driver
2020-01-15 13:33:23 -08:00
Megan Marsh
a847530a83
Update builder/vagrant/driver_2_2.go
...
Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>
2020-01-15 13:12:44 -08:00
Megan Marsh
d55f256cac
Merge pull request #8414 from footplus/fix_osc_ssh_host_detection
...
builder/osc: fix ssh host detection in Public Cloud and Nets
2020-01-15 12:13:28 -08:00
Megan Marsh
48811ed4e5
replace buffer copy loop with a scanner that handles carriage returns
2020-01-15 12:05:29 -08:00
Megan Marsh
6315f69019
break out of loop once channel is read from.
2020-01-15 11:00:41 -08:00
Wilken Rivera
888f780f61
Merge pull request #8582 from hashicorp/fix-load-config
...
Fix loading external plugins defined in PACKER_CONFIG
2020-01-15 13:58:41 -05:00
Megan Marsh
b8edaa9850
Merge pull request #8605 from hashicorp/fix_8599
...
remove unhelpful quotes to fix bug with reading key from a path with …
2020-01-15 10:56:23 -08:00
Megan Marsh
bbd64896a0
use strconv.unquote instead of DIY
2020-01-15 10:23:25 -08:00
nywilken
fb76323c4d
config: Fix loading external plugins from a packerconfig
...
This change introduces a loadExternalComponent which can be used for
loading a single plugin path. The function is a combination of
the discoverSingle and discoverExternalComponents functions.
2020-01-15 13:08:30 -05:00
Wilken Rivera
744412d9de
Merge pull request #8604 from hashicorp/td-vagrantfile-bootstrapping-scripts
...
scripts/vagrant: Update Vagrant bootstrapping scripts
2020-01-15 12:50:45 -05:00
nywilken
8a36ddd69d
scripts/vagrant: Update Vagrant bootstrapping scripts
2020-01-15 12:42:15 -05:00
Sylvia Moss
0e177915f8
Add retry mechanism to DeregisterImage from awsec2 ( #8598 )
2020-01-15 10:28:14 +01:00
Megan Marsh
5980d32efb
remove unhelpful quotes to fix bug with reading key from a path with spaces in it.
2020-01-14 13:57:11 -08:00
Sylvia Moss
06a26e74b4
Override post-processor config when processing ( #8592 )
2020-01-14 11:13:16 +01:00
Megan Marsh
82f03fca7c
fix to work with hcl2; update tests
2020-01-13 15:52:05 -08:00
Wilken Rivera
5138ca8c67
Merge pull request #8594 from hashicorp/fix_vagrant_cloud_parse_errors
...
post-processor/vagrant-cloud: Update error handling for Vagrant Cloud API
2020-01-13 17:43:38 -05:00