Commit Graph

43 Commits

Author SHA1 Message Date
Ash Berlin 242ed49ecb Use bufio.Scanner in BasicUi.Ask so we can read whole lines
The previous version used fmt.Fscanln which sounds like it should scan
for a whole line, but it actually errors if there is more than a single
word/token given. You can see this here https://play.golang.org/p/1RYXdtPSbk

And looking at the only usage of this function in core it won't break
anything to change it to actually return whole lines instead.

    line, err := ui.Ask("[c] Clean up and exit, [a] abort without cleanup, or [r] retry step (build may fail even if retry succeeds)?")

Closes #4474
2017-01-29 14:10:14 +00:00
Mitchell Hashimoto 847cb02eb3 packer: fuzzy search broken pipe too [GH-1314] 2014-09-03 21:31:34 -07:00
Mitchell Hashimoto e2e4c9f671 packer: errors go to stderr [GH-868] 2014-02-21 18:29:15 -08:00
Mitchell Hashimoto 1c65536514 packer: closed pipe is caught [GH-875] 2014-02-21 17:43:45 -08:00
Mitchell Hashimoto 18f3588f35 packer: no colored output if machine-readable [GH-684] 2013-12-16 14:10:28 -08:00
Mitchell Hashimoto c7d7e2cf0f packer: don't change background color in UI 2013-11-19 21:31:54 -08:00
Mitchell Hashimoto 532b4d3647 packer: don't panic if can't write to UI 2013-10-23 20:32:20 -07:00
Mitchell Hashimoto c77d26e46c packer: replace \r with literal on Ui for MR 2013-08-11 23:19:13 -07:00
Mitchell Hashimoto ba3344a322 packer: replace new lines with literal \n 2013-08-11 23:18:14 -07:00
Mitchell Hashimoto 7b4b5d23fc packer: output a newline after each MR line 2013-08-11 23:14:42 -07:00
Mitchell Hashimoto aa143a330b packer: TargettedUi properly targets machine-readable data 2013-08-11 19:08:08 -07:00
Mitchell Hashimoto 89be12ae21 packer: Add MachineReadableUi 2013-08-11 19:05:07 -07:00
Mitchell Hashimoto edc59499e7 packer: BasicUi doesn't do machine-readable, just log 2013-08-11 18:38:24 -07:00
Mitchell Hashimoto 03c10a9aa8 packer: renamed PrefixedUi to TargettedUi 2013-08-11 18:31:28 -07:00
Mitchell Hashimoto 02edc7579b packer: Rename ReaderWriterUi to BasicUi 2013-08-11 18:20:27 -07:00
Mitchell Hashimoto fb6d2754da packer: Add Machine func to Ui 2013-08-11 18:16:00 -07:00
Mitchell Hashimoto 7bdb0c96f8 packer: fmt 2013-07-31 14:43:34 -07:00
Mitchell Hashimoto 08d2ac7815 packer: don't output colors if Windows and not Cygwin 2013-07-31 14:06:01 -07:00
Mitchell Hashimoto c2236e9bfd packer: Only trim whitespace on the right of prefixed UI 2013-07-09 12:41:36 -07:00
Mitchell Hashimoto 7198936f7e packer: PrefixedUi properly prefixes each line of output 2013-07-02 12:28:25 -07:00
Mitchell Hashimoto 43b6c1fa89 packer: Ui.Message should Fprint, not Fprintf 2013-06-23 23:06:59 -07:00
Mitchell Hashimoto f4a5adf471 packer: Output a newline when interrupted for UI 2013-06-17 11:40:57 -07:00
Mitchell Hashimoto e0b05355c3 packer: If interrupted, Ask is disabled 2013-06-15 18:25:34 -07:00
Mitchell Hashimoto dc5d261994 packer: Ui can return an error for Ask, returns one for interrupt 2013-06-15 18:24:38 -07:00
Mitchell Hashimoto 22e7345148 packer: Ui requires input for Ctrl-C 2013-06-14 17:37:38 -07:00
Mitchell Hashimoto ea01d7b2c6 fmt 2013-06-14 16:00:16 -07:00
Mitchell Hashimoto 9a69b21025 packer: Ui.Ask quits during interrupt 2013-06-14 15:59:54 -07:00
Mitchell Hashimoto 21b6d2a435 builder/common: multistep debug fn gracefully exits during an interrupt 2013-06-14 15:47:06 -07:00
Mitchell Hashimoto e0f2bcf8a2 packer: Add "Ask" method to Ui to ask for input 2013-06-14 15:17:03 -07:00
Mitchell Hashimoto 0f98852d4d packer: Ui error output is red 2013-06-12 10:41:58 -07:00
Mitchell Hashimoto e21d389fd2 packer: Fixin bugs in PrefixUi calling the wrong method 2013-06-03 13:54:28 -07:00
Mitchell Hashimoto 3e1b10c09e packer: ColoredUi bolds, but doesn't bold messages 2013-06-03 13:49:59 -07:00
Mitchell Hashimoto f041ebb2fd packer: ColoredUi 2013-06-03 13:35:43 -07:00
Mitchell Hashimoto edab952a68 packer: Add Message method to Ui 2013-06-03 11:30:38 -07:00
Mitchell Hashimoto 2788d29bd1 packer, packer/rpc: Update Ui to just take a message 2013-05-27 15:12:48 -07:00
Mitchell Hashimoto 2c4a873a5f packer: Add PrefixedUi 2013-05-21 13:20:51 -07:00
Mitchell Hashimoto 8dfe78dd19 packer: Log UI output 2013-05-21 11:40:07 -07:00
Mitchell Hashimoto 4453fda2e8 go fmt 2013-05-21 00:56:27 -07:00
Mitchell Hashimoto 559777e5b7 packer: Ui automatically appends newline 2013-05-20 23:43:37 -07:00
Mitchell Hashimoto 44bd56c3a8 go fmt 2013-05-10 17:01:24 -07:00
Mitchell Hashimoto 198f984b92 packer: error if UI fails 2013-05-08 17:09:10 -07:00
Mitchell Hashimoto 95153413a6 packer: Ui has Error method 2013-05-08 15:12:48 -07:00
Mitchell Hashimoto db1c11fff5 Lots of stuff, too early for meaningful commit messages
UI, command dispatch
2013-03-24 14:03:53 -07:00