Mikhail Ushanov
ee133482b4
aws: add validation for device_name parameter
...
cause it's required in block-device-mapping.
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
Megan Marsh
02bfac118f
default wait time for amazon import to one hour.
2018-10-09 13:08:42 -07:00
Megan Marsh
f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
...
abort if image import fails
2018-10-09 12:56:28 -07:00
Adrien Delorme
f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
...
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
Adrien Delorme
22d3e9b5c4
builder/amazon/ebs: pass config as a pointer so values could be populated by a run
2018-09-27 16:27:34 +02:00
Matthew Hooker
9181570bc3
remove stray struct dumps in logs
2018-09-27 00:14:05 -07:00
Megan Marsh
d616f0ba71
abort if image import fails
2018-09-20 13:18:59 -07:00
Megan Marsh
79093da6ad
skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock
2018-09-19 10:30:08 -07:00
Megan Marsh
93f1155a14
remove test-related special casing
2018-09-18 08:08:36 -07:00
Anshul Sharma
ef3c10c403
Modify Validate Region for test cases
2018-09-17 14:45:55 -07:00
Anshul Sharma
98f13eaf29
Use DescribeRegions for aws region validation
2018-09-17 14:45:55 -07:00
Megan Marsh
f4e6d06e68
reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides
2018-09-17 11:10:50 -07:00
Megan Marsh
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
Adrien Delorme
770f61e682
spot instance creation, only set blockDurationMinutes when > 0
2018-09-12 10:21:39 -07:00
Adrien Delorme
2e73ed8d46
pass Comm instance to fix Spot instance creation
2018-09-11 18:20:14 -07:00
Matt DeBoer
09797df958
use a UI wrapper to auto-decode error messages
...
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
e02d0dacc4
Merge branch 'master' into aws-filters
2018-09-07 16:14:00 +02:00
Sargun Dhillon
63d784023f
Add support to support non-gp2 volume types for building from_scratch
2018-09-06 13:22:09 -07:00
Sargun Dhillon
07ce820c70
Enable setting the volume type when building with the Amazon Chroot builder
2018-09-06 13:22:09 -07:00
Megan Marsh
b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
...
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
Adrien Delorme
b80e1d51c6
aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI
2018-09-05 10:24:28 +02:00
Sargun Dhillon
902497d6ce
Allow users to build hvm images from pv images to have ena_support
2018-09-04 18:16:52 -07:00
Megan Marsh
349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
...
Increase retries
2018-09-04 11:39:28 -07:00
Adrien Delorme
2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
...
Fix 6569
2018-09-03 08:44:07 +02:00
RenaudS
26aab49aaf
aws spot instances: add block_duration_minutes option ( #6638 )
...
* Add block_duration_minutes option
* int64 cannot be nil
* Update doc
* Fix formating
2018-09-03 08:33:58 +02:00
Megan Marsh
4472ecccb0
fix waiters that weren't applying env defaults
2018-08-31 13:30:41 -07:00
Megan Marsh
9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
...
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
Megan Marsh
2b9f937c23
increase max retries from 3 to 20
2018-08-30 09:35:06 -07:00
Adrien Delorme
df9e756865
pass the Comm instance to the amazon ebs builders steps
2018-08-30 12:50:29 +02:00
Adrien Delorme
b0c09087a2
move SSHInterface/SSHIPVersion fields to communitator.Config struct
2018-08-29 14:51:28 +02:00
Adrien Delorme
0938b640cc
use key pair name from config
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef4ca9c48e
builder.amazon: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
9a9b82715b
config.Comm.SSHKeyPair => SSHKeyPairName
2018-08-29 14:40:33 +02:00
Adrien Delorme
3a4bb26150
builder.aws: use key pair from comm struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
293c485372
builder.aws: use SSHAgentAuth from Comm
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef08c441c9
builder.aws: use Comm field for StepKeyPair & StepGetPassword
2018-08-29 14:40:33 +02:00
Adrien Delorme
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
Megan Marsh
e4f6b6f720
fix chroot communicator to properly escape quotes
2018-08-28 09:16:43 -07:00
Matthew Hooker
e41e99954d
go 1.11 format rules
2018-08-24 15:56:44 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Rickard von Essen
23f62f221e
Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available
2018-08-24 20:24:48 +02:00
Megan Marsh
fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
...
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
Adrien Delorme
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls ( #6622 )
...
* Remove duplicate unused SSHConfig funcs
* call to SSHConfigFunc() for azure/arm builder
* ncloud too
* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Rickard von Essen
533967cb66
builder/amazon: Add suppport for security_group_filter
...
Allow selecting SG's using a filter. Also some cleanup of vpc_filter and
subnet_filter.
2018-08-24 12:42:38 +02:00
Megan Marsh
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Rickard von Essen
9840862757
builder/amazon: Add suppport for vpc_filter and subnet_filter
...
First step of adding support for discovering VPC's and Subnets using
filters.
2018-08-23 12:52:03 +02:00
Adrien Delorme
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker
31fcfe4bc2
PoC for filtering logs
2018-08-20 15:20:21 -07:00
Megan Marsh
00c6ec979f
do 30 minutes not 25
2018-08-17 13:30:02 -07:00
Megan Marsh
00de0f4996
increase the timeout for waiting for an ami to become available
2018-08-17 13:27:19 -07:00
Megan Marsh
71cad4f2a9
fix tests
2018-08-14 12:30:05 -07:00
Megan Marsh
250da0ab49
fix security hole with ami filter
2018-08-13 17:01:13 -07:00
Anshul Sharma
c1edcd3774
amazon-ebssurrogate clean up volumes
2018-07-26 09:38:59 +03:00
Megan Marsh
07b6bc0c4f
Merge pull request #6504 from sharmaansh/6309-amazon-chroot-create-volume-tags
...
amazon-chroot: Add tags on CreateVolume
2018-07-23 14:58:17 -07:00
Matthew Hooker
814c1cf2b2
spellfix
2018-07-18 13:00:45 -07:00
Anshul Sharma
885ecb0790
Issue-6309 Amazon Chroot Provider
...
- Add tags on CreateVolume
2018-07-18 13:01:15 +03:00
James Nugent
9fffe4056e
Merge pull request #5452 from smaato/tag-spot-requests
...
Enable tagging of spot requests
2018-07-16 13:00:07 -05:00
Mark Meyer
2fec76ea87
Check if spot price is empty, when spot_tags is set
2018-07-13 22:42:42 +02:00
Megan Marsh
b6b907f523
read in the environment variables that government wait time and polling time for the AWS wait in step_stop_ebs_volume
2018-07-13 09:43:28 -07:00
Megan Marsh
8e22803099
fix loading of environment variables for managing aws waiters
2018-07-11 13:10:38 -07:00
Megan Marsh
f657ca39c9
refactored env var code and tests so that I don't have to set env vars during tests to check logic
2018-07-11 10:36:21 -07:00
Megan Marsh
14166fdd99
update amazon import docs to include the env vars for setting aws waiter delays and timeouts
2018-07-11 10:36:21 -07:00
Megan Marsh
bfbe318727
fix the homegrown waiters
...
fix image import; issue was with wait options not being evaluated
2018-07-11 10:36:21 -07:00
Megan Marsh
f49a2d8aed
move UI call to before the wait; add context to these steps
2018-07-11 10:36:21 -07:00
Megan Marsh
cf63dd10bf
replace AMIStateRefreshFunc, InstanceStateRefreshFunc, our spot instance waiter, our chroot volume waiter, and our snapshot waiters with waiters form AWS's SDK.
2018-07-11 10:34:20 -07:00
Mark Meyer
3dbf1cb371
Enable tagging of spot requests
...
This adds a new parameter to the EBS builders named `spot_tags'. This
parameter accepts a map of tags, much like `tags'. These tags will be
applied to a spot request that is created.
Improve visibility.
2018-07-07 16:06:51 +02:00
EC2 Default User
58f73aabbf
Add ap-northeast-3 region
2018-06-15 07:15:41 +00:00
Megan Marsh
87a93e84ac
sh -c to execute command to accomodate communicator change
2018-06-08 13:14:55 -07:00
James Nugent
b97475b647
Merge pull request #6265 from DanHam/enable-t2-unlimited
...
Add support for T2 Unlimited for Amazon builders
2018-05-25 00:26:17 +04:00
DanHam
af7f7f2ce9
Fix redundant Sprintf
2018-05-24 21:05:03 +01:00
M. Marsh
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
...
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
Megan Marsh
e670eed315
Add new option, nvme_device_path, so that we can properly mount nvme block devices.
2018-05-23 09:16:40 -07:00
M. Marsh
a8b6a04dda
Merge pull request #6194 from hashicorp/fix_6176
...
allow user to mount entire block device in chroot builder
2018-05-21 15:28:18 -07:00
DanHam
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
DanHam
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
DanHam
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
DanHam
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
DanHam
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
DanHam
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
DanHam
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
Megan Marsh
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
Megan Marsh
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
Matthew Hooker
0521efa200
correctly log reason waiting for ami failed.
2018-05-03 12:27:09 -07:00
Matthew Hooker
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
...
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
AlessioT
3d4c7d0df1
Feature Request: Log reason why AMI creation failed
2018-04-30 20:59:13 +01:00
DanHam
9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests
2018-04-30 18:16:46 +01:00
DanHam
54e9690dff
Remove tmp files created by builder/amazon/common tests
2018-04-30 18:16:46 +01:00
AlessioT
373226e9c5
Extract state reason for failure
2018-04-28 12:40:48 +01:00
AlessioT
09bb21774d
alessio.tomasino@yahoo.co.uk
2018-04-28 11:02:53 +01:00
AlessioT
c27f3e9445
alessio.tomasino@yahoo.co.uk
2018-04-28 11:00:33 +01:00
Megan Marsh
59e3ec722d
allow user to mount entire block device in chroot builder
2018-04-25 10:47:52 -07:00
Matthew Hooker
cbdf9db832
Use contexts with amazon waiters.
2018-04-23 12:57:15 -07:00
Megan Marsh
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
Matthew Hooker
f094b3be85
update changelog
2018-04-05 16:32:03 -07:00
Matthew Hooker
302b1988a5
Restrict deregistered AMIs to those owned by self.
2018-04-05 13:29:36 -07:00
Megan Marsh
22608f3efd
Merge pull request #6088 from adongy/master
...
Expose more source ami data in the template
2018-04-02 16:32:16 -07:00
ADO
04790695e6
Add interpolate_build_info_test tests
2018-03-30 16:46:35 +02:00
ADO
507b3619e7
Expose more source ami data in the template
2018-03-30 10:47:11 +02:00
Joseph Wright
1913517d29
Fix formatting by running `make fmt`
2018-03-25 19:51:49 -04:00
Joseph Wright
cb3699a584
Modify ebssurrogate builder to snapshot all launch devices
...
Documentation for ebssurrogate states that all of the devices in
`launch_block_device_mappings` are snapshotted and included in the
image. In fact, only the device that was designated as the root
device was snapshotted. This patch modifies the builder to create
snapshots of all the devices and include them in the image. This
allows creating images with separate filesystems preconfigured,
rather than having to add volumes to `ami_block_device_mappings`
and configure them after boot.
2018-03-25 19:37:44 -04:00
Megan Marsh
072cd6b745
Merge pull request #5998 from hashicorp/do_5895
...
allow users of AWS to use the dynamically-generated admin password wh…
2018-03-22 16:01:22 -07:00
Matthew Hooker
b16f2ec64b
builder/amazon: Use sdk default cred providers
...
I think we were overcomplicating things. The SDK provides the correct
credential chain by default, so let's use that. This patch does a quick
check for static credentials and uses those if found, then defaults to
the default credential provider chain.
This patch also removes the metadata timeout argument. Current versions
of the SDK have short timeouts by default, so I don't believe this is
needed.
2018-03-15 16:49:47 -07:00
Matthew Hooker
e483087574
builder/amazon: Use service default retries.
...
Each service has its own preconfigured number of times to retry.
Lets use that instead of setting a global number.
2018-03-14 22:26:35 -07:00
Megan Marsh
d689e6b4d3
allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.
2018-03-14 15:58:12 -07:00
Josh Soref
0171dfc890
spelling: validating
2018-03-14 03:28:19 +00:00
Josh Soref
007930ec2d
spelling: restricted
2018-03-14 03:20:51 +00:00
Less Mo
686cacb435
builder/amazon: Added new region cn-northwest-1
...
Add new region China Ningxia cn-northwest-1.
2018-03-02 16:34:19 +08:00
Matthew Hooker
2806523834
Fix issue with assume role credentials
2018-02-15 14:54:01 -08:00
Matthew Hooker
19a89a101e
builder/amazon: remove ssh_private_ip
...
ssh_private_ip should now be set through ssh_interface.
Adds fixer to automatically fix existing json files
2018-02-08 16:47:43 -08:00
Matthew Hooker
5b64f71702
Merge pull request #5764 from hashicorp/fix5760
...
"borrow" access config code from terraform.
2018-02-08 14:55:43 -08:00
Matthew Hooker
21812fa17f
Add volume and run tags if in us-gov/china
...
We can't tag on instance creation when we're in "restricted" regions,
so let's add the tags after the resources have been created.
Adds methods to AccessConfig to detect if we're in China or US Gov
regions (i.e. "restricted").
Also turns tag:tag maps into a type, and moves methods around validating
and converting them to ec2Tags to methods of the type.
2018-02-05 16:39:20 -08:00
Matthew Hooker
fad4d5c272
update tests for mapstructure behavior changes
2018-01-26 12:40:34 -08:00
Megan Marsh
de2e5edf2e
remove errant change in amazon builder
2018-01-26 08:43:51 -08:00
Megan Marsh
6556a851dc
fix ssh key handling
2018-01-25 14:34:01 -08:00
Matthew Hooker
eafda52411
use amazon steps from master
2018-01-24 17:09:18 -08:00
Matthew Hooker
7a189a83a1
fix imports
...
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a831d522be
change run signatures
...
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.
`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a0c625ea44
Revert "working with opt-in"
...
This reverts commit 4068ffdaf541354e75507add7ca0b193993fcd52.
2018-01-24 17:09:16 -08:00
Matthew Hooker
e98f201602
working with opt-in
2018-01-24 17:09:16 -08:00
Matthew Hooker
366dc3da0a
move multistep imports to helper.
...
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker
807e88245b
trying to add context to state bag
2018-01-24 17:09:15 -08:00
Matthew Hooker
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
Matthew Hooker
cea2ab8c6d
move kms/encrypted validation to block devices
2018-01-12 15:10:51 -08:00
Matthew Hooker
e968f9d6cc
spelling/style fixes
2018-01-12 14:26:56 -08:00
Jason Wieringa
f6772f06be
builder/amazon: Raise error when ebsvolume kms_key_id is without encrypted = true
2018-01-11 20:27:38 -08:00
Jason Wieringa
2ac59b3c27
builder/amazon: Added KmsKeyID to BlockDevice
...
+ Adds kms_key_id to list of options
+ Tests that configuraiton is set along with encrypted
+ Updates documentation on ebsvolume builder
2018-01-11 20:27:38 -08:00
Matthew Hooker
f5ea1e8312
Use WaitUntilInstanceReady waiter
2018-01-10 15:57:31 -08:00
Matthew Hooker
dfd5f07145
fix ebs acc test
2018-01-08 12:27:10 -08:00
Matthew Hooker
c5bcb97d06
"borrow" access config code from terraform.
...
This gives us a few benefits:
* timeout early if metadata service can't be reached
* report which auth provider we're using
* give much better errors if something goes wrong
2018-01-04 15:04:07 -08:00
Matthew Hooker
98c2a2d1f7
builder/aws: catch static credential errors early.
...
If we're using static credentials, either both the access key and secret key must be set, or neither of them should be.
2018-01-04 11:50:27 -08:00
Matthew Hooker
f3dea272d9
Set session in state bag
...
We can construct connections to arbitrary regions from it
2017-12-19 11:32:33 -08:00
Matthew Hooker
f6c401a143
don't pass in accessconfig
2017-12-19 11:32:32 -08:00
Matthew Hooker
1c352726d7
Merge pull request #5719 from rchenv/issue5606
...
Ensure all AWS connections are configured alike
2017-12-19 11:32:24 -08:00
Rong Chen
3e92b1374e
issue5606: follow the convention to use AccessConfig to create new aws session for step_create_tags etc.
2017-12-19 10:34:12 -08:00
Olivier Bazoud
8bcb469b8b
builder/amazon: Added new region Paris - eu-west-3
2017-12-19 10:00:03 +01:00
Rickard von Essen
63f791570a
Merge pull request #5665 from kwilczynski/remove-sts-token-from-logging
...
amazon: Remove Session Token (STS) from being shown in the log.
2017-12-10 06:50:42 +01:00
Matthew Hooker
f216330ba3
spot instance ena/sriov checking for all other builders
2017-12-08 14:56:19 -08:00
Matthew Hooker
4b1d8e3fe8
don't allow enhanced networking flags for spot instances.
2017-12-08 13:38:49 -08:00
Matthew Hooker
73b98b2a04
use waiter to wait for ebs instances to stop
2017-12-08 13:38:48 -08:00
Matthew Hooker
dada63801b
also use waiter code for spot instances
2017-12-08 13:38:48 -08:00
Matthew Hooker
9e61005f7c
Merge pull request #5660 from hashicorp/fix_5625
...
modify validation to allow user to have the original region in the am…
2017-12-08 13:36:10 -08:00
Ben Gnoinski
5df2e040d0
Update amazon run_config.go absent ssh_private_key_file error
2017-12-08 08:51:27 -08:00
Matthew Hooker
2c1c7b9659
Merge pull request #5630 from johndaviesco/winrm_no_proxy
...
Winrm no proxy
2017-12-07 15:41:16 -08:00
Matthew Hooker
a90c45d9bb
Wait until source instance OK before continuing
2017-12-07 12:31:50 -08:00
Matthew Hooker
7b5c0900ef
Correctly set aws region if given in template along with a profile.
2017-12-07 11:12:57 -08:00
Krzysztof Wilczynski
05327b7524
amazon: Remove Session Token (STS) from being shown in the log.
...
This commit adds a change which ensures that the Session Token
config struct item is removed from log output.
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-04 22:14:38 +01:00
Megan Marsh
1c681fc096
tests
2017-11-30 14:08:48 -08:00
Megan Marsh
556da47d35
modify validation to allow user to have the original region in the ami_regions list
2017-11-30 13:51:33 -08:00
John Davies-Colley
10aaa49beb
fixing tests and funky logic 💦
2017-11-28 14:42:14 +13:00
John Davies-Colley
0c787ec9df
Valadating early ⏰
2017-11-28 11:46:32 +13:00
John Davies-Colley
75320440ec
adding missing quote 🙏
2017-11-22 15:59:15 +13:00
John Davies-Colley
707ec675b2
ssh interface for amazon builders 🔨
2017-11-22 15:49:38 +13:00
Matthew Hooker
0a24f4eb2e
don't shadow package name
2017-11-07 16:05:43 -08:00
Matthew Hooker
f681faa296
fix tests
2017-11-07 14:57:10 -08:00
Matthew Hooker
545ee45567
debug region we found
2017-11-07 14:51:20 -08:00
Matthew Hooker
c106e7c26c
Don't set region from metadata if profile is set.
2017-11-07 14:33:26 -08:00
Matthew Hooker
52fc0100eb
this is a critical error
2017-11-07 12:52:03 -08:00
Matthew Hooker
95e4ae251e
WIP
2017-11-02 09:03:44 -07:00
Matthew Hooker
e87b468c6e
Merge pull request #5536 from hashicorp/fix5535
...
add delay option to security group waiter
2017-11-02 08:54:34 -07:00
Matthew Hooker
8ab390a048
Merge pull request #5495 from smaato/master
...
Fix regressions relating to spot instances and EBS volumes
2017-11-02 08:53:27 -07:00
Matthew Hooker
f2413ff138
add delay option to security group waiter
2017-11-02 00:25:54 -07:00
Matthew Hooker
d322fc6c19
Shorten metadata timeout
...
When running in travis, metadata requests will timeout after 5 seconds.
After 24 such timeouts, we'll hit travis' build timeout of two minutes,
and the build will fail. Lowering it to 100 gets us in a safe time
limit. We _may_ need to expose a timeout env var with this logic,
however.
2017-10-30 15:22:15 -07:00
Matthew Hooker
314fc94bd8
clean up
2017-10-30 15:02:39 -07:00
Matthew Hooker
0e4ea7420b
fix tests
2017-10-30 14:34:16 -07:00
Matthew Hooker
c65fa8490d
fix various bugs deregistering AMIs
...
always deregister ami in session region
validate that session region does not appear in ami_regions
2017-10-30 14:17:19 -07:00
Matthew Hooker
6c4fbe8d87
use correct default region when deregistering AMIs.
2017-10-30 13:07:58 -07:00
Mark Meyer
4c5df79222
Fix regressions introduced in the instance builder
...
Related to #5504
2017-10-24 23:23:18 +02:00
Mark Meyer
309bf61257
Add missing blockdevices to ebsvolume builder
2017-10-23 22:33:16 +02:00
Mark Meyer
1cc9b3f1e3
Bring back volume tagging to ebsvolume
...
Related to #5486
2017-10-23 22:09:04 +02:00
Mark Meyer
7e1646826d
Check if VolumeTags is empty before tagging volumes
...
Related to #5486
2017-10-23 21:10:40 +02:00
Matthew Hooker
f7e269945e
add cidr validation and rename option
2017-10-12 17:05:56 -07:00
Matthew Hooker
c74be87187
Merge pull request #5384 from dave2/sg-source-cidr
...
[WIP] Allow temporary security group to have source CIDR block explicit
2017-10-12 17:05:45 -07:00
SwampDragons
512ac214b4
Merge pull request #5417 from smaato/master
...
Add ability to tag volumes on creation
2017-10-12 12:56:25 -07:00
Mark Meyer
dbb3c76032
Remove redundant step and its usage
...
StepTagEBSVolumes is no longer needed, since this functionality is now
taken over by StepRunSourceInstance and StepRunSpotInstance. So remove
this functionality from the codebase.
2017-10-12 21:40:21 +02:00
Matthew Hooker
ae455bff99
add debugging help if ec2-upload-bundle fails
2017-10-05 17:33:07 -07:00
Mark Meyer
2661fd7869
Move building of spot instances into its own step
2017-10-04 12:38:21 +02:00
Mark Meyer
939b44b4fd
Add logic to handle volumes of spot instances
2017-10-03 01:03:21 +02:00
Mark Meyer
cfd6b6fed5
Change EBS builder to do tag-on-creation
...
The EBS builder will now use the tag-on-creation pattern, so
that it's possible to restrict packer to only create volumes that are
properly tagged by using an AWS policy.
2017-10-03 00:13:02 +02:00
Megan Marsh
201e8c05a0
add ami name to output
2017-09-26 16:04:40 -07:00
Zanetti, David
8a8b51be97
Allow temporary security group to have source CIDR block explicitly provided
2017-09-26 00:57:56 +00:00
Matthew Hooker
02cd6bc7f0
Merge pull request #5288 from hashicorp/fix3114
...
add token variable to upload bundle command template
2017-09-25 18:36:28 -05:00
Matthew Hooker
4bc8e7de3d
add token variable to upload bundle command template
2017-09-25 16:35:53 -07:00
Zanetti, David
42dc1e4795
In Amazon builders, allow tag names to be interpolated like values
2017-09-25 02:24:23 +00:00
Megan Marsh
1adcce6046
Merge pull request #5284 from hashicorp/fix_5093
...
Allow granular modification of sriov and ena enhanced networking opti…
2017-08-29 14:28:42 -07:00
Megan Marsh
85ad1f58fb
include ena_support and sriov_support in chroot and instance docs
2017-08-29 09:36:06 -07:00
Megan Marsh
f19040f3aa
Merge pull request #5196 from cstuntz/aws-add-tags
...
Upgrade aws-sdk-go to 1.10.14, add tags at instance run time
2017-08-28 13:17:29 -07:00
Megan Marsh
2d4bc70d7b
use ami prefix to make it clear that these variables are amazon specific
...
add fixer, fixer tests
2017-08-28 11:21:27 -07:00
Megan Marsh
9e2e467b31
Allow granular modification of sriov and ena enhanced networking options in amazon amis. Maintain old functionality.
2017-08-25 14:49:53 -07:00
Megan Marsh
7da52e1f77
Merge pull request #5250 from hashicorp/repro_3399
...
make force_deregister work in all regions, not just original region.
2017-08-24 14:41:02 -07:00
Łukasz Kostka
8703937cde
Natural order of AMI artifacts
2017-08-24 20:57:12 +02:00
Megan Marsh
14b2d04332
make force_deregister work in all regions, not just original region.
2017-08-14 12:31:58 -07:00
Sean Chittenden
cd84b17923
Fix building packer on GOOS=solaris
...
Update to golang/x/sys/unix is coming in the subsequent commit.
2017-08-14 10:34:06 -07:00
Matthew Hooker
754c80d217
create default tags as well
2017-08-11 12:31:05 -07:00
cstuntz
db7f860d91
Adding tagging back to spot instances, after they're created
2017-08-11 10:43:05 -07:00
Megan Marsh
a924db9a79
Merge pull request #5228 from hashicorp/4653_dont_delete_snapshots
...
continue, not break
2017-08-08 15:07:01 -07:00
Megan Marsh
ef0a091720
continue, not break
2017-08-08 14:53:56 -07:00
Matthew Hooker
968eb94b80
Merge pull request #5211 from hashicorp/4653_dont_delete_snapshots
...
use block device mappings to know whether a snapshot existed before p…
2017-08-08 14:31:38 -07:00
Megan Marsh
2d6028eb9a
use named loops instead of doDelete flag
2017-08-08 14:28:01 -07:00
Megan Marsh
e9ec705497
use block device mappings to know whether a snapshot existed before packer's current run. If yes, don't delete the unencrypted snapshot.
2017-08-08 13:59:55 -07:00
Megan Marsh
c760e1323f
don't panic if the communicator is none and the port is 0
2017-08-03 13:54:57 -07:00
cstuntz
c717765154
Removing tagging post instance launch
2017-08-02 09:29:47 -07:00
cstuntz
42444e58e6
Updating step_run_source_instance to add tags at instance start instead of adding them to running instance
2017-07-31 11:38:30 -07:00
Megan Marsh
12d43c98f7
test the deduplication code
2017-06-27 16:12:22 -07:00
Megan Marsh
5f92de6a39
fix panic that occurs when ami_block_device_mappings and does not explicitly contain the root volume
2017-06-27 13:17:45 -07:00
Megan Marsh
ac15b33d2b
Merge pull request #5029 from hashicorp/5007_instance_stop
...
add exponential backoff retry for stopping instance in amazon
2017-06-20 12:08:52 -07:00
Megan Marsh
f7a703dfb2
add pending to allowable states while waiting for ebs instance to stop
2017-06-20 10:55:23 -07:00
Megan Marsh
d706147423
add exponential backoff retry for stopping instance in amazon
...
retry only if the error is instancenotfound
2017-06-20 10:50:57 -07:00
Matthew Hooker
febc65aa7c
try again to get region from metadata
2017-06-14 16:30:18 -07:00
Matthew Hooker
8dae6b60c1
Merge pull request #4996 from hashicorp/mwhooker/4613
...
builder/amazon: Support Assume Role with MFA and ECS Task Roles
2017-06-13 17:40:09 -07:00
Matthew Hooker
350e8bfe0d
we don't need to look for region in metadata.
...
Closes #4615'
2017-06-13 17:35:48 -07:00
Matthew Hooker
94d7a4ce8d
post-processor/vagrant-cloud: try upload once
...
* fixes multiple uploads mentioned in #4973
* removed unused token code
2017-06-12 17:34:32 -07:00
Matthew Hooker
4860d7179d
remove redundant log line
2017-06-09 13:00:08 -07:00
Constantin Bugneac
ae03dab920
Print in the output the security group name too.
2017-06-09 20:05:59 +01:00
Matthew Hooker
a619759bf7
add support for profile
2017-06-09 11:24:30 -07:00
Matthew Hooker
3fb4162660
remove code from bad merge
2017-06-09 11:07:29 -07:00
Matthew Hooker
624aaa2067
bugfix
2017-06-09 11:01:27 -07:00
Matthew Hooker
3ed7572525
remove cli_config
2017-06-09 10:59:50 -07:00
Matthew Hooker
f637878822
with wrapping
2017-06-09 10:46:01 -07:00
Matthew Hooker
23084fe171
dedupe
2017-06-09 10:41:58 -07:00
Matthew Hooker
58e386827a
fix typo
2017-06-09 10:40:50 -07:00
Rickard von Essen
15f80dc5ab
aws: Drop undocumented option `profile`
...
This was added in 883acb18fa
to support
assume role and shared configuration file. This was never completed.
2017-06-09 10:37:54 -07:00
Matthew Hooker
56c513088b
I think this was the intention
2017-06-09 10:34:49 -07:00
Matthew Hooker
94854a26d9
fix go vet issue
2017-06-09 10:30:07 -07:00
Matthew Hooker
d7e39b72b2
remove dead code
2017-06-09 10:30:07 -07:00
Rickard von Essen
f106e60a7e
builder/amazon: Added MFA support
2017-06-09 10:28:31 -07:00
Rickard von Essen
f55c3b9d34
builder/amazon: Support assume role with assume_role_arn
...
This supports assuming a role when using profile or static credentials.
2017-06-09 10:27:56 -07:00
Rickard von Essen
3833d34829
builder/amazon: Cleaned up credential handeling
...
This properly handles:
- Preference between types of credential
- Assume role via ECS Task Role
2017-06-09 10:26:22 -07:00
Matthew Hooker
769ff28e03
builder/ebssurrogate: Use correct devices for AMI.
2017-06-06 12:33:08 -07:00
Matthew Hooker
11ba986abc
Merge pull request #4930 from hashicorp/fix4925
...
builder/amazon: don't try to delete extra volumes during clean up
2017-06-02 14:08:49 -07:00
Matthew Hooker
1f4b532ed5
Merge pull request #4948 from hashicorp/kms_key_regions
...
Kms key regions
2017-06-01 13:30:31 -07:00
Megan Marsh
b8c2a5fd43
fix step initializer everywhere StepAMIRegionCopy is called
2017-06-01 09:28:17 -07:00
Megan Marsh
875745ab9b
one more test
2017-05-31 14:16:02 -07:00
Megan Marsh
1944f38985
update docs and clean up
2017-05-31 13:41:32 -07:00
Megan Marsh
5b35d199da
golang has different style than python
2017-05-31 12:27:45 -07:00
Megan Marsh
f9d7292566
builder/amazon regional KMS keys
2017-05-31 11:23:18 -07:00
Jason Ramey
cc309c0e5f
spelling fix
2017-05-26 01:03:11 -04:00
Matthew Hooker
0e3469e913
spell fix
2017-05-25 18:49:45 -07:00
Megan Marsh
7174a7a3d5
New map: region_kms_key_ids, allowing custom encryption keys on a per-region basis. Also new tests.
2017-05-25 14:42:03 -07:00
Matthew Hooker
77b4d47409
only delete snapshots which exist
2017-05-25 14:16:20 -07:00
Matthew Hooker
c0b27dfa6f
don't try to delete extra volumes during clean up
2017-05-25 13:48:32 -07:00
Matthew Hooker
1cf4754d80
correct ami_name error reporting
2017-05-25 13:02:36 -07:00
Megan Marsh
4abb541468
fix logging to clarify that encrypt_boot needs to be set, not encrypt, and fix typo
2017-05-24 16:39:36 -07:00
Matthew Hooker
4137660b7a
fix ami name validation
2017-05-19 02:11:43 -07:00
Matthew Hooker
ee5d13611f
update ssh client usage for new crypto/ssh version
2017-05-18 12:01:44 -07:00
Rémi Jouannet
45143bb6f4
add an option custom_endpoint_ec2 for amazon builder, add a condition if vpc_id is empty don't add the parameter to the aws call
2017-05-17 18:45:20 +02:00
Paul Thrasher
0be5a28080
Fix issue 4693 - Derive vpc_id from subnet_id
...
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.
This fixes issue #4693 .
2017-05-15 13:46:05 -07:00
Ben Fagin
6f63881020
fixes a typo introduced in a previous change
2017-05-11 13:34:48 -07:00
luis-silva
a269bbc6fa
Fix issue 4875 - use retry logic when creating instance tags
2017-05-11 16:25:28 +01:00
Matthew Hooker
80d6cd91fd
remove unneeded keypair var
2017-05-01 10:17:21 -07:00
Matthew Hooker
602fd64c5d
builder/amazon: set flag to delete temporary keypair
2017-04-30 14:24:22 -07:00
Matthew Hooker
da8c4004f0
builder/amazon: numbers are valid in ami name
2017-04-05 12:39:16 -07:00
Matthew Hooker
3f6b5165f2
add affirmative test case for #4762
2017-04-04 22:08:09 -07:00
Craig Barr
d9041bda0c
Improved the test for special character so that it doesn't get halted by less than 3 character check
2017-04-05 11:06:59 +10:00
Craig Barr
7911cfa94b
Formatting as per make fmt
2017-04-05 11:02:23 +10:00
Craig Barr
fdae6858c8
conforming to the standard for imports
2017-04-05 10:53:58 +10:00
Craig Barr
df6337e8ab
Added AMIName validation (issue 4761)
2017-04-05 10:46:44 +10:00
Matthew Hooker
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
Matthew Hooker
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
Matthew Hooker
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
Matthew Hooker
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
Matthew Hooker
0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
Matthew Hooker
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
Matthew Hooker
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
Matthew Hooker
e4aa2a34ca
builder/amazon-chroot: nullable copy_files
...
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
Matthew Hooker
74c8c585f5
builder/amazon: report tag creation
2017-03-23 16:12:59 -07:00
Matthew Hooker
bd76b7bb6f
builder/amazon: validate ssh key name/file
...
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
Matthew Hooker
50d9546658
builder/amazon: set force_deregister to true on -force
2017-03-09 14:24:49 -08:00
Rickard von Essen
2300b102b7
amazon: Step Region Copy crashing on device mapping
...
Closes #4635
2017-03-08 18:12:37 +01:00
Matthew Hooker
9c027aa70b
Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
...
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
James Nugent
e856339309
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
...
As pointed out in the initial code review of #4351 , some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:
- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`
We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
James Nugent
1eec5bf058
builder/amazon-ebssurrogate: Exclude duplicate root volume
...
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
Matthew Hooker
fd1b00a0d1
use aws helper method
2017-02-26 19:33:34 -08:00
Matthew Hooker
61976dfd86
Merge pull request #4578 from life360/enable_ena
...
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
Matthew Hooker
6a7c37beb6
builder/amazon-chroot: support encrypted boot volume
2017-02-26 17:48:13 -08:00
Matthew Hooker
2cb9b32acf
don't attempt to delete non-existant key when using agent auth
2017-02-26 17:38:22 -08:00
Matthew Hooker
f95514c120
fix ssh agent authentication
...
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
Aaron Stone
1cc3cdf7b5
Always set both SRIOV and ENA when Enhanced Networking is enabled
...
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).
Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
Richard Owen
33a4c2e13b
Change EC2 WindowsPasswordTimeout to 20 minutes
...
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
James Nugent
635aeb765b
amazon/ebssurrogate: Add New Builder
...
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
Rickard von Essen
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
Rickard von Essen
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
Rickard von Essen
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
Rickard von Essen
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
Matthew Hooker
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
Matthew Hooker
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
Matthew Hooker
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
Matthew Hooker
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
Matthew Hooker
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
Roman Zhuzha
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
Roman Zhuzha
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
Roman Zhuzha
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
Roman Zhuzha
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
Roman Zhuzha
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
Matthew Hooker
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
Richard Moore
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
Rickard von Essen
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00