e1a46ec293
Fix gosimple S1025 linting errors ( #8838 )
...
Remove unneeded use of fmt.Sprintf for variables that are already strings.
2020-03-04 15:31:30 -05:00
8d5ecb9514
fix bug where ReadAll on the stderr pipe was causing an infinite hang because there was no stderr to report
2019-06-28 16:23:28 -07:00
71f2017209
read stderr before we try to read the artchive.
2019-04-16 13:05:25 -07:00
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00
12b9004c76
reduce duplicated code
2019-03-29 11:14:01 -07:00
ee1ff3132d
remove attempt to discover whether destination is a directory from upload function in various communicators
2018-04-10 08:13:06 -07:00
ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
...
Fix 4915
2018-02-05 14:54:27 -08:00
5866d4ea24
Move container user inspect to StepConnectDocker.
2017-10-10 22:45:47 +02:00
8452ca898c
implemented for docker communicator
2017-10-03 17:06:33 -07:00
ba72021274
Fix owner of files uploaded to docker container run as non-root.
2017-10-03 21:49:26 +02:00
b3661c1f63
builder/docker: set user during exec.
...
Add `exec_user` option to control what user `docker exec` is run as.
2017-09-28 16:39:23 -07:00
392af507e0
builder/docker: respect rsync semantics when uploading directories.
2017-09-12 14:45:25 -07:00
4edbd5322c
docker: stream uploads over stdin
...
Only write to a tempfile if we don't have a stat struct
2017-08-24 13:29:38 -07:00
c8db128dc5
Modified func Upload to use docker cp
2017-08-24 13:29:37 -07:00
ef858857e4
fix bug introduced by 5221
2017-08-14 14:07:21 -07:00
199b9062b0
fix file copy script to prevent error when encountering empty directory
2017-08-09 15:19:17 -07:00
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
a51f492558
communicator/docker: preserve file mode.
2017-01-23 13:47:22 -08:00
476d981211
Merge pull request #3800 from benwtr/issue-3142-match-dotfiles-docker-communicator
...
Fix file provisioner dotfile matching w/ docker builder
2016-09-20 12:25:37 +02:00
8ecbbe9037
backticks instead of $() for csh compatibility
2016-08-11 11:27:56 -07:00
0d7937fce1
[docker] ls -A instead of * glob for copying paths
2016-08-11 18:03:48 +00:00
165ec694ab
fix docker builder with ansible provisioner
...
Refactor the docker builder so that it does not expect output from the
container to be strictly line oriented or even text, because SFTP, used by
Ansible, is a binary protocol. Since `docker exec` was introduced in 2014,
remove support for older versions of docker that required using `docker
attach`. The old notes in the docker builder referring to specific issues have
all been resolved or else closed because they could not be reproduced.
2016-04-27 13:54:40 -07:00
feee19e4ed
file provisioner improvements
...
* allow specify source/destination as dir
* allow specify many files as source
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-02-12 11:48:28 -08:00
5ad4b0e97e
Added tests and handle the tar format from docker cp -
2015-08-12 12:16:26 -07:00
3523ffdce1
Farewell extra line. You were pretty but out of place.
2015-08-12 11:36:10 -07:00
047382eec9
Style tweak
2015-08-11 22:30:19 -07:00
dc3c55cf8e
Implemented downloader for the docker communicator so we can pull files out of a container
2015-08-11 22:22:52 -07:00
715662f60b
Reformat
2015-07-27 16:42:06 -07:00
b2811a8252
Update communicator.go
2015-07-16 21:51:13 -04:00
d00271aab3
Fix Capitilzation
2015-07-16 21:50:24 -04:00
4da4150abe
Update communicator.go
2015-07-16 21:37:08 -04:00
e3ab74e09f
Add Config struct for docker PTY
2015-07-16 21:06:03 -04:00
31ac2652d6
bulder/docker: canExec as sep function
2015-05-29 11:08:41 -07:00
6570b53c4a
builder/docker: use exec for v1.4+
2015-05-29 09:29:59 -07:00
a7206aebd7
builder/docker: attempt to satisfy travis for #1993
2015-03-20 12:50:03 -04:00
df7623d9d8
builder/docker: Run scripts /w `exec` if -v > 1.4
2015-03-20 12:07:43 -04:00
f52283d78e
all calls to cp should be escaped
2014-12-22 12:58:41 +01:00
955122f2e1
Be more explicit about escaping alias
2014-12-02 15:07:29 +01:00
075abfeeae
Escapes cp alias
...
Fix for #1656
2014-12-02 14:58:13 +01:00
d4080244b0
Resolves issue where docker communicator mishandled symlinks by treating them as files
2014-11-12 14:22:48 -07:00
75395af12d
Merge branch '1064-fix-upload-file-permissions' of github.com:rasa/packer into rasa-1064-fix-upload-file-permissions
...
Conflicts:
builder/parallels/common/step_upload_parallels_tools.go
builder/vmware/common/step_upload_tools.go
provisioner/chef-client/provisioner.go
provisioner/chef-solo/provisioner.go
2014-09-08 13:20:46 -07:00
b267c3eb4a
builder/docker: wait for tail to end when running remote command
2014-09-04 17:24:09 -07:00
c139aa3b71
builder/docker: style
2014-09-04 17:07:21 -07:00
d92179847d
provisioner/file: set file/directory permissions
...
fixes #1064
2014-05-09 21:03:35 -07:00
7bcfd83bdd
builder/docker: stream output from commands
2013-11-09 19:06:03 -08:00
2b89da50b3
builder/docker: UploadDir
2013-11-09 18:44:43 -08:00
23ad5442ec
builder/docker: perform cleanup in run method, not prematurely
2013-11-09 10:15:25 -08:00
44a41451f0
builder/docker: Communicator.Start doesn't block
2013-11-09 10:13:27 -08:00
d27ceaf509
builder/docker: remove the exit code file when we're done
2013-11-09 00:47:37 -08:00
2e7574e360
builder/docker: command output and exit codes work
...
/cc @mwhooker - CCing you on this because it is also ridiculous. See the
big comments
2013-11-09 00:33:36 -08:00
Wilken Rivera
Megan Marsh
Adrien Delorme
Matthew Hooker
localghost
Michael Juliano
Rickard von Essen
Ben P
Billie H. Cleek
Vasiliy Tolstov
Chris Bednarski
georgevicbell
Mitchell Hashimoto
Donald Guy
Godefroid Chapelle
Israel Shirk
Ross Smith II