Commit Graph

2446 Commits

Author SHA1 Message Date
Matthew Hooker 4137660b7a
fix ami name validation 2017-05-19 02:11:43 -07:00
Matthew Hooker e67d1fd676 Merge pull request #4900 from rogers0/PR/crypto-CVE-ABI-change
handle ABI change of golang-golang-x-crypto-dev
2017-05-18 12:06:08 -07:00
Matthew Hooker ee5d13611f
update ssh client usage for new crypto/ssh version 2017-05-18 12:01:44 -07:00
numa b15c3a5c92 Fix error message
I've matched the error message to the document
2017-05-18 18:40:16 +09:00
Rémi Jouannet 45143bb6f4 add an option custom_endpoint_ec2 for amazon builder, add a condition if vpc_id is empty don't add the parameter to the aws call 2017-05-17 18:45:20 +02:00
Matthew Hooker 06c7136e30
compare regions against valid regions 2017-05-16 21:00:13 -07:00
Luke Farnell 3afd77a5e4
fixed logic error and fixed suggestion 2017-05-16 21:00:13 -07:00
Luke Farnell 078c139ef1
Fix tests and add more 2017-05-16 21:00:13 -07:00
Luke Farnell 0f354614c0
Region Validation 2017-05-16 21:00:13 -07:00
Luke Farnell abf2e618b5
Wait for snapshot transfer and change artifact output 2017-05-16 21:00:13 -07:00
Luke Farnell 4f5d3face2
remove duplicates 2017-05-16 21:00:12 -07:00
Luke Farnell 8ed50608b1
add image transfer for DigitalOcean 2017-05-16 21:00:12 -07:00
Paul Thrasher 0be5a28080 Fix issue 4693 - Derive vpc_id from subnet_id
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.

This fixes issue #4693.
2017-05-15 13:46:05 -07:00
Ben Fagin 6f63881020 fixes a typo introduced in a previous change 2017-05-11 13:34:48 -07:00
luis-silva a269bbc6fa Fix issue 4875 - use retry logic when creating instance tags 2017-05-11 16:25:28 +01:00
Sean Chittenden eece75a7a6
Wait for a 410 before returning success on a machine delete. 2017-05-10 09:12:24 -07:00
Justin Reagor bd12c17bb0 Update triton client calls to pass along context 2017-05-05 11:20:21 -04:00
Matthew Hooker 80d6cd91fd
remove unneeded keypair var 2017-05-01 10:17:21 -07:00
Ben Phegan c4b8e8e5df Merge branch 'master' into virtualbox_sata_port_count 2017-05-01 09:23:05 +10:00
Matthew Hooker 602fd64c5d
builder/amazon: set flag to delete temporary keypair 2017-04-30 14:24:22 -07:00
Matthew Hooker 7aca9b7f71
builder/azure: replace panics with error returns 2017-04-27 11:04:57 -07:00
James Nugent d2ae36214a builder/triton: Reconcile #4829 and #4838 docs
This changes the default region to match the default from Joyent
documentation.
2017-04-26 15:47:04 -07:00
James Nugent c1cad8726b builder/triton: Better AccessConfig tests
This commit adds an actual public/private key pair for testing since
these are now validated.
2017-04-26 14:08:29 -07:00
James Nugent d9ba951929 builder/triton: Switch to joyent/triton-go library
This commit substitutes the now-deprecated gosdc library for the newer
triton-go library. This is transparent from a user perspective, except
for the fact that key material can now be ommitted and requests can be
signed with an SSH agent. This allows for both encrypted keys and ECDSA
keys to be used.

In addition, a fix is made to not pass in an empty array of networks if
none are specified in configuration, thus honouring the API default of
putting instances with no explicit networks specified on the Joyent
public and internal shared networks.
2017-04-26 14:02:03 -07:00
Matthew Hooker 9f992b8f80
go files are 0644 2017-04-25 12:50:58 -07:00
Christopher Boumenot f0e5f75b06 Update TODO.md 2017-04-24 14:19:24 -07:00
Bryon Ross d092044834 Help ensure VMX builder properly removes mounted CDs on OS X
Pull request 1504 describes a workaround for a potential race condition in which the VMX builder can fail to remove mounted floppies or CDs. This workaround was enabled for all operating systems except OS X. Since this issue can also occur on OS X, also apply the workaround on it.
2017-04-19 16:27:16 -07:00
zhuzhih2017 d646e1d035 refactor the code according hashicorp rename the repository 2017-04-18 15:14:45 +08:00
Rickard von Essen a3f70b874b
Spelling (context) 2017-04-09 20:38:19 +02:00
Rickard von Essen 5ee212c85f
Inlined ctx 2017-04-09 20:33:05 +02:00
Luke Farnell 5b7ec545c5 Added monitoring and updated godo 2017-04-08 15:52:57 -04:00
Matthew Hooker da8c4004f0
builder/amazon: numbers are valid in ami name 2017-04-05 12:39:16 -07:00
Matthew Hooker bc3510b473
fix spelling
closes #4767
2017-04-05 12:01:02 -07:00
Matthew Hooker 3f6b5165f2
add affirmative test case for #4762 2017-04-04 22:08:09 -07:00
Craig Barr d9041bda0c Improved the test for special character so that it doesn't get halted by less than 3 character check 2017-04-05 11:06:59 +10:00
Craig Barr 7911cfa94b Formatting as per make fmt 2017-04-05 11:02:23 +10:00
Craig Barr fdae6858c8 conforming to the standard for imports 2017-04-05 10:53:58 +10:00
Craig Barr df6337e8ab Added AMIName validation (issue 4761) 2017-04-05 10:46:44 +10:00
Matthew Hooker 81522dced0
move packer to hashicorp 2017-04-04 13:39:01 -07:00
Matthew Hooker bce03492d9
remove references to ServiceAccountEmail 2017-04-03 11:22:00 -07:00
Rickard von Essen 77dc8b84c1
builder/googlecompute: Revert to using default service account
Fixes issue with cross Project builds.

Closes #4608

Regression introduced in PR #3639
2017-04-02 17:52:14 +02:00
Matthew Hooker 6f27f67346
more fixes from errcheck 2017-03-29 13:38:31 -07:00
Matthew Hooker 4fcbf75da9
s/non existent/nonexistent/ 2017-03-29 12:38:33 -07:00
Matthew Hooker cc11ec3566
check for a couple errors 2017-03-28 20:36:21 -07:00
Matthew Hooker 35578d9ed1
remove unnecessary type conversions 2017-03-28 20:36:21 -07:00
Matthew Hooker bf64d7bdc2
automagic simplification 2017-03-28 20:36:20 -07:00
Matthew Hooker 79287d7e47
simplify some code 2017-03-28 20:36:20 -07:00
Matthew Hooker 0149f679de
Print instead of Printf with no dynamic first variable. 2017-03-28 20:36:20 -07:00
Matthew Hooker d1b20b3d9c
remove a bunch of dead code.
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
Matthew Hooker 230079f73a
spell fixes 2017-03-28 20:36:19 -07:00
Matthew Hooker e4aa2a34ca
builder/amazon-chroot: nullable copy_files
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
Matthew Hooker 35480e21b2
fix typo 2017-03-24 11:56:49 -07:00
Matthew Hooker 0ad6b169bc
builder/virtualbox: retry removing floppy controller 2017-03-23 23:58:23 -07:00
Matthew Hooker 74c8c585f5
builder/amazon: report tag creation 2017-03-23 16:12:59 -07:00
Ben Phegan 0c777a1d63 Fix for DriverMock not implementing Driver 2017-03-23 12:11:19 +11:00
Ben Phegan 67eb600c08 Add sata_port_count so that a SATA controller can be created with more than 1 port. The default of prevents additional drives being added. Default preserved if not overridden. 2017-03-22 23:09:25 +11:00
Matthew Hooker 8b763032ce
builder/hyper-v don't wait for shutdown to return.
Mirrors work done in #4436
2017-03-20 15:32:42 -07:00
Matthew Hooker 68e2b150cd
builder/virtualbox: allow skipping upload of version file 2017-03-16 18:14:11 -07:00
Rickard von Essen 8c2a8f5f81 Merge pull request #4655 from lbordowitz/ostk-sshca
OpenStack: Add ssh agent support
2017-03-14 21:07:03 +01:00
Rickard von Essen 6cd3cb18da
builder/openstack: validate ssh key name/file
This is a port for OpenStack of PR #4665
2017-03-14 20:47:40 +01:00
Matthew Hooker bd76b7bb6f
builder/amazon: validate ssh key name/file
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.

When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
Rickard von Essen 4c5461102a
amazon: Added (more) support for SSH Agent and temporary keypair names 2017-03-13 07:29:59 +01:00
zhuzhih2017 0400ebae95 Fix the code according PR review 2017-03-12 10:22:25 +08:00
Rickard von Essen a047916944 Merge pull request #4621 from hui-yang/disk-type
builder/parallels-iso: Configuration of disk type, plain or expanding
2017-03-10 19:32:41 +01:00
Larry Bordowitz c5b8a1069a Add ssh agent to enable SSH-CA authentication. 2017-03-10 08:45:50 -08:00
Matthew Hooker 50d9546658
builder/amazon: set force_deregister to true on -force 2017-03-09 14:24:49 -08:00
Matthew Hooker 597b7ad8c5
builder/hyper-v: validate output dir in step, not in config
essentially same work as #2233
2017-03-08 23:52:34 -08:00
Matthew Hooker c5ddbacb62 Merge pull request #4318 from Tadas/fix-hyperv-admin
Check for 'Hyper-V Administrators' security group
2017-03-08 23:35:17 -08:00
Matthew Hooker 9e8b602f28 Merge pull request #4643 from rickard-von-essen/issue-4620
googlecompute: Correct values for on_host_maintenance
2017-03-08 14:17:51 -08:00
Rickard von Essen eac5b6392d googlecompute: Correct values for on_host_maintenance
If preemptible is true then on_host_maintenance must be TERMINATE.

Also corrected order in docs.

Closes #4620
2017-03-08 19:44:07 +01:00
Rickard von Essen 2300b102b7 amazon: Step Region Copy crashing on device mapping
Closes #4635
2017-03-08 18:12:37 +01:00
huiyang b3c6ef9f6b Skip disk compaction for plain disks 2017-03-07 18:22:23 -08:00
huiyang 52d4514d6a builder/parallels-iso: Configuration of disk type, plain or expanding 2017-03-03 15:32:51 -08:00
zhuzhih2017 5e44a28a42 fix the missing access key for testcase 2017-03-03 17:56:48 +08:00
zhuzhih2017 fadfb696dd Add packer plugin which support alicloud ecs images 2017-03-03 16:56:17 +08:00
Matthew Hooker 8cc2ed7d6e
vmware/esx: try for longer to connect to vnc port 2017-02-28 22:21:19 -08:00
Matthew Hooker 9c027aa70b Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
James Nugent e856339309 build/amazon-ebssurrogate: Add region copy, attributes, tags steps
As pointed out in the initial code review of #4351, some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:

- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`

We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
James Nugent 1eec5bf058 builder/amazon-ebssurrogate: Exclude duplicate root volume
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
Matthew Hooker fd1b00a0d1
use aws helper method 2017-02-26 19:33:34 -08:00
Matthew Hooker 61976dfd86 Merge pull request #4578 from life360/enable_ena
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
Matthew Hooker ed92055372 Merge pull request #4532 from mitchellh/vmipgetagain
builder/vmware: don't cache ip address so we know if it changes
2017-02-26 18:46:46 -08:00
Matthew Hooker 1f2df5c174 Merge pull request #4536 from mitchellh/vmwareextraopts
builder/vmware: allow extra options for ovftool
2017-02-26 18:45:40 -08:00
Matthew Hooker 6a7c37beb6
builder/amazon-chroot: support encrypted boot volume 2017-02-26 17:48:13 -08:00
Matthew Hooker f62d0abf4e Merge pull request #4560 from guessi/deprecated_option_tag
Conditional ignore `force` flag for `docker-tag`
2017-02-26 17:43:25 -08:00
Matthew Hooker 2cb9b32acf
don't attempt to delete non-existant key when using agent auth 2017-02-26 17:38:22 -08:00
Matthew Hooker f95514c120
fix ssh agent authentication
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
Aaron Stone 1cc3cdf7b5 Always set both SRIOV and ENA when Enhanced Networking is enabled
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).

Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
Richard Owen 33a4c2e13b Change EC2 WindowsPasswordTimeout to 20 minutes
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
James Nugent 635aeb765b amazon/ebssurrogate: Add New Builder
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
Matthew Hooker 3409ea76ee Merge pull request #4564 from wtsi-hgi/fix/4551-openstack-builder-reuse-ips
add reuse_ips option for openstack builder
2017-02-21 15:20:10 -08:00
Matthew Hooker 2381bfa8ad Merge pull request #4518 from AlexLov/bugfix_image_family
[googlecompute] fix bug of creating image from custom image_family
2017-02-21 10:58:23 -08:00
Joshua Randall e9cfaa2730 add reuse_ips option for openstack builder
add reuse_ips option and use it to control whether openstack builder
will attempt to reuse existing unassigned floating ips rather than
allocating a new one.

fix #4551
2017-02-16 12:44:03 +00:00
guessi 66615e3f56 reuse the func DockerDriver.Version() 2017-02-16 08:26:44 +08:00
guessi 5eae809b0c improve description 2017-02-16 01:14:21 +08:00
guessi c5e01da3c6 Conditional ignore `force` flag for `docker-tag`
`docker tag -f` will now become an error, since it was removed after
upgrading docker daemon to 1.12.0 (or later)

this PR is to bypass `force` flag if docker >= 1.12.0 was detected

reference:
- https://docs.docker.com/engine/deprecated/#/f-flag-on-docker-tag

Signed-off-by: guessi <guessi@gmail.com>
2017-02-16 00:50:46 +08:00
Matthew Hooker 4f92b9fb61
Merge branch 'pr/4544' 2017-02-10 12:11:43 -08:00
Dimitri Rudnev 2009fcd9df OnHostMaintenance, googlecompute updating documenation , additional option for validation and setting defaults 2017-02-10 11:57:15 -08:00
Dimitri Rudnev bab590c177 Adding OnHostMaintenance option for googlecompue builder 2017-02-10 10:58:57 -08:00
Matthew Hooker 0ed84f843e
builder/vmware: allow extra options for ovftool 2017-02-10 00:22:20 -08:00