Wilken Rivera
78642536b4
CODEOWNERS: Add code owner for tencentcloud
2020-04-14 11:02:04 -04:00
Adrien Delorme
840e67f775
HCL2: when we see a map generate an attribute spec instead of a block spec ( #9035 )
...
* mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec
this will alow to do
tags = {
key = "value"
}
instead of
tags {
key = "value"
}
This will also enable using variables directly for those tags
* generate code
* update tests
2020-04-14 16:05:13 +02:00
Wilken Rivera
5075fc6ff7
Merge pull request #9059 from hashicorp/d-update-getting-started
...
docs/getting-started: Update PATH install instructions
2020-04-14 08:34:54 -04:00
Wilken Rivera
9eccbb4cfe
docs/getting-started: Update PATH install instructions
2020-04-14 06:46:29 -04:00
Wilken Rivera
c9c0ee65d3
circle-ci: update ci-lint steps ( #9043 )
...
* new-from-rev option is showing inconsistent results on circle and
locally. This change moves to a custom command `script/lint.sh` that gets a list of added
go files and pipes them to golangci-lint for testing.
* Add a git fetch as a step before retrieving merge-base changes to fix
the issue described at https://discuss.circleci.com/t/checkout-script-adds-commits-to-master-from-circle-branch/14194/2
* Moved source code out of GOPATH to ensure go mod support and reduce
the risk of having golangci-lint trying to scan all of the files within
GOPATH. This was an issue in the past, in changing it I found less OOM
issues on circle.
2020-04-14 12:03:22 +02:00
Wilken Rivera
cc257387f1
Merge pull request #9056 from jhawk28/bug_9051
...
clean up documentation for new vsphere NIC and storage params
2020-04-13 14:44:10 -04:00
Joshua Foster
7f0dbdebb2
clean up documentation for new NIC and storage params
...
adding examples, updating .gitattributes so *.mdx files have LF endings for windows
2020-04-13 14:28:50 -04:00
Marc Carmier
a1d14c75f4
Update vsphere documentation with link to the `vsphere-iso` builder ( #9041 )
2020-04-10 13:03:55 -04:00
Wilken Rivera
6b52df0c50
update changelog
2020-04-10 12:38:21 -04:00
Wilken Rivera
be6fe60306
Merge pull request #9037 from hashicorp/fix_9032
...
golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform
2020-04-10 06:32:53 -04:00
Paul Meyer
7e949182a8
Update CHANGELOG.md
2020-04-09 14:43:49 -07:00
Paul Meyer
df47fd5076
Merge pull request #9021 from paulmey/azure-chroot-shared-image-destination
...
[azure/chroot] Add azure-chroot shared image destination
2020-04-09 14:42:13 -07:00
Megan Marsh
217dcbb97f
golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform
2020-04-09 14:38:17 -07:00
Paul Meyer
621bd8ccac
Fix error message grammar
2020-04-09 20:55:10 +00:00
Paul Meyer
89a8238a07
Fix artifact output
2020-04-09 20:54:50 +00:00
Paul Meyer
47107e6355
Default polling delay 5 sec
2020-04-09 20:37:23 +00:00
Vijay Rajah
9209826bfe
Update the doc with more info
2020-04-10 00:34:56 +05:30
Megan Marsh
73c349d09c
Merge pull request #8908 from hashicorp/fix_4795
...
provisioner/powershell: Add cleanup step to remove any temporarily created scripts
2020-04-09 08:56:19 -07:00
Adrien Delorme
2af40c762b
HCL2: pass on builder type and name ( #8956 )
...
* sets `packer_build_name` and `packer_builder_type` variables for builder provisioners and post-processors in HCL2
* allows to use the new `${source.type}` and `${source.name}` variables in HCL2
* fixes #8932
Note that the common.PackerConfig is used everywhere and was not set for HCL2, this had some implications:
For #8923 you can see the issue here:
dde74232f2/builder/lxd/config.go (L61-L63)
More random examples of where this could cause an issue :
0785c2f6fc/provisioner/ansible-local/provisioner.go (L380-L381)
b4efd13a4d/builder/amazon/ebs/builder.go (L232-L236)
* [All references to PackerConfig.PackerBuildName](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L7:2&tab=references )
* [All references to PackerConfig.PackerBuilderType](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L8:2&tab=references )
2020-04-09 11:14:37 +02:00
Wilken Rivera
c358682411
Merge pull request #9030 from hashicorp/document_headless_vmware
...
update docs for headless to help users know they may need to launch the gui
2020-04-08 17:37:22 -04:00
Paul Meyer
4ffe5611b8
Add more tests
2020-04-08 21:05:26 +00:00
Megan Marsh
a48c0ecf49
update docs for headless to help users know they may need to launch the gui
2020-04-08 13:53:19 -07:00
Vijay Rajah
1e66a1b355
Fix linting & code generation
2020-04-09 00:00:13 +05:30
Vijay Rajah
56bf8bd686
Merge branch 'set_azure_custom_res_names' of github.com:vijayrajah/packer into set_azure_custom_res_names
2020-04-08 23:54:21 +05:30
vijayrajah
a3c580f2ac
Merge branch 'master' into set_azure_custom_res_names
2020-04-08 23:51:58 +05:30
Vijay Rajah
53f54000e6
generate spec & fix typo
2020-04-08 23:42:49 +05:30
Megan Marsh
e845632d3d
Merge pull request #9027 from alrs/fix-powershell-provisioner-err
...
provisioner/powershell: Test Error Improvements
2020-04-08 10:20:50 -07:00
Lars Lehtonen
49f28c9439
provisioner/powershell: fix dropped error
...
provisioner/powershell: improve error message
2020-04-08 10:04:08 -07:00
Thor K. H
2a40f471b7
Add vgpu_profile support for using GRID vGPUs
...
It hooks directly into Configure, common for both vsphere-clone and
vsphere-iso.
Note that acceptance tests are still missing.
2020-04-08 17:11:14 +02:00
Wilken Rivera
4a46d6ff7b
docs/provisioner/powershell: Add documentation for `skip_clean` option
2020-04-08 10:23:15 -04:00
Wilken Rivera
fe721d8e11
test/provisioner/powershell: Add acceptance test for powershell provisioner cleanup
...
Passing Tests
```
--- PASS: TestAccPowershellProvisioner_basic (282.02s)
--- PASS: TestAccPowershellProvisioner_basic/testing_amazon-ebs_builder_against_powershell_provisioner (282.01s) PASS
ok github.com/hashicorp/packer/provisioner/powershell 282.046s
```
Failing tests on master
```
2020/04/08 09:59:34 Uploading file to 'c:/Windows/Temp/script.bat'
2020/04/08 09:59:36 [INFO] starting remote command: set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs"
&& "c:/Windows/Temp/script.bat"
2020/04/08 09:59:36 ui: amazon-ebs:
2020/04/08 09:59:36 ui: amazon-ebs: C:\Users\Administrator>dir C:\Windows\Temp\packer-*.ps1
2020/04/08 09:59:36 ui: amazon-ebs: Volume in drive C has no label.
2020/04/08 09:59:36 [INFO] command 'set "PACKER_BUILDER_TYPE=amazon-ebs"
&& set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat"' exited with code: 0
2020/04/08 09:59:36 ui: amazon-ebs: Volume Serial Number is 46CA-4083
2020/04/08 09:59:36 ui: amazon-ebs:
2020/04/08 09:59:36 ui: amazon-ebs: Directory of C:\Windows\Temp
2020/04/08 09:59:36 ui: amazon-ebs:
2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 102 packer-acc-test-script-test.ps1
2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 76 packer-acc-test-vars.ps1
2020/04/08 09:59:36 ui: amazon-ebs: 2 File(s) 178 bytes
2020/04/08 09:59:36 ui: amazon-ebs: 0 Dir(s) 9,735,806,976 bytes free
2020/04/08 09:59:36 ui: ==> amazon-ebs: Provisioning step had errors: Running the cleanup provisioner, if present...
2020/04/08 09:59:36 ui: ==> amazon-ebs: Terminating the source AWS instance...
2020/04/08 10:00:09 ui: ==> amazon-ebs: Cleaning up any extra volumes...
2020/04/08 10:00:09 ui: ==> amazon-ebs: No volumes to clean up, skipping
2020/04/08 10:00:09 ui: ==> amazon-ebs: Deleting temporary security group...
2020/04/08 10:00:10 ui: ==> amazon-ebs: Deleting temporary keypair...
2020/04/08 10:00:11 ui error: Build 'amazon-ebs' errored: Script exited
with non-zero exit status: 0.Allowed exit codes are: [1]
2020/04/08 10:00:11 machine readable: error-count []string{"1"}
2020/04/08 10:00:11 ui error:
==> Some builds didn't complete successfully and had errors:
2020/04/08 10:00:11 machine readable: amazon-ebs,error []string{"Script
exited with non-zero exit status: 0.Allowed exit codes are: [1]"}
2020/04/08 10:00:11 ui error: --> amazon-ebs: Script exited with
non-zero exit status: 0.Allowed exit codes are: [1]
```
test: Fix windows-shell command
2020-04-08 10:05:54 -04:00
Wilken Rivera
91c8afda8e
provisioner/elevated: Add cleanup logic to remove elevated user scheduled task artifacts
2020-04-08 00:23:40 -04:00
Wilken Rivera
11db6014fa
provisioner/powershell: Update remote clean up logic
...
* Add retry logic so that the provisioner will retry if it fails to upload/execute because of some restart provisioner step
* Add a testConfigWithSkipClean for testing that the provisioner executes the correct commands
* Add a test case for toggling the "skip_clean" config option
2020-04-08 00:23:40 -04:00
Wilken Rivera
f6a61e2511
provisioner/powershell: Add post clean up step to remove temp script files
2020-04-08 00:23:40 -04:00
Wilken Rivera
3892e0905a
Merge pull request #9022 from hashicorp/document_boot_wait
...
properly document how to set boot_wait to 0s
2020-04-08 00:10:34 -04:00
Megan Marsh
346dcae78e
make generate
2020-04-07 17:01:23 -07:00
Megan Marsh
6fc3c4eb49
properly document how to set boot_wait to 0s
2020-04-07 16:43:33 -07:00
Paul Meyer
b12aedcda9
Remove lint
2020-04-07 23:09:42 +00:00
Paul Meyer
5c89d22fa2
generated & docs
2020-04-07 23:05:09 +00:00
Megan Marsh
5b8113ab0f
Merge pull request #9006 from hashicorp/provisioner_acc_contributing
...
Add how to write provisioner's acceptance tests to CONTRIBUTING docs
2020-04-07 16:02:16 -07:00
Paul Meyer
2240ead39c
[azure/chroot] Add shared image output
2020-04-07 22:49:24 +00:00
Paul Meyer
73edd9d3d2
Make skip_cleanup generic
2020-04-07 22:49:24 +00:00
Paul Meyer
90188bb18d
add func for searching string slice
2020-04-07 22:49:24 +00:00
Paul Meyer
a3d8bf27e1
Add snapshot and gallery clients
2020-04-07 22:49:24 +00:00
Paul Meyer
cfe37057bd
Use const for statebag key
2020-04-07 22:49:24 +00:00
Paul Meyer
f3703a775f
Use subscription id from client set
2020-04-07 22:49:24 +00:00
Paul Meyer
6131301fdd
Standardize compute SDK version
2020-04-07 22:49:24 +00:00
Paul Meyer
f73a673b99
Extract build steps generation
...
Add tests for build step generation
2020-04-07 22:49:21 +00:00
Paul Meyer
c167ef91ce
Move PIR :latest resolution to step
2020-04-07 22:49:21 +00:00
Paul Meyer
f0ec912ba6
Make VirtualMachineImagesClient easier to mock
2020-04-07 22:49:21 +00:00