b6d21ecd63
validate that required fields are present
2018-01-26 08:53:24 -08:00
25bc1da8fe
remove unsused access config
2018-01-26 08:48:23 -08:00
de2e5edf2e
remove errant change in amazon builder
2018-01-26 08:43:51 -08:00
4622bb4585
return no artifact if no snapshot was created
2018-01-25 16:32:37 -08:00
77277ebc98
add logging behind "PACKER_OCI_CLASSIC_LOGGING" env var
2018-01-25 16:32:34 -08:00
0fad49e897
simplify
2018-01-25 15:05:36 -08:00
4dc42942f5
fix multistep path
2018-01-25 14:46:02 -08:00
6dc0bd759a
import context
2018-01-25 14:43:55 -08:00
dd2384483b
add context to steps
2018-01-25 14:42:39 -08:00
00db189c9c
add docs page
2018-01-25 14:34:03 -08:00
1fffbacdd3
fix ordering of deleting security rules and lists
2018-01-25 14:34:03 -08:00
76ea73c5b2
I don't think we need to delete this artifact right now
2018-01-25 14:34:03 -08:00
603881d990
add oci/classic artifact
2018-01-25 14:34:03 -08:00
44befb0857
rename
2018-01-25 14:34:02 -08:00
b9a90b9261
Check for error when creating ip reso
2018-01-25 14:34:02 -08:00
7d23cfae0a
allow user to add a security list for SSH access; add cleanup for packer-generated rules and lists
2018-01-25 14:34:02 -08:00
531cb2244d
add separated out steps
2018-01-25 14:34:02 -08:00
53ff257cf0
it LLIIIIIIIIIVES
2018-01-25 14:34:02 -08:00
89159f3a87
fix bugs in cleanup
2018-01-25 14:34:02 -08:00
f6c60aac78
clean up instance
2018-01-25 14:34:01 -08:00
256382547b
snapshot step works
2018-01-25 14:34:01 -08:00
69ba710c2a
PROGRESS! Now it only fails on the snapshot step
2018-01-25 14:34:01 -08:00
f208a071a4
fix communicator
2018-01-25 14:34:01 -08:00
6556a851dc
fix ssh key handling
2018-01-25 14:34:01 -08:00
a8a0072049
oops need to add this moved file to git
2018-01-25 14:34:01 -08:00
8b420944c5
debugs
2018-01-25 14:34:00 -08:00
46c3113613
it compiles :)
2018-01-25 14:34:00 -08:00
8aa716cd4c
stub out step_snapshot
2018-01-25 14:33:43 -08:00
007e8f7c14
finish stubbing out step_create_IP_reservation
2018-01-25 14:33:43 -08:00
7d72870179
add buffer to read template into
2018-01-25 14:33:42 -08:00
0117f53721
add error message
2018-01-25 14:33:42 -08:00
a66dfe1972
fleshing out step_create_instance
2018-01-25 14:33:42 -08:00
4fe89be32a
fleshing out steps
2018-01-25 14:33:42 -08:00
75ee66f934
add stubbed out steps
2018-01-25 14:33:42 -08:00
3bf431a423
construct OCI client
2018-01-25 14:33:41 -08:00
9e8d845c03
create instance reservation
2018-01-25 14:33:41 -08:00
543caf3ec5
WIP OCI Classic builder
2018-01-25 14:33:41 -08:00
eafda52411
use amazon steps from master
2018-01-24 17:09:18 -08:00
8cd403425e
test fixes WIP
2018-01-24 17:09:17 -08:00
5d48d658b4
Wire context through misc steps
...
Some steps actually need to pass the context around, so let's create
a ctx variable and pass it.
2018-01-24 17:09:17 -08:00
7a189a83a1
fix imports
...
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
a831d522be
change run signatures
...
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.
`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
a0c625ea44
Revert "working with opt-in"
...
This reverts commit 4068ffdaf541354e75507add7ca0b193993fcd52.
2018-01-24 17:09:16 -08:00
e98f201602
working with opt-in
2018-01-24 17:09:16 -08:00
366dc3da0a
move multistep imports to helper.
...
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
807e88245b
trying to add context to state bag
2018-01-24 17:09:15 -08:00
5967732442
Merge pull request #5795 from stack72/bump-triton-go-deps
...
builder/triton: bump triton-go dependencies
2018-01-23 14:40:03 +00:00
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
20f9ef3445
builder/triton: bump triton-go dependencies
...
This introduces a new triton-go errors package so we can error handle our code in a better way
2018-01-17 16:55:00 +02:00
c17f827e1d
Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols.
2018-01-16 13:37:32 -06:00
3cf448f6ec
Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path.
2018-01-16 13:37:32 -06:00
46a5ca30e5
Removed call to filepath.Rel(...) in builder/vmware/iso/step_create_vmx.go
2018-01-16 13:37:32 -06:00
5d97b105a8
Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist.
2018-01-16 13:37:31 -06:00
d275bacb0f
go fmt builder/vmware/iso/step_create_vmx.go to calm down Travis CI.
2018-01-16 13:37:31 -06:00
e940dc7e42
Fixed a config_test that should've failed but didn't because ftp:// uris work now. HeH!
2018-01-16 13:37:31 -06:00
281dd1258a
Added proper support for downloading via a Windows UNC path or a relative uri.
...
Added proper support for validating a downloadableURL containing a UNC or relative uri.
Removed the workaround for an earlier Go issue that had remained dormant in common/download.go (issue #5927 ).
When building a .vmx file via the vmware-iso builder, transform the path to the correct os-formatted one (using filepath.FromSlash).
2018-01-16 13:36:17 -06:00
cea2ab8c6d
move kms/encrypted validation to block devices
2018-01-12 15:10:51 -08:00
e968f9d6cc
spelling/style fixes
2018-01-12 14:26:56 -08:00
f6772f06be
builder/amazon: Raise error when ebsvolume kms_key_id is without encrypted = true
2018-01-11 20:27:38 -08:00
2ac59b3c27
builder/amazon: Added KmsKeyID to BlockDevice
...
+ Adds kms_key_id to list of options
+ Tests that configuraiton is set along with encrypted
+ Updates documentation on ebsvolume builder
2018-01-11 20:27:38 -08:00
b909e9d4e6
remove not used variables
2018-01-12 10:15:40 +09:00
26030d750c
update err format
2018-01-12 10:12:47 +09:00
2ce3ca1538
Merge pull request #5773 from hashicorp/fix5705
...
Use SDK's InstanceReady waiter
2018-01-11 12:12:03 -08:00
fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
...
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
5189d65467
Support Naver Cloud Platform
2018-01-11 18:57:53 +09:00
3ace5bb91b
simplify FileExistsLocally
2018-01-10 16:11:17 -08:00
f5ea1e8312
Use WaitUntilInstanceReady waiter
2018-01-10 15:57:31 -08:00
216c44b153
fix FileExistsLocally
2018-01-09 15:47:07 -08:00
dfd5f07145
fix ebs acc test
2018-01-08 12:27:10 -08:00
e164621bfe
log line to help prevent confusion when guest_additions_url is set from env variable that is empty
2018-01-05 09:19:38 -08:00
ff3cbbf28c
Merge pull request #5757 from arizvisa/virtualbox-guest_additions_url-interpolation
...
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-04 15:39:29 -08:00
c5bcb97d06
"borrow" access config code from terraform.
...
This gives us a few benefits:
* timeout early if metadata service can't be reached
* report which auth provider we're using
* give much better errors if something goes wrong
2018-01-04 15:04:07 -08:00
98c2a2d1f7
builder/aws: catch static credential errors early.
...
If we're using static credentials, either both the access key and secret key must be set, or neither of them should be.
2018-01-04 11:50:27 -08:00
4f3b470804
add helper function to manage validation of filepaths created using DownloadableURL
2018-01-03 16:53:47 -08:00
4fcd542d0c
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-02 21:09:41 -06:00
c3467b686c
builder/triton: Add support for Triton RBAC
...
Fixes : #5737
Triton allows for subusers to be granted access to your account. This PR allows a user to be specified
2017-12-29 21:20:40 +02:00
a90376f12a
Attach keypair before starting instance in alicloud builder
...
[Documentation of `AttachKeyPair`](https://goo.gl/gC3srG ) states that
attaching keypair to running instance takes effect after reboot.
So we need to attach keypair before starting instance to avoid an
additional restart.
2017-12-29 10:13:26 +08:00
7250c4f7f0
Add Intel HAXM support to QEMU builder
2017-12-29 11:51:57 +11:00
05fcecb1e7
Merge pull request #5666 from kwilczynski/remove-ecr-credentials-from-logging
...
docker: Remove credentials from being shown in the log.
2017-12-26 08:07:37 +01:00
f3dea272d9
Set session in state bag
...
We can construct connections to arbitrary regions from it
2017-12-19 11:32:33 -08:00
f6c401a143
don't pass in accessconfig
2017-12-19 11:32:32 -08:00
1c352726d7
Merge pull request #5719 from rchenv/issue5606
...
Ensure all AWS connections are configured alike
2017-12-19 11:32:24 -08:00
3e92b1374e
issue5606: follow the convention to use AccessConfig to create new aws session for step_create_tags etc.
2017-12-19 10:34:12 -08:00
8bcb469b8b
builder/amazon: Added new region Paris - eu-west-3
2017-12-19 10:00:03 +01:00
c338cb79d0
Initial commit of feature to allow MAC address specification for HyperV builders
2017-12-15 13:24:15 +11:00
c2ecdd98c6
5691: Invalid image URLs make Azure builder crash
2017-12-12 20:12:53 +11:00
54f059d3d4
Add support for skip export
2017-12-11 11:24:59 +05:30
567b566c23
docker: Remove AWS credentials and Session Token from being shown in the log.
...
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-10 20:55:03 +01:00
63f791570a
Merge pull request #5665 from kwilczynski/remove-sts-token-from-logging
...
amazon: Remove Session Token (STS) from being shown in the log.
2017-12-10 06:50:42 +01:00
d069dc5b7c
handle holding a-z keys, such as for boot options (vmware builder)
2017-12-09 20:51:49 -06:00
f216330ba3
spot instance ena/sriov checking for all other builders
2017-12-08 14:56:19 -08:00
4b1d8e3fe8
don't allow enhanced networking flags for spot instances.
2017-12-08 13:38:49 -08:00
73b98b2a04
use waiter to wait for ebs instances to stop
2017-12-08 13:38:48 -08:00
dada63801b
also use waiter code for spot instances
2017-12-08 13:38:48 -08:00
9e61005f7c
Merge pull request #5660 from hashicorp/fix_5625
...
modify validation to allow user to have the original region in the am…
2017-12-08 13:36:10 -08:00
5df2e040d0
Update amazon run_config.go absent ssh_private_key_file error
2017-12-08 08:51:27 -08:00
4acc98a729
add super key (vmware builder)
2017-12-07 23:15:56 -06:00
2c1c7b9659
Merge pull request #5630 from johndaviesco/winrm_no_proxy
...
Winrm no proxy
2017-12-07 15:41:16 -08:00
a90c45d9bb
Wait until source instance OK before continuing
2017-12-07 12:31:50 -08:00
7b5c0900ef
Correctly set aws region if given in template along with a profile.
2017-12-07 11:12:57 -08:00
1202bdd080
Merge pull request #5661 from jamielennox/no-location-for-existing-rg
...
Azure: Don't provide location for build_resource_group_name
2017-12-05 09:52:45 -08:00
05327b7524
amazon: Remove Session Token (STS) from being shown in the log.
...
This commit adds a change which ensures that the Session Token
config struct item is removed from log output.
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-04 22:14:38 +01:00
d043c37ad4
Azure: Don't provide location for build_resource_group_name
...
Location is required by default because you must specify where to create
the resource group containing the packer resources.
When using build_resource_group_name you are specifying that packer
should use an existing resource group and so the location that resources
are in can be determined by fetching the information from the existing
group.
It is forbidden to pass both variables as it is easier and more
intuitive that the location comes from the group rather than ignore a
parameter.
Closes : #5655
2017-12-04 11:22:54 +11:00
8a30b3db80
Merge pull request #5456 from GoSecure/vmware-iso-improved-network-logging
...
vmware-iso builder: Logging on network errors on connection refused
2017-11-30 16:31:30 -08:00
1c681fc096
tests
2017-11-30 14:08:48 -08:00
556da47d35
modify validation to allow user to have the original region in the ami_regions list
2017-11-30 13:51:33 -08:00
da0c13f622
azure: delete keyvault deployment
2017-11-30 01:19:08 -08:00
bdc1fa0527
Merge pull request #5641 from zhuzhih2017/master
...
Add security token supported and TLS handshake timeout support
2017-11-28 11:15:56 +08:00
de0017c37a
Add security token supported and TLS handshake timeout support
2017-11-28 10:32:17 +08:00
10aaa49beb
fixing tests and funky logic 💦
2017-11-28 14:42:14 +13:00
0c787ec9df
Valadating early ⏰
2017-11-28 11:46:32 +13:00
3d5303c60d
Fix tests
2017-11-24 13:24:44 +05:30
b7e3f37b44
Add support for differential disk
2017-11-24 12:44:53 +05:30
75320440ec
adding missing quote 🙏
2017-11-22 15:59:15 +13:00
707ec675b2
ssh interface for amazon builders 🔨
2017-11-22 15:49:38 +13:00
a3c9485062
azure: sanity check resource group names
2017-11-20 15:19:12 -08:00
247da61ad1
Merge pull request #5593 from boumenot/pr-azure-keep-resource-group
...
Azure: Keep temporary resource group.
2017-11-16 17:39:33 -08:00
8985bd45ba
azure: go fmt
2017-11-16 17:32:35 -08:00
ee767e55d1
azure: change literal to constant
2017-11-16 16:36:42 -08:00
2684153cb2
azure: reject bad configuration faster
2017-11-16 16:34:18 -08:00
787f08f39b
azure: add user message to indicate what is being deleted
2017-11-16 16:31:05 -08:00
20390ff1ec
fix vetting for test fail print statements
2017-11-15 17:01:53 -08:00
ab542c07ff
Merge pull request #5547 from egraff/hyperv-patch
...
builder/hyperv/vmcx: missing InterpolateContext
2017-11-15 17:00:55 -08:00
b8bd66d10d
Align virtual disk size for qemu builder
...
When booting from a disk image, the Qemu builder resizes the disk to 40000
which is not a multiple of 1kB. This causes problems while booting from the image.
Updating the default disk size to 40960 fixes this issue
2017-11-15 15:00:13 -05:00
b07a0cd6f0
fix tests
...
always sort telemetry options
2017-11-14 16:39:03 -08:00
6756df9510
use url library instead of parsing string naiively
2017-11-13 12:57:53 -08:00
771349e58c
fix error message
2017-11-13 12:52:47 -08:00
764be03876
didn't mean for this error message to get changed
2017-11-13 12:42:57 -08:00
0d18de2942
do validation in vmx config stage
2017-11-13 12:42:57 -08:00
f0299ba713
Adding GCE container optimized os image project
2017-11-12 00:45:22 -08:00
f43f3155d4
Remove breaking debug statement
2017-11-10 11:04:31 +11:00
f146e5903f
Merge pull request #5567 from bennu/vm-template-with-export-vm
...
enable vsphere-template post processor to work with export behavior
2017-11-09 15:24:41 -08:00
e5c59468df
Merge pull request #5343 from evandbrown/pr-googlecompute-subnetworks
...
Interpolate network and subnetwork values
2017-11-09 12:10:41 -08:00
aae324e4e7
Merge pull request #5562 from hashicorp/fix5558
...
don't set region from metadata if profile is set.
2017-11-09 10:22:15 -08:00
0e706320ad
Issue #5045 - Add build_resource_group_name
...
* Created a new parameter for using existing resource groups
* Implemented logic to ensure temp_ and build_ can't both be used
* Implemented logic to ensure they can only be used in correct context
* Implemented tests for this logic
* Updated where required to ensure the process works
2017-11-09 22:20:09 +11:00
23f4d187e2
validating keep_registered and fixing skip_export issues
2017-11-08 15:57:34 -03:00
450a233303
builder/triton: Wait for ImageCreation State
...
A bug was reported to Joyent, that sometimes packer UI reports that an image was created but it wasn't actually available in Triton for use. We believe that there was a bug uploading that image to Manta but that the metadata of the image was already populated and thus packer was reporting success as it was just checking for the metadata presence
This PR changes Packer to wait for the state of the image to be `active` to make sure that it has fully uploaded and is ready for use
```
==> triton: Stopping source machine (61647c3c-f2bf-4e30-b4bc-f076d3b01522)...
==> triton: Waiting for source machine to stop (61647c3c-f2bf-4e30-b4bc-f076d3b01522)...
==> triton: Creating image from source machine...
==> triton: Waiting for image to become available...
==> triton: Deleting source machine...
==> triton: Waiting for source machine to be deleted...
Build 'triton' finished.
==> Builds finished. The artifacts of successful builds are:
--> triton: Image was created: c2537582-34c7-42ea-bd11-b6ed499d5831
```
2017-11-08 16:38:04 +02:00
d00f884e71
Merge pull request #5530 from BaxterStockman/lxc-builder-cli-options
...
Add options to LXC builder for influencing for how containers are built and started
2017-11-07 22:32:17 -08:00
0a24f4eb2e
don't shadow package name
2017-11-07 16:05:43 -08:00
f681faa296
fix tests
2017-11-07 14:57:10 -08:00
545ee45567
debug region we found
2017-11-07 14:51:20 -08:00
c106e7c26c
Don't set region from metadata if profile is set.
2017-11-07 14:33:26 -08:00
52fc0100eb
this is a critical error
2017-11-07 12:52:03 -08:00
13e0c232d4
builder/googlecompute: Test networking interpolation
...
This change pulls the logic that interpolates network and subnetwork
into its own func and adds tests.
2017-11-06 21:22:53 -08:00
f2fed94a71
builder/googlecompute: Derive network and subnetwork IDs locally
...
This change constructs partial URLs for networks and subnetworks if they
are not already partial or full URLs (i.e., they do not contain a '/' in
their name). Network and subnetwork self-links are no longer retrieved
from the API.
Previously, if a user did not provide the network or subnetwork as a
fully-qualified URL (i.e., self-link), the builder would make
compute.(sub)networks.get API calls with the provided identifier to
discover the self-link. This requires the user or service account Packer
is using to have permission to describe those network resources, which
is becoming less common as IAM is used more. Specifically, a user may
have permission to launch a VM into a network/subnetwork, but will not
have permission to call APIs to describe network resources.
2017-11-06 16:41:42 -08:00
bada7b73c1
builder/googlecompute: Selectively set default network
...
If a network is not specified, it should only be set to "default" if a
subnetwork is also not specified.
2017-11-06 16:41:42 -08:00
1b3eb1c34d
builder/googlecompute: Set default network_project_id
...
If network_project_id is not specified in the GCE builder config, it
should default to the project_id.
2017-11-06 16:41:42 -08:00
68fa09c308
Merge pull request #5512 from hashicorp/fix5501
...
builder/virtualbox-ovf retry removing VM.
2017-11-06 15:56:08 -08:00
bdb2509735
Merge pull request #5475 from ChrisLundquist/lxd-publish-properties
...
[Lxd] publish properties
2017-11-06 15:45:56 -08:00
0172a5c82b
Merge pull request #5511 from hashicorp/fix5507
...
remove login_email from docker
2017-11-06 15:34:04 -08:00
Megan Marsh
Matthew Hooker
James Nugent
stack72
Ali Rizvi-Santiago
Jason Wieringa
유성덕
QuantumGhost
Glenn McDonald
Rickard von Essen
Rong Chen
Olivier Bazoud
Ben Phegan
Arjen Schwarz
Vijaya Bhaskar Reddy Kondreddi
Krzysztof Wilczynski
Andrew Pennebaker
Ben Gnoinski
Christopher Boumenot
Jamie Lennox
Christopher Boumenot
zhuzhih2017
John Davies-Colley
Ammar Ansari
Daniel Hess
bugbuilder
Chris Lundquist
Evan Brown