12887 Commits

Author SHA1 Message Date
Megan Marsh
96366ac814
Merge pull request #7922 from stephen-fox/honor-comment-existing-ssh-key-pair
Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'.
2019-07-29 13:22:46 -07:00
Megan Marsh
7c93a5c51e code changed recently so that sometimes the conf is nil. 2019-07-29 13:19:43 -07:00
Megan Marsh
b42701380c add test for nil case 2019-07-29 12:11:59 -07:00
Ruben Tsirunyan
f9d79addac Adding documentation for ansible-galaxy related arguments 2019-07-29 13:23:39 +04:00
Ruben Tsirunyan
1b35c586ce Changes to roles_path option 2019-07-29 13:23:39 +04:00
Ruben Tsirunyan
d247329599 Adding support for installing roles with ansible-galaxy for ansible provisioner 2019-07-29 13:23:39 +04:00
DanHam
088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag 2019-07-28 10:44:24 +01:00
Stephen Fox
9592211bcf Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'.
The 'ssh.KeyPairFromPrivateKey()' function in the 'ssh' helper
library was not honoring the value of the 'Comment' field in the
'FromPrivateKeyConfig' struct. This commit fixes the issue, and
updates unit tests to catch the issue if it happens again.
2019-07-27 15:52:13 -04:00
Thomas Meckel
a876bf3c4e Added documentation for virtualbox-vm builder 2019-07-27 16:08:13 +02:00
Megan Marsh
903a422020
Merge pull request #7917 from hashicorp/cleanup_unused_cancel_funcs
These cancel functions have been obsolete since March 2019
2019-07-26 14:42:06 -07:00
Megan Marsh
7ac17126a0
Merge pull request #7913 from hashicorp/red_herring_EOF_abort
[WIP] Red herring eof abort
2019-07-26 14:36:14 -07:00
Megan Marsh
0f704fb5b2 These cancel functions have been obsolete since merge of c7ce4d598e50d455e8b8383c36dc2ac3b324ebd3 2019-07-26 14:12:58 -07:00
Megan Marsh
90c5da40f2 implement abort logic and printing for the askstep implementation as well 2019-07-26 12:24:03 -07:00
Megan Marsh
a99c0802be
Merge pull request #7914 from shawnmssu/fix_ucloud_builder
UCloud Builder: update api about stop instance
2019-07-26 11:37:36 -07:00
Thomas Meckel
822b72bd14 Added force_delete_snapshot configuration item and the corresponding checks 2019-07-26 12:34:28 +02:00
Thomas Meckel
e7583de847 StepCreateSnapshot.Run() will stop and create an error if the virtual machine is still running
Removed left over code from StepCreateSnapshot.Cleanup()
2019-07-26 12:34:27 +02:00
Thomas Meckel
d9b8623f64 StepShutdown now always waits for the shutdown of the virtual machine to complete, not only if a shutdown command is specified 2019-07-26 12:34:27 +02:00
Thomas Meckel
b873876670 Added test TestSnapshot_EnsureParents
No using asserts NotNil and Nil
2019-07-26 12:34:27 +02:00
Thomas Meckel
6fd0b3e83e Fixed a bug in ParseSnapshotData
Added fuction GetSnapshots
2019-07-26 12:34:26 +02:00
Thomas Meckel
225a140055 Applied correct source format (got fmt) to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
51e5ae69db Corrected method signatures in builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
ab6a163ff2 Added missing newline at end of builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
e9b5332e99 Added missing functions to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
fd5a2db58f Removed commented (obsolete) code from builder\virtualbox\common\driver_4_2.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
5e00253450 Delete stack_test.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
a4d168ec4b Corrected go.mod and modules.txt 2019-07-26 12:34:24 +02:00
Thomas Meckel
4faed184c9 Added github.com/golang-collections/collections to vendor directory 2019-07-26 12:29:48 +02:00
Thomas Meckel
7d3c84e5f9 Changed VirtualBox VM builder according to current builder interface 2019-07-26 12:29:48 +02:00
Thomas Meckel
2ef911f6f0 Fixed bugs in snapshot and builder code 2019-07-26 12:29:47 +02:00
Thomas Meckel
ebd2780e5d implemented first unit tests for snapshot.go 2019-07-26 12:29:46 +02:00
Thomas Meckel
f1f7c4e10c * added function ParseSnapshotData to parse a string representation of a VBox snapshot tree
* fixed bugs
2019-07-26 12:29:46 +02:00
Thomas Meckel
45e2095ae3 Moved parsing of tree string representation to new function in snapshot.go 2019-07-26 12:29:45 +02:00
Thomas Meckel
092e32fe9e First version of reworked snapshot implementation 2019-07-26 12:29:45 +02:00
Thomas Meckel
a6074894f1 Defined struct and first function for enhanced snapshot handling 2019-07-26 12:29:45 +02:00
Thomas Meckel
d3202497ae First working version of virtualbox/vm builder 2019-07-26 12:29:44 +02:00
Thomas Meckel
2a531f8ad6 Merged changes from local branch 2019-07-26 12:29:44 +02:00
mingsheng.su
66f142adf1 update docs 2019-07-26 17:27:58 +08:00
mingsheng.su
59c8911cd5 update api about stop instance 2019-07-26 17:03:57 +08:00
Megan Marsh
9912e569e1 deduplicate loglines that stream both to ui ERROR call and to streaming logs when PACKER_LOG=1 2019-07-25 16:33:02 -07:00
Megan Marsh
54034689ef On abort, return gracefully rather than exiting so that the subprocess doesn't unexpectedly disconnect from the parent and cause a confusing EOF error in the logs 2019-07-25 16:32:16 -07:00
Megan Marsh
7e2ea77634 docs 2019-07-25 13:16:08 -07:00
Megan Marsh
2e3d4bebe7 docs 2019-07-25 13:13:40 -07:00
Megan Marsh
5d4d5a21bf check env for a PACKER_CONFIG_DIR before defaulting to homedir for config 2019-07-25 13:06:41 -07:00
Megan Marsh
d21f4eb888
Merge pull request #7908 from muesli/typo-fixes
Fixed various typos
2019-07-25 12:21:20 -07:00
Megan Marsh
3d22535742
Merge pull request #7884 from jprorama/fix-7171
[WIP] Fix #7171: select instance network on which to assign floating ip
2019-07-25 11:57:24 -07:00
Megan Marsh
166f1de5fd
Merge pull request #7887 from xunleii/f-scaleway-autoremove-volume
Allow removing volume after image creation for Scaleway builder
2019-07-25 11:56:23 -07:00
Megan Marsh
aeceba5fd2
Merge pull request #7906 from grahamking/patch-1
plugins.html.md: Unix dir packer.d -> .packer.d
2019-07-25 11:54:38 -07:00
Megan Marsh
e4c1979708
Merge pull request #7907 from grahamking/patch-2
plugins.html.md: Update docs example to match code example.
2019-07-25 11:53:58 -07:00
Megan Marsh
175d0b817d
Merge pull request #7905 from hashicorp/set_config_dir
make sure we create the temp dir explicitly when we are setting up th…
2019-07-25 11:35:50 -07:00
Christian Muehlhaeuser
216afbaa8b
Fixed various typos
Just a bunch of nit-picky typo fixes.
2019-07-25 06:49:51 +02:00