4992429e8c
Minor comment fixes
2018-05-18 17:34:01 -07:00
00e809cb7e
Refactored the change into a new function
2018-05-18 15:21:49 -07:00
ea9b2a8b5f
review feedback
2018-05-18 12:09:42 -07:00
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
...
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
...
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
667113338a
missed formating
2018-05-18 01:41:00 -07:00
7f2277676a
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:34:12 -07:00
77fe1bffe4
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:25:19 -07:00
de1783240f
Updates to remove space changes
2018-05-18 00:53:44 -07:00
91eed4da52
trim right of the keyvault url
2018-05-18 00:44:25 -07:00
df5cc234fc
updates
2018-05-18 00:39:57 -07:00
1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
...
This reverts commit f342975ff3
2018-05-16 13:52:00 +01:00
2939cd75ae
Revert "Report the result of the disk compaction step"
...
Unfortunately this broke the ability to build on remote (ESXi) hosts.
This reverts commit 08f9d619a9
2018-05-16 12:55:59 +01:00
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
...
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting
2018-05-15 12:25:06 +01:00
99e3487795
Add missing validation and tests for Spot Instance requests
2018-05-15 12:25:06 +01:00
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders
2018-05-15 12:25:06 +01:00
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance
2018-05-15 12:25:06 +01:00
df7fb86984
Add tests for T2 Unlimited configuration
2018-05-15 12:25:06 +01:00
be02b3f613
Validate template settings when T2 Unlimited has been enabled
...
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance
2018-05-15 12:25:06 +01:00
2c339b99d2
Sort run config options alphabetically
2018-05-15 12:25:06 +01:00
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
5710c0aca1
Making log output clearer for hyper-v gui connection
2018-05-14 20:53:51 +10:00
29c4b4436d
Changes requested in PR #6243
...
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
fc734b6bd9
Using vmconnect to display gui for hyper-v
...
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
...
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
...
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
13c0b0b370
Added warning for VHD creation and updated samples
2018-05-10 13:15:35 -07:00
6f00596053
Adds config option to specify hyper-v secure boot template
2018-05-10 19:00:35 +02:00
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
...
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
a866232ac9
Use regex based approach to detect attached disks
2018-05-08 12:52:39 +01:00
6dc4b1cbdc
move all of the run commands for shell-local provisioner and postprocessor into common library too
2018-05-07 15:10:09 -07:00
616b41e58f
deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
2018-05-07 15:10:09 -07:00
80a096cadd
azure: device login for US Gov
2018-05-06 20:59:38 -07:00
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
...
Update Azure SDK
2018-05-04 09:47:28 -07:00
4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
...
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
169f9d22e6
Update 'the other place' too
2018-05-04 00:32:15 +00:00
80f57308d7
Process review feedback
2018-05-04 00:28:34 +00:00
420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
...
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
0521efa200
correctly log reason waiting for ami failed.
2018-05-03 12:27:09 -07:00
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
...
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
c47e5d19f0
Fix use of auto generated ssh key for scaleway builder
2018-05-03 11:33:28 +01:00
585b93cfd6
Follow variable privateKey <-> statebag private_key convention
2018-05-03 00:33:12 +01:00
78d68880c0
Randomize osDisk name for Azure Managed Image builds.
...
This fixes #6115
2018-05-02 22:42:08 +02:00
07d8c71a2d
Create and use context for Builder.Run
2018-05-01 23:40:40 +00:00
e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
...
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
cf94086b5f
Formatting fixes
2018-05-01 19:53:20 +00:00
6260151034
Merge pull request #6226 from hashicorp/fix6225
...
builder/qemu: properly prepare boot command.
2018-05-01 12:41:11 -07:00
4f1395e0f6
builder/qemu: properly prepare boot command.
2018-05-01 12:40:00 -07:00
c13965c0ce
Add acceptance tests
2018-05-01 15:39:50 +00:00
a3fb24639a
make tests pass again
2018-05-01 15:39:50 +00:00
09ce3c9803
Make it compile again
2018-05-01 15:39:50 +00:00
3d4c7d0df1
Feature Request: Log reason why AMI creation failed
2018-04-30 20:59:13 +01:00
25dd27a164
Remove tmp directories created by builder/vmware/common tests
2018-04-30 20:38:03 +01:00
13b7078cb0
Remove tmp directories created by builder/virtualbox/common tests
2018-04-30 20:38:03 +01:00
475b3978d2
Remove tmp directories created by builder/parallels/common tests
2018-04-30 20:38:03 +01:00
5642f8cb01
Remove tmp files created by builder/googlecompute tests
2018-04-30 20:38:03 +01:00
9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests
2018-04-30 18:16:46 +01:00
54e9690dff
Remove tmp files created by builder/amazon/common tests
2018-04-30 18:16:46 +01:00
96adb4a9d1
Remove tmp files created by builder/alicloud/ecs tests
2018-04-30 18:16:46 +01:00
373226e9c5
Extract state reason for failure
2018-04-28 12:40:48 +01:00
09bb21774d
alessio.tomasino@yahoo.co.uk
2018-04-28 11:02:53 +01:00
c27f3e9445
alessio.tomasino@yahoo.co.uk
2018-04-28 11:00:33 +01:00
c828015bc3
Follow variable varName <-> statebag var_name convention
2018-04-27 20:09:19 +01:00
df5c67090e
Merge pull request #6193 from adarobin/hvf
...
add support for hvf accelerator to qemu builder
2018-04-27 11:41:01 -07:00
ed6d999b1f
add windows-sql-cloud to the list of projects to check for an image name
2018-04-27 11:24:08 -07:00
f342975ff3
Fix test - reporting compaction results requires a tmp file
2018-04-27 16:40:44 +01:00
08f9d619a9
Report the result of the disk compaction step
2018-04-27 16:40:29 +01:00
10d93dffa4
Fix tests for vmware/common
2018-04-27 16:40:23 +01:00
a729ecda87
Fix tests for vmware/vmx builder
2018-04-27 16:40:13 +01:00
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops
2018-04-27 16:39:52 +01:00
29b89e63b8
add support for hvf accelerator to qemu builder
2018-04-27 10:11:20 -04:00
879319a76c
Merge pull request #6202 from rickard-von-essen/fix-6184
...
builder/parallels-pvm: Add missing compaction of disks
2018-04-26 15:44:12 -07:00
67a9c7fb92
we never expect remote cache to be a directory.
2018-04-26 12:40:40 -07:00
de1dac1bdf
don't delete the cache directory.
2018-04-26 12:40:40 -07:00
97cfd60b82
Remove remote cache correctly.
2018-04-26 12:40:35 -07:00
451e3d0554
builder/vmware-esxi: remove floppy files when done
2018-04-26 10:47:33 -07:00
3aebd5f462
Add use_fixed_vhd_format Hyper-V ISO option
2018-04-26 13:35:19 -04:00
77d0ba492d
parallels-pvm: Add missing compaction of disks
2018-04-26 14:09:17 +02:00
59e3ec722d
allow user to mount entire block device in chroot builder
2018-04-25 10:47:52 -07:00
ef03e97dc3
pass MacAddress to StepCreateVM
2018-04-24 20:39:42 -04:00
148f7d39e4
Merge pull request #6142 from harveylowndes/use-official-go-sdk
...
builder/oracle: Use official OCI Go SDK
2018-04-24 16:34:38 -07:00
db65c99bf4
update code based on master and update docs
2018-04-24 10:35:27 +01:00
e2e7953fe4
Merge branch 'master' into allow_gcp_winrm_password
2018-04-24 10:25:27 +01:00
cbdf9db832
Use contexts with amazon waiters.
2018-04-23 12:57:15 -07:00
6bbfe7e0bd
remove useless check against format
2018-04-23 10:24:49 -07:00
fdeadfe3f6
builder/vmware: correctly default export format to ovf
2018-04-23 10:17:53 -07:00
0e80d98805
Merge pull request #6166 from hashicorp/parallelsfixes
...
forcefully stop parallels vm.
2018-04-23 10:08:35 -07:00
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
...
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
e455e7b054
Merge pull request #6074 from DanHam/fix-vmx-compacting-error
...
Fix error with VMware vmx builder at compacting stage
2018-04-23 09:03:36 -07:00
a2a593759e
Merge pull request #6041 from Xeite/f-add-instance-name
...
builder/openstack: Add instance_name config to OpenStack builder
2018-04-23 08:47:50 +02:00
bd9e585cb9
Add test for enumeration of vmx network type
2018-04-21 22:49:36 +01:00
94d5a7f2e2
Fix copy/paste error referencing Virtualbox
2018-04-21 22:49:36 +01:00
1aee759f06
Fix tests and reconfigure for support of multi-disk vm
2018-04-21 22:49:36 +01:00
6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm
2018-04-21 22:49:36 +01:00
bcbee45bf9
Merge pull request #6039 from stack72/triton-insecure-skip-tls-verify
...
builder/triton: Add support to Skip TLS Verification of Triton Certificate
2018-04-20 13:44:28 -07:00
Hariharan Jayaraman
M. Marsh
Christopher Boumenot
DanHam
Unknown
Stefan Henseler
Christopher Boumenot
Paul Meyer
Rickard von Essen
Paul Meyer
Matthew Hooker
Oskar Wycislak
AlessioT
Adam Robinson
Matthew Donoughe
Richard Nienaber