Mitchell Hashimoto
9e9f31314d
builder/amazon/chroot: fix compile error
2013-11-08 11:19:10 -08:00
Mitchell Hashimoto
21c7d1c8b1
builder/amazon/chroot: allow no such file errors on upload [GH-588]
2013-11-08 10:53:54 -08:00
Mitchell Hashimoto
e4b719a286
builder/amazon/chroot: quote commands and pass through a shell [GH-581]
2013-11-08 10:22:56 -08:00
Matthew Hooker
2af19060ce
Fix the way we run commands in chroot.
...
* Single quotes around chroot command cause it to fail.
* The chroot command also gets passed through the CommandWrapper template, so having sudo would clash with however the user wants to run it.
* Fix spelling mistake.
2013-10-01 09:35:55 +00:00
Mitchell Hashimoto
a793e03fb6
builder/amazon/chroot: remove unused comment
2013-09-30 09:35:58 -07:00
Mitchell Hashimoto
c84dd13539
builder/amazon/chroot: CommandWrapper
...
/cc @mwhooker - I changed the interface up a bit to return an error,
since things should return errors in Go (the ui.Error bit was kind of
ghetto because it had no way to bubble that error up except through the
UI).
Using this, I made it so that the communicator uses both a
CommandWrapper and ShellCommand with chroot so that the chroot commannd
is also wrapped (it wasn't before).
I think the functionality of all this is the same but I'd love if you
could look it over and make sure.
2013-09-30 09:33:57 -07:00
Matthew Hooker
6f7aad23f0
comment, formatting.
2013-09-29 08:04:57 +00:00
Matthew Hooker
a84c74318c
WIP copying files.
2013-09-28 01:10:33 +00:00
Matthew Hooker
837e641802
move wrapper definitions around.
2013-09-27 22:08:15 +00:00
Matthew Hooker
8857358830
building but there's an exec error.
2013-09-27 20:47:44 +00:00
Matthew Hooker
299ee6efd2
replace command config with wrapper command.
2013-09-27 10:54:53 +00:00
Matthew Hooker
93c2de0af3
fix chroot Upload command.
2013-09-27 02:11:28 +00:00
Matthew Hooker
74adaa534e
bugfix.
2013-09-26 01:35:29 -07:00
Matthew Hooker
da467b7d67
using blocking cp method.
2013-09-26 01:32:53 -07:00
Matthew Hooker
0659ccdea0
Revert "notes/reorg."
...
This reverts commit 73c5aec24d
.
Conflicts:
builder/amazon/chroot/step_copy_files.go
2013-09-26 01:16:51 -07:00
Matthew Hooker
95f5cea285
wip
2013-09-26 01:08:06 -07:00
Matthew Hooker
a03807f8e8
wip
2013-09-26 00:58:25 -07:00
Matthew Hooker
73c5aec24d
notes/reorg.
2013-09-26 00:31:07 -07:00
Matthew Hooker
cd0cae207c
pass chroot command to /bin/sh
...
this allows us to specify an arbitrary chroot command, i.e. for sudo
2013-09-25 03:20:22 -07:00
Matthew Hooker
bac3d8ffed
Allow user to override chroot command.
2013-09-17 05:58:16 -07:00
Mitchell Hashimoto
7895df8c8f
builder/amazon/chroot: implement UploadDir for chroot communicator
2013-08-25 20:30:56 -07:00
Mitchell Hashimoto
df4c844493
builder/amazon/chroot: log the exit code for the chroot communicator
2013-07-30 17:23:37 -07:00
Mitchell Hashimoto
759ff1ace1
builder/amazon/chroot: upload should os.Create, not os.Open
2013-07-30 16:07:50 -07:00
Mitchell Hashimoto
9f2399516a
builder/amazon/chroot: provision within the chroot
2013-07-30 16:07:50 -07:00