Amrita Dutta
1438e2e449
SIG as destination validation changes
2019-06-04 00:47:29 +00:00
Amrita Dutta
700c95c613
Update Azure SDK for Go to v30.0.0
2019-05-30 21:25:43 +00:00
Megan Marsh
3e73abc93a
refresh line endings
2019-05-17 14:58:20 -07:00
Adrien Delorme
d72040f4fa
move retry code into the common/retry pkg and make retry context aware
2019-04-09 17:46:38 +02:00
Adrien Delorme
a81abd297b
Merge remote-tracking branch 'origin/master' into context_provisioner
2019-04-08 20:09:01 +02:00
Megan Marsh
3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770
...
introduce the clean_resource_name to clean image/var names
2019-04-05 09:12:20 -07:00
Adrien Delorme
c4f3dccc14
rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
2019-04-03 15:56:15 +02:00
Adrien Delorme
a4bf94dd3c
change Builder to be passed a context for cancellation
...
we have to to give it to our hook
2019-04-03 15:55:55 +02:00
Adrien Delorme
9836dad0c9
introduce the clean_resource_name to clean image names and deprecate the old ones
2019-04-03 11:25:51 +02:00
Paul Meyer
eb274c4e87
Power off before shapshotting
2019-04-01 18:40:50 +00:00
Paul Meyer
e4bea87a20
Merge pull request #7211 from riezebosch/master
...
arm-builder: specify zone resilient image from config
2019-03-19 08:59:29 -07:00
Adrien Delorme
9f82b75e57
Use the hashicorp/go-getter to download files
...
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
2019-03-13 12:11:58 +01:00
Joel Lopes
c8a60c77d1
Add comments
2019-02-21 18:12:57 -08:00
Joel Lopes
1c030cb54b
Use IMDS to get subscription for Azure MSI
2019-02-21 09:35:14 -08:00
Manuel Riezebosch
d79b54e46a
feat(arm-builder): print warning on zone resiliency for currently not supported locations
2019-02-15 19:27:53 +01:00
Manuel Riezebosch
f31031f6b1
feat(arm-builder): zone resilient from config
2019-02-15 19:27:32 +01:00
Paul Meyer
68516fc05c
Fix Azure interactive authentication
...
Builder looks up tenant ID before asking for token. Client config did
not allow that. Also found that token provider was not properly
initialized.
Fixes 7267
2019-02-05 02:35:12 +00:00
Paul Meyer
e189db97d4
[azure] deallocate instead of just power-off
...
1. allegedly prevents error where fails because VM still appears running
2. prevents left-behind VM's after failures from accumulating charges
2019-01-16 00:31:23 +00:00
Paul Meyer
aa29facdae
Allow certificate bearer JWT client authentication
...
This allows certificate based authentication, both by just referencing
the certificate file as well as by providing a bearer JWT. This last
option allows authentication without exposing the private key to packer
using an expiring JWT containting the thumbprint (and sometimes the
whole certificate for subject/issuer based auth), signed using the
certificate private key.
2019-01-15 17:29:28 +00:00
Paul Meyer
7e34579b7e
Factor out Azure client credential config
2019-01-15 17:23:57 +00:00
Christopher Boumenot
f9230aeb95
azure: fix snapshot regression
2018-12-13 13:58:18 -08:00
Christopher Boumenot
c7d8f4e150
azure: configuration for disk caching
...
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite. This seems the most appropriate value
given Packer. Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
Christopher Boumenot
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
...
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
Amrita Dutta
b8def0b3fb
Added test to check for missing OS disk snapshot name and data disk snapshot prefix
2018-11-15 22:01:16 +00:00
Amrita Dutta
67342750a3
Addressed PR comments
2018-11-14 01:47:48 +00:00
Adrien Delorme
175b6a7971
add test for MSI configuration
2018-11-12 12:04:57 +01:00
Adrien Delorme
1958ef6e81
remove unecessary check
2018-11-12 11:32:49 +01:00
Adrien Delorme
08e8b1850e
remove unnecessary parenthesis
2018-11-12 10:49:39 +01:00
Amrita Dutta
2d6b18e63e
Fix tests after bug fix
2018-11-10 00:05:25 +00:00
Amrita Dutta
213fbbae00
Updated go version and reformatted
2018-11-09 22:41:48 +00:00
Amrita Dutta
a297d73b98
correcting wrong log message
2018-11-09 19:29:57 +00:00
Amrita Dutta
06525dd885
adding logs in the steps
2018-11-09 19:28:37 +00:00
Adrien Delorme
1ab0173e69
azure builder: allow to auth with managed identities ( MSI )
2018-11-09 17:39:03 +01:00
Amrita Dutta
8881bc2d64
Fix bug in snapshot client creation
2018-11-09 03:30:57 +00:00
Mikhail Ushanov
536252683e
builders: reuse private key file reading function
...
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
Amrita Dutta
8d8c86366b
Config tests + typo fix
2018-11-07 22:23:22 +00:00
Amrita Dutta
8c326dbab7
Formatting changes
2018-11-07 18:08:15 +00:00
Amrita Dutta
b2d1675d39
Added tests
2018-11-07 03:23:17 +00:00
Amrita Dutta
369b2dae5e
Inlining suggested functions
2018-11-06 21:50:53 +00:00
Amrita Dutta
593363c5be
fix typo in last commit
2018-11-06 19:23:15 +00:00
Amrita Dutta
1266d5146d
addressed PR comments + add file for data disk snapshots
2018-11-06 19:17:03 +00:00
Amrita Dutta
d12d23d34b
OS disk snapshot
2018-11-05 23:48:22 +00:00
Megan Marsh
cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
...
Fix 6774
2018-10-10 13:25:58 -07:00
Megan Marsh
53bce398bb
add Managed Image test to azure artifact
2018-10-10 10:04:19 -07:00
Megan Marsh
5dc4ff95da
fix azure artifact so it works with managed images as well as VHDs
2018-10-10 10:04:11 -07:00
mbearup
c7180413b0
Fix tests for Shared Image Gallery
2018-10-09 16:38:50 -07:00
mbearup
a3a2a9e970
Fix issue with composite literal in test
2018-10-09 15:35:09 -07:00
mbearup
335feaf89c
Convert shared_image_gallery options to a struct
...
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
mbearup
5373b8586d
Update tests for Azure Shared Image Gallery
2018-10-05 16:04:07 -07:00
mbearup
b6bb5d4b4d
Fix format/spacing for config.go
2018-10-05 10:52:02 -07:00
mbearup
d21b13cb85
Modify variable names for Shared Image Gallery.
...
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
mbearup
55be0da5da
Initial changes to support Shared Image Gallery
2018-09-30 13:56:44 -07:00
Megan Marsh
38cc525ec7
new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
2018-09-14 11:06:38 -07:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
4682b3a9d2
refactor possible random strings into common/random
2018-09-05 10:26:52 +02:00
Adrien Delorme
170b2f3383
builder/azure/common.RandomString-> common/random.String
...
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Christopher Boumenot
2e294da82a
Merge pull request #6644 from riezebosch/master
...
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
Manuel Riezebosch
fcfa54fb1d
[azure-arm] retry cleanup individual resources on error
2018-08-31 13:43:38 +02:00
Adrien Delorme
336cac29d4
also use config.SSHPrivateKey for azure-arm builds
2018-08-29 14:40:32 +02:00
Adrien Delorme
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
Matthew Hooker
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
Matthew Hooker
e41e99954d
go 1.11 format rules
2018-08-24 15:56:44 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Adrien Delorme
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls ( #6622 )
...
* Remove duplicate unused SSHConfig funcs
* call to SSHConfigFunc() for azure/arm builder
* ncloud too
* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Patrick Double
2868971a9b
Fixes per code review
2018-08-09 07:14:14 -05:00
Patrick Double
d796edc783
Add to vagrant post-processor support for Azure
2018-08-08 10:04:28 -05:00
Christopher Boumenot
a3e6153068
azure: implement clean_image_name
2018-08-01 10:54:45 -07:00
Christopher Boumenot
fa7f54cb55
azure: satisfy Azure password requirements
2018-07-11 15:32:45 -07:00
Mike
5ea6429cd6
managed_image_resource_group_name max length change
2018-07-11 11:31:51 -04:00
Hariharan Jayaraman
b23d6c9589
fixing infinite loop issue deleting existing resources if we have a empty target resource
2018-06-06 15:25:19 -07:00
Hariharan Jayaraman
a13a2511f9
Added additional error message if we failed to parse token
2018-05-21 22:20:36 -07:00
Hariharan Jayaraman
1bd7aa534e
Addressed PR feedback
2018-05-21 21:38:41 -07:00
Hariharan Jayaraman
8a3e599cad
Added text to point out two device auth
2018-05-21 11:05:59 -07:00
Hariharan Jayaraman
da67df6d03
space fix
2018-05-18 21:17:19 -07:00
Hariharan Jayaraman
4992429e8c
Minor comment fixes
2018-05-18 17:34:01 -07:00
Hariharan Jayaraman
00e809cb7e
Refactored the change into a new function
2018-05-18 15:21:49 -07:00
Hariharan Jayaraman
ea9b2a8b5f
review feedback
2018-05-18 12:09:42 -07:00
Hariharan Jayaraman
667113338a
missed formating
2018-05-18 01:41:00 -07:00
Hariharan Jayaraman
7f2277676a
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:34:12 -07:00
Hariharan Jayaraman
77fe1bffe4
Ensure that Device Login tests dont block general acceptance tests
2018-05-18 01:25:19 -07:00
Hariharan Jayaraman
de1783240f
Updates to remove space changes
2018-05-18 00:53:44 -07:00
Hariharan Jayaraman
91eed4da52
trim right of the keyvault url
2018-05-18 00:44:25 -07:00
Hariharan Jayaraman
df5cc234fc
updates
2018-05-18 00:39:57 -07:00
Hariharan Jayaraman
1f46271a6b
Ensuring device login works for Windows build
2018-05-18 00:32:01 -07:00
Christopher Boumenot
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
...
Async delete Resource Group
2018-05-16 15:13:09 -07:00
Hariharan Jayaraman
e1b18d594a
Updates based on PR feedback
2018-05-15 11:41:26 -07:00
Hariharan Jayaraman
c8c9bbb22a
Async delete Resource Group
2018-05-14 20:06:23 -07:00
Hariharan Jayaraman
13c0b0b370
Added warning for VHD creation and updated samples
2018-05-10 13:15:35 -07:00
Paul Meyer
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
...
Update Azure SDK
2018-05-04 09:47:28 -07:00
Paul Meyer
169f9d22e6
Update 'the other place' too
2018-05-04 00:32:15 +00:00
Paul Meyer
80f57308d7
Process review feedback
2018-05-04 00:28:34 +00:00
Oskar Wycislak
78d68880c0
Randomize osDisk name for Azure Managed Image builds.
...
This fixes #6115
2018-05-02 22:42:08 +02:00
Paul Meyer
07d8c71a2d
Create and use context for Builder.Run
2018-05-01 23:40:40 +00:00
Paul Meyer
cf94086b5f
Formatting fixes
2018-05-01 19:53:20 +00:00
Paul Meyer
c13965c0ce
Add acceptance tests
2018-05-01 15:39:50 +00:00
Paul Meyer
a3fb24639a
make tests pass again
2018-05-01 15:39:50 +00:00
Paul Meyer
09ce3c9803
Make it compile again
2018-05-01 15:39:50 +00:00
Megan Marsh
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
Matthew Hooker
d70451f82e
Merge pull request #6106 from sethvargo/sethvargo/useragent
...
Add a common package for specifying useragent and adopt that everywhere
2018-04-05 15:38:11 -07:00
Megan Marsh
d236f26439
allow users to access winrm password in powershell and elevated powershell provisioners
2018-04-05 15:24:54 -07:00
Seth Vargo
5eeac07b63
Include existing azure user agent
2018-04-05 14:28:51 -04:00
Seth Vargo
b17b333e29
Add a common package for specifying useragent and adopt that everywhere
...
There were 5 different formats for the Packer useragent string. This
fixes that and unifies it into a helper package.
I did not touch oracle's user-agent, because it looked kinda special.
2018-04-05 14:28:50 -04:00
Christopher Boumenot
eb201724c1
azure: unit tests for naming temp resources
2018-03-20 16:20:11 -07:00
Megan Marsh
414dd80e61
Merge pull request #6013 from jsoref/spelling
...
Spelling
2018-03-14 09:50:27 -07:00
Josh Soref
aae5b50dab
spelling: response
2018-03-14 02:19:26 +00:00
Megan Marsh
2de0652eb4
Merge pull request #6003 from boumenot/pr-azure-support-force
...
azure: respect -force for managed image deletion
2018-03-13 09:47:16 -07:00
Josh Soref
e43b8de3b1
spelling: network
2018-03-13 08:14:30 +00:00
Josh Soref
1e99dce12b
spelling: inertness
2018-03-13 08:05:14 +00:00
Josh Soref
210f8e8312
spelling: hyphen
2018-03-13 07:59:00 +00:00
Josh Soref
04d6bfc696
spelling: environment
2018-03-13 07:41:21 +00:00
Christopher Boumenot
2a21032964
azure: randomize NIC and Public IP names
2018-03-11 20:47:45 -07:00
Christopher Boumenot
149ce52079
azure: respect -force for managed image deletion
2018-03-10 10:43:28 -08:00
Megan Marsh
b1eaaed6fb
Merge pull request #5970 from boumenot/pr-azure-plan-info
...
azure: support for marketplace plan information
2018-03-09 15:21:03 -08:00
Christopher Boumenot
1ef491d4c8
incorporate reviewer feedback
2018-03-08 22:43:26 -08:00
SwampDragons
585e31e47a
Merge pull request #5974 from boumenot/pr-azure-better-error-message
...
azure: better error message
2018-03-05 17:28:50 -08:00
Christopher Boumenot
d2e593de37
azure: support for marketplace plan information
2018-03-05 09:05:21 -08:00
Christopher Boumenot
8166ba2d8d
azure: better error message
2018-03-04 21:21:02 -08:00
Christopher Boumenot
e0ac07f5db
azure: correct function name spelling
2018-03-03 08:53:10 +00:00
jmajoor
675dc06967
Tests for the optional disk_additional_size configuration.
2018-02-26 17:37:46 -08:00
jmajoor
33c3d2885d
Add the additional disk steps to the Linux build
2018-02-26 17:33:40 -08:00
jmajoor
47947bd0f6
Apply gofmt
2018-02-23 18:43:55 -08:00
jmajoor
efcdbfeab9
Add support for optionally building Azure VMs with additional disks.
2018-02-23 15:34:13 -08:00
Matthew Hooker
8cd403425e
test fixes WIP
2018-01-24 17:09:17 -08:00
Matthew Hooker
7a189a83a1
fix imports
...
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a831d522be
change run signatures
...
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.
`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
366dc3da0a
move multistep imports to helper.
...
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker
ebe995c0ff
run goimports
2018-01-22 17:21:10 -08:00
Arjen Schwarz
c2ecdd98c6
5691: Invalid image URLs make Azure builder crash
2017-12-12 20:12:53 +11:00
Jamie Lennox
d043c37ad4
Azure: Don't provide location for build_resource_group_name
...
Location is required by default because you must specify where to create
the resource group containing the packer resources.
When using build_resource_group_name you are specifying that packer
should use an existing resource group and so the location that resources
are in can be determined by fetching the information from the existing
group.
It is forbidden to pass both variables as it is easier and more
intuitive that the location comes from the group rather than ignore a
parameter.
Closes : #5655
2017-12-04 11:22:54 +11:00
Christopher Boumenot
da0c13f622
azure: delete keyvault deployment
2017-11-30 01:19:08 -08:00
Christopher Boumenot
a3c9485062
azure: sanity check resource group names
2017-11-20 15:19:12 -08:00
Christopher Boumenot
8985bd45ba
azure: go fmt
2017-11-16 17:32:35 -08:00
Christopher Boumenot
ee767e55d1
azure: change literal to constant
2017-11-16 16:36:42 -08:00
Christopher Boumenot
2684153cb2
azure: reject bad configuration faster
2017-11-16 16:34:18 -08:00
Christopher Boumenot
787f08f39b
azure: add user message to indicate what is being deleted
2017-11-16 16:31:05 -08:00
Arjen Schwarz
f43f3155d4
Remove breaking debug statement
2017-11-10 11:04:31 +11:00
Arjen Schwarz
0e706320ad
Issue #5045 - Add build_resource_group_name
...
* Created a new parameter for using existing resource groups
* Implemented logic to ensure temp_ and build_ can't both be used
* Implemented logic to ensure they can only be used in correct context
* Implemented tests for this logic
* Updated where required to ensure the process works
2017-11-09 22:20:09 +11:00
Arjen Schwarz
f4600a208f
Azure: Keep temporary resource group. Fixes #5045
...
This changeset will detect if the defined temporary resource group
already exists. If it does, it will not destroy it, but clean up
every resource required for building that is created by Packer
individually, both on success and failure.
Unit tests have been fixed, but more tests should be added for the new
functionalities.
2017-11-06 16:16:58 +11:00
Matthew Hooker
d4895156e5
remove copyright notice
2017-09-07 11:44:38 -07:00
Christopher Boumenot
9a34fd15ca
azure: improve docs and validation
...
Closes #5186
2017-08-24 15:23:13 -07:00
Christopher Boumenot
0780667b4d
azure: support storage account for managed images
...
Closes #5202
2017-08-24 15:10:49 -07:00
Joao Albuquerque
d909c702ee
Working PublicPrivate
2017-08-08 15:05:45 +01:00
Christopher Boumenot
ec96cacdf3
azure: write temporary ssh key to a file
2017-06-27 13:23:04 -07:00
Christopher Boumenot
06ea433104
azure: private SSH private key for debug
2017-06-26 13:44:34 -07:00
Christopher Boumenot
0d427939bc
azure: Fix custom managed images
...
I missed a change in my SDK update, and when I integrated this missing
change I broke custom images.
2017-06-26 11:13:41 -07:00
Christopher Boumenot
1874514e4f
azure: go vet ./...
2017-06-26 11:13:40 -07:00
Christopher Boumenot
9425ece680
azure: Handle SDK changes
...
There are two types for storage profile, but they use the same
serialization name (storageProfile). This creates problems, so I worked
around it by taking the union of this type as well as OS Disk.
2017-06-26 11:13:40 -07:00
Christopher Boumenot
b7e32cb10a
azure: best error message possible
2017-06-26 11:13:39 -07:00
Christopher Boumenot
c09f8b84b9
azure: fit and finish
...
* More unit testing to assert customer's configuration.
* Further reduce the options that are needed to power an Azure build.
This seems like a much more manageable level.
* Update all of the examples to use a more current VM sku.
* Add an example for RHEL.
* Move from OpenSuSE to SuSE.
* Update the docs.
2017-06-26 11:13:39 -07:00