Luke Farnell
0f354614c0
Region Validation
2017-05-16 21:00:13 -07:00
Luke Farnell
abf2e618b5
Wait for snapshot transfer and change artifact output
2017-05-16 21:00:13 -07:00
Luke Farnell
4f5d3face2
remove duplicates
2017-05-16 21:00:12 -07:00
Luke Farnell
8ed50608b1
add image transfer for DigitalOcean
2017-05-16 21:00:12 -07:00
Paul Thrasher
0be5a28080
Fix issue 4693 - Derive vpc_id from subnet_id
...
In AWS we can derive the `VpcId` and AZ from the `SubnetId`, so now we do. In the config you can now only specify the `SubnetId`.
This fixes issue #4693 .
2017-05-15 13:46:05 -07:00
Ben Fagin
6f63881020
fixes a typo introduced in a previous change
2017-05-11 13:34:48 -07:00
luis-silva
a269bbc6fa
Fix issue 4875 - use retry logic when creating instance tags
2017-05-11 16:25:28 +01:00
Sean Chittenden
eece75a7a6
Wait for a 410 before returning success on a machine delete.
2017-05-10 09:12:24 -07:00
Justin Reagor
bd12c17bb0
Update triton client calls to pass along context
2017-05-05 11:20:21 -04:00
Matthew Hooker
80d6cd91fd
remove unneeded keypair var
2017-05-01 10:17:21 -07:00
Ben Phegan
c4b8e8e5df
Merge branch 'master' into virtualbox_sata_port_count
2017-05-01 09:23:05 +10:00
Matthew Hooker
602fd64c5d
builder/amazon: set flag to delete temporary keypair
2017-04-30 14:24:22 -07:00
Matthew Hooker
7aca9b7f71
builder/azure: replace panics with error returns
2017-04-27 11:04:57 -07:00
James Nugent
d2ae36214a
builder/triton: Reconcile #4829 and #4838 docs
...
This changes the default region to match the default from Joyent
documentation.
2017-04-26 15:47:04 -07:00
James Nugent
c1cad8726b
builder/triton: Better AccessConfig tests
...
This commit adds an actual public/private key pair for testing since
these are now validated.
2017-04-26 14:08:29 -07:00
James Nugent
d9ba951929
builder/triton: Switch to joyent/triton-go library
...
This commit substitutes the now-deprecated gosdc library for the newer
triton-go library. This is transparent from a user perspective, except
for the fact that key material can now be ommitted and requests can be
signed with an SSH agent. This allows for both encrypted keys and ECDSA
keys to be used.
In addition, a fix is made to not pass in an empty array of networks if
none are specified in configuration, thus honouring the API default of
putting instances with no explicit networks specified on the Joyent
public and internal shared networks.
2017-04-26 14:02:03 -07:00
Matthew Hooker
9f992b8f80
go files are 0644
2017-04-25 12:50:58 -07:00
Christopher Boumenot
f0e5f75b06
Update TODO.md
2017-04-24 14:19:24 -07:00
Bryon Ross
d092044834
Help ensure VMX builder properly removes mounted CDs on OS X
...
Pull request 1504 describes a workaround for a potential race condition in which the VMX builder can fail to remove mounted floppies or CDs. This workaround was enabled for all operating systems except OS X. Since this issue can also occur on OS X, also apply the workaround on it.
2017-04-19 16:27:16 -07:00
zhuzhih2017
d646e1d035
refactor the code according hashicorp rename the repository
2017-04-18 15:14:45 +08:00
Rickard von Essen
a3f70b874b
Spelling (context)
2017-04-09 20:38:19 +02:00
Rickard von Essen
5ee212c85f
Inlined ctx
2017-04-09 20:33:05 +02:00
Luke Farnell
5b7ec545c5
Added monitoring and updated godo
2017-04-08 15:52:57 -04:00
Matthew Hooker
da8c4004f0
builder/amazon: numbers are valid in ami name
2017-04-05 12:39:16 -07:00
Matthew Hooker
bc3510b473
fix spelling
...
closes #4767
2017-04-05 12:01:02 -07:00
Matthew Hooker
3f6b5165f2
add affirmative test case for #4762
2017-04-04 22:08:09 -07:00
Craig Barr
d9041bda0c
Improved the test for special character so that it doesn't get halted by less than 3 character check
2017-04-05 11:06:59 +10:00
Craig Barr
7911cfa94b
Formatting as per make fmt
2017-04-05 11:02:23 +10:00
Craig Barr
fdae6858c8
conforming to the standard for imports
2017-04-05 10:53:58 +10:00
Craig Barr
df6337e8ab
Added AMIName validation (issue 4761)
2017-04-05 10:46:44 +10:00
Matthew Hooker
81522dced0
move packer to hashicorp
2017-04-04 13:39:01 -07:00
Matthew Hooker
bce03492d9
remove references to ServiceAccountEmail
2017-04-03 11:22:00 -07:00
Rickard von Essen
77dc8b84c1
builder/googlecompute: Revert to using default service account
...
Fixes issue with cross Project builds.
Closes #4608
Regression introduced in PR #3639
2017-04-02 17:52:14 +02:00
Matthew Hooker
6f27f67346
more fixes from errcheck
2017-03-29 13:38:31 -07:00
Matthew Hooker
4fcbf75da9
s/non existent/nonexistent/
2017-03-29 12:38:33 -07:00
Matthew Hooker
cc11ec3566
check for a couple errors
2017-03-28 20:36:21 -07:00
Matthew Hooker
35578d9ed1
remove unnecessary type conversions
2017-03-28 20:36:21 -07:00
Matthew Hooker
bf64d7bdc2
automagic simplification
2017-03-28 20:36:20 -07:00
Matthew Hooker
79287d7e47
simplify some code
2017-03-28 20:36:20 -07:00
Matthew Hooker
0149f679de
Print instead of Printf with no dynamic first variable.
2017-03-28 20:36:20 -07:00
Matthew Hooker
d1b20b3d9c
remove a bunch of dead code.
...
https://github.com/dominikh/go-tools/tree/master/cmd/unused
2017-03-28 20:36:20 -07:00
Matthew Hooker
230079f73a
spell fixes
2017-03-28 20:36:19 -07:00
Matthew Hooker
e4aa2a34ca
builder/amazon-chroot: nullable copy_files
...
Allow users to specify that they don't want any
files copied into the chroot by setting an empty
copy_files list
2017-03-24 13:51:47 -07:00
Matthew Hooker
35480e21b2
fix typo
2017-03-24 11:56:49 -07:00
Matthew Hooker
0ad6b169bc
builder/virtualbox: retry removing floppy controller
2017-03-23 23:58:23 -07:00
Matthew Hooker
74c8c585f5
builder/amazon: report tag creation
2017-03-23 16:12:59 -07:00
Ben Phegan
0c777a1d63
Fix for DriverMock not implementing Driver
2017-03-23 12:11:19 +11:00
Ben Phegan
67eb600c08
Add sata_port_count so that a SATA controller can be created with more than 1 port. The default of prevents additional drives being added. Default preserved if not overridden.
2017-03-22 23:09:25 +11:00
Matthew Hooker
8b763032ce
builder/hyper-v don't wait for shutdown to return.
...
Mirrors work done in #4436
2017-03-20 15:32:42 -07:00
Matthew Hooker
68e2b150cd
builder/virtualbox: allow skipping upload of version file
2017-03-16 18:14:11 -07:00
Rickard von Essen
8c2a8f5f81
Merge pull request #4655 from lbordowitz/ostk-sshca
...
OpenStack: Add ssh agent support
2017-03-14 21:07:03 +01:00
Rickard von Essen
6cd3cb18da
builder/openstack: validate ssh key name/file
...
This is a port for OpenStack of PR #4665
2017-03-14 20:47:40 +01:00
Matthew Hooker
bd76b7bb6f
builder/amazon: validate ssh key name/file
...
When using ssh_key_name, ssh_private_key file must be given,
or ssh_agent_auth enabled.
When automatically retrieving the winrm password, if ssh_key_name is
given, ssh_private_key_file must also be given.
2017-03-13 13:14:18 -07:00
Rickard von Essen
4c5461102a
amazon: Added (more) support for SSH Agent and temporary keypair names
2017-03-13 07:29:59 +01:00
zhuzhih2017
0400ebae95
Fix the code according PR review
2017-03-12 10:22:25 +08:00
Rickard von Essen
a047916944
Merge pull request #4621 from hui-yang/disk-type
...
builder/parallels-iso: Configuration of disk type, plain or expanding
2017-03-10 19:32:41 +01:00
Larry Bordowitz
c5b8a1069a
Add ssh agent to enable SSH-CA authentication.
2017-03-10 08:45:50 -08:00
Jimmy The Dog
1e9b0f7b8f
Replace export output dir in state bag with params
...
step_export now has the OutputDir as a param instead of getting it from
the state bag, on the advice of @mwhooker in PR comment
2017-03-10 10:43:45 +00:00
Jimmy The Dog
e851efb1b6
Set export_dir to the output_dir property
2017-03-10 08:20:48 +00:00
Jimmy The Dog
9eb9abdce9
Merge branch 'master' into ovfexportpath-localoutputdir
2017-03-10 08:12:26 +00:00
Matthew Hooker
50d9546658
builder/amazon: set force_deregister to true on -force
2017-03-09 14:24:49 -08:00
Matthew Hooker
597b7ad8c5
builder/hyper-v: validate output dir in step, not in config
...
essentially same work as #2233
2017-03-08 23:52:34 -08:00
Matthew Hooker
c5ddbacb62
Merge pull request #4318 from Tadas/fix-hyperv-admin
...
Check for 'Hyper-V Administrators' security group
2017-03-08 23:35:17 -08:00
Matthew Hooker
9e8b602f28
Merge pull request #4643 from rickard-von-essen/issue-4620
...
googlecompute: Correct values for on_host_maintenance
2017-03-08 14:17:51 -08:00
Rickard von Essen
eac5b6392d
googlecompute: Correct values for on_host_maintenance
...
If preemptible is true then on_host_maintenance must be TERMINATE.
Also corrected order in docs.
Closes #4620
2017-03-08 19:44:07 +01:00
Rickard von Essen
2300b102b7
amazon: Step Region Copy crashing on device mapping
...
Closes #4635
2017-03-08 18:12:37 +01:00
huiyang
b3c6ef9f6b
Skip disk compaction for plain disks
2017-03-07 18:22:23 -08:00
huiyang
52d4514d6a
builder/parallels-iso: Configuration of disk type, plain or expanding
2017-03-03 15:32:51 -08:00
zhuzhih2017
5e44a28a42
fix the missing access key for testcase
2017-03-03 17:56:48 +08:00
zhuzhih2017
fadfb696dd
Add packer plugin which support alicloud ecs images
2017-03-03 16:56:17 +08:00
Matthew Hooker
8cc2ed7d6e
vmware/esx: try for longer to connect to vnc port
2017-02-28 22:21:19 -08:00
Matthew Hooker
9c027aa70b
Merge pull request #4601 from mitchellh/ebssurrogate-copy-ami
...
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
2017-02-27 10:47:34 -08:00
James Nugent
e856339309
build/amazon-ebssurrogate: Add region copy, attributes, tags steps
...
As pointed out in the initial code review of #4351 , some of the steps
from the standard EBS builder were (intetionally) omitted. It turns out
that these actually are useful, and the original rationale for the
omission was wrong. Consequently, this commit adds in the following
steps:
- `StepPrevalidate`
- `StepTagEBSVolumes`
- `StepDeregisterAMI`
- `StepCreateEncryptedAMICopy`
- `StepAMIRegionCopy`
- `StepModifyAMIAttribute`
- `StepCreateTags`
We also fix the interpolation filter and documentation to reflect these
additions, though the majority were already documented and just not
functional.
2017-02-27 09:05:39 -06:00
James Nugent
1eec5bf058
builder/amazon-ebssurrogate: Exclude duplicate root volume
...
This commit removes the root volume from the list of launch block device
mappings passed to the image, since it is already passed in the form of
a snapshot (which is then configured to be the root device). Without
this commit, AMIs created using this builder have two root volumes
attached on launch.
2017-02-27 06:57:35 -06:00
Matthew Hooker
fd1b00a0d1
use aws helper method
2017-02-26 19:33:34 -08:00
Matthew Hooker
61976dfd86
Merge pull request #4578 from life360/enable_ena
...
Always set both SRIOV and ENA when Enhanced Networking is enabled
2017-02-26 19:31:22 -08:00
Matthew Hooker
ed92055372
Merge pull request #4532 from mitchellh/vmipgetagain
...
builder/vmware: don't cache ip address so we know if it changes
2017-02-26 18:46:46 -08:00
Matthew Hooker
1f2df5c174
Merge pull request #4536 from mitchellh/vmwareextraopts
...
builder/vmware: allow extra options for ovftool
2017-02-26 18:45:40 -08:00
Matthew Hooker
6a7c37beb6
builder/amazon-chroot: support encrypted boot volume
2017-02-26 17:48:13 -08:00
Matthew Hooker
f62d0abf4e
Merge pull request #4560 from guessi/deprecated_option_tag
...
Conditional ignore `force` flag for `docker-tag`
2017-02-26 17:43:25 -08:00
Matthew Hooker
2cb9b32acf
don't attempt to delete non-existant key when using agent auth
2017-02-26 17:38:22 -08:00
Matthew Hooker
f95514c120
fix ssh agent authentication
...
treat key name to empty string if it's not been set
by prior step.
2017-02-26 17:17:49 -08:00
Aaron Stone
1cc3cdf7b5
Always set both SRIOV and ENA when Enhanced Networking is enabled
...
Set SriovNetSupport to "simple". As of February 2017, this applies to C3, C4,
D2, I2, R3, and M4 (excluding m4.16xlarge).
Set EnaSupport to true. As of February 2017, this applies to C5, I3, P2, R4,
X1, and m4.16xlarge.
2017-02-25 07:16:35 -08:00
Jimmy The Dog
ce41055ac6
builder/vmware-iso: do not append to output dir, as ovftool does that
2017-02-24 14:49:40 +00:00
Jimmy The Dog
14810523b8
builder/vmware-iso: get artifact files from local dir
2017-02-24 14:48:38 +00:00
Jimmy The Dog
7a2b30dcc4
builder/vmware-iso: need to always set local output dir, or non-remote build exports will fail
2017-02-24 13:18:28 +00:00
Jimmy The Dog
f8df5f81db
builder/vmware-iso: set local output dir
2017-02-24 12:46:00 +00:00
Richard Owen
33a4c2e13b
Change EC2 WindowsPasswordTimeout to 20 minutes
...
10 minutes is often exceeded when using a custom source AMI
which has been sysprepped.
2017-02-24 11:08:17 +00:00
James Nugent
635aeb765b
amazon/ebssurrogate: Add New Builder
...
This commit adds a new type of builder which builds an AMI based on a
snapshot of an EBS volume which is provisioned on a "surrogate"
instance. This can be used to build operating system images from
scratch, but unlike the `chroot` builder does not require running from
an AWS EC2 instance.
2017-02-21 18:38:19 -06:00
Matthew Hooker
3409ea76ee
Merge pull request #4564 from wtsi-hgi/fix/4551-openstack-builder-reuse-ips
...
add reuse_ips option for openstack builder
2017-02-21 15:20:10 -08:00
Matthew Hooker
2381bfa8ad
Merge pull request #4518 from AlexLov/bugfix_image_family
...
[googlecompute] fix bug of creating image from custom image_family
2017-02-21 10:58:23 -08:00
Joshua Randall
e9cfaa2730
add reuse_ips option for openstack builder
...
add reuse_ips option and use it to control whether openstack builder
will attempt to reuse existing unassigned floating ips rather than
allocating a new one.
fix #4551
2017-02-16 12:44:03 +00:00
guessi
66615e3f56
reuse the func DockerDriver.Version()
2017-02-16 08:26:44 +08:00
guessi
5eae809b0c
improve description
2017-02-16 01:14:21 +08:00
guessi
c5e01da3c6
Conditional ignore `force` flag for `docker-tag`
...
`docker tag -f` will now become an error, since it was removed after
upgrading docker daemon to 1.12.0 (or later)
this PR is to bypass `force` flag if docker >= 1.12.0 was detected
reference:
- https://docs.docker.com/engine/deprecated/#/f-flag-on-docker-tag
Signed-off-by: guessi <guessi@gmail.com>
2017-02-16 00:50:46 +08:00
Matthew Hooker
4f92b9fb61
Merge branch 'pr/4544'
2017-02-10 12:11:43 -08:00
Dimitri Rudnev
2009fcd9df
OnHostMaintenance, googlecompute updating documenation , additional option for validation and setting defaults
2017-02-10 11:57:15 -08:00
Dimitri Rudnev
bab590c177
Adding OnHostMaintenance option for googlecompue builder
2017-02-10 10:58:57 -08:00
Matthew Hooker
0ed84f843e
builder/vmware: allow extra options for ovftool
2017-02-10 00:22:20 -08:00
Matthew Hooker
29dd20da68
builder/vmware: don't cache ip address so we know if it changes
2017-02-09 23:16:40 -08:00
Matthew Hooker
c41e32dbc1
print stderr on docker import failure
2017-02-09 20:41:29 -08:00
Alex Lov
cfa8f8c215
fix bug of creating image from custom image_family
2017-02-08 22:50:19 +03:00
Matthew Hooker
84fc62f6b2
Merge pull request #4496 from mitchellh/vmrmguest2
...
builder/virtualbox: remove guest additions
2017-02-03 23:14:35 -08:00
Matthew Hooker
1fa643e88d
Merge pull request #4498 from mitchellh/f-simple-passwords
...
Reduce character set for passwords
2017-02-02 15:04:02 -08:00
Matthew Hooker
70af3d8148
Merge pull request #4497 from mitchellh/f-clickable-links
...
Make rdp and vnc links clickable by adding the protocol
2017-02-02 12:41:59 -08:00
Chris Bednarski
dcb4b50dbf
Reduce character set for passwords
...
At the beginning of each VMware build packer generates a random VNC password and prints it to the terminal / log. When copying a password from a terminal emulator with double-click, the text selection uses word boundaries to attempt to automatically detect where the password string is located. When the password contains weird characers like %^&# this parsing fails and you only get half the password. The reduction in characters does not significantly reduce the entropy of the password but improves user-friendliness when you actually want to use it.
Also deletedsome unused files
2017-02-02 04:03:46 -08:00
Chris Bednarski
facf27ceeb
Make rdp and vnc links clickable by adding the protocol
2017-02-02 01:55:28 -08:00
Matthew Hooker
e9e3215c38
builder/virtualbox: remove guest additions
2017-02-02 00:47:56 -08:00
Matthew Hooker
228bc9cfd3
use driver delete method
2017-02-01 23:57:45 -08:00
Jelle Hissink
6973e752d2
Vmware vsphere vnc port timeout increased
2017-01-29 14:41:14 +01:00
Thomas Conte
d294d2c576
gofmt
2017-01-28 10:29:35 +01:00
Thomas Conte
1ec6578c02
Add two new variables to Azure builder config
2017-01-27 12:26:28 +01:00
Matthew Hooker
22d1322bd9
always check for an error first when walking a path
2017-01-26 16:32:21 -08:00
Rickard von Essen
c9259d116f
builder/amazon-ebsvolume: Fix interpolation of block_device
2017-01-26 21:27:36 +01:00
Matthew Hooker
76f897077d
Merge pull request #4399 from rickard-von-essen/aws-interpolate
...
WIP: builder/amazon: Interpolate {{ .BuildRegion }} and {{ .SourceAMI }}
2017-01-26 11:41:16 -08:00
Matthew Hooker
485fa58b43
Merge pull request #4443 from mitchellh/preservedockermode
...
communicator/docker: preserve file mode.
2017-01-26 11:22:00 -08:00
Rickard von Essen
de7388fa0a
builder/amazon-ebsvolume: Fixed interpolation of tags
2017-01-25 19:40:43 +01:00
Matthew Hooker
2a7c84e9ff
Merge pull request #4343 from vtolstov/qemu_convert
...
builder/qemu: allow to convert from any supported format
2017-01-24 01:12:31 -08:00
Matthew Hooker
56c5628205
builder/vmware-iso: set ovftool output path
2017-01-23 17:47:35 -08:00
Matthew Hooker
a51f492558
communicator/docker: preserve file mode.
2017-01-23 13:47:22 -08:00
Rickard von Essen
6e891cf682
Fixed botched merge and review comments
2017-01-22 21:57:23 +01:00
Matthew Hooker
9e2d69fb97
builder/docker: create export dir if needed
2017-01-21 23:51:08 -08:00
Rickard von Essen
ba9cae5078
builder/amazon: Add SourceAMI and BuildRegion template
...
Added {{ .SourceAMI }} and {{ .BuildRegion }} template values availible
in `ami_description`, `run_tags`, `run_volume_tags`, `tags`, and
`snapshot_tags`.
2017-01-21 20:39:58 +01:00
Matthew Hooker
f1175c1921
parallels/vmware: don't wait for shutdown command.
...
Resolves #4134
replaces/ closes #4379
Leaving Hyper-V builder alone for now until we can get a case that reproduces.
2017-01-20 01:44:18 -08:00
Matthew Hooker
fc30f6cc0a
log tag creation.
...
closes #4427
2017-01-19 12:00:41 -08:00
Matthew Hooker
56b5e97bf4
verify given security group
2017-01-18 15:25:31 -08:00
Matthew Hooker
b265d2614f
builder/amazon: fix when using security_group_id
...
If `security_group_id` was specified with a group that didn't exist, packer
would go into an infinite loop waiting for it. We shouldn't make assumptions
about the status of explicitely set security groups, so let's just error out
right away if we can't find it.
2017-01-18 15:11:52 -08:00
Eike Verdenhalven
7ad77b9e93
integrate new winrm transport interface
2017-01-18 22:11:48 +01:00
Matthew Hooker
0a46d883df
Merge pull request #4409 from mitchellh/httpenvvar
...
set PACKER_HTTP_ADDR env var when available.
2017-01-18 12:35:14 -08:00
Matthew Hooker
f5bf588393
tag all volumes
2017-01-18 11:34:46 -08:00
Matthew Hooker
800351b7ca
fix panic and don't print each tag we add.
2017-01-18 11:34:36 -08:00
Roman Zhuzha
d9186dc8cf
add proper error handling for tagging source instance
2017-01-18 14:02:10 +01:00
Roman Zhuzha
ae016a1f25
simplify code flow: skip the step if no run_volume_tags provided
2017-01-18 13:03:05 +01:00
Roman Zhuzha
a65af51a4b
apply source instance default "Name" tag only if it's not provided in run_tags
2017-01-18 12:55:18 +01:00
Roman Zhuzha
36d8a1df1d
use common.ConvertToEC2Tags to apply tags to source EBS volumes, change Say message
2017-01-18 12:52:59 +01:00
Roman Zhuzha
aa70c82ec8
use ConvertToEC2Tags to apply tags to source instance, add Say message
2017-01-18 12:50:20 +01:00
Matthew Hooker
26dd3af9ec
Merge pull request #4411 from rickard-von-essen/issue-4406
...
builder/vmware: Try to use `ip address` to find host IP
2017-01-17 22:02:59 -08:00
Matthew Hooker
d4b043451f
Merge pull request #4357 from dave2/gh-4215
...
Openstack builder should use existing floating IPs before allocating them
2017-01-17 11:14:59 -08:00
Matthew Hooker
94a2aae749
Merge pull request #4361 from Tom-Byrne/openstack-instance-metadata
...
support OpenStack instance (not image) metadata
2017-01-17 11:05:20 -08:00
Rickard von Essen
81ad800fb6
builder/vmware: Try to use `ip address` to find host IP
...
Closes #4406
2017-01-17 10:33:48 +01:00
Matthew Hooker
d2e59e4e92
set PACKER_HTTP_ADDR env var when available.
...
If using a builder that has an http server set up for file transfer,
expose the connection info to the shell provisioner through the environment
variable PACKER_HTTP_ADDR.
Closes #2869
2017-01-16 23:19:52 -08:00
Chris Bednarski
6ad702ad74
Update comments to reflect current implementation
2017-01-14 20:11:51 -08:00
Chris Bednarski
ee2d636840
Improve delay between key events
...
- Can now tune delay using PACKER_KEY_INTERVAL
- Added implementation to all of VMware and QEMU
- Removed double delay for QEMU
- Default key delay of 100ms (as before)
- Added docs to QEMU and VMware pages
2017-01-14 17:56:04 -08:00
Chris Bednarski
d0c64f90d5
Read key interval from ENV; default to 100ms
2017-01-14 16:52:37 -08:00
Chris Bednarski
da083506f1
Reduce key delay to 10ms to boot times are a lot faster
2017-01-14 16:52:24 -08:00
Matthew Hooker
c1f5545986
compress pr #4395
2017-01-13 11:42:20 -08:00
Richard Moore
9435fa62e3
Output error causing ebs volume deletion failure
...
When an ebs volume fails to delete, Packer reports that there
was an error deleting the volume and the volume id. But it doesn't
give you the details of what that error is. This commit adds the
error reported back to the standard output.
2017-01-13 15:33:47 +00:00
Matthew Hooker
b9d08e9d56
Merge pull request #4385 from rickard-von-essen/issue-4383
...
docker: Fix crash when performing log in to ECR with an invalid URL.
2017-01-11 11:37:37 -08:00
Rickard von Essen
112f5abdae
docker: Fix crash when performing log in to ECR with an invalid URL.
...
Closes #4383
2017-01-11 20:23:24 +01:00
Matthew Hooker
98b0f018fa
Merge pull request #4378 from DanHam/skip-export-vmware
...
Add option to skip export of installed VM for VMware ISO builder
2017-01-10 15:24:58 -08:00
Matthew Hooker
a3da92dc97
Merge pull request #4339 from DanHam/gh-4131
...
Add option to skip export of installed VM for vbox ISO & OVF builders
2017-01-10 15:08:15 -08:00
DanHam
c7e8d671a9
Add option to skip export of installed VM for VMware iso builder
2017-01-10 11:44:11 +00:00
Rickard von Essen
26fe9cf339
builder/amazon: Fix crash in amazon-instance
...
Closes #4360
2017-01-06 15:17:02 +01:00
Matthew Hooker
377f451a9e
it's InvalidGroup
2017-01-05 16:56:49 -08:00
Matthew Hooker
e54605c120
Properly wait for security group to exist.
...
Adds check for `InvalidGroupID.NotFound` in addition to
`InvalidSecurityGroupID.NotFound`.
Uses aws's `waiter` for clarity.
2017-01-05 15:20:28 -08:00
Tom-Byrne
d7545c4ba0
support OpenStack instance metadata
2017-01-05 14:42:32 +00:00
Zanetti, David
08ef89f032
Openstack builder should use existing floating IPs before allocating them
...
Rather than always creating a new floating IP, search the provided pool
for an unallocated address and use this instead. Only allocate a temporary
address if there is no spare address in the pool.
Closes #4215
2017-01-05 08:59:49 +13:00
Matthew Hooker
aef6e0e93f
Merge pull request #4304 from dave2/gh-4277
...
Querying EC2 security groups should report unexpected errors
2017-01-04 10:53:28 -08:00
Rickard von Essen
85cf00069f
Merge pull request #4294 from legal90/iso-target-extension
...
Add "iso_target_extension" option for all local *-iso builders
2017-01-04 13:48:28 +01:00
James Nugent
01c09aa7f7
Merge pull request #4325 from siepkes/f-triton-builder-2
...
Add Joyent Triton Builder
2017-01-01 15:40:11 -06:00
Rickard von Essen
ae2e59634c
Merge pull request #4341 from rahart/f-chroot-snapshots-crash
...
amazon-chroot builder snapshot interface panic
2017-01-01 22:13:11 +01:00
DanHam
ac769be49a
Pause between each boot command element rather than each char with -debug
...
Fixes #4332
2016-12-31 11:57:11 +00:00
Vasiliy Tolstov
20349f750d
builder/qemu: allow to convert from any supported format
...
In case of disk_image: true user can have raw image, but in packer
template specify qcow2 image format.
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
2016-12-30 17:19:14 +03:00
Jasper Siepkes
690302a6a3
Minor cleanup and style fix.
2016-12-29 18:58:56 +01:00
Travis Harrington
e31d75eca8
Quick fix for issue #4340
2016-12-29 09:16:52 -07:00
DanHam
0ac071b6e7
Add option to skip export of installed VM for Virtualbox ISO & OVF builders
...
Closes #4131
2016-12-29 13:19:59 +00:00
Jasper Siepkes
0c9b576c05
* Unentagled SSH communication with VM's from the Cloud API SSH private
...
key.
* Improved documentation.
2016-12-29 13:24:56 +01:00
Jasper Siepkes
24786aeece
Processed code review feedback.
...
* Removed unneeded if statements.
* Made source machine name optional.
2016-12-28 16:03:11 +01:00
Jasper Siepkes
7606dd541b
* Contains the SSH fix by @watters of #3840 .
...
* Fixed minor lint error.
* Added documentation for this builder in `triton.html.md`.
* Added (and updated) the needed Joyent Triton Cloud API Go libraries
to `vendor.json`.
2016-12-27 17:05:27 +01:00
James Nugent
e15be036d7
builder: add Triton builder
...
This is a builder for Joyent's Triton system. It was originally at
jen20/packer-builder-triton, and subsequently at
joyent/packer-builder-triton on GitHub. The following commit vendors the
dependencies.
2016-12-24 10:25:31 +01:00
DanHam
13bb4d153a
qemu builder now needs to explicitly set WinRMPort for StepConnect
...
Same as vbox builders, aligns qemu with changes to
helper/communicator/step_connect.go introduced by PR #2576
2016-12-23 23:15:51 +00:00
DanHam
686ec1866e
vbox builders now need to explicitly set WinRMPort for StepConnect
...
Aligns vbox builders with changes to helper/communicator/step_connect.go
introduced by PR #2576
Fixes #4310
2016-12-23 15:55:10 +00:00
Tadas Medisauskas
4939ea1a3b
Add support for Hyper-V admins security group
2016-12-22 14:59:25 +00:00
Matthew Hooker
2e358ae4a1
Revert "builder/virtualbox: group keyboard codes"
2016-12-21 15:12:17 -08:00
Rickard von Essen
4b1e014be8
builder/amazon: Crashes when multiple EBS vols are used
...
If you use a new EBS vol (which hasn't any snapshot) Packer crashes when
creating the AMI.
Closes #4303
2016-12-21 15:37:08 +01:00
Matthew Hooker
308a01795c
Merge pull request #4305 from mitchellh/replace4247
...
builder/virtualbox: group keyboard codes
2016-12-20 18:15:38 -08:00
Matthew Hooker
ee86dc87fd
fix broken test
2016-12-20 18:10:58 -08:00
Matthew Hooker
aa177de54b
add test for #4247
2016-12-20 17:51:47 -08:00
Zanetti, David
ae5730c5a5
Querying EC2 security groups should report unexpected errors
...
As noted in #4277 , we don't report any errors from the loop waiting for
a security group to exist. Instead, we should accept 'errors' which result
from the group not yet existing, and report errors which are actual issues
the user needs to resolve (eg, IAM permissions are incorrect).
Closes #4277
2016-12-21 11:45:12 +13:00
Matthew Hooker
f1dd0811d8
builders/openstack: fix for finding resource by ID.
...
Pass server serviceClient to create params so it can look up resources by ID.
Resolves #4299
2016-12-19 13:47:09 -08:00
Matthew Hooker
9801e67fdc
Merge pull request #4293 from mitchellh/usedefaultdisplay
...
builder/qemu: add use_default_display option for osx compatibility
2016-12-19 11:41:36 -08:00
Matthew Hooker
e4f6eaae9b
Merge pull request #4231 from artburkart/force-delete-snapshot-patch
...
Fixes acceptance test for PR #4223
2016-12-17 11:43:26 -08:00
Mikhail Zholobov
57d07f227a
Add "iso_target_extension" option for all local *-iso builders
...
This option allows to set the extension of the ISO file after download.
Defaults to "iso". It makes sense for building Mac OS X guests, where the
bootable image is actually a DMG, not an ISO.
In particular, it is important for "parallels-iso" builder to set the right extension.
2016-12-17 12:50:30 +02:00
Matthew Hooker
0339fcc442
builder/qemu: add use_default_display option
...
If set, won't set `-display dsl` as a default argument. Useful for osx
compatibility.
2016-12-16 17:44:54 -08:00
Mikhail Zholobov
aa623e22a3
golint: Add comments for exported methods
2016-12-17 00:37:04 +02:00
Mikhail Zholobov
73d87b07de
golint: Fix lint offences
2016-12-17 00:37:03 +02:00
Mikhail Zholobov
00a90e622b
Remove unused constant "KeyLeftShift"
2016-12-17 00:37:03 +02:00
Mikhail Zholobov
1ca841b499
Fix shadowed declarations
...
Performed by "go vet" tool
2016-12-17 00:37:03 +02:00
Mikhail Zholobov
dde445bd0d
Fix style: Organize imports in groups
...
Performed by "goimports" tool
Style conventions: https://github.com/golang/go/wiki/CodeReviewComments#imports
2016-12-17 00:37:03 +02:00
Mikhail Zholobov
319b85cb7a
Fix style: Use a consistent case for initialisms
...
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
2016-12-17 00:36:56 +02:00
Matthew Hooker
c61c7765ec
Merge pull request #4288 from troytoman/gce-network-uri
...
enable support for Google Compute XPN
2016-12-15 12:03:46 -08:00
Matthew Hooker
88841cb0e4
Merge pull request #4283 from mitchellh/openstackhacks
...
builder/openstack: Add image visibility & members
2016-12-14 16:13:21 -08:00
Matthew Hooker
754ed931e9
be nice if user gets the image visibility case wrong
2016-12-14 16:08:36 -08:00
Rickard von Essen
d3c2239b9e
builder/amazon: Change shutdown_behaviour to shutdown_behavior
2016-12-14 21:59:16 +01:00
Rickard von Essen
c24b4423b2
builder/amazon: Added new region London - eu-west-2
2016-12-14 10:55:19 +01:00
Matthew Hooker
1408c3fde8
bugfix
2016-12-14 01:01:57 -08:00
Matthew Hooker
00e4585ce5
first pass at adding new members
2016-12-13 16:32:30 -08:00
Matthew Hooker
cbe7e9113a
return early if no set visibility
2016-12-13 16:32:15 -08:00
Matthew Hooker
99667df17e
update image visibility own step
2016-12-13 16:28:54 -08:00
Matthew Hooker
7bd211cf61
first attempt at modifying visibility
2016-12-13 15:21:20 -08:00
Matthew Hooker
6a6e735d16
use 404 error type
2016-12-13 14:20:39 -08:00
Zanetti, David
01e3e7f7a3
Second part of resync of gophercloud
2016-12-13 14:06:01 -08:00
Alexander Krasnukhin
ac98aad1df
Fix log statement
2016-12-13 12:53:03 +01:00
Matthew Hooker
45d4cf8b36
move powershell module to common
2016-12-12 18:34:15 -08:00
Matthew Hooker
5e324d6bb4
apply #4041 to hyperV builder
2016-12-12 18:34:15 -08:00
Taliesin Sisson
e50fe9fd54
Porting over paulmey changes to license and copyright headers. Good guy Microsoft have changed the licensing to MPL2 and removed the copyright headers so that we can include it in the official Packer release.
...
1ce6ba91f7
?diff=unified#diff-5d60887f0940c9f8d6724e59843ac1fb
2016-12-12 22:45:24 +00:00
Taliesin Sisson
e357c56186
Builders don't need to set this up anymore
2016-12-12 22:45:23 +00:00
Taliesin Sisson
74255c553b
Be smarter about loading guest additions iso. Windows 10 and Windows Server 2016 no longer come with iso. So default to not loading guest additions when the iso is missing
2016-12-12 22:45:22 +00:00
Taliesin Sisson
335615408a
Run go fmt on files
2016-12-12 22:45:19 +00:00
Taliesin Sisson
44f73fa75f
Changed ram_size_mb to ram_size
2016-12-12 22:45:18 +00:00
Taliesin Sisson
fb192ce6d6
Remove unused import
2016-12-12 22:45:17 +00:00
Taliesin Sisson
04a6880361
Remove unused import
2016-12-12 22:45:17 +00:00
Taliesin Sisson
3f0835aab2
Remove headless option as it is not used.
2016-12-12 22:45:16 +00:00
Taliesin Sisson
3c1df5a791
Remove inconsistent "_mb" from ram size
2016-12-12 22:45:14 +00:00
Taliesin Sisson
0515487062
Configuration settings are no longer used
2016-12-12 22:45:13 +00:00
Taliesin Sisson
20643e35a8
Do not specify a default username or password
2016-12-12 22:45:13 +00:00
Taliesin Sisson
d7117560cf
We are using powershell and Msvm to send keys to virtual keyboard so update comment
2016-12-12 22:45:12 +00:00
Taliesin Sisson
a27d75ff89
Fix comment left over from initial import
2016-12-12 22:45:11 +00:00
Taliesin Sisson
501845cb4f
SSHKeyPath and SSHWaitTimeout have been deprecated in favor of communicator configuration
2016-12-12 22:45:10 +00:00
Taliesin Sisson
c2d1f6b617
Added the ability to independently configure switch vlan. This will people to leave the switch in trunk mode and set a vlan for the vm.
2016-12-12 22:45:06 +00:00
James Johnson
48b6cc0650
Enable VlanID
2016-12-12 22:45:05 +00:00
Taliesin Sisson
9fbd1e472a
Add support for mac spoofing and dynamic memory.
...
To enable nested virtualization, mac spoofing, no dynamic memory and at least 4gb of ram should be set for the vm. Set warning if this has not been done.
Detected Virtualization Extensions are supported by the machine your are running on, as it only works for Windows 10 and Windows Server 2016 onwards.
2016-12-12 22:45:04 +00:00
Patrick Lang
6d391fc34a
Adding support for nested Hyper-V
2016-12-12 22:45:02 +00:00
Patrick Lang
f94c2cd2f7
Adding nested virtualization support
2016-12-12 22:45:01 +00:00
Patrick Lang
6342e1525d
s/EnabeSecureBoot/EnableSecureBoot/g
2016-12-12 22:45:01 +00:00
Taliesin Sisson
9c53df1e0e
Add special key modifiers to log output when used.
...
Update documentation to include new key modifiers.
2016-12-12 22:44:59 +00:00
Taliesin Sisson
5f7290c6f8
Add type scan support for ctrl, shift, alt.
...
<leftAlt>
<leftCtrl>
<leftShift>
<rightAlt>
<rightCtrl>
<rightShift>
Add type support for combinations of ctr, alt, shift with (only use lower case characters with this):
<leftAltOn>
<leftCtrlOn>
<leftShiftOn>
<leftAltOff>
<leftCtrlOff>
<leftShiftOff>
<rightAltOn>
<rightCtrlOn>
<rightShiftOn>
<rightAltOff>
<rightCtrlOff>
<rightShiftOff>
2016-12-12 22:44:58 +00:00
Taliesin Sisson
c1538c59c9
Builds in AppVeyor are failing as they do not have enough free memory. Drop the thresh hold a little more.
2016-12-12 22:44:57 +00:00
Taliesin Sisson
52c6cd5fc1
Test should run and pass even when run on an environment that does not have Powershel.
2016-12-12 22:44:53 +00:00
Taliesin Sisson
4d22bd1d4a
Generate switch name using uuid v1
2016-12-12 22:44:49 +00:00
Taliesin Sisson
7c754bf791
Try to match style of other builders
2016-12-12 22:44:48 +00:00
Taliesin Sisson
fb098fcbf0
http server has moved to common step
2016-12-12 22:44:47 +00:00
Taliesin Sisson
d878f4dd8e
A workaround for bug in Windows 10 and Windows 2016 where you have to specify a path when creating a dvd drive
2016-12-12 22:44:44 +00:00
Taliesin Sisson
bda2468404
removed unused reference
2016-12-12 22:44:40 +00:00
Taliesin Sisson
d1961b7c8e
Echo output when its used
2016-12-12 22:44:40 +00:00
Taliesin Sisson
18241e5215
Setting boot drive is generation specific
2016-12-12 22:44:37 +00:00
Taliesin Sisson
8477a0b748
Accidentally included bracket
2016-12-12 22:44:35 +00:00
Taliesin Sisson
e0c10dec12
If exit code = 1 and the length of the stderr is 0, then we can assume that the exit code was not set, so assume success
2016-12-12 22:44:34 +00:00
Taliesin Sisson
fe8d99fd8a
If we are not getting the exit code assigned then default to it being successful
...
Useful to know what the exit code is if there is an error
2016-12-12 22:44:31 +00:00
Taliesin Sisson
3cb621f890
Get rid of mount and unmount that does not specify controller location exactly
...
Handle cleanup if unmount step has not already done so
2016-12-12 22:44:30 +00:00
Taliesin Sisson
31ac1da28d
Setting boot drive message
2016-12-12 22:44:30 +00:00
Taliesin Sisson
4b6ce3da60
Build agents might not have guest additions
2016-12-12 22:44:29 +00:00
Taliesin Sisson
aaf9007249
Include cache in the state bag.
2016-12-12 22:44:28 +00:00
Taliesin Sisson
50a8d1b6b4
Forgot to check in these files.
2016-12-12 22:44:27 +00:00
Taliesin Sisson
010d171bec
GuestAdditionsMode and GuestAdditionsPath can be set in config. If GuestAdditionsMode == "attach" it will mount the HyperV Integration Services ISO. If GuestAdditionsPath is set, then it will be used as an alternative to where the HyperV Integration Service ISO is.
...
Included the build step to download ISO, so iso_urls works properly now.
Online activation should be done via provisioner
Installation of integration services should be done via provisioner
Cleaned up the way dvd drives are mounted and unmounted (still need to implement feature to find unused drives before adding a new one)
Cleaned up the way floppies are mounted and unmounted
2016-12-12 22:44:27 +00:00
Taliesin Sisson
422efeeaf6
Make use of driver instead of directly referencing hyper
...
Move inline powershell to hyperv
2016-12-12 22:44:26 +00:00
Taliesin Sisson
730c6217ad
Fix disk size test
...
Default minimum and maximum sizes were geared towards spinning up windows server instances. Linux instances are far more efficient and make do with lower requirements. Set the minimum sizes to match this.
2016-12-12 22:44:21 +00:00
Taliesin Sisson
9f94834826
Use correct formatting for printf
2016-12-12 22:44:19 +00:00
Taliesin Sisson
54733323a8
Should only default to first controller if its not 1 of the 2 controllers available
2016-12-12 22:44:18 +00:00
Taliesin Sisson
c24c882b84
Use simple naming convention for now
2016-12-12 22:44:16 +00:00